René's URL Explorer Experiment


Title: Various Fixes with Modules by hansl · Pull Request #5510 · angular/angular-cli · GitHub

Open Graph Title: Various Fixes with Modules by hansl · Pull Request #5510 · angular/angular-cli

X Title: Various Fixes with Modules by hansl · Pull Request #5510 · angular/angular-cli

Description: CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.

Open Graph Description: fix(@ngtools/webpack): only remove moduleId in decorators … Prior to this we were removing all mentions of moduleId, which is invalid if the users want to use it themselves. Now we only removes it...

X Description: fix(@ngtools/webpack): only remove moduleId in decorators … Prior to this we were removing all mentions of moduleId, which is invalid if the users want to use it themselves. Now we only removes it...

Opengraph URL: https://github.com/angular/angular-cli/pull/5510

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:74151899-9d93-8be7-9c65-84dffeb30519
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAE6:2F543F:21F8B67:2CBAFBE:6B024599
html-safe-nonce7f347cb22f6538aa9c199c56694bb0e4a48441b3075d4c3659747ceadfa10c27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUU2OjJGNTQzRjoyMUY4QjY3OjJDQkFGQkU6NkIwMjQ1OTkiLCJ2aXNpdG9yX2lkIjoiNDQ5MjA3MTU1ODk4NjIyMDk1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac97a93f0176c3645f049adc4b5dfa677515b12aa1122c460b49dc6d87b8a7a85b
hovercard-subject-tagpull_request:111463565
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular-cli/5510/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/404b98389ec56bf5063f7c3720153db94199b7e54bd0dd908ccdac352b88e7a5/angular/angular-cli/pull/5510
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/404b98389ec56bf5063f7c3720153db94199b7e54bd0dd908ccdac352b88e7a5/angular/angular-cli/pull/5510
og:image:altfix(@ngtools/webpack): only remove moduleId in decorators … Prior to this we were removing all mentions of moduleId, which is invalid if the users want to use it themselves. Now we only removes it...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehansl
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/5510#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F5510
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F5510
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/5510
Reloadhttps://github.com/angular/angular-cli/pull/5510
Reloadhttps://github.com/angular/angular-cli/pull/5510
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
hanslhttps://github.com/hansl
angular:masterhttps://github.com/angular/angular-cli/tree/master
hansl:fix-module-idhttps://github.com/hansl/angular-cli/tree/fix-module-id
Conversationhttps://github.com/angular/angular-cli/pull/5510
Commits2 (2)https://github.com/angular/angular-cli/pull/5510/commits
Checkshttps://github.com/angular/angular-cli/pull/5510/checks
Files changedhttps://github.com/angular/angular-cli/pull/5510/files
Various Fixes with Moduleshttps://github.com/angular/angular-cli/pull/5510#top
hanslhttps://github.com/hansl
angular:masterhttps://github.com/angular/angular-cli/tree/master
hansl:fix-module-idhttps://github.com/hansl/angular-cli/tree/fix-module-id
https://github.com/hansl
hanslhttps://github.com/hansl
Mar 19, 2017https://github.com/angular/angular-cli/pull/5510#issue-215287266
Please reload this pagehttps://github.com/angular/angular-cli/pull/5510
#5509https://github.com/angular/angular-cli/issues/5509
#5143https://github.com/angular/angular-cli/issues/5143
#4817https://github.com/angular/angular-cli/issues/4817
Please reload this pagehttps://github.com/angular/angular-cli/pull/5510
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 19, 2017https://github.com/angular/angular-cli/pull/5510#event-1005956144
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Mar 19, 2017 https://github.com/angular/angular-cli/pull/5510#pullrequestreview-27757240
View reviewed changes https://github.com/angular/angular-cli/pull/5510/files
packages/@ngtools/webpack/src/loader.spec.tshttps://github.com/angular/angular-cli/pull/5510/files#diff-beca3d8752c6d7e1fd49308a8ddeb99954d2c2d86bccda29148967dc6296779a
filipesilvahttps://github.com/filipesilva
Mar 19, 2017https://github.com/angular/angular-cli/pull/5510#discussion_r106816706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/5510
hanslhttps://github.com/hansl
Mar 20, 2017https://github.com/angular/angular-cli/pull/5510#discussion_r106826646
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/5510
hanslhttps://github.com/hansl
March 19, 2017 18:48https://github.com/angular/angular-cli/pull/5510#commits-pushed-1216c0d
https://github.com/hansl
fix(@ngtools/webpack): only remove moduleId in decoratorshttps://github.com/angular/angular-cli/pull/5510/commits/1216c0dbaed51d219d836a3588305e4fa4c6d0eb
1216c0dhttps://github.com/angular/angular-cli/pull/5510/commits/1216c0dbaed51d219d836a3588305e4fa4c6d0eb
angular#5509https://github.com/angular/angular-cli/issues/5509
https://github.com/hansl
fix(@ngtools/webpack): add parent nodes and keep programhttps://github.com/angular/angular-cli/pull/5510/commits/3d322cf68a7c3fc69818bc39341d9f3eba12e8cb
3d322cfhttps://github.com/angular/angular-cli/pull/5510/commits/3d322cf68a7c3fc69818bc39341d9f3eba12e8cb
angular#5143https://github.com/angular/angular-cli/issues/5143
angular#4817https://github.com/angular/angular-cli/issues/4817
https://github.com/hansl
hanslhttps://github.com/hansl
force-pushedhttps://github.com/angular/angular-cli/compare/572225b25206240dcc4a67dd1773dc74ec2448f4..3d322cf68a7c3fc69818bc39341d9f3eba12e8cb
572225bhttps://github.com/angular/angular-cli/commit/572225b25206240dcc4a67dd1773dc74ec2448f4
3d322cfhttps://github.com/angular/angular-cli/commit/3d322cf68a7c3fc69818bc39341d9f3eba12e8cb
Compare https://github.com/angular/angular-cli/compare/572225b25206240dcc4a67dd1773dc74ec2448f4..3d322cf68a7c3fc69818bc39341d9f3eba12e8cb
March 20, 2017 01:49https://github.com/angular/angular-cli/pull/5510#event-1006082182
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Mar 20, 2017 https://github.com/angular/angular-cli/pull/5510#pullrequestreview-27818345
View reviewed changes https://github.com/angular/angular-cli/pull/5510/files/3d322cf68a7c3fc69818bc39341d9f3eba12e8cb
https://github.com/hansl
hanslhttps://github.com/hansl
ebb495dhttps://github.com/angular/angular-cli/commit/ebb495dc8e8728aa43cb4cc5d2190197dff1c98d
Mar 20, 2017https://github.com/angular/angular-cli/pull/5510#event-1006989446
https://github.com/hansl
hanslhttps://github.com/hansl
November 28, 2018 23:34https://github.com/angular/angular-cli/pull/5510#event-1993876890
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular-cli/pull/5510#issuecomment-530931133
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular-cli/pull/5510
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 12, 2019https://github.com/angular/angular-cli/pull/5510#event-2630018282
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F5510
https://github.com/filipesilva
filipesilva https://github.com/filipesilva
https://github.com/angular/angular-cli/pull/5510/files/3d322cf68a7c3fc69818bc39341d9f3eba12e8cb
Please reload this pagehttps://github.com/angular/angular-cli/pull/5510
Is moduleId a reserved Keyword in Angular? https://github.com/angular/angular-cli/issues/5509
ng test fails when using ngrx and module.Id https://github.com/angular/angular-cli/issues/5143
Including moduleId property in @Component decorator causes 'Module build failed: TypeError: Cannot read property 'getChildAt' of undefined' https://github.com/angular/angular-cli/issues/4817
Please reload this pagehttps://github.com/angular/angular-cli/pull/5510
https://github.com/hansl
https://github.com/filipesilva
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.