René's URL Explorer Experiment


Title: fix(@angular/cli): fix test typings by filipesilva · Pull Request #5504 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/cli): fix test typings by filipesilva · Pull Request #5504 · angular/angular-cli

X Title: fix(@angular/cli): fix test typings by filipesilva · Pull Request #5504 · angular/angular-cli

Description: fix(@angular/cli): fix test typings Our unit test webpack config was erroneously sending in entry points to karma-webpack, who should receive no entry points. This in turn was hiding errors related to typeRoots lookups. It was also causing unit tests compilation to behave weirdly: unit test errors would not stop compilation, because other entries would still compile. This might also have contributed to the overall slowness of unit tests in #5423. Related to TypeStrong/ts-node#283 Fix #3911 Fix #5332 Fix #5351 fix(@angular/cli): fix error handling on test Fix #2778 Fix #3424

Open Graph Description: fix(@angular/cli): fix test typings Our unit test webpack config was erroneously sending in entry points to karma-webpack, who should receive no entry points. This in turn was hiding errors related...

X Description: fix(@angular/cli): fix test typings Our unit test webpack config was erroneously sending in entry points to karma-webpack, who should receive no entry points. This in turn was hiding errors related...

Opengraph URL: https://github.com/angular/angular-cli/pull/5504

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1d813814-374a-f945-6798-f0fe95a96271
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE814:1F927B:2102EEA:2B61815:6B023B65
html-safe-nonce2c7838bbd21ca95d801c17fbe6a92e70ea90a4fc875a8752bbd23ebeed02e23e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODE0OjFGOTI3QjoyMTAyRUVBOjJCNjE4MTU6NkIwMjNCNjUiLCJ2aXNpdG9yX2lkIjoiOTA2NzI4NzM2OTQyNTc2MzE3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4ac82de102c1823cc1ca7193466080968261e6b68566ef8b78663f3f7a0401d9
hovercard-subject-tagpull_request:111429360
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/5504/files
twitter:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
og:image:altfix(@angular/cli): fix test typings Our unit test webpack config was erroneously sending in entry points to karma-webpack, who should receive no entry points. This in turn was hiding errors related...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/5504/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F5504%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F5504%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/5504/files
Reloadhttps://github.com/angular/angular-cli/pull/5504/files
Reloadhttps://github.com/angular/angular-cli/pull/5504/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
hanslhttps://github.com/hansl
angular:masterhttps://github.com/angular/angular-cli/tree/master
filipesilva:fix-test-typingshttps://github.com/filipesilva/angular-cli/tree/fix-test-typings
Conversation 3 https://github.com/angular/angular-cli/pull/5504
Commits 2 https://github.com/angular/angular-cli/pull/5504/commits
Checks 0 https://github.com/angular/angular-cli/pull/5504/checks
Files changed https://github.com/angular/angular-cli/pull/5504/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/5504/files
fix(@angular/cli): fix test typings https://github.com/angular/angular-cli/pull/5504/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/5504/files
adabd88 fix(@angular/cli): fix test typings filipesilva Mar 18, 2017 https://github.com/angular/angular-cli/pull/5504/commits/adabd880d44361b74edb3d14d32da192ba634bb7
8ab3954 fix(@angular/cli): fix error handling on test filipesilva Mar 19, 2017 https://github.com/angular/angular-cli/pull/5504/commits/8ab395410b0eb94aafeada4de28dff82517ca45a
Clear filters https://github.com/angular/angular-cli/pull/5504/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/5504/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/5504/files
tsconfig.spec.json https://github.com/angular/angular-cli/pull/5504/files#diff-355fd786ff10325cbb3dd906d4f0195892e5a562edfe2ab7b88fc45be135e45b
test.ts https://github.com/angular/angular-cli/pull/5504/files#diff-f0f54a41f55f47b25c0dce3723b494cdab186c4841e66c68e113d9d485fe7074
webpack-test-config.ts https://github.com/angular/angular-cli/pull/5504/files#diff-78da4466ff5617d9d7e29a9f3eb7a8d7690895f9160094264613d8631f576473
karma-webpack-emitless-error.ts https://github.com/angular/angular-cli/pull/5504/files#diff-f366075deda130d99050ea001892b9f8290ff5031f4cdd41215b7bb6b5bec597
karma-webpack-throw-error.ts https://github.com/angular/angular-cli/pull/5504/files#diff-a5370d6a8934b6e048db8d9ec023dca4109af77019873fc03fb9f59749b39f50
karma.ts https://github.com/angular/angular-cli/pull/5504/files#diff-4dc23bf381f7c44b4727c7eb0edd8a1e721d46f11c8964da15aa727c4ace1ebf
extract_i18n_plugin.ts https://github.com/angular/angular-cli/pull/5504/files#diff-221f0cb646e60b61ae5a82edfa55ded553f4a60b7e0a522bb1518725b6c681d2
plugin.ts https://github.com/angular/angular-cli/pull/5504/files#diff-c74346e4d6811376a2760d083f05525afe9fbf3e2b506954aeb865cddf58f048
exclude.ts https://github.com/angular/angular-cli/pull/5504/files#diff-bddd67426dedda1fa14e357f6d86d023dc5703abce656d6625e324bdc889ea27
test-fail-single-run.ts https://github.com/angular/angular-cli/pull/5504/files#diff-c57f49cbe5699314f9387f81a3aeead81d6a0948f68e77c6de0ba912d291da42
test-fail-watch.ts https://github.com/angular/angular-cli/pull/5504/files#diff-80365c84f0daec5fc059de593c4b4b0a8fa8f387b31253775674fa31f38c5aaa
packages/@angular/cli/blueprints/ng/files/__path__/tsconfig.spec.jsonhttps://github.com/angular/angular-cli/pull/5504/files#diff-355fd786ff10325cbb3dd906d4f0195892e5a562edfe2ab7b88fc45be135e45b
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/packages/%40angular/cli/blueprints/ng/files/__path__/tsconfig.spec.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/5504/files#diff-355fd786ff10325cbb3dd906d4f0195892e5a562edfe2ab7b88fc45be135e45b
https://github.com/angular/angular-cli/pull/5504/files#diff-355fd786ff10325cbb3dd906d4f0195892e5a562edfe2ab7b88fc45be135e45b
packages/@angular/cli/models/webpack-configs/test.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-f0f54a41f55f47b25c0dce3723b494cdab186c4841e66c68e113d9d485fe7074
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/packages/%40angular/cli/models/webpack-configs/test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/5504/files#diff-f0f54a41f55f47b25c0dce3723b494cdab186c4841e66c68e113d9d485fe7074
https://github.com/angular/angular-cli/pull/5504/files#diff-f0f54a41f55f47b25c0dce3723b494cdab186c4841e66c68e113d9d485fe7074
https://github.com/angular/angular-cli/pull/5504/files#diff-f0f54a41f55f47b25c0dce3723b494cdab186c4841e66c68e113d9d485fe7074
packages/@angular/cli/models/webpack-test-config.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-78da4466ff5617d9d7e29a9f3eb7a8d7690895f9160094264613d8631f576473
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/packages/%40angular/cli/models/webpack-test-config.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/5504/files#diff-78da4466ff5617d9d7e29a9f3eb7a8d7690895f9160094264613d8631f576473
https://github.com/angular/angular-cli/pull/5504/files#diff-78da4466ff5617d9d7e29a9f3eb7a8d7690895f9160094264613d8631f576473
packages/@angular/cli/plugins/karma-webpack-emitless-error.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-f366075deda130d99050ea001892b9f8290ff5031f4cdd41215b7bb6b5bec597
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/packages/%40angular/cli/plugins/karma-webpack-emitless-error.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
packages/@angular/cli/plugins/karma-webpack-throw-error.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-a5370d6a8934b6e048db8d9ec023dca4109af77019873fc03fb9f59749b39f50
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/packages/%40angular/cli/plugins/karma-webpack-throw-error.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
packages/@angular/cli/plugins/karma.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-4dc23bf381f7c44b4727c7eb0edd8a1e721d46f11c8964da15aa727c4ace1ebf
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/packages/%40angular/cli/plugins/karma.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/5504/files#diff-4dc23bf381f7c44b4727c7eb0edd8a1e721d46f11c8964da15aa727c4ace1ebf
https://github.com/angular/angular-cli/pull/5504/files#diff-4dc23bf381f7c44b4727c7eb0edd8a1e721d46f11c8964da15aa727c4ace1ebf
https://github.com/angular/angular-cli/pull/5504/files#diff-4dc23bf381f7c44b4727c7eb0edd8a1e721d46f11c8964da15aa727c4ace1ebf
https://github.com/angular/angular-cli/pull/5504/files#diff-4dc23bf381f7c44b4727c7eb0edd8a1e721d46f11c8964da15aa727c4ace1ebf
packages/@ngtools/webpack/src/extract_i18n_plugin.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-221f0cb646e60b61ae5a82edfa55ded553f4a60b7e0a522bb1518725b6c681d2
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/packages/%40ngtools/webpack/src/extract_i18n_plugin.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/5504/files#diff-221f0cb646e60b61ae5a82edfa55ded553f4a60b7e0a522bb1518725b6c681d2
https://github.com/angular/angular-cli/pull/5504/files#diff-221f0cb646e60b61ae5a82edfa55ded553f4a60b7e0a522bb1518725b6c681d2
packages/@ngtools/webpack/src/plugin.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-c74346e4d6811376a2760d083f05525afe9fbf3e2b506954aeb865cddf58f048
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/packages/%40ngtools/webpack/src/plugin.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/5504/files#diff-c74346e4d6811376a2760d083f05525afe9fbf3e2b506954aeb865cddf58f048
https://github.com/angular/angular-cli/pull/5504/files#diff-c74346e4d6811376a2760d083f05525afe9fbf3e2b506954aeb865cddf58f048
tests/e2e/tests/build/aot/exclude.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-bddd67426dedda1fa14e357f6d86d023dc5703abce656d6625e324bdc889ea27
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/tests/e2e/tests/build/aot/exclude.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/5504/files#diff-bddd67426dedda1fa14e357f6d86d023dc5703abce656d6625e324bdc889ea27
https://github.com/angular/angular-cli/pull/5504/files#diff-bddd67426dedda1fa14e357f6d86d023dc5703abce656d6625e324bdc889ea27
tests/e2e/tests/test/test-fail-single-run.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-c57f49cbe5699314f9387f81a3aeead81d6a0948f68e77c6de0ba912d291da42
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/tests/e2e/tests/test/test-fail-single-run.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
tests/e2e/tests/test/test-fail-watch.tshttps://github.com/angular/angular-cli/pull/5504/files#diff-80365c84f0daec5fc059de593c4b4b0a8fa8f387b31253775674fa31f38c5aaa
View file https://github.com/filipesilva/angular-cli/blob/8ab395410b0eb94aafeada4de28dff82517ca45a/tests/e2e/tests/test/test-fail-watch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/5504/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.