| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a417b3f9-0a67-9bed-8505-80f0327d79ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E18A:382318:E99CE3:124D093:6B02364E |
| html-safe-nonce | 5fbdaa11fe45ba3862f086fbd4d7aea7137487f154d8fbd61d9a24d0e2d3ee18 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMThBOjM4MjMxODpFOTlDRTM6MTI0RDA5Mzo2QjAyMzY0RSIsInZpc2l0b3JfaWQiOiI4NjI3NjI4NDY4MDMwNTUxNjMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a753c62b59ff4963e048a8ac2b6259f1632e93006d38c10505ae8f4795218850 |
| hovercard-subject-tag | pull_request:111429360 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular-cli/5504/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bc999cc3ddec293a6840d4bf8090f0d10d9c83f60822fc2a37f0720d47d4967f/angular/angular-cli/pull/5504 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc999cc3ddec293a6840d4bf8090f0d10d9c83f60822fc2a37f0720d47d4967f/angular/angular-cli/pull/5504 |
| og:image:alt | fix(@angular/cli): fix test typings
Our unit test webpack config was erroneously sending in entry points to karma-webpack, who should receive no entry points.
This in turn was hiding errors related... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | filipesilva |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular-cli/pull/5504#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F5504 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F5504 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular-cli |
| Reload | https://github.com/angular/angular-cli/pull/5504 |
| Reload | https://github.com/angular/angular-cli/pull/5504 |
| Reload | https://github.com/angular/angular-cli/pull/5504 |
| angular | https://github.com/angular |
| angular-cli | https://github.com/angular/angular-cli |
| Code | https://github.com/angular/angular-cli |
| Issues198 (198) | https://github.com/angular/angular-cli/issues |
| Pull requests23 (23) | https://github.com/angular/angular-cli/pulls |
| Actions | https://github.com/angular/angular-cli/actions |
| Security and quality8 (8) | https://github.com/angular/angular-cli/security |
| Insights | https://github.com/angular/angular-cli/insights |
| https://github.com/angular/angular-cli |
| hansl | https://github.com/hansl |
| angular:master | https://github.com/angular/angular-cli/tree/master |
| filipesilva:fix-test-typings | https://github.com/filipesilva/angular-cli/tree/fix-test-typings |
| Conversation | https://github.com/angular/angular-cli/pull/5504 |
| Commits2 (2) | https://github.com/angular/angular-cli/pull/5504/commits |
| Checks | https://github.com/angular/angular-cli/pull/5504/checks |
| Files changed | https://github.com/angular/angular-cli/pull/5504/files |
| fix(@angular/cli): fix test typings | https://github.com/angular/angular-cli/pull/5504#top |
| hansl | https://github.com/hansl |
| angular:master | https://github.com/angular/angular-cli/tree/master |
| filipesilva:fix-test-typings | https://github.com/filipesilva/angular-cli/tree/fix-test-typings |
|
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| Mar 18, 2017 | https://github.com/angular/angular-cli/pull/5504#issue-215227945 |
| Please reload this page | https://github.com/angular/angular-cli/pull/5504 |
| #5423 | https://github.com/angular/angular-cli/issues/5423 |
| TypeStrong/ts-node#283 | https://github.com/TypeStrong/ts-node/issues/283 |
| #3911 | https://github.com/angular/angular-cli/issues/3911 |
| #5332 | https://github.com/angular/angular-cli/issues/5332 |
| #5351 | https://github.com/angular/angular-cli/issues/5351 |
| #2778 | https://github.com/angular/angular-cli/issues/2778 |
| #3424 | https://github.com/angular/angular-cli/issues/3424 |
| Please reload this page | https://github.com/angular/angular-cli/pull/5504 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 18, 2017 | https://github.com/angular/angular-cli/pull/5504#event-1005684193 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| force-pushed | https://github.com/angular/angular-cli/compare/4f05519c8d0e12391e7d16c9fa98638667110935..ad58c18758407e87bc972d23ef5a35b152272be7 |
| 4f05519 | https://github.com/angular/angular-cli/commit/4f05519c8d0e12391e7d16c9fa98638667110935 |
| ad58c18 | https://github.com/angular/angular-cli/commit/ad58c18758407e87bc972d23ef5a35b152272be7 |
|
Compare
| https://github.com/angular/angular-cli/compare/4f05519c8d0e12391e7d16c9fa98638667110935..ad58c18758407e87bc972d23ef5a35b152272be7 |
| March 18, 2017 23:30 | https://github.com/angular/angular-cli/pull/5504#event-1005690225 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| Mar 19, 2017 | https://github.com/angular/angular-cli/pull/5504#issuecomment-287613248 |
| Please reload this page | https://github.com/angular/angular-cli/pull/5504 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
|
state: WIP
| https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Mar 19, 2017 | https://github.com/angular/angular-cli/pull/5504#event-1005834775 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| force-pushed | https://github.com/angular/angular-cli/compare/eb63b6f17c3516c26b4d6c8a03da2d8241b90f55..5ab01b7f5493789476dc2ace5f69df5b8cf27fa2 |
| eb63b6f | https://github.com/angular/angular-cli/commit/eb63b6f17c3516c26b4d6c8a03da2d8241b90f55 |
| 5ab01b7 | https://github.com/angular/angular-cli/commit/5ab01b7f5493789476dc2ace5f69df5b8cf27fa2 |
|
Compare
| https://github.com/angular/angular-cli/compare/eb63b6f17c3516c26b4d6c8a03da2d8241b90f55..5ab01b7f5493789476dc2ace5f69df5b8cf27fa2 |
| March 19, 2017 15:56 | https://github.com/angular/angular-cli/pull/5504#event-1005893197 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
|
state: WIP
| https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Mar 19, 2017 | https://github.com/angular/angular-cli/pull/5504#event-1005893230 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| hansl | https://github.com/hansl |
| March 19, 2017 15:56 | https://github.com/angular/angular-cli/pull/5504#event-1005893266 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| force-pushed | https://github.com/angular/angular-cli/compare/31ece403ae1575b060d11859193c68e26b64e8fb..2d6d4e2a8dfb54aca2409745887cc177d24a33b8 |
| 31ece40 | https://github.com/angular/angular-cli/commit/31ece403ae1575b060d11859193c68e26b64e8fb |
| 2d6d4e2 | https://github.com/angular/angular-cli/commit/2d6d4e2a8dfb54aca2409745887cc177d24a33b8 |
|
Compare
| https://github.com/angular/angular-cli/compare/31ece403ae1575b060d11859193c68e26b64e8fb..2d6d4e2a8dfb54aca2409745887cc177d24a33b8 |
| March 19, 2017 16:50 | https://github.com/angular/angular-cli/pull/5504#event-1005910594 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
|
state: WIP
| https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Mar 19, 2017 | https://github.com/angular/angular-cli/pull/5504#event-1005949280 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| force-pushed | https://github.com/angular/angular-cli/compare/1e72de02cab6da870077787cbbf15bc5acefd22e..055a4b7d62b73224f8914ccd7942a5da4914f089 |
| 1e72de0 | https://github.com/angular/angular-cli/commit/1e72de02cab6da870077787cbbf15bc5acefd22e |
| 055a4b7 | https://github.com/angular/angular-cli/commit/055a4b7d62b73224f8914ccd7942a5da4914f089 |
|
Compare
| https://github.com/angular/angular-cli/compare/1e72de02cab6da870077787cbbf15bc5acefd22e..055a4b7d62b73224f8914ccd7942a5da4914f089 |
| March 19, 2017 23:48 | https://github.com/angular/angular-cli/pull/5504#event-1006043196 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
|
state: WIP
| https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Mar 19, 2017 | https://github.com/angular/angular-cli/pull/5504#event-1006046622 |
|
| https://github.com/filipesilva |
| fix(@angular/cli): fix test typings | https://github.com/angular/angular-cli/pull/5504/commits/adabd880d44361b74edb3d14d32da192ba634bb7 |
| adabd88 | https://github.com/angular/angular-cli/pull/5504/commits/adabd880d44361b74edb3d14d32da192ba634bb7 |
| angular#5500 | https://github.com/angular/angular-cli/pull/5500 |
| angular#5423 | https://github.com/angular/angular-cli/issues/5423 |
| TypeStrong/ts-node#283 | https://github.com/TypeStrong/ts-node/issues/283 |
| angular#3911 | https://github.com/angular/angular-cli/issues/3911 |
| angular#5332 | https://github.com/angular/angular-cli/issues/5332 |
| angular#5351 | https://github.com/angular/angular-cli/issues/5351 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| force-pushed | https://github.com/angular/angular-cli/compare/79c68a881f82c175db38c4a434526b18c9070b6d..fd29bfb43c9a96b62e865532bb5e40f0dcc2d8d6 |
| 79c68a8 | https://github.com/angular/angular-cli/commit/79c68a881f82c175db38c4a434526b18c9070b6d |
| fd29bfb | https://github.com/angular/angular-cli/commit/fd29bfb43c9a96b62e865532bb5e40f0dcc2d8d6 |
|
Compare
| https://github.com/angular/angular-cli/compare/79c68a881f82c175db38c4a434526b18c9070b6d..fd29bfb43c9a96b62e865532bb5e40f0dcc2d8d6 |
| March 20, 2017 11:15 | https://github.com/angular/angular-cli/pull/5504#event-1006499037 |
|
| https://github.com/filipesilva |
| fix(@angular/cli): fix error handling on test | https://github.com/angular/angular-cli/pull/5504/commits/8ab395410b0eb94aafeada4de28dff82517ca45a |
| 8ab3954 | https://github.com/angular/angular-cli/pull/5504/commits/8ab395410b0eb94aafeada4de28dff82517ca45a |
| angular#2778 | https://github.com/angular/angular-cli/issues/2778 |
| angular#3424 | https://github.com/angular/angular-cli/issues/3424 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| force-pushed | https://github.com/angular/angular-cli/compare/fd29bfb43c9a96b62e865532bb5e40f0dcc2d8d6..8ab395410b0eb94aafeada4de28dff82517ca45a |
| fd29bfb | https://github.com/angular/angular-cli/commit/fd29bfb43c9a96b62e865532bb5e40f0dcc2d8d6 |
| 8ab3954 | https://github.com/angular/angular-cli/commit/8ab395410b0eb94aafeada4de28dff82517ca45a |
|
Compare
| https://github.com/angular/angular-cli/compare/fd29bfb43c9a96b62e865532bb5e40f0dcc2d8d6..8ab395410b0eb94aafeada4de28dff82517ca45a |
| March 20, 2017 11:35 | https://github.com/angular/angular-cli/pull/5504#event-1006522752 |
| https://github.com/hansl |
| hansl | https://github.com/hansl |
|
Mar 20, 2017
| https://github.com/angular/angular-cli/pull/5504#pullrequestreview-27885798 |
|
View reviewed changes
| https://github.com/angular/angular-cli/pull/5504/files/8ab395410b0eb94aafeada4de28dff82517ca45a |
| hansl | https://github.com/hansl |
| https://github.com/angular/angular-cli/pull/5504#pullrequestreview-27885798 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular-cli/pull/5504 |
| https://github.com/hansl |
| hansl | https://github.com/hansl |
| 9cda847 | https://github.com/angular/angular-cli/commit/9cda847035fc2b09f3f2b6e866acb6f3d9a51471 |
| Mar 20, 2017 | https://github.com/angular/angular-cli/pull/5504#event-1006991304 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
| March 20, 2017 16:19 | https://github.com/angular/angular-cli/pull/5504#event-1007008115 |
| https://github.com/filipesilva |
| filipesilva | https://github.com/filipesilva |
|
Mar 20, 2017
| https://github.com/angular/angular-cli/pull/5504#ref-pullrequest-215543616 |
|
feat(@angular/cli): Add typings.d.ts to types in TS config
#5525
| https://github.com/angular/angular-cli/pull/5525 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 11, 2019 | https://github.com/angular/angular-cli/pull/5504#issuecomment-530594269 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular-cli/pull/5504 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 11, 2019 | https://github.com/angular/angular-cli/pull/5504#event-2627366553 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F5504 |
|
| https://github.com/hansl |
|
hansl
| https://github.com/hansl |
|
| https://github.com/angular/angular-cli/pull/5504/files/8ab395410b0eb94aafeada4de28dff82517ca45a |
| Please reload this page | https://github.com/angular/angular-cli/pull/5504 |
|
tsconfig.app.json types are ignored
| https://github.com/angular/angular-cli/issues/5351 |
|
ng test losing typings after retrigger
| https://github.com/angular/angular-cli/issues/5332 |
|
ng test does not honor tsconfig.json compilation options
| https://github.com/angular/angular-cli/issues/3911 |
|
"ng test" does not bail on type definition errors
| https://github.com/angular/angular-cli/issues/3424 |
|
Compilation errors don't cause non-zero exit codes in ng test
| https://github.com/angular/angular-cli/issues/2778 |
| Please reload this page | https://github.com/angular/angular-cli/pull/5504 |
|
| https://github.com/filipesilva |
|
| https://github.com/hansl |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |