René's URL Explorer Experiment


Title: fix(@angular/cli): fix css url processing by filipesilva · Pull Request #4803 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/cli): fix css url processing by filipesilva · Pull Request #4803 · angular/angular-cli

X Title: fix(@angular/cli): fix css url processing by filipesilva · Pull Request #4803 · angular/angular-cli

Description: Fixing component css in #4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using --base-href and/or --deploy-url. It also fixes asset output on --aot mode. Thanks to @clydin for finding out assets were being dropped in the child compiler. Fix #4778 Fix #4782 Fix #4806

Open Graph Description: Fixing component css in #4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using --base-href and/or --deploy-url. It also fixes asset output on --aot mode. ...

X Description: Fixing component css in #4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using --base-href and/or --deploy-url. It also fixes asset output on --aot mode. ...

Opengraph URL: https://github.com/angular/angular-cli/pull/4803

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3876f33e-aa23-6bcd-4ff5-ca2ec4e17c82
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9E2:240CD1:3E77711:4F56730:6B0215B3
html-safe-noncec596c156d074453791bdd7f4ad8010190a03596bdb2fec637c7011d9ea9ceb36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUUyOjI0MENEMTozRTc3NzExOjRGNTY3MzA6NkIwMjE1QjMiLCJ2aXNpdG9yX2lkIjoiNjEwODY1NzUyMDc1MzEyMDY5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccf76b135a603311a11dc028fc2258944d1f3c9455a23a64e52b46cde78e9e5bb
hovercard-subject-tagpull_request:106833604
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/4803/files
twitter:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
og:image:altFixing component css in #4667 uncovered errors in CSS url processing. This PR correctly composes absolute urls when using --base-href and/or --deploy-url. It also fixes asset output on --aot mode. ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/4803/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F4803%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F4803%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/4803/files
Reloadhttps://github.com/angular/angular-cli/pull/4803/files
Reloadhttps://github.com/angular/angular-cli/pull/4803/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
filipesilvahttps://github.com/filipesilva
angular:masterhttps://github.com/angular/angular-cli/tree/master
filipesilva:css-urlshttps://github.com/filipesilva/angular-cli/tree/css-urls
Conversation 10 https://github.com/angular/angular-cli/pull/4803
Commits 2 https://github.com/angular/angular-cli/pull/4803/commits
Checks 0 https://github.com/angular/angular-cli/pull/4803/checks
Files changed https://github.com/angular/angular-cli/pull/4803/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/4803/files
fix(@angular/cli): fix css url processing https://github.com/angular/angular-cli/pull/4803/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/4803/files
0f75bbd fix(@angular/cli): fix css url processing filipesilva Feb 17, 2017 https://github.com/angular/angular-cli/pull/4803/commits/0f75bbd957bf5d22bdaa3da1fa9dbf305b8110e2
98d654d fix tests filipesilva Feb 20, 2017 https://github.com/angular/angular-cli/pull/4803/commits/98d654d4dcce7109a49fda45e9851a5e05ca40de
Clear filters https://github.com/angular/angular-cli/pull/4803/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/4803/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/4803/files
package.json https://github.com/angular/angular-cli/pull/4803/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
styles.ts https://github.com/angular/angular-cli/pull/4803/files#diff-ce486e55cd2af186cea1db221c18d0093b911e8d35d90e1115bd74d3ba4cc41d
package.json https://github.com/angular/angular-cli/pull/4803/files#diff-b6726b257c1f40fd790e351d34abb639af4c9bfc76fa83a5d3947f3ebc788c56
eject.ts https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
resource_loader.ts https://github.com/angular/angular-cli/pull/4803/files#diff-cdc14c740d614d58a9d900a9b360c52a9988fc64aa992a5fea13086ef4735288
test-licenses.js https://github.com/angular/angular-cli/pull/4803/files#diff-4286f5a1c3768d67e1675490b330be5ea96d0433c716ee2051c48d9b344254d6
css-urls.ts https://github.com/angular/angular-cli/pull/4803/files#diff-2dfd41856f9652ac231650ad960a8ef3cdd83392e10e0c3dfe31355c0a40c860
package.jsonhttps://github.com/angular/angular-cli/pull/4803/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/filipesilva/angular-cli/blob/98d654d4dcce7109a49fda45e9851a5e05ca40de/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/4803/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/4803/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angular-cli/pull/4803/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
packages/@angular/cli/models/webpack-configs/styles.tshttps://github.com/angular/angular-cli/pull/4803/files#diff-ce486e55cd2af186cea1db221c18d0093b911e8d35d90e1115bd74d3ba4cc41d
View file https://github.com/filipesilva/angular-cli/blob/98d654d4dcce7109a49fda45e9851a5e05ca40de/packages/%40angular/cli/models/webpack-configs/styles.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/4803/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/4803/files#diff-ce486e55cd2af186cea1db221c18d0093b911e8d35d90e1115bd74d3ba4cc41d
https://github.com/angular/angular-cli/pull/4803/files#diff-ce486e55cd2af186cea1db221c18d0093b911e8d35d90e1115bd74d3ba4cc41d
https://github.com/angular/angular-cli/pull/4803/files#diff-ce486e55cd2af186cea1db221c18d0093b911e8d35d90e1115bd74d3ba4cc41d
https://github.com/angular/angular-cli/pull/4803/files#diff-ce486e55cd2af186cea1db221c18d0093b911e8d35d90e1115bd74d3ba4cc41d
https://github.com/angular/angular-cli/pull/4803/files#diff-ce486e55cd2af186cea1db221c18d0093b911e8d35d90e1115bd74d3ba4cc41d
packages/@angular/cli/package.jsonhttps://github.com/angular/angular-cli/pull/4803/files#diff-b6726b257c1f40fd790e351d34abb639af4c9bfc76fa83a5d3947f3ebc788c56
View file https://github.com/filipesilva/angular-cli/blob/98d654d4dcce7109a49fda45e9851a5e05ca40de/packages/%40angular/cli/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/4803/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/4803/files#diff-b6726b257c1f40fd790e351d34abb639af4c9bfc76fa83a5d3947f3ebc788c56
https://github.com/angular/angular-cli/pull/4803/files#diff-b6726b257c1f40fd790e351d34abb639af4c9bfc76fa83a5d3947f3ebc788c56
packages/@angular/cli/tasks/eject.tshttps://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
View file https://github.com/filipesilva/angular-cli/blob/98d654d4dcce7109a49fda45e9851a5e05ca40de/packages/%40angular/cli/tasks/eject.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/4803/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
https://github.com/angular/angular-cli/pull/4803/files#diff-476b273d6f6b00245bef84dbe972a692a2daa48552f6b255e96b67198b39a158
packages/@ngtools/webpack/src/resource_loader.tshttps://github.com/angular/angular-cli/pull/4803/files#diff-cdc14c740d614d58a9d900a9b360c52a9988fc64aa992a5fea13086ef4735288
View file https://github.com/filipesilva/angular-cli/blob/98d654d4dcce7109a49fda45e9851a5e05ca40de/packages/%40ngtools/webpack/src/resource_loader.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/4803/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/4803/files#diff-cdc14c740d614d58a9d900a9b360c52a9988fc64aa992a5fea13086ef4735288
https://github.com/angular/angular-cli/pull/4803/files#diff-cdc14c740d614d58a9d900a9b360c52a9988fc64aa992a5fea13086ef4735288
scripts/test-licenses.jshttps://github.com/angular/angular-cli/pull/4803/files#diff-4286f5a1c3768d67e1675490b330be5ea96d0433c716ee2051c48d9b344254d6
View file https://github.com/filipesilva/angular-cli/blob/98d654d4dcce7109a49fda45e9851a5e05ca40de/scripts/test-licenses.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/4803/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/4803/files#diff-4286f5a1c3768d67e1675490b330be5ea96d0433c716ee2051c48d9b344254d6
https://github.com/angular/angular-cli/pull/4803/files#diff-4286f5a1c3768d67e1675490b330be5ea96d0433c716ee2051c48d9b344254d6
https://github.com/angular/angular-cli/pull/4803/files#diff-4286f5a1c3768d67e1675490b330be5ea96d0433c716ee2051c48d9b344254d6
tests/e2e/tests/build/css-urls.tshttps://github.com/angular/angular-cli/pull/4803/files#diff-2dfd41856f9652ac231650ad960a8ef3cdd83392e10e0c3dfe31355c0a40c860
View file https://github.com/filipesilva/angular-cli/blob/98d654d4dcce7109a49fda45e9851a5e05ca40de/tests/e2e/tests/build/css-urls.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/4803/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.