René's URL Explorer Experiment


Title: fix(scripts): allow using same lib inside app by filipesilva · Pull Request #3814 · angular/angular-cli · GitHub

Open Graph Title: fix(scripts): allow using same lib inside app by filipesilva · Pull Request #3814 · angular/angular-cli

X Title: fix(scripts): allow using same lib inside app by filipesilva · Pull Request #3814 · angular/angular-cli

Description: We were loading scripts by adding an include list to the script-loader loader rule, forcing that list of files to always be loaded with script loader. But there were cases where you could need to load it both via scripts (because other global scripts needed a lib), and inside your app (or libs your app imported). This cased the import to return a empty object because it was loaded as a string due to being forced through script-loader. With this fix, scripts are forced to be loaded via script loader individually for the scripts entry point instead of globally. Fix #2141

Open Graph Description: We were loading scripts by adding an include list to the script-loader loader rule, forcing that list of files to always be loaded with script loader. But there were cases where you could need to l...

X Description: We were loading scripts by adding an include list to the script-loader loader rule, forcing that list of files to always be loaded with script loader. But there were cases where you could need to l...

Opengraph URL: https://github.com/angular/angular-cli/pull/3814

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e3b2877e-d8e1-8b05-7093-f3df5d268945
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCA0:111FE:4233F8:570B93:6B023B14
html-safe-nonce6c34d80883f287b31a48a7d7aa8095d485ea4684ba62a582b1f4dc6d26e26850
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0EwOjExMUZFOjQyMzNGODo1NzBCOTM6NkIwMjNCMTQiLCJ2aXNpdG9yX2lkIjoiNDMxMjU3MjgyODMwMzExMjk4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc672b76bd1b28798bc19726bcda8fbb3c59fc246266c76333780cce9024d8f88
hovercard-subject-tagpull_request:99826176
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/3814/files
twitter:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
og:image:altWe were loading scripts by adding an include list to the script-loader loader rule, forcing that list of files to always be loaded with script loader. But there were cases where you could need to l...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/3814/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F3814%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F3814%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/3814/files
Reloadhttps://github.com/angular/angular-cli/pull/3814/files
Reloadhttps://github.com/angular/angular-cli/pull/3814/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
hanslhttps://github.com/hansl
angular:masterhttps://github.com/angular/angular-cli/tree/master
filipesilva:fix-scripts-plus-importhttps://github.com/filipesilva/angular-cli/tree/fix-scripts-plus-import
Conversation 23 https://github.com/angular/angular-cli/pull/3814
Commits 2 https://github.com/angular/angular-cli/pull/3814/commits
Checks 0 https://github.com/angular/angular-cli/pull/3814/checks
Files changed https://github.com/angular/angular-cli/pull/3814/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/3814/files
fix(scripts): allow using same lib inside app https://github.com/angular/angular-cli/pull/3814/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/3814/files
0f0bbc9 fix(scripts): allow using same lib inside app filipesilva Jan 1, 2017 https://github.com/angular/angular-cli/pull/3814/commits/0f0bbc9dca2f1aab62771378aca43ae92f5c2d6b
349370b Merge branch 'master' into fix-scripts-plus-import filipesilva Jan 20, 2017 https://github.com/angular/angular-cli/pull/3814/commits/349370bb17bf2fd2e174885e3168d318af6718e8
Clear filters https://github.com/angular/angular-cli/pull/3814/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/3814/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/3814/files
webpack-build-common.ts https://github.com/angular/angular-cli/pull/3814/files#diff-212c0b27910672a8407b5251ac0f35e239a6e4a92e42860e04fab1e7fa62b256
scripts-array.ts https://github.com/angular/angular-cli/pull/3814/files#diff-f7f97bc1564b8700503a722d275d42239326ec902b5f04fe5a42858a9e938460
packages/angular-cli/models/webpack-build-common.tshttps://github.com/angular/angular-cli/pull/3814/files#diff-212c0b27910672a8407b5251ac0f35e239a6e4a92e42860e04fab1e7fa62b256
View file https://github.com/filipesilva/angular-cli/blob/349370bb17bf2fd2e174885e3168d318af6718e8/packages/angular-cli/models/webpack-build-common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/3814/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/3814/files#diff-212c0b27910672a8407b5251ac0f35e239a6e4a92e42860e04fab1e7fa62b256
https://github.com/angular/angular-cli/pull/3814/files#diff-212c0b27910672a8407b5251ac0f35e239a6e4a92e42860e04fab1e7fa62b256
tests/e2e/tests/build/scripts-array.tshttps://github.com/angular/angular-cli/pull/3814/files#diff-f7f97bc1564b8700503a722d275d42239326ec902b5f04fe5a42858a9e938460
View file https://github.com/filipesilva/angular-cli/blob/349370bb17bf2fd2e174885e3168d318af6718e8/tests/e2e/tests/build/scripts-array.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/3814/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/3814/files#diff-f7f97bc1564b8700503a722d275d42239326ec902b5f04fe5a42858a9e938460
https://github.com/angular/angular-cli/pull/3814/files#diff-f7f97bc1564b8700503a722d275d42239326ec902b5f04fe5a42858a9e938460
https://github.com/angular/angular-cli/pull/3814/files#diff-f7f97bc1564b8700503a722d275d42239326ec902b5f04fe5a42858a9e938460
hanslhttps://github.com/hansl
Jan 4, 2017https://github.com/angular/angular-cli/pull/3814/files#r94517582
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/3814/files
filipesilvahttps://github.com/filipesilva
Jan 4, 2017https://github.com/angular/angular-cli/pull/3814/files#r94518434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/3814/files
hanslhttps://github.com/hansl
Jan 6, 2017https://github.com/angular/angular-cli/pull/3814/files#r94882496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/3814/files
clydinhttps://github.com/clydin
Jan 11, 2017https://github.com/angular/angular-cli/pull/3814/files#r95607100
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/3814/files
filipesilvahttps://github.com/filipesilva
Jan 11, 2017https://github.com/angular/angular-cli/pull/3814/files#r95636697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/3814/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.