René's URL Explorer Experiment


Title: fix(@angular/ssr): guard aborted requests across rendering and serialization by alan-agius4 · Pull Request #34768 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/ssr): guard aborted requests across rendering and serialization by alan-agius4 · Pull Request #34768 · angular/angular-cli

X Title: fix(@angular/ssr): guard aborted requests across rendering and serialization by alan-agius4 · Pull Request #34768 · angular/angular-cli

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix What is the current behavior? When a request is aborted during SSR rendering: AngularServerApp.handleRendering() can still perform asset reads, run html:transform:pre hooks, invoke renderAngular(), or run Beasties inlineCriticalCss() after request.signal has already aborted. renderAngular() does not check moduleRef.injector.destroyed, applicationRef.destroyed, platformRef.destroyed (post-whenStable), or destroyPromise consistently across bootstrap, stability, and content(), only clears renderTimeoutId on the first destroy() call, detaches abort listeners two microtasks after content() settles, and can leave asyncDestroyPlatform() unresolved if platformRef.destroy() throws. Companion framework fix: angular/angular#72139 Related issue: #34754 What is the new behavior? Short-circuit AngularServerApp.handleRendering() on request.signal.aborted before asset reads, html:transform:pre hooks, renderAngular(), redirect response creation, and critical CSS inlining, and uniformly await result.destroy() when aborting inside the response ReadableStream. Keep immediate platform destruction on abort in renderAngular() (relying on the framework teardown fixes in angular/angular#72139 instead of deferring destruction or adding fallback timeouts). Guard moduleRef.injector.destroyed, applicationRef.destroyed, platformRef.destroyed, and destroyPromise consistently across renderAngular() and content(), clear renderTimeoutId on every destroy() call, detach abort listeners before settling content(), and wrap platformRef.destroy() in try/finally inside asyncDestroyPlatform(). Does this PR introduce a breaking change? No

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...

Opengraph URL: https://github.com/angular/angular-cli/pull/34768

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1c628d9d-1bfb-f90e-c160-3b3ddab2dd92
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF2A:1EFF:3E6F8C:539CAC:6B01DBD8
html-safe-nonceaf75abf828cfb54d029b79fab8a30e40d110698a001d53a5fe1859df92a0ae4e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjJBOjFFRkY6M0U2RjhDOjUzOUNBQzo2QjAxREJEOCIsInZpc2l0b3JfaWQiOiI0MDkzOTUyNjc5MzM0NzYzNDgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc01b7249aef90c041261ab6e7d95d30ea0ac06357b7d9f32782ff13d99d630f2
hovercard-subject-tagpull_request:5409716851
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34768/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34768/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34768%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34768%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34768/files
Reloadhttps://github.com/angular/angular-cli/pull/34768/files
Reloadhttps://github.com/angular/angular-cli/pull/34768/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
alan-agius4:fix-ssr-abort-guardshttps://github.com/alan-agius4/angular-cli/tree/fix-ssr-abort-guards
Conversation 4 https://github.com/angular/angular-cli/pull/34768
Commits 1 https://github.com/angular/angular-cli/pull/34768/commits
Checks 41 https://github.com/angular/angular-cli/pull/34768/checks
Files changed 4 https://github.com/angular/angular-cli/pull/34768/files
fix(@angular/ssr): guard aborted requests across rendering and serialization https://github.com/angular/angular-cli/pull/34768/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/34768/files
66d97cf fix(@angular/ssr): guard aborted requests across rendering and serial… alan-agius4 Nov 20, 2026 https://github.com/angular/angular-cli/pull/34768/commits/66d97cfc6f4a03b45062e670e8e496e155a7e088
Clear filters https://github.com/angular/angular-cli/pull/34768/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34768/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34768/files
app.ts https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
ng.ts https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
app_spec.ts https://github.com/angular/angular-cli/pull/34768/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
ng_spec.ts https://github.com/angular/angular-cli/pull/34768/files#diff-3c7a491b51741ebfa9211cba5e96dcd167e559972f7e1f05ec90111d640949dd
packages/angular/ssr/src/app.tshttps://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
View file https://github.com/angular/angular-cli/blob/66d97cfc6f4a03b45062e670e8e496e155a7e088/packages/angular/ssr/src/app.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34768/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
Please reload this pagehttps://github.com/angular/angular-cli/pull/34768/files
https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34768/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
packages/angular/ssr/src/utils/ng.tshttps://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
View file https://github.com/angular/angular-cli/blob/66d97cfc6f4a03b45062e670e8e496e155a7e088/packages/angular/ssr/src/utils/ng.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34768/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
dgp1130https://github.com/dgp1130
Nov 20, 2026https://github.com/angular/angular-cli/pull/34768/files#r4645319982
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34768/files
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34768/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
packages/angular/ssr/test/app_spec.tshttps://github.com/angular/angular-cli/pull/34768/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
View file https://github.com/angular/angular-cli/blob/66d97cfc6f4a03b45062e670e8e496e155a7e088/packages/angular/ssr/test/app_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34768/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34768/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34768/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34768/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34768/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34768/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
Please reload this pagehttps://github.com/angular/angular-cli/pull/34768/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.