René's URL Explorer Experiment


Title: fix(@angular/build): refresh template diagnostics on Windows after an external template changes by thekhegay · Pull Request #34736 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/build): refresh template diagnostics on Windows after an external template changes by thekhegay · Pull Request #34736 · angular/angular-cli

X Title: fix(@angular/build): refresh template diagnostics on Windows after an external template changes by thekhegay · Pull Request #34736 · angular/angular-cli

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? Issue Number: #34725 On Windows SourceFileCache.invalidate puts path.normalized paths (backslashes) into modifiedFiles, but resource dependencies from compiler have forward slashes. So modifiedFiles.has(resourceDependency) in AotCompilation never matches, diagnostics cache of the component is not dropped and template errors stay stale after editing external template What is the new behavior? Resource dependency is normalized before the lookup, same as referencedFiles are normalized in SourceFileCache.invalidate. On POSIX normalize doesnt change anything Does this PR introduce a breaking change? Yes No Other information No test: mismatch only happens with Windows separators, cant reproduce it on Linux/macOS. Issue has repro repo with output from both platforms

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...

Opengraph URL: https://github.com/angular/angular-cli/pull/34736

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1219aa4-ebc2-de20-76f5-d45ec663dafa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB69E:2E3FEE:3788DA4:4657CF9:6B01E997
html-safe-nonceeb5801f2d332de7149ec638f5f0907df9a6c9ff44056a052b7879476cc590b18
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjlFOjJFM0ZFRTozNzg4REE0OjQ2NTdDRjk6NkIwMUU5OTciLCJ2aXNpdG9yX2lkIjoiNzkzMTY2Njk4NTIyNDYyODYzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac12938e2f0d3b014d80998d334e18f90bb7cb4de297745db371133ee260e3043f
hovercard-subject-tagpull_request:5350883247
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34736/files
twitter:imagehttps://avatars.githubusercontent.com/u/5451538?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5451538?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34736/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34736%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34736%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34736/files
Reloadhttps://github.com/angular/angular-cli/pull/34736/files
Reloadhttps://github.com/angular/angular-cli/pull/34736/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
thekhegayhttps://github.com/thekhegay
angular:mainhttps://github.com/angular/angular-cli/tree/main
thekhegay:build-windows-template-diagnosticshttps://github.com/thekhegay/angular-cli/tree/build-windows-template-diagnostics
Conversation 3 https://github.com/angular/angular-cli/pull/34736
Commits 2 https://github.com/angular/angular-cli/pull/34736/commits
Checks 10 https://github.com/angular/angular-cli/pull/34736/checks
Files changed https://github.com/angular/angular-cli/pull/34736/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34736/files
fix(@angular/build): refresh template diagnostics on Windows after an external template changes https://github.com/angular/angular-cli/pull/34736/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/34736/files
8df8406 fix(@angular/build): refresh template diagnostics on Windows after an… thekhegay Nov 16, 2026 https://github.com/angular/angular-cli/pull/34736/commits/8df840671edaa9e7ff3e95f57e4cf1813fdc4c42
9a58469 fixup! fix(@angular/build): refresh template diagnostics on Windows a… thekhegay Nov 17, 2026 https://github.com/angular/angular-cli/pull/34736/commits/9a58469389f937b843861d420b4ac9a4a0d9041e
Clear filters https://github.com/angular/angular-cli/pull/34736/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34736/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34736/files
packages/angular/build/src/tools/angular/compilation/aot-compilation.tshttps://github.com/angular/angular-cli/pull/34736/files#diff-19d6524b0f4f9196f5fdbe8df8970c13e3a1fe3c891a032556c1b8f6f5a74d71
View file https://github.com/angular/angular-cli/blob/9a58469389f937b843861d420b4ac9a4a0d9041e/packages/angular/build/src/tools/angular/compilation/aot-compilation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34736/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34736/files#diff-19d6524b0f4f9196f5fdbe8df8970c13e3a1fe3c891a032556c1b8f6f5a74d71
https://github.com/angular/angular-cli/pull/34736/files#diff-19d6524b0f4f9196f5fdbe8df8970c13e3a1fe3c891a032556c1b8f6f5a74d71
https://github.com/angular/angular-cli/pull/34736/files#diff-19d6524b0f4f9196f5fdbe8df8970c13e3a1fe3c891a032556c1b8f6f5a74d71
https://github.com/angular/angular-cli/pull/34736/files#diff-19d6524b0f4f9196f5fdbe8df8970c13e3a1fe3c891a032556c1b8f6f5a74d71
Please reload this pagehttps://github.com/angular/angular-cli/pull/34736/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.