Title: fix(@angular/build): refresh template diagnostics on Windows after an external template changes by thekhegay · Pull Request #34736 · angular/angular-cli · GitHub
Open Graph Title: fix(@angular/build): refresh template diagnostics on Windows after an external template changes by thekhegay · Pull Request #34736 · angular/angular-cli
X Title: fix(@angular/build): refresh template diagnostics on Windows after an external template changes by thekhegay · Pull Request #34736 · angular/angular-cli
Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? Issue Number: #34725 On Windows SourceFileCache.invalidate puts path.normalized paths (backslashes) into modifiedFiles, but resource dependencies from compiler have forward slashes. So modifiedFiles.has(resourceDependency) in AotCompilation never matches, diagnostics cache of the component is not dropped and template errors stay stale after editing external template What is the new behavior? Resource dependency is normalized before the lookup, same as referencedFiles are normalized in SourceFileCache.invalidate. On POSIX normalize doesnt change anything Does this PR introduce a breaking change? Yes No Other information No test: mismatch only happens with Windows separators, cant reproduce it on Linux/macOS. Issue has repro repo with output from both platforms
Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...
X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...
Opengraph URL: https://github.com/angular/angular-cli/pull/34736
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e1219aa4-ebc2-de20-76f5-d45ec663dafa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B69E:2E3FEE:3788DA4:4657CF9:6B01E997 |
| html-safe-nonce | eb5801f2d332de7149ec638f5f0907df9a6c9ff44056a052b7879476cc590b18 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjlFOjJFM0ZFRTozNzg4REE0OjQ2NTdDRjk6NkIwMUU5OTciLCJ2aXNpdG9yX2lkIjoiNzkzMTY2Njk4NTIyNDYyODYzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 12938e2f0d3b014d80998d334e18f90bb7cb4de297745db371133ee260e3043f |
| hovercard-subject-tag | pull_request:5350883247 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34736/files |
| twitter:image | https://avatars.githubusercontent.com/u/5451538?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5451538?s=400&v=4 |
| og:image:alt | PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width