René's URL Explorer Experiment


Title: fix(@angular/pwa): support projects with the pre-v18 src/assets layout by MeAkib · Pull Request #34734 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/pwa): support projects with the pre-v18 src/assets layout by MeAkib · Pull Request #34734 · angular/angular-cli

X Title: fix(@angular/pwa): support projects with the pre-v18 src/assets layout by MeAkib · Pull Request #34734 · angular/angular-cli

Description: ng add @angular/pwa decides between the public and legacy src/assets layouts with host.exists(assetsDir), but Tree.exists() only matches files, so the legacy branch never runs and pre-v18 layout projects get the manifest and icons in a public directory their build does not serve. The manifest link injected into index.html then 404s and the application is not installable, while the schematic reports success. Detect the directory through its entries instead and restore the layout that worked before the public directory support was introduced: the manifest is written to the source root, where the asset entry added to the workspace configuration and the injected manifest link already point, and the icons are written to the existing assets directory with the manifest referencing them as assets/icons/*. The workspace file is now written after the asset entry additions, which previously happened after writeWorkspace() and were never persisted. Projects using the public directory layout are unaffected.

Open Graph Description: ng add @angular/pwa decides between the public and legacy src/assets layouts with host.exists(assetsDir), but Tree.exists() only matches files, so the legacy branch never runs and pre-v18 layout pr...

X Description: ng add @angular/pwa decides between the public and legacy src/assets layouts with host.exists(assetsDir), but Tree.exists() only matches files, so the legacy branch never runs and pre-v18 layout pr...

Opengraph URL: https://github.com/angular/angular-cli/pull/34734

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1a3e50c6-60b8-c0ab-b5b8-590d357d0ecf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD30E:31D532:11D7485:17B7290:6B01E997
html-safe-nonce22e34e79cc9487ef3074dcf0614649d4def5f05d575ca3b060be94dfda3b1c7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzBFOjMxRDUzMjoxMUQ3NDg1OjE3QjcyOTA6NkIwMUU5OTciLCJ2aXNpdG9yX2lkIjoiODQ3NTEzMjUxNDU2NDk1ODYxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd64cbf35104f1848771bef1c95a03045ccded91e2371268fb51ba1697468a499
hovercard-subject-tagpull_request:5341404437
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34734/files
twitter:imagehttps://avatars.githubusercontent.com/u/48770016?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/48770016?s=400&v=4
og:image:altng add @angular/pwa decides between the public and legacy src/assets layouts with host.exists(assetsDir), but Tree.exists() only matches files, so the legacy branch never runs and pre-v18 layout pr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34734/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34734%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34734%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34734/files
Reloadhttps://github.com/angular/angular-cli/pull/34734/files
Reloadhttps://github.com/angular/angular-cli/pull/34734/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
MeAkibhttps://github.com/MeAkib
angular:mainhttps://github.com/angular/angular-cli/tree/main
MeAkib:fix/pwa-legacy-assets-layouthttps://github.com/MeAkib/angular-cli/tree/fix/pwa-legacy-assets-layout
Conversation 0 https://github.com/angular/angular-cli/pull/34734
Commits 1 https://github.com/angular/angular-cli/pull/34734/commits
Checks 39 https://github.com/angular/angular-cli/pull/34734/checks
Files changed 2 https://github.com/angular/angular-cli/pull/34734/files
fix(@angular/pwa): support projects with the pre-v18 src/assets layout https://github.com/angular/angular-cli/pull/34734/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/34734/files
1aaf30b fix(@angular/pwa): support projects with the pre-v18 src/assets layout MeAkib Nov 16, 2026 https://github.com/angular/angular-cli/pull/34734/commits/1aaf30bba174ca45c1cd61eff22f91b4925b785b
Clear filters https://github.com/angular/angular-cli/pull/34734/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34734/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34734/files
index.ts https://github.com/angular/angular-cli/pull/34734/files#diff-0dca0bc75c24ec0dd38e278b2ae1915ae008c1cbfeca1e16b0506e06678edfb1
index_spec.ts https://github.com/angular/angular-cli/pull/34734/files#diff-289ff91ac060efc6dff2f80f848e5a09c25a1f0ec0f0c891e312b9a4695f2b6c
packages/angular/pwa/pwa/index.tshttps://github.com/angular/angular-cli/pull/34734/files#diff-0dca0bc75c24ec0dd38e278b2ae1915ae008c1cbfeca1e16b0506e06678edfb1
View file https://github.com/angular/angular-cli/blob/1aaf30bba174ca45c1cd61eff22f91b4925b785b/packages/angular/pwa/pwa/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34734/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34734/files#diff-0dca0bc75c24ec0dd38e278b2ae1915ae008c1cbfeca1e16b0506e06678edfb1
https://github.com/angular/angular-cli/pull/34734/files#diff-0dca0bc75c24ec0dd38e278b2ae1915ae008c1cbfeca1e16b0506e06678edfb1
https://github.com/angular/angular-cli/pull/34734/files#diff-0dca0bc75c24ec0dd38e278b2ae1915ae008c1cbfeca1e16b0506e06678edfb1
https://github.com/angular/angular-cli/pull/34734/files#diff-0dca0bc75c24ec0dd38e278b2ae1915ae008c1cbfeca1e16b0506e06678edfb1
https://github.com/angular/angular-cli/pull/34734/files#diff-0dca0bc75c24ec0dd38e278b2ae1915ae008c1cbfeca1e16b0506e06678edfb1
packages/angular/pwa/pwa/index_spec.tshttps://github.com/angular/angular-cli/pull/34734/files#diff-289ff91ac060efc6dff2f80f848e5a09c25a1f0ec0f0c891e312b9a4695f2b6c
View file https://github.com/angular/angular-cli/blob/1aaf30bba174ca45c1cd61eff22f91b4925b785b/packages/angular/pwa/pwa/index_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34734/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34734/files#diff-289ff91ac060efc6dff2f80f848e5a09c25a1f0ec0f0c891e312b9a4695f2b6c
Please reload this pagehttps://github.com/angular/angular-cli/pull/34734/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.