René's URL Explorer Experiment


Title: fix(@schematics/angular): set explicit type for the application root component by nagahara-naoki · Pull Request #34685 · angular/angular-cli · GitHub

Open Graph Title: fix(@schematics/angular): set explicit type for the application root component by nagahara-naoki · Pull Request #34685 · angular/angular-cli

X Title: fix(@schematics/angular): set explicit type for the application root component by nagahara-naoki · Pull Request #34685 · angular/angular-cli

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? When the workspace sets "@schematics/angular:component": { "type": "component" }, ng generate application --file-name-style-guide=2025 inherits that type for its root component. It generates app.component.css, while the application template generates app.ts referencing ./app.css. The first build fails with NG2008, and extra app.component.* files are left in the application. Issue Number: Closes #34684 What is the new behavior? Pass an explicit empty type when generating the application root component with the 2025 naming style, so the component files match the application templates: app.ts, app.html, and app.css. The 2016 branch continues to pass type: 'component'. Ordinary component generation still uses the workspace default. This follows the approach used in #34450 and #34472. The new E2E test sets the workspace component type, generates and builds applications using both naming styles, checks their stylesheet references and the absence of the incorrectly named root component, and verifies that a separately generated component still uses the workspace type. Does this PR introduce a breaking change? Yes No Other information Validated locally against main at d5035923f0e357b2526c98110125eee04b05192f: Before the fix, the new regression test fails during the generated application's build with NG2008. After the fix, the regression test and the existing schematic-defaults E2E test both pass. The Angular schematics unit suite reports 976 specs, 0 failures, and 1 existing pending spec. Prettier, ESLint on the production file, and git diff --check pass. Commands: pnpm bazel test //tests:e2e_node24 \ --config=e2e --config=no-sharding \ --test_filter='tests/generate/{application/application-workspace-type-default,schematic-defaults}.ts' \ --test_arg=--esbuild --nocache_test_results pnpm bazel test //packages/schematics/angular:test --config=no-sharding The full CLI repository test suite was not run.

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...

Opengraph URL: https://github.com/angular/angular-cli/pull/34685

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6b9bc447-fd06-ea7f-3323-10994430d312
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id81CA:2E124E:333E150:417E6F8:6B01E473
html-safe-nonce9efcffe2eb0fdbe91d526d52ba7e81d3387a448b5dc44e3761ee1f2297d5b4e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUNBOjJFMTI0RTozMzNFMTUwOjQxN0U2Rjg6NkIwMUU0NzMiLCJ2aXNpdG9yX2lkIjoiNTE2NTI0OTUzMzA3MTk3NTUzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd9ca8b11599c25d24133a4d0369c3dba605311a44d9c41ae6188c456d2a7c462
hovercard-subject-tagpull_request:5259045846
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34685/files
twitter:imagehttps://avatars.githubusercontent.com/u/118710021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/118710021?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34685/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34685%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34685%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34685/files
Reloadhttps://github.com/angular/angular-cli/pull/34685/files
Reloadhttps://github.com/angular/angular-cli/pull/34685/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
nagahara-naokihttps://github.com/nagahara-naoki
angular:mainhttps://github.com/angular/angular-cli/tree/main
nagahara-naoki:fix-application-component-typehttps://github.com/nagahara-naoki/angular-cli/tree/fix-application-component-type
Conversation 0 https://github.com/angular/angular-cli/pull/34685
Commits 1 https://github.com/angular/angular-cli/pull/34685/commits
Checks 11 https://github.com/angular/angular-cli/pull/34685/checks
Files changed 2 https://github.com/angular/angular-cli/pull/34685/files
fix(@schematics/angular): set explicit type for the application root component https://github.com/angular/angular-cli/pull/34685/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/34685/files
c3f60f9 fix(@schematics/angular): set explicit type for the application root … nagahara-naoki Nov 11, 2026 https://github.com/angular/angular-cli/pull/34685/commits/c3f60f92f748381f8293311f483f1b35071d9216
Clear filters https://github.com/angular/angular-cli/pull/34685/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34685/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34685/files
index.ts https://github.com/angular/angular-cli/pull/34685/files#diff-e38d84140bc2e1e6a2e1846a1bc9d4c2cb6c2ddcc87ca87d10d6cbf25811ec64
application-workspace-type-default.ts https://github.com/angular/angular-cli/pull/34685/files#diff-fe467e8c0df3fd80065ef577a00bec009ad520c3ee976c3f0c3aedd34ea0fcac
packages/schematics/angular/application/index.tshttps://github.com/angular/angular-cli/pull/34685/files#diff-e38d84140bc2e1e6a2e1846a1bc9d4c2cb6c2ddcc87ca87d10d6cbf25811ec64
View file https://github.com/angular/angular-cli/blob/c3f60f92f748381f8293311f483f1b35071d9216/packages/schematics/angular/application/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34685/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34685/files#diff-e38d84140bc2e1e6a2e1846a1bc9d4c2cb6c2ddcc87ca87d10d6cbf25811ec64
https://github.com/angular/angular-cli/pull/34685/files#diff-e38d84140bc2e1e6a2e1846a1bc9d4c2cb6c2ddcc87ca87d10d6cbf25811ec64
tests/e2e/tests/generate/application/application-workspace-type-default.tshttps://github.com/angular/angular-cli/pull/34685/files#diff-fe467e8c0df3fd80065ef577a00bec009ad520c3ee976c3f0c3aedd34ea0fcac
View file https://github.com/angular/angular-cli/blob/c3f60f92f748381f8293311f483f1b35071d9216/tests/e2e/tests/generate/application/application-workspace-type-default.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34685/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular-cli/pull/34685/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.