René's URL Explorer Experiment


Title: fix(@angular/build): use oxc-parser fallback when stripping source-map comments by clydin · Pull Request #34632 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/build): use oxc-parser fallback when stripping source-map comments by clydin · Pull Request #34632 · angular/angular-cli

X Title: fix(@angular/build): use oxc-parser fallback when stripping source-map comments by clydin · Pull Request #34632 · angular/angular-cli

Description: Previously, removeSourceMappingURL relied on a custom character-by-character state machine to strip top-level //# sourceMappingURL= comments from JavaScript strings. Because that scanner did not track regular expression literals, quote characters or backticks inside a regex literal (such as /"/) inverted string boundaries for the remainder of the file. When a subsequent string literal contained //# sourceMappingURL=, the scanner misidentified it as a top-level comment and truncated valid JavaScript, or failed to strip the actual trailing comment at the end of the chunk. Extend the single-trailing-comment fast path to string inputs and pass raw byte buffers directly from the Vite memory plugin so standard chunks slice trailing source-map comments without invoking a parser. When a file contains multiple or non-trailing //# sourceMappingURL= occurrences, lazily load oxc-parser and read only the comments of the parse result, avoiding JS-side AST deserialization while delegating full ECMAScript lexical handling (including regex literals, templates, and escapes) to Oxc. This keeps main-thread startup free of eager native or WASM parser loading. The fallback removes whitespace consistently with the fast path, removing comment-only lines entirely while preserving line terminators for comments that follow code. Also harden trailing URL and base64 validation so block comments or template literals closing on the same line are never misclassified by the fast path. Closes #34590

Open Graph Description: Previously, removeSourceMappingURL relied on a custom character-by-character state machine to strip top-level //# sourceMappingURL= comments from JavaScript strings. Because that scanner did not tr...

X Description: Previously, removeSourceMappingURL relied on a custom character-by-character state machine to strip top-level //# sourceMappingURL= comments from JavaScript strings. Because that scanner did not tr...

Opengraph URL: https://github.com/angular/angular-cli/pull/34632

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f26fd077-b91c-a9ba-29a2-fbbe39f35710
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEC4:11EACE:11DFD43:17DF8BE:6B011E7B
html-safe-nonceac46c8c8522aeb146d20280a5c13740c4e92d2b8ced0658dc473df61f560b8bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUM0OjExRUFDRToxMURGRDQzOjE3REY4QkU6NkIwMTFFN0IiLCJ2aXNpdG9yX2lkIjoiMjEzMTgyMTg0MTA5Njk3Mzk0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9e319b292fd58c0635edc5ef338b2b6e33d526540a8d19beaa8efab00faf70c9
hovercard-subject-tagpull_request:5121983963
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34632/files
twitter:imagehttps://avatars.githubusercontent.com/u/19598772?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19598772?s=400&v=4
og:image:altPreviously, removeSourceMappingURL relied on a custom character-by-character state machine to strip top-level //# sourceMappingURL= comments from JavaScript strings. Because that scanner did not tr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34632/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34632%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34632%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34632/files
Reloadhttps://github.com/angular/angular-cli/pull/34632/files
Reloadhttps://github.com/angular/angular-cli/pull/34632/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
clydinhttps://github.com/clydin
angular:mainhttps://github.com/angular/angular-cli/tree/main
clydin:fix/source-map-oxc-comment-strippinghttps://github.com/clydin/angular-cli/tree/fix/source-map-oxc-comment-stripping
Conversation 4 https://github.com/angular/angular-cli/pull/34632
Commits 3 https://github.com/angular/angular-cli/pull/34632/commits
Checks 39 https://github.com/angular/angular-cli/pull/34632/checks
Files changed 12 https://github.com/angular/angular-cli/pull/34632/files
fix(@angular/build): use oxc-parser fallback when stripping source-map comments https://github.com/angular/angular-cli/pull/34632/files#top
Show all changes 3 commits https://github.com/angular/angular-cli/pull/34632/files
575c988 fix(@angular/build): use oxc-parser fallback when stripping source-ma… clydin Oct 30, 2026 https://github.com/angular/angular-cli/pull/34632/commits/575c988150f1e2ffae26532fc71ea21aee2fe45f
ce1b638 fixup! fix(@angular/build): use oxc-parser fallback when stripping so… clydin Nov 2, 2026 https://github.com/angular/angular-cli/pull/34632/commits/ce1b638075e4d426adc79d46b27b25ab7ff389d9
69e3051 refactor(@angular/build): centralize oxc-parser loading with scoped W… clydin Nov 3, 2026 https://github.com/angular/angular-cli/pull/34632/commits/69e30518a4862d4158cf68fe252ae7a4cbf7c460
Clear filters https://github.com/angular/angular-cli/pull/34632/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34632/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34632/files
BUILD.bazel https://github.com/angular/angular-cli/pull/34632/files#diff-4e38d57b1b9374164f644a8a33664c299986b8022c69e74f6a949c87cb984cae
oxc-ast-host_spec.ts https://github.com/angular/angular-cli/pull/34632/files#diff-0ef61accbf6c5a305f9e4c929f408a8785ca9c629fa6f4c7243bf0593a442b10
i18n-inliner-worker.ts https://github.com/angular/angular-cli/pull/34632/files#diff-8286bb9cde4479188ce9d5ec6b9290ff0a34f7ad525cb74a456de84b03db1870
javascript-transformer-worker.ts https://github.com/angular/angular-cli/pull/34632/files#diff-173a9619da788c16e651856599f8b2431c8798bc914a139c87e4b9a232ce0143
load-oxc-parser.ts https://github.com/angular/angular-cli/pull/34632/files#diff-44cc572ce2c4202a82a1962a50746343db5afa7c356acb66f797a9b546bbf75a
load-oxc-parser_spec.ts https://github.com/angular/angular-cli/pull/34632/files#diff-7e75d7c59d89eeb752ae9a150684b2051d38973e4768f9ed51b8582b92f4bf0b
oxc-transform.ts https://github.com/angular/angular-cli/pull/34632/files#diff-ab71bbd7c77007d549a58993f8553660a7973cfdee3eb940b6ddd4fc8ce4c88a
oxc-wasi-shim.ts https://github.com/angular/angular-cli/pull/34632/files#diff-f343eae0474b7fcf943cdff4cf65e91544c5a9573f7513e84a50b6b5bc8b39f2
traversal.ts https://github.com/angular/angular-cli/pull/34632/files#diff-0aeb9efae4fd529eadec6431f66b63c0c6755efab2331fbf6d4c0cfaaabe4029
angular-memory-plugin.ts https://github.com/angular/angular-cli/pull/34632/files#diff-1606ea32e9ebfb3e2287640f1dd235f9a942dcefe7387a0525b00974a1eec6f6
source-map.ts https://github.com/angular/angular-cli/pull/34632/files#diff-11c4f9e3bd52af0d3707e9e600d00c545b5b69fa536d913a8ef0d67a5b36de2c
source-map_spec.ts https://github.com/angular/angular-cli/pull/34632/files#diff-1fbd76767923401ad7c4b90231d4560ad3c204e2c1f47dbfd3ba8851b2fc37fb
packages/angular/build/BUILD.bazelhttps://github.com/angular/angular-cli/pull/34632/files#diff-4e38d57b1b9374164f644a8a33664c299986b8022c69e74f6a949c87cb984cae
View file https://github.com/clydin/angular-cli/blob/69e30518a4862d4158cf68fe252ae7a4cbf7c460/packages/angular/build/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34632/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34632/files#diff-4e38d57b1b9374164f644a8a33664c299986b8022c69e74f6a949c87cb984cae
https://github.com/angular/angular-cli/pull/34632/files#diff-4e38d57b1b9374164f644a8a33664c299986b8022c69e74f6a949c87cb984cae
packages/angular/build/src/tools/angular/linker/oxc-ast-host_spec.tshttps://github.com/angular/angular-cli/pull/34632/files#diff-0ef61accbf6c5a305f9e4c929f408a8785ca9c629fa6f4c7243bf0593a442b10
View file https://github.com/clydin/angular-cli/blob/69e30518a4862d4158cf68fe252ae7a4cbf7c460/packages/angular/build/src/tools/angular/linker/oxc-ast-host_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34632/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34632/files#diff-0ef61accbf6c5a305f9e4c929f408a8785ca9c629fa6f4c7243bf0593a442b10
https://github.com/angular/angular-cli/pull/34632/files#diff-0ef61accbf6c5a305f9e4c929f408a8785ca9c629fa6f4c7243bf0593a442b10
https://github.com/angular/angular-cli/pull/34632/files#diff-0ef61accbf6c5a305f9e4c929f408a8785ca9c629fa6f4c7243bf0593a442b10
packages/angular/build/src/tools/i18n/i18n-inliner-worker.tshttps://github.com/angular/angular-cli/pull/34632/files#diff-8286bb9cde4479188ce9d5ec6b9290ff0a34f7ad525cb74a456de84b03db1870
View file https://github.com/clydin/angular-cli/blob/69e30518a4862d4158cf68fe252ae7a4cbf7c460/packages/angular/build/src/tools/i18n/i18n-inliner-worker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34632/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34632/files#diff-8286bb9cde4479188ce9d5ec6b9290ff0a34f7ad525cb74a456de84b03db1870
https://github.com/angular/angular-cli/pull/34632/files#diff-8286bb9cde4479188ce9d5ec6b9290ff0a34f7ad525cb74a456de84b03db1870
https://github.com/angular/angular-cli/pull/34632/files#diff-8286bb9cde4479188ce9d5ec6b9290ff0a34f7ad525cb74a456de84b03db1870
https://github.com/angular/angular-cli/pull/34632/files#diff-8286bb9cde4479188ce9d5ec6b9290ff0a34f7ad525cb74a456de84b03db1870
https://github.com/angular/angular-cli/pull/34632/files#diff-8286bb9cde4479188ce9d5ec6b9290ff0a34f7ad525cb74a456de84b03db1870
packages/angular/build/src/tools/javascript-transformer/javascript-transformer-worker.tshttps://github.com/angular/angular-cli/pull/34632/files#diff-173a9619da788c16e651856599f8b2431c8798bc914a139c87e4b9a232ce0143
View file https://github.com/clydin/angular-cli/blob/69e30518a4862d4158cf68fe252ae7a4cbf7c460/packages/angular/build/src/tools/javascript-transformer/javascript-transformer-worker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34632/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34632/files#diff-173a9619da788c16e651856599f8b2431c8798bc914a139c87e4b9a232ce0143
https://github.com/angular/angular-cli/pull/34632/files#diff-173a9619da788c16e651856599f8b2431c8798bc914a139c87e4b9a232ce0143
packages/angular/build/src/tools/oxc/load-oxc-parser.tshttps://github.com/angular/angular-cli/pull/34632/files#diff-44cc572ce2c4202a82a1962a50746343db5afa7c356acb66f797a9b546bbf75a
View file https://github.com/clydin/angular-cli/blob/69e30518a4862d4158cf68fe252ae7a4cbf7c460/packages/angular/build/src/tools/oxc/load-oxc-parser.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34632/{{ revealButtonHref }}
packages/angular/build/src/tools/oxc/load-oxc-parser_spec.tshttps://github.com/angular/angular-cli/pull/34632/files#diff-7e75d7c59d89eeb752ae9a150684b2051d38973e4768f9ed51b8582b92f4bf0b
View file https://github.com/clydin/angular-cli/blob/69e30518a4862d4158cf68fe252ae7a4cbf7c460/packages/angular/build/src/tools/oxc/load-oxc-parser_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34632/{{ revealButtonHref }}
packages/angular/build/src/tools/oxc/oxc-transform.tshttps://github.com/angular/angular-cli/pull/34632/files#diff-ab71bbd7c77007d549a58993f8553660a7973cfdee3eb940b6ddd4fc8ce4c88a
View file https://github.com/clydin/angular-cli/blob/69e30518a4862d4158cf68fe252ae7a4cbf7c460/packages/angular/build/src/tools/oxc/oxc-transform.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34632/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34632/files#diff-ab71bbd7c77007d549a58993f8553660a7973cfdee3eb940b6ddd4fc8ce4c88a
https://github.com/angular/angular-cli/pull/34632/files#diff-ab71bbd7c77007d549a58993f8553660a7973cfdee3eb940b6ddd4fc8ce4c88a
https://github.com/angular/angular-cli/pull/34632/files#diff-ab71bbd7c77007d549a58993f8553660a7973cfdee3eb940b6ddd4fc8ce4c88a
https://github.com/angular/angular-cli/pull/34632/files#diff-ab71bbd7c77007d549a58993f8553660a7973cfdee3eb940b6ddd4fc8ce4c88a
Please reload this pagehttps://github.com/angular/angular-cli/pull/34632/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34632/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.