René's URL Explorer Experiment


Title: fix(@schematics/angular): cast createSpyObj to MockedObject for jasmine.SpyObj variables in refactor-jasmine-vitest by thekhegay · Pull Request #34602 · angular/angular-cli · GitHub

Open Graph Title: fix(@schematics/angular): cast createSpyObj to MockedObject for jasmine.SpyObj variables in refactor-jasmine-vitest by thekhegay · Pull Request #34602 · angular/angular-cli

X Title: fix(@schematics/angular): cast createSpyObj to MockedObject for jasmine.SpyObj variables in refactor-jasmine-vitest by thekhegay · Pull Request #34602 · angular/angular-cli

Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? Issue Number: N/A Pattern from Angular testing guide let heroServiceSpy: jasmine.SpyObj; beforeEach(() => { heroServiceSpy = jasmine.createSpyObj('HeroService', ['getHeroes']); }); is migrated to MockedObject variable and object literal with only getHeroes. Jasmine createSpyObj returns any so it compiled before, after migration tsc fails with error TS2322: Type '{ getHeroes: Mock; }' is not assignable to type 'MockedObject'. File is reported as transformed and there is no TODO What is the new behavior? When createSpyObj initializes or is assigned to variable annotated with jasmine.SpyObj, literal is cast as MockedObject and type import is added. Declaration is looked up in nearest enclosing block, so svc declared in two describe blocks gets its own type in each. Migrated spec from above passes tsc --strict (TS 6.0, vitest 5.0) New spec cases cover assignment, initializer and two describe blocks with same name, they fail on main Does this PR introduce a breaking change? Yes No Other information Cast types members that were not spied as present, same as jasmine.SpyObj with untyped createSpyObj did before migration. Other option is TODO without cast, I went with cast since it keeps migrated tests compiling

Open Graph Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...

X Description: PR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...

Opengraph URL: https://github.com/angular/angular-cli/pull/34602

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:67a2ac2b-fab1-966f-3525-be9ce692ac8b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC78:D1D28:11CFD15:17AB6D4:6B01E998
html-safe-nonce3794e9a2c1c04ad980d4b6ac5a8b50789ef863617b880e99dbdf6591cd5e22f6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzc4OkQxRDI4OjExQ0ZEMTU6MTdBQjZENDo2QjAxRTk5OCIsInZpc2l0b3JfaWQiOiIyNTIzNzI0MDgyMDA1MDEwODQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac90361e75f88286d93130bf286246538f410b658620c9257a4634ff95a1a91fd9
hovercard-subject-tagpull_request:5082612902
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34602/files
twitter:imagehttps://avatars.githubusercontent.com/u/5451538?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5451538?s=400&v=4
og:image:altPR Checklist The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34602/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34602%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34602%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34602/files
Reloadhttps://github.com/angular/angular-cli/pull/34602/files
Reloadhttps://github.com/angular/angular-cli/pull/34602/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
thekhegayhttps://github.com/thekhegay
angular:mainhttps://github.com/angular/angular-cli/tree/main
thekhegay:jasmine-vitest-createspyobj-typehttps://github.com/thekhegay/angular-cli/tree/jasmine-vitest-createspyobj-type
Conversation 8 https://github.com/angular/angular-cli/pull/34602
Commits 3 https://github.com/angular/angular-cli/pull/34602/commits
Checks 10 https://github.com/angular/angular-cli/pull/34602/checks
Files changed https://github.com/angular/angular-cli/pull/34602/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34602/files
fix(@schematics/angular): cast createSpyObj to MockedObject for jasmine.SpyObj variables in refactor-jasmine-vitest https://github.com/angular/angular-cli/pull/34602/files#top
Show all changes 3 commits https://github.com/angular/angular-cli/pull/34602/files
991f480 fix(@schematics/angular): cast createSpyObj to MockedObject for jasmi… thekhegay Oct 30, 2026 https://github.com/angular/angular-cli/pull/34602/commits/991f4809e6c40744b30a1888dff61860310141a7
befdb9c fixup! fix(@schematics/angular): cast createSpyObj to MockedObject fo… thekhegay Oct 30, 2026 https://github.com/angular/angular-cli/pull/34602/commits/befdb9ca7f76d134c167b2485448b7389bedea59
89e35f4 fixup! fix(@schematics/angular): cast createSpyObj to MockedObject fo… thekhegay Nov 3, 2026 https://github.com/angular/angular-cli/pull/34602/commits/89e35f47b138f782a122e9ebb56b5830a075d476
Clear filters https://github.com/angular/angular-cli/pull/34602/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34602/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34602/files
jasmine-spy.ts https://github.com/angular/angular-cli/pull/34602/files#diff-00d4389ba97503285d1132eebe1ac7764b79176043e43e0d700e32fb682e2a53
jasmine-spy_spec.ts https://github.com/angular/angular-cli/pull/34602/files#diff-797d6c9574119f84619a4c839d32fb9b4da4a453171d609c1b8b2418add2f371
packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-spy.tshttps://github.com/angular/angular-cli/pull/34602/files#diff-00d4389ba97503285d1132eebe1ac7764b79176043e43e0d700e32fb682e2a53
View file https://github.com/angular/angular-cli/blob/89e35f47b138f782a122e9ebb56b5830a075d476/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-spy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34602/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34602/files#diff-00d4389ba97503285d1132eebe1ac7764b79176043e43e0d700e32fb682e2a53
https://github.com/angular/angular-cli/pull/34602/files#diff-00d4389ba97503285d1132eebe1ac7764b79176043e43e0d700e32fb682e2a53
https://github.com/angular/angular-cli/pull/34602/files#diff-00d4389ba97503285d1132eebe1ac7764b79176043e43e0d700e32fb682e2a53
Please reload this pagehttps://github.com/angular/angular-cli/pull/34602/files
https://github.com/angular/angular-cli/pull/34602/files#diff-00d4389ba97503285d1132eebe1ac7764b79176043e43e0d700e32fb682e2a53
packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-spy_spec.tshttps://github.com/angular/angular-cli/pull/34602/files#diff-797d6c9574119f84619a4c839d32fb9b4da4a453171d609c1b8b2418add2f371
View file https://github.com/angular/angular-cli/blob/89e35f47b138f782a122e9ebb56b5830a075d476/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-spy_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34602/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34602/files#diff-797d6c9574119f84619a4c839d32fb9b4da4a453171d609c1b8b2418add2f371
https://github.com/angular/angular-cli/pull/34602/files#diff-797d6c9574119f84619a4c839d32fb9b4da4a453171d609c1b8b2418add2f371
Please reload this pagehttps://github.com/angular/angular-cli/pull/34602/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.