René's URL Explorer Experiment


Title: fix(@angular/ssr): validate prerender parameter values by SkyZeroZx · Pull Request #34570 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/ssr): validate prerender parameter values by SkyZeroZx · Pull Request #34570 · angular/angular-cli

X Title: fix(@angular/ssr): validate prerender parameter values by SkyZeroZx · Pull Request #34570 · angular/angular-cli

Description: CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.

Open Graph Description: Reject getPrerenderParams values that are not valid path segments, such as a/b, .. or a value containing \, instead of prerendering a different route or redirect target. Fixes #34569

X Description: Reject getPrerenderParams values that are not valid path segments, such as a/b, .. or a value containing \, instead of prerendering a different route or redirect target. Fixes #34569

Opengraph URL: https://github.com/angular/angular-cli/pull/34570

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:11f3afd5-515a-ba7f-a82f-495d1fc30239
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC46:27EB5C:17293E:219A62:6AFDC10F
html-safe-nonce1045ba324c4496bb400d057452c3fc678d83fe716c7f051484db91ccf9572da6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzQ2OjI3RUI1QzoxNzI5M0U6MjE5QTYyOjZBRkRDMTBGIiwidmlzaXRvcl9pZCI6Ijc4MzMxNTE0MDgwNzA4MjI1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0ae10e1a4c42aeea072b24aa594bc7f63429dec04b221e867aab3be9a84bc44d
hovercard-subject-tagpull_request:5052881664
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular-cli/34570/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/42787ac1956d4f1c44eac239025868013544c88482a105211187a2d937e4cb8e/angular/angular-cli/pull/34570
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/42787ac1956d4f1c44eac239025868013544c88482a105211187a2d937e4cb8e/angular/angular-cli/pull/34570
og:image:altReject getPrerenderParams values that are not valid path segments, such as a/b, .. or a value containing \, instead of prerendering a different route or redirect target. Fixes #34569
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSkyZeroZx
hostnamegithub.com
expected-hostnamegithub.com
None35c6bf57da1370dc64866160540c0ee9f825f291935b3bf6ec5492b00e35f3a6
turbo-cache-controlno-cache
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseab48c73a2978548773f5f24717ed9e58508befdb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34570#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34570
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34570
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34570
Reloadhttps://github.com/angular/angular-cli/pull/34570
Reloadhttps://github.com/angular/angular-cli/pull/34570
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues196 (196)https://github.com/angular/angular-cli/issues
Pull requests20 (20)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
SkyZeroZx:fix/validate-prerender-param-valueshttps://github.com/SkyZeroZx/angular-cli/tree/fix/validate-prerender-param-values
Conversationhttps://github.com/angular/angular-cli/pull/34570
Commits3 (3)https://github.com/angular/angular-cli/pull/34570/commits
Checkshttps://github.com/angular/angular-cli/pull/34570/checks
Files changedhttps://github.com/angular/angular-cli/pull/34570/files
fix(@angular/ssr): validate prerender parameter valueshttps://github.com/angular/angular-cli/pull/34570#top
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
SkyZeroZx:fix/validate-prerender-param-valueshttps://github.com/SkyZeroZx/angular-cli/tree/fix/validate-prerender-param-values
https://github.com/SkyZeroZx
SkyZeroZxhttps://github.com/SkyZeroZx
Oct 28, 2026https://github.com/angular/angular-cli/pull/34570#issue-6081785587
#34569https://github.com/angular/angular-cli/issues/34569
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/SkyZeroZx
fix(@angular/ssr): validate prerender parameter valueshttps://github.com/angular/angular-cli/pull/34570/commits/abd7f7bb75344d8a0f16d663f27bae24f564d27c
abd7f7bhttps://github.com/angular/angular-cli/pull/34570/commits/abd7f7bb75344d8a0f16d663f27bae24f564d27c
angular#34569https://github.com/angular/angular-cli/issues/34569
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
area: @angular/ssr https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40angular%2Fssr%22
Oct 28, 2026https://github.com/angular/angular-cli/pull/34570#event-34489057495
https://github.com/apps/gemini-code-assist
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Oct 28, 2026 https://github.com/angular/angular-cli/pull/34570#pullrequestreview-5685010427
View reviewed changes https://github.com/angular/angular-cli/pull/34570/files/abd7f7bb75344d8a0f16d663f27bae24f564d27c
gemini-code-assisthttps://github.com/apps/gemini-code-assist
https://github.com/angular/angular-cli/pull/34570#pullrequestreview-5685010427
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
packages/angular/ssr/src/routes/ng-routes.tshttps://github.com/angular/angular-cli/pull/34570/files/abd7f7bb75344d8a0f16d663f27bae24f564d27c#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Oct 28, 2026 https://github.com/angular/angular-cli/pull/34570#pullrequestreview-5685854351
View reviewed changes https://github.com/angular/angular-cli/pull/34570/files/abd7f7bb75344d8a0f16d663f27bae24f564d27c
alan-agius4https://github.com/alan-agius4
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/angular/angular-cli/pull/34570#pullrequestreview-5685854351
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#34569https://github.com/angular/angular-cli/issues/34569
#34569https://github.com/angular/angular-cli/issues/34569
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
packages/angular/ssr/src/routes/ng-routes.tshttps://github.com/angular/angular-cli/pull/34570/files/abd7f7bb75344d8a0f16d663f27bae24f564d27c#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
packages/angular/ssr/src/routes/ng-routes.tshttps://github.com/angular/angular-cli/pull/34570/files/abd7f7bb75344d8a0f16d663f27bae24f564d27c#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/SkyZeroZx
fixup! fix(@angular/ssr): validate prerender parameter valueshttps://github.com/angular/angular-cli/pull/34570/commits/5b4836b99aa9de20a2aae4a0f15bfcde3f9ac912
5b4836bhttps://github.com/angular/angular-cli/pull/34570/commits/5b4836b99aa9de20a2aae4a0f15bfcde3f9ac912
https://github.com/SkyZeroZx
SkyZeroZxhttps://github.com/SkyZeroZx
Oct 28, 2026https://github.com/angular/angular-cli/pull/34570#issuecomment-6477383525
#34569https://github.com/angular/angular-cli/issues/34569
GHSA-jp2q-rh7r-4vjfhttps://github.com/angular/angular-cli/security/advisories/GHSA-jp2q-rh7r-4vjf
GHSA-w34w-96hf-98hjhttps://github.com/angular/angular-cli/security/advisories/GHSA-w34w-96hf-98hj
encodes every page segmenthttps://github.com/SkyZeroZx/angular-cli-prerender-param-ssrf-poc/blob/6728e7569f7e7ca1b244a031f0a074398f8b3e7a/lab/cms.mjs#L51
53b9623https://github.com/angular/angular-cli/commit/53b9623b7b4ee2266332f57e71896361dac21db8
#33044https://github.com/angular/angular-cli/issues/33044
slug validatorhttps://github.com/SkyZeroZx/angular-cli-prerender-param-ssrf-poc/blob/6728e7569f7e7ca1b244a031f0a074398f8b3e7a/lab/cms.mjs#L34
https://github.com/SkyZeroZx/angular-cli-prerender-param-ssrf-poc/tree/repro/prerender-param-minimalhttps://github.com/SkyZeroZx/angular-cli-prerender-param-ssrf-poc/tree/repro/prerender-param-minimal
four planted valueshttps://github.com/SkyZeroZx/angular-cli-prerender-param-ssrf-poc/blob/6728e7569f7e7ca1b244a031f0a074398f8b3e7a/lab/cms.mjs#L163
token interceptorhttps://github.com/SkyZeroZx/angular-cli-prerender-param-ssrf-poc/blob/6728e7569f7e7ca1b244a031f0a074398f8b3e7a/src/app/token.interceptor.ts
routeshttps://github.com/SkyZeroZx/angular-cli-prerender-param-ssrf-poc/blob/6728e7569f7e7ca1b244a031f0a074398f8b3e7a/src/app/app.routes.ts
@alan-agius4https://github.com/alan-agius4
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/SkyZeroZx
SkyZeroZxhttps://github.com/SkyZeroZx
alan-agius4https://github.com/alan-agius4
October 28, 2026 18:35https://github.com/angular/angular-cli/pull/34570#event-34507821101
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Oct 29, 2026 https://github.com/angular/angular-cli/pull/34570#pullrequestreview-5694469010
View reviewed changes https://github.com/angular/angular-cli/pull/34570/files/5b4836b99aa9de20a2aae4a0f15bfcde3f9ac912
alan-agius4https://github.com/alan-agius4
https://github.com/angular/angular-cli/pull/34570#pullrequestreview-5694469010
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@SkyZeroZxhttps://github.com/SkyZeroZx
#34569https://github.com/angular/angular-cli/issues/34569
Security Policy (SECURITY.md)https://github.com/angular/angular-cli/blob/main/SECURITY.md#policies
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
packages/angular/ssr/src/routes/ng-routes.tshttps://github.com/angular/angular-cli/pull/34570/files/5b4836b99aa9de20a2aae4a0f15bfcde3f9ac912#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
packages/angular/ssr/src/routes/ng-routes.tshttps://github.com/angular/angular-cli/pull/34570/files/5b4836b99aa9de20a2aae4a0f15bfcde3f9ac912#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
packages/angular/ssr/test/routes/ng-routes_spec.tshttps://github.com/angular/angular-cli/pull/34570/files/5b4836b99aa9de20a2aae4a0f15bfcde3f9ac912#diff-cb5be939ccf7ec9153bee6fdbe2965ebdcdf302ddc7c148b8f897f193714c345
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
action: cleanup https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
target: patch https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Oct 29, 2026https://github.com/angular/angular-cli/pull/34570#event-34560826901
https://github.com/SkyZeroZx
fixup! fix(@angular/ssr): validate prerender parameter valueshttps://github.com/angular/angular-cli/pull/34570/commits/8190c2026c0588fc1a5848b6885a4241b3a23f4e
8190c20https://github.com/angular/angular-cli/pull/34570/commits/8190c2026c0588fc1a5848b6885a4241b3a23f4e
https://github.com/SkyZeroZx
SkyZeroZxhttps://github.com/SkyZeroZx
alan-agius4https://github.com/alan-agius4
October 29, 2026 15:03https://github.com/angular/angular-cli/pull/34570#event-34599731385
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
action: cleanup https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Oct 30, 2026https://github.com/angular/angular-cli/pull/34570#event-34679897523
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Oct 30, 2026 https://github.com/angular/angular-cli/pull/34570#pullrequestreview-5710972627
View reviewed changes https://github.com/angular/angular-cli/pull/34570/files/8190c2026c0588fc1a5848b6885a4241b3a23f4e
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
action: merge https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Oct 30, 2026https://github.com/angular/angular-cli/pull/34570#event-34680324181
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
bf1602ahttps://github.com/angular/angular-cli/commit/bf1602a9163cc5b14a87736d171eec71982334b6
Oct 30, 2026https://github.com/angular/angular-cli/pull/34570#event-34681023201
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Oct 30, 2026https://github.com/angular/angular-cli/pull/34570#issuecomment-6520657602
bf1602ahttps://github.com/angular/angular-cli/commit/bf1602a9163cc5b14a87736d171eec71982334b6
dcd5029https://github.com/angular/angular-cli/commit/dcd5029bbdcbe1fe1761f8f7fefa0b83d81f4af3
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/SkyZeroZx
SkyZeroZxhttps://github.com/SkyZeroZx
Nov 16, 2026 https://github.com/angular/angular-cli/pull/34570#ref-issue-6415060026
Angular SSR prerender chunk-name collision desynchronizes Content-Length and contaminates other users' responses behind a proxy #34722 https://github.com/angular/angular-cli/issues/34722
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34570
https://github.com/alan-agius4
alan-agius4 https://github.com/alan-agius4
https://github.com/angular/angular-cli/pull/34570/files/8190c2026c0588fc1a5848b6885a4241b3a23f4e
https://github.com/apps/gemini-code-assist
gemini-code-assist[bot] https://github.com/apps/gemini-code-assist
https://github.com/angular/angular-cli/pull/34570/files/abd7f7bb75344d8a0f16d663f27bae24f564d27c
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
action: merge https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: @angular/ssr https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40angular%2Fssr%22
target: patch https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Angular SSR prerender params allow build-time SSRF, credential leaks, and open redirects https://github.com/angular/angular-cli/issues/34569
Please reload this pagehttps://github.com/angular/angular-cli/pull/34570
https://github.com/SkyZeroZx
https://github.com/alan-agius4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.