René's URL Explorer Experiment


Title: fix(@angular/ssr): destroy platform when request is aborted during rendering by alan-agius4 · Pull Request #34568 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/ssr): destroy platform when request is aborted during rendering by alan-agius4 · Pull Request #34568 · angular/angular-cli

X Title: fix(@angular/ssr): destroy platform when request is aborted during rendering by alan-agius4 · Pull Request #34568 · angular/angular-cli

Description: Previously, aborting request.signal during server-side rendering caused AngularServerApp.handle() to reject via promiseWithAbort, while renderAngular() continued running in the background until whenStable() completed (or leaked the platform if a pending task never resolved). This commit forwards request.signal into renderAngular() so that aborting an in-flight request destroys the underlying PlatformRef, cancels any pending render timer, and exits cleanly. Additionally, promiseWithAbort() now attaches rejection handlers to the underlying promise even when the signal is already aborted to avoid unhandled promise rejections. Closes #34567

Open Graph Description: Previously, aborting request.signal during server-side rendering caused AngularServerApp.handle() to reject via promiseWithAbort, while renderAngular() continued running in the background until whe...

X Description: Previously, aborting request.signal during server-side rendering caused AngularServerApp.handle() to reject via promiseWithAbort, while renderAngular() continued running in the background until whe...

Opengraph URL: https://github.com/angular/angular-cli/pull/34568

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f2803ca7-3609-f7f1-f8bb-d776c8fa7acf
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE0E:21AC3F:39742BA:48B72A3:6B01D975
html-safe-nonce16130aa0b2bdfea9eecba8a827c425fac4a071675a3b418a6208f1431018b184
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTBFOjIxQUMzRjozOTc0MkJBOjQ4QjcyQTM6NkIwMUQ5NzUiLCJ2aXNpdG9yX2lkIjoiMTAyNzg0ODA4MTYwMjg5NDE5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac73ab80289fa4df96d0cf3759c18a771ef6097d8196107a602d48782a1a2a1a55
hovercard-subject-tagpull_request:5051612337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34568/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altPreviously, aborting request.signal during server-side rendering caused AngularServerApp.handle() to reject via promiseWithAbort, while renderAngular() continued running in the background until whe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34568/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34568%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34568%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34568/files
Reloadhttps://github.com/angular/angular-cli/pull/34568/files
Reloadhttps://github.com/angular/angular-cli/pull/34568/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
alan-agius4:fix/ssr-abort-destroy-platformhttps://github.com/alan-agius4/angular-cli/tree/fix/ssr-abort-destroy-platform
Conversation 18 https://github.com/angular/angular-cli/pull/34568
Commits 3 https://github.com/angular/angular-cli/pull/34568/commits
Checks 38 https://github.com/angular/angular-cli/pull/34568/checks
Files changed https://github.com/angular/angular-cli/pull/34568/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
fix(@angular/ssr): destroy platform when request is aborted during rendering https://github.com/angular/angular-cli/pull/34568/files#top
Show all changes 3 commits https://github.com/angular/angular-cli/pull/34568/files
322f09f fix(@angular/ssr): destroy platform when request is aborted during re… alan-agius4 Oct 28, 2026 https://github.com/angular/angular-cli/pull/34568/commits/322f09f96351ada1cde2902bfecaf396d9444e02
a984205 fixup! fix(@angular/ssr): destroy platform when request is aborted du… alan-agius4 Oct 28, 2026 https://github.com/angular/angular-cli/pull/34568/commits/a984205bf4937ad5f4a9f7166a90a9d08a55b50e
212ad75 fixup! fix(@angular/ssr): destroy platform when request is aborted du… alan-agius4 Oct 28, 2026 https://github.com/angular/angular-cli/pull/34568/commits/212ad758cc6143e7e773beb10653daf05c621106
Clear filters https://github.com/angular/angular-cli/pull/34568/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
app-engine.ts https://github.com/angular/angular-cli/pull/34568/files#diff-9df5b3b80a3bd85ffc99332844919db77414775d776705b618f030efd6548bdc
app-engine.ts https://github.com/angular/angular-cli/pull/34568/files#diff-e73c5e1874d4865f0e28b188dbf677f900833cabc57dfed1020ba73132b151a8
app.ts https://github.com/angular/angular-cli/pull/34568/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
ng.ts https://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
promise.ts https://github.com/angular/angular-cli/pull/34568/files#diff-0a92c0de2636322d94a775ee1485ec98dc0b4d23650d073d29666a630f0fef74
app_spec.ts https://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
promise_spec.ts https://github.com/angular/angular-cli/pull/34568/files#diff-ea76e8d6b70e3507bb79b58e6ffa7bde4857d1d30d1201f98a63dd474a33ea71
tsconfig-build-esm.json https://github.com/angular/angular-cli/pull/34568/files#diff-cacf92c62c5a213513d587a9886bf3689619dcfa7204956132ad0bfed1b707af
packages/angular/ssr/node/src/app-engine.tshttps://github.com/angular/angular-cli/pull/34568/files#diff-9df5b3b80a3bd85ffc99332844919db77414775d776705b618f030efd6548bdc
View file https://github.com/alan-agius4/angular-cli/blob/212ad758cc6143e7e773beb10653daf05c621106/packages/angular/ssr/node/src/app-engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34568/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34568/files#diff-9df5b3b80a3bd85ffc99332844919db77414775d776705b618f030efd6548bdc
https://github.com/angular/angular-cli/pull/34568/files#diff-9df5b3b80a3bd85ffc99332844919db77414775d776705b618f030efd6548bdc
packages/angular/ssr/src/app-engine.tshttps://github.com/angular/angular-cli/pull/34568/files#diff-e73c5e1874d4865f0e28b188dbf677f900833cabc57dfed1020ba73132b151a8
View file https://github.com/alan-agius4/angular-cli/blob/212ad758cc6143e7e773beb10653daf05c621106/packages/angular/ssr/src/app-engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34568/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34568/files#diff-e73c5e1874d4865f0e28b188dbf677f900833cabc57dfed1020ba73132b151a8
https://github.com/angular/angular-cli/pull/34568/files#diff-e73c5e1874d4865f0e28b188dbf677f900833cabc57dfed1020ba73132b151a8
packages/angular/ssr/src/app.tshttps://github.com/angular/angular-cli/pull/34568/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
View file https://github.com/alan-agius4/angular-cli/blob/212ad758cc6143e7e773beb10653daf05c621106/packages/angular/ssr/src/app.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34568/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34568/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34568/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34568/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34568/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34568/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
packages/angular/ssr/src/utils/ng.tshttps://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
View file https://github.com/alan-agius4/angular-cli/blob/212ad758cc6143e7e773beb10653daf05c621106/packages/angular/ssr/src/utils/ng.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34568/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
dgp1130https://github.com/dgp1130
Oct 28, 2026https://github.com/angular/angular-cli/pull/34568/files#r4403789652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
alan-agius4https://github.com/alan-agius4
Oct 28, 2026https://github.com/angular/angular-cli/pull/34568/files#r4404303795
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
https://github.com/angular/angular-cli/pull/34568/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
packages/angular/ssr/src/utils/promise.tshttps://github.com/angular/angular-cli/pull/34568/files#diff-0a92c0de2636322d94a775ee1485ec98dc0b4d23650d073d29666a630f0fef74
View file https://github.com/alan-agius4/angular-cli/blob/212ad758cc6143e7e773beb10653daf05c621106/packages/angular/ssr/src/utils/promise.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34568/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34568/files#diff-0a92c0de2636322d94a775ee1485ec98dc0b4d23650d073d29666a630f0fef74
https://github.com/angular/angular-cli/pull/34568/files#diff-0a92c0de2636322d94a775ee1485ec98dc0b4d23650d073d29666a630f0fef74
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
https://github.com/angular/angular-cli/pull/34568/files#diff-0a92c0de2636322d94a775ee1485ec98dc0b4d23650d073d29666a630f0fef74
packages/angular/ssr/test/app_spec.tshttps://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
View file https://github.com/alan-agius4/angular-cli/blob/212ad758cc6143e7e773beb10653daf05c621106/packages/angular/ssr/test/app_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34568/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
dgp1130https://github.com/dgp1130
Oct 28, 2026https://github.com/angular/angular-cli/pull/34568/files#r4403904927
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
https://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34568/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34568/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.