René's URL Explorer Experiment


Title: fix(@angular-devkit/schematics): support delegating trees in `filter` and `partition` by Thanatos9404 · Pull Request #34539 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular-devkit/schematics): support delegating trees in `filter` and `partition` by Thanatos9404 · Pull Request #34539 · angular/angular-cli

X Title: fix(@angular-devkit/schematics): support delegating trees in `filter` and `partition` by Thanatos9404 · Pull Request #34539 · angular/angular-cli

Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? filter() only accepts a HostTree and throws "Tree type is not supported." for anything else. A UnitTestTree is a DelegateTree around a HostTree, so a schematic that uses filter() fails in unit tests when it runs on the tree returned by an earlier runSchematic call. Issue Number: #26000 What is the new behavior? filter() and partition() (behind partitionApplyMerge) call branch() on a delegating tree first, which returns a branch of the HostTree it wraps. Other tree types still throw as before. Does this PR introduce a breaking change? Yes No Other information The new specs in base_spec.ts cover filter on a plain HostTree (it had no spec) and filter and partitionApplyMerge on a nested UnitTestTree, since runSchematic returns a UnitTestTree around another one when the schematic edits its input tree in place. Locally, the UnitTestTree specs fail on main with "Tree type is not supported." and pass with this change, and the 86 specs under src/rules and src/tree pass (run with jasmine, not Bazel). Closes #26000

Open Graph Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-com...

X Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-com...

Opengraph URL: https://github.com/angular/angular-cli/pull/34539

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f31dc502-36f9-f0eb-71ac-f569db212737
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDAB2:1148D3:11B1E90:16A1055:6B011E7E
html-safe-nonceaad9ffe1dc4ff28573d29e385d816397fc934ce377a925c6a6d60740ad50d85a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUIyOjExNDhEMzoxMUIxRTkwOjE2QTEwNTU6NkIwMTFFN0UiLCJ2aXNpdG9yX2lkIjoiMzI5MDgyMDM1NTA2MDQ3MzQ3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7aba2dad83cd18b146093153e75220b42ecc53325d16cc0f77a306b796b8a564
hovercard-subject-tagpull_request:5034948226
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34539/files
twitter:imagehttps://avatars.githubusercontent.com/u/172882149?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/172882149?s=400&v=4
og:image:altPR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-com...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34539/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34539%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34539%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34539/files
Reloadhttps://github.com/angular/angular-cli/pull/34539/files
Reloadhttps://github.com/angular/angular-cli/pull/34539/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
Thanatos9404https://github.com/Thanatos9404
angular:mainhttps://github.com/angular/angular-cli/tree/main
Thanatos9404:fix/schematics-filter-delegate-treehttps://github.com/Thanatos9404/angular-cli/tree/fix/schematics-filter-delegate-tree
Conversation 7 https://github.com/angular/angular-cli/pull/34539
Commits 3 https://github.com/angular/angular-cli/pull/34539/commits
Checks 39 https://github.com/angular/angular-cli/pull/34539/checks
Files changed https://github.com/angular/angular-cli/pull/34539/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34539/files
fix(@angular-devkit/schematics): support delegating trees in filter and partition https://github.com/angular/angular-cli/pull/34539/files#top
Show all changes 3 commits https://github.com/angular/angular-cli/pull/34539/files
0fffc6d fix(@angular-devkit/schematics): support delegating trees in the `fil… Thanatos9404 Oct 27, 2026 https://github.com/angular/angular-cli/pull/34539/commits/0fffc6d003651c17c60c6c3e0814990822a63ee0
1f1d28d fixup! fix(@angular-devkit/schematics): support delegating trees in t… Thanatos9404 Oct 27, 2026 https://github.com/angular/angular-cli/pull/34539/commits/1f1d28d681eebe52187718adcec609fd79a5a9d9
68b5efa fix(@angular-devkit/schematics): support delegating trees in `partition` Thanatos9404 Oct 27, 2026 https://github.com/angular/angular-cli/pull/34539/commits/68b5efae4f70d7beedf55d5e2651b8a0ed8fcbd8
Clear filters https://github.com/angular/angular-cli/pull/34539/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34539/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34539/files
base.ts https://github.com/angular/angular-cli/pull/34539/files#diff-d1b8b64d7cb42d3a247a5679c8144da21f41d8d990b20f40c84296bb262e73db
base_spec.ts https://github.com/angular/angular-cli/pull/34539/files#diff-ae047451e6b85f0de503cf181de920160d2d41e0d499e491dd89663e4518e0c9
static.ts https://github.com/angular/angular-cli/pull/34539/files#diff-8c7602458c459f562cb58dcef49bf928a2e15858db53bdbdb3b77fae2a54a563
packages/angular_devkit/schematics/src/rules/base.tshttps://github.com/angular/angular-cli/pull/34539/files#diff-d1b8b64d7cb42d3a247a5679c8144da21f41d8d990b20f40c84296bb262e73db
View file https://github.com/Thanatos9404/angular-cli/blob/68b5efae4f70d7beedf55d5e2651b8a0ed8fcbd8/packages/angular_devkit/schematics/src/rules/base.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34539/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34539/files#diff-d1b8b64d7cb42d3a247a5679c8144da21f41d8d990b20f40c84296bb262e73db
https://github.com/angular/angular-cli/pull/34539/files#diff-d1b8b64d7cb42d3a247a5679c8144da21f41d8d990b20f40c84296bb262e73db
https://github.com/angular/angular-cli/pull/34539/files#diff-d1b8b64d7cb42d3a247a5679c8144da21f41d8d990b20f40c84296bb262e73db
https://github.com/angular/angular-cli/pull/34539/files#diff-d1b8b64d7cb42d3a247a5679c8144da21f41d8d990b20f40c84296bb262e73db
packages/angular_devkit/schematics/src/rules/base_spec.tshttps://github.com/angular/angular-cli/pull/34539/files#diff-ae047451e6b85f0de503cf181de920160d2d41e0d499e491dd89663e4518e0c9
View file https://github.com/Thanatos9404/angular-cli/blob/68b5efae4f70d7beedf55d5e2651b8a0ed8fcbd8/packages/angular_devkit/schematics/src/rules/base_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34539/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34539/files#diff-ae047451e6b85f0de503cf181de920160d2d41e0d499e491dd89663e4518e0c9
https://github.com/angular/angular-cli/pull/34539/files#diff-ae047451e6b85f0de503cf181de920160d2d41e0d499e491dd89663e4518e0c9
https://github.com/angular/angular-cli/pull/34539/files#diff-ae047451e6b85f0de503cf181de920160d2d41e0d499e491dd89663e4518e0c9
https://github.com/angular/angular-cli/pull/34539/files#diff-ae047451e6b85f0de503cf181de920160d2d41e0d499e491dd89663e4518e0c9
packages/angular_devkit/schematics/src/tree/static.tshttps://github.com/angular/angular-cli/pull/34539/files#diff-8c7602458c459f562cb58dcef49bf928a2e15858db53bdbdb3b77fae2a54a563
View file https://github.com/Thanatos9404/angular-cli/blob/68b5efae4f70d7beedf55d5e2651b8a0ed8fcbd8/packages/angular_devkit/schematics/src/tree/static.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34539/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34539/files#diff-8c7602458c459f562cb58dcef49bf928a2e15858db53bdbdb3b77fae2a54a563
https://github.com/angular/angular-cli/pull/34539/files#diff-8c7602458c459f562cb58dcef49bf928a2e15858db53bdbdb3b77fae2a54a563
https://github.com/angular/angular-cli/pull/34539/files#diff-8c7602458c459f562cb58dcef49bf928a2e15858db53bdbdb3b77fae2a54a563
Please reload this pagehttps://github.com/angular/angular-cli/pull/34539/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.