René's URL Explorer Experiment


Title: fix(@angular/ssr): resolve parameters in redirect targets by bschaeublin · Pull Request #34321 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/ssr): resolve parameters in redirect targets by bschaeublin · Pull Request #34321 · angular/angular-cli

X Title: fix(@angular/ssr): resolve parameters in redirect targets by bschaeublin · Pull Request #34321 · angular/angular-cli

Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? Follow-up to #34301 (comment). Parameters in a redirectTo target are sent unchanged in the server's Location header, while the router replaces them: Route Request Server Location Router navigates to user/:id → profile/:id /user/7 /profile/:id /profile/7 search/:term → /find?q=:x /search/cats?x=dogs /find?q=:x /find?q=dogs What is the new behavior? The server resolves both, one commit each, like the router does: Route parameters: during route extraction, :name in the redirect path becomes *, the position of that parameter in the request path, which buildPathWithParams resolves at request time. Prerendered routes get the value from getPrerenderParams. Only parameters of the redirecting route's own path can be used; any other :name is reported as an extraction error, matching the router's NG04001. Query placeholders of absolute redirects: q=:x takes the values of x from the request query, or undefined if it is missing. Does this PR introduce a breaking change? Yes No Other information The new extraction error only affects configs that the router already rejects with NG04001. Routes with a custom matcher are left unchanged, since their parameters are only known at runtime. Closes: #34410

Open Graph Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-comm...

X Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-comm...

Opengraph URL: https://github.com/angular/angular-cli/pull/34321

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fa9fe27a-2273-6ad5-575f-7c1cb0a0aa09
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF4C:3CFE29:4047D:5C8A1:6AFDD859
html-safe-nonce6ea7f6f44a684ab2aef1a0af83e24e21abbaded0d3d2cac496eef666c2a77351
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjRDOjNDRkUyOTo0MDQ3RDo1QzhBMTo2QUZERDg1OSIsInZpc2l0b3JfaWQiOiIxNzI4NDI0NTg4MzcyNDY1NzUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac99e93c3363bbd3306c80b29c0dc7ec6cb0a7f5de6b740466f75a746e05a9088b
hovercard-subject-tagpull_request:4831665039
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/34321/files
twitter:imagehttps://avatars.githubusercontent.com/u/11610660?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11610660?s=400&v=4
og:image:altPR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-comm...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9918bd4004419458bcd838065ac2a76b76ebd11705d73909fff5ab99e996fa23
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea231c174493a6a442c0b0544475c918b30128208
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/34321/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34321%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F34321%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/34321/files
Reloadhttps://github.com/angular/angular-cli/pull/34321/files
Reloadhttps://github.com/angular/angular-cli/pull/34321/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues196 (196)https://github.com/angular/angular-cli/issues
Pull requests20 (20)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
bschaeublinhttps://github.com/bschaeublin
angular:mainhttps://github.com/angular/angular-cli/tree/main
bschaeublin:fix/ssr-redirect-target-paramshttps://github.com/bschaeublin/angular-cli/tree/fix/ssr-redirect-target-params
Conversation 17 https://github.com/angular/angular-cli/pull/34321
Commits 4 https://github.com/angular/angular-cli/pull/34321/commits
Checks 58 https://github.com/angular/angular-cli/pull/34321/checks
Files changed https://github.com/angular/angular-cli/pull/34321/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
fix(@angular/ssr): resolve parameters in redirect targets https://github.com/angular/angular-cli/pull/34321/files#top
Show all changes 4 commits https://github.com/angular/angular-cli/pull/34321/files
1f12518 fix(@angular/ssr): resolve route parameters in redirect targets bschaeublin Oct 12, 2026 https://github.com/angular/angular-cli/pull/34321/commits/1f1251825a7bdaaaa6cdab067d67cc0b8289389e
4df24ec fixup! fix(@angular/ssr): resolve route parameters in redirect targets bschaeublin Oct 20, 2026 https://github.com/angular/angular-cli/pull/34321/commits/4df24ec5c281dd6bfe22872458fd2743e8de7122
dff1cab fix(@angular/ssr): resolve query parameter placeholders in redirect t… bschaeublin Oct 12, 2026 https://github.com/angular/angular-cli/pull/34321/commits/dff1cab8c64aa5ab7231be180f889040779543ac
1281fa8 fixup! fix(@angular/ssr): resolve query parameter placeholders in red… bschaeublin Oct 20, 2026 https://github.com/angular/angular-cli/pull/34321/commits/1281fa8efb1893648d567e8833a5cc204f503558
Clear filters https://github.com/angular/angular-cli/pull/34321/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
app.ts https://github.com/angular/angular-cli/pull/34321/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
ng-routes.ts https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
url.ts https://github.com/angular/angular-cli/pull/34321/files#diff-3c008a32fe9ef8fdde37a370240701348718b1d5cdeb39a0d00690be4b2e2521
app_spec.ts https://github.com/angular/angular-cli/pull/34321/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
ng-routes_spec.ts https://github.com/angular/angular-cli/pull/34321/files#diff-cb5be939ccf7ec9153bee6fdbe2965ebdcdf302ddc7c148b8f897f193714c345
url_spec.ts https://github.com/angular/angular-cli/pull/34321/files#diff-7c084e5be759b8630b279521d4d200a0f6cfd625bcc4ca32e47bbb4a7bb5882e
packages/angular/ssr/src/app.tshttps://github.com/angular/angular-cli/pull/34321/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
View file https://github.com/bschaeublin/angular-cli/blob/1281fa8efb1893648d567e8833a5cc204f503558/packages/angular/ssr/src/app.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34321/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34321/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34321/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34321/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
https://github.com/angular/angular-cli/pull/34321/files#diff-8ef62cb23ebfc354d39a8ed845d9a724d734f935785b65179986e097f0a8248e
packages/angular/ssr/src/routes/ng-routes.tshttps://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
View file https://github.com/bschaeublin/angular-cli/blob/1281fa8efb1893648d567e8833a5cc204f503558/packages/angular/ssr/src/routes/ng-routes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34321/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
https://github.com/angular/angular-cli/pull/34321/files#diff-fc750eeef1ce9e348f16a8ca827e2031d90c9f8b1ac129adf353e2cd74447f1b
packages/angular/ssr/src/utils/url.tshttps://github.com/angular/angular-cli/pull/34321/files#diff-3c008a32fe9ef8fdde37a370240701348718b1d5cdeb39a0d00690be4b2e2521
View file https://github.com/bschaeublin/angular-cli/blob/1281fa8efb1893648d567e8833a5cc204f503558/packages/angular/ssr/src/utils/url.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34321/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34321/files#diff-3c008a32fe9ef8fdde37a370240701348718b1d5cdeb39a0d00690be4b2e2521
https://github.com/angular/angular-cli/pull/34321/files#diff-3c008a32fe9ef8fdde37a370240701348718b1d5cdeb39a0d00690be4b2e2521
https://github.com/angular/angular-cli/pull/34321/files#diff-3c008a32fe9ef8fdde37a370240701348718b1d5cdeb39a0d00690be4b2e2521
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Oct 12, 2026https://github.com/angular/angular-cli/pull/34321/files#r4249848701
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://camo.githubusercontent.com/f9141739e81c5065c5f99ee945037104c1ba6def9f166570e17368344f990bdd/68747470733a2f2f7777772e677374617469632e636f6d2f636f64657265766965776167656e742f686967682d7072696f726974792e737667
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
bschaeublinhttps://github.com/bschaeublin
Oct 12, 2026https://github.com/angular/angular-cli/pull/34321/files#r4250441367
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
alan-agius4https://github.com/alan-agius4
Oct 20, 2026https://github.com/angular/angular-cli/pull/34321/files#r4322434921
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
bschaeublinhttps://github.com/bschaeublin
Oct 20, 2026https://github.com/angular/angular-cli/pull/34321/files#r4328051144
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
https://github.com/angular/angular-cli/pull/34321/files#diff-3c008a32fe9ef8fdde37a370240701348718b1d5cdeb39a0d00690be4b2e2521
packages/angular/ssr/test/app_spec.tshttps://github.com/angular/angular-cli/pull/34321/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
View file https://github.com/bschaeublin/angular-cli/blob/1281fa8efb1893648d567e8833a5cc204f503558/packages/angular/ssr/test/app_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/34321/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/34321/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34321/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/34321/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
alan-agius4https://github.com/alan-agius4
Oct 20, 2026https://github.com/angular/angular-cli/pull/34321/files#r4322434928
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
bschaeublinhttps://github.com/bschaeublin
Oct 20, 2026https://github.com/angular/angular-cli/pull/34321/files#r4328046218
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
https://github.com/angular/angular-cli/pull/34321/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/34321/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.