René's URL Explorer Experiment


Title: fix(@angular/build): ignore side-effect annotations in unit test builds by alan-agius4 · Pull Request #33917 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/build): ignore side-effect annotations in unit test builds by alan-agius4 · Pull Request #33917 · angular/angular-cli

X Title: fix(@angular/build): ignore side-effect annotations in unit test builds by alan-agius4 · Pull Request #33917 · angular/angular-cli

Description: In libraries built with ng-packagr, package.json typically specifies "sideEffects": false so consumer applications can tree-shake unused code. However, when executing unit tests through @angular/build:unit-test, the test builder bundles workspace library source directly (via tsconfig paths). Because esbuild tree-shaking respects "sideEffects": false annotations in the enclosing package.json, bundling multiple spec entry points without splitting can cause esbuild to prune module bodies (such as component definitions) from multi-level export * barrel graphs while retaining namespace re-export accessors. At runtime, accessing the exported symbols evaluates to undefined, causing failures such as TypeError: Cannot read properties of undefined (reading 'ɵcmp'). Test bundles are executed locally in memory and never distributed over the wire, so side-effect annotations and pure call pruning are not required. Setting ignoreAnnotations: true when disableCodeSplitting is enabled ensures that statically reachable barrel exports in workspace code are retained without affecting production application or package builds. Closes #33910

Open Graph Description: In libraries built with ng-packagr, package.json typically specifies "sideEffects": false so consumer applications can tree-shake unused code. However, when executing unit tests through @...

X Description: In libraries built with ng-packagr, package.json typically specifies "sideEffects": false so consumer applications can tree-shake unused code. However, when executing unit tests t...

Opengraph URL: https://github.com/angular/angular-cli/pull/33917

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:33ef1ce3-29c4-02e7-b0c5-b96f51d5aade
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED4E:E0ADF:152B364:1AB7B45:6B02137C
html-safe-nonce4767ff8e006157bdf1426bf3c079558629fc4b9fc92319c1a6817384b160e596
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDRFOkUwQURGOjE1MkIzNjQ6MUFCN0I0NTo2QjAyMTM3QyIsInZpc2l0b3JfaWQiOiI3NjQ4ODM3NzE5NDI2MjA4NjM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac227f2adbaa1b14fdd77b93d4a17d120c5d01eb99765c6407eead8c6c77b134c8
hovercard-subject-tagpull_request:4358191702
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/33917/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altIn libraries built with ng-packagr, package.json typically specifies "sideEffects": false so consumer applications can tree-shake unused code. However, when executing unit tests through @...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/33917/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33917%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33917%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/33917/files
Reloadhttps://github.com/angular/angular-cli/pull/33917/files
Reloadhttps://github.com/angular/angular-cli/pull/33917/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
alan-agius4:fix-unit-test-barrel-side-effectshttps://github.com/alan-agius4/angular-cli/tree/fix-unit-test-barrel-side-effects
Conversation 4 https://github.com/angular/angular-cli/pull/33917
Commits 1 https://github.com/angular/angular-cli/pull/33917/commits
Checks 39 https://github.com/angular/angular-cli/pull/33917/checks
Files changed https://github.com/angular/angular-cli/pull/33917/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917/files
fix(@angular/build): ignore side-effect annotations in unit test builds https://github.com/angular/angular-cli/pull/33917/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/33917/files
9f33518 fix(@angular/build): ignore side-effect annotations in unit test builds alan-agius4 Aug 25, 2026 https://github.com/angular/angular-cli/pull/33917/commits/9f3351843b3a9087492bdfbf4377c57414e1e26c
Clear filters https://github.com/angular/angular-cli/pull/33917/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917/files
vitest-barrel-side-effects_spec.ts https://github.com/angular/angular-cli/pull/33917/files#diff-5f70e384d9147c45ce5109164ba52404a028c554725b1500f98b7cf1e0a1e548
application-code-bundle.ts https://github.com/angular/angular-cli/pull/33917/files#diff-c92828b292a980ac9ce4a0e3fc1d4ed69c93c9488d7222741b30bc653be7dde2
...es/angular/build/src/builders/unit-test/tests/behavior/vitest-barrel-side-effects_spec.tshttps://github.com/angular/angular-cli/pull/33917/files#diff-5f70e384d9147c45ce5109164ba52404a028c554725b1500f98b7cf1e0a1e548
View file https://github.com/alan-agius4/angular-cli/blob/9f3351843b3a9087492bdfbf4377c57414e1e26c/packages/angular/build/src/builders/unit-test/tests/behavior/vitest-barrel-side-effects_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33917/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917/files
packages/angular/build/src/tools/esbuild/application-code-bundle.tshttps://github.com/angular/angular-cli/pull/33917/files#diff-c92828b292a980ac9ce4a0e3fc1d4ed69c93c9488d7222741b30bc653be7dde2
View file https://github.com/alan-agius4/angular-cli/blob/9f3351843b3a9087492bdfbf4377c57414e1e26c/packages/angular/build/src/tools/esbuild/application-code-bundle.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33917/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/33917/files#diff-c92828b292a980ac9ce4a0e3fc1d4ed69c93c9488d7222741b30bc653be7dde2
https://github.com/angular/angular-cli/pull/33917/files#diff-c92828b292a980ac9ce4a0e3fc1d4ed69c93c9488d7222741b30bc653be7dde2
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.