René's URL Explorer Experiment


Title: fix(@angular/build): ignore side-effect annotations in unit test builds by alan-agius4 · Pull Request #33917 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/build): ignore side-effect annotations in unit test builds by alan-agius4 · Pull Request #33917 · angular/angular-cli

X Title: fix(@angular/build): ignore side-effect annotations in unit test builds by alan-agius4 · Pull Request #33917 · angular/angular-cli

Description: CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.

Open Graph Description: In libraries built with ng-packagr, package.json typically specifies "sideEffects": false so consumer applications can tree-shake unused code. However, when executing unit tests through @...

X Description: In libraries built with ng-packagr, package.json typically specifies "sideEffects": false so consumer applications can tree-shake unused code. However, when executing unit tests t...

Opengraph URL: https://github.com/angular/angular-cli/pull/33917

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9c0bd38d-c957-bfbd-7c53-3ed570db2141
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB29E:AFBD9:12E5C38:18FAC08:6B01EDE7
html-safe-nonce5b269221bbe96f6081fdbf7f1d3c9210322da11f6e9838005aada2ba38dbb8ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjlFOkFGQkQ5OjEyRTVDMzg6MThGQUMwODo2QjAxRURFNyIsInZpc2l0b3JfaWQiOiI4MzY4ODc5NTg5MjEyMTU1MzY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdefc6cfb3934547874f52ca8932917adac77bca25223970538156f1c05d5b21a
hovercard-subject-tagpull_request:4358191702
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular-cli/33917/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2ed6d6bcf69f278d492f67496b001dafa1447f5006e8daa3a3e8514ed0dd081a/angular/angular-cli/pull/33917
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2ed6d6bcf69f278d492f67496b001dafa1447f5006e8daa3a3e8514ed0dd081a/angular/angular-cli/pull/33917
og:image:altIn libraries built with ng-packagr, package.json typically specifies "sideEffects": false so consumer applications can tree-shake unused code. However, when executing unit tests through @...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealan-agius4
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/33917#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33917
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33917
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/33917
Reloadhttps://github.com/angular/angular-cli/pull/33917
Reloadhttps://github.com/angular/angular-cli/pull/33917
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
alan-agius4:fix-unit-test-barrel-side-effectshttps://github.com/alan-agius4/angular-cli/tree/fix-unit-test-barrel-side-effects
Conversationhttps://github.com/angular/angular-cli/pull/33917
Commits1 (1)https://github.com/angular/angular-cli/pull/33917/commits
Checkshttps://github.com/angular/angular-cli/pull/33917/checks
Files changedhttps://github.com/angular/angular-cli/pull/33917/files
fix(@angular/build): ignore side-effect annotations in unit test buildshttps://github.com/angular/angular-cli/pull/33917#top
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
alan-agius4:fix-unit-test-barrel-side-effectshttps://github.com/alan-agius4/angular-cli/tree/fix-unit-test-barrel-side-effects
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Aug 25, 2026https://github.com/angular/angular-cli/pull/33917#issue-5246433325
#33910https://github.com/angular/angular-cli/issues/33910
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
area: @angular/build https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40angular%2Fbuild%22
Aug 25, 2026https://github.com/angular/angular-cli/pull/33917#event-29980065210
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
action: review https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Aug 25, 2026https://github.com/angular/angular-cli/pull/33917#event-29980082935
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
clydinhttps://github.com/clydin
August 25, 2026 13:30https://github.com/angular/angular-cli/pull/33917#event-29980086865
https://github.com/apps/gemini-code-assist
gemini-code-assisthttps://github.com/apps/gemini-code-assist
Aug 25, 2026 https://github.com/angular/angular-cli/pull/33917#pullrequestreview-5019491851
View reviewed changes https://github.com/angular/angular-cli/pull/33917/files
gemini-code-assisthttps://github.com/apps/gemini-code-assist
https://github.com/angular/angular-cli/pull/33917#pullrequestreview-5019491851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917
packages/angular/build/src/builders/unit-test/tests/behavior/vitest-barrel-side-effects_spec.tshttps://github.com/angular/angular-cli/pull/33917/files#diff-5f70e384d9147c45ce5109164ba52404a028c554725b1500f98b7cf1e0a1e548
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917
https://github.com/alan-agius4
fix(@angular/build): ignore side-effect annotations in unit test buildshttps://github.com/angular/angular-cli/pull/33917/commits/9f3351843b3a9087492bdfbf4377c57414e1e26c
9f33518https://github.com/angular/angular-cli/pull/33917/commits/9f3351843b3a9087492bdfbf4377c57414e1e26c
angular#33910https://github.com/angular/angular-cli/issues/33910
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
force-pushedhttps://github.com/angular/angular-cli/compare/e1a935de068cc883f62136739e9818a16cae2a2a..9f3351843b3a9087492bdfbf4377c57414e1e26c
e1a935dhttps://github.com/angular/angular-cli/commit/e1a935de068cc883f62136739e9818a16cae2a2a
9f33518https://github.com/angular/angular-cli/commit/9f3351843b3a9087492bdfbf4377c57414e1e26c
Compare https://github.com/angular/angular-cli/compare/e1a935de068cc883f62136739e9818a16cae2a2a..9f3351843b3a9087492bdfbf4377c57414e1e26c
August 25, 2026 13:34https://github.com/angular/angular-cli/pull/33917#event-29980327541
https://github.com/clydin
clydinhttps://github.com/clydin
Aug 25, 2026 https://github.com/angular/angular-cli/pull/33917#pullrequestreview-5019984251
View reviewed changes https://github.com/angular/angular-cli/pull/33917/files/9f3351843b3a9087492bdfbf4377c57414e1e26c
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
action: merge https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 25, 2026https://github.com/angular/angular-cli/pull/33917#event-29983265044
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
4d0be68https://github.com/angular/angular-cli/commit/4d0be683b780a9a1629dc8f9cddad49153bddabf
Aug 25, 2026https://github.com/angular/angular-cli/pull/33917#event-29983315269
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
August 25, 2026 14:24https://github.com/angular/angular-cli/pull/33917#event-29983317513
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Aug 25, 2026https://github.com/angular/angular-cli/pull/33917#issuecomment-5411856096
4d0be68https://github.com/angular/angular-cli/commit/4d0be683b780a9a1629dc8f9cddad49153bddabf
3f132eahttps://github.com/angular/angular-cli/commit/3f132eaa97b95e16c58b8095c2566e3c78190446
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 20, 2026https://github.com/angular/angular-cli/pull/33917#issuecomment-6280319940
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Oct 20, 2026https://github.com/angular/angular-cli/pull/33917#event-33697344695
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33917
https://github.com/clydin
clydin https://github.com/clydin
https://github.com/angular/angular-cli/pull/33917/files/9f3351843b3a9087492bdfbf4377c57414e1e26c
https://github.com/apps/gemini-code-assist
gemini-code-assist[bot] https://github.com/apps/gemini-code-assist
https://github.com/angular/angular-cli/pull/33917/files/e1a935de068cc883f62136739e9818a16cae2a2a
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917
action: merge https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: @angular/build https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40angular%2Fbuild%22
target: patch https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
unit-test builder: "sideEffects": false elides statically-referenced barrel modules, component reads as undefined in TestBed https://github.com/angular/angular-cli/issues/33910
Please reload this pagehttps://github.com/angular/angular-cli/pull/33917
https://github.com/alan-agius4
https://github.com/clydin
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.