René's URL Explorer Experiment


Title: fix(@angular/build): serialize server manifest asset paths by Hexix23 · Pull Request #33901 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/build): serialize server manifest asset paths by Hexix23 · Pull Request #33901 · angular/angular-cli

X Title: fix(@angular/build): serialize server manifest asset paths by Hexix23 · Pull Request #33901 · angular/angular-cli

Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes Other... Please describe: What is the current behavior? Prerendered route parameters can become HTML output paths. The server manifest generator then embeds each output path into executable JavaScript in two places without serializing it as a JavaScript string. The vulnerable code is in generateAngularServerAppManifest(): serverAssets[file.path] = `{size: ${size}, hash: '${file.hash}', text: () => import('./${jsChunkFilePath}').then(m => m.default)}`; // ... Object.entries(serverAssets) .map(([key, value]) => `'${key}': ${value}`) file.path is used as a single-quoted object key and its derived chunk path is used as a single-quoted dynamic import specifier. A quote or line terminator in a route-derived output path is therefore interpreted as JavaScript syntax instead of remaining string data. The source-to-sink path is: getPrerenderParams() route value -> prerendered /index.html output path -> additionalHtmlOutputFiles -> generateAngularServerAppManifest() -> unescaped object key and dynamic import specifier -> executable angular-app-manifest.mjs Because main.server.mjs imports the generated manifest, injected source can execute when the emitted Node server artifact is imported or started. The build itself does not need to execute the inserted source. Issue Number: N/A What is the new behavior? Both route-derived path uses are emitted with JSON.stringify(). This keeps quotes, line terminators, backslashes, and other JavaScript-significant characters inside string literals. The regression test supplies a file-system-valid asset path containing an apostrophe, verifies the exact serialized object key and import specifier, and parses the complete generated manifest with esbuild. Does this PR introduce a breaking change? Yes No Other information The affected path is part of the standard application builder's SSR/prerender flow. The fix does not change safe asset paths, chunk naming, route semantics, or the generated manifest API. Validation: pnpm bazel test //packages/angular/build:test --test_filter='generateAngularServerAppManifest'

Open Graph Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-comm...

X Description: PR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-comm...

Opengraph URL: https://github.com/angular/angular-cli/pull/33901

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8d2f163b-ac6b-bd5f-0cb0-363754f7ef71
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id828C:371B99:9766D9:D4A9EA:6AFDCA57
html-safe-nonceb7ab5e0ff0235cb645ac4b10550e5816ab08b8c4971cbc52f2fd4dc828eb2118
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjhDOjM3MUI5OTo5NzY2RDk6RDRBOUVBOjZBRkRDQTU3IiwidmlzaXRvcl9pZCI6Ijc3MDU2OTQ5ODYxMTY2NDc1MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac54d9b2c1e91461589669ac9da1bbc8aaf4bc7a9ff0ccc62a83c90fe8ca422ea2
hovercard-subject-tagpull_request:4344021087
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/33901/files
twitter:imagehttps://avatars.githubusercontent.com/u/62616592?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/62616592?s=400&v=4
og:image:altPR Checklist Please check to confirm your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-comm...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9ab00cc3b4fa90bbd3da70765dd38efc23cfa9d9b0930e41feea2bf67f60ecaf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1b795ba060b92691fc16c5a12cf2bf95e83432b4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/33901/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33901%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33901%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/33901/files
Reloadhttps://github.com/angular/angular-cli/pull/33901/files
Reloadhttps://github.com/angular/angular-cli/pull/33901/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues196 (196)https://github.com/angular/angular-cli/issues
Pull requests20 (20)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
Hexix23https://github.com/Hexix23
angular:mainhttps://github.com/angular/angular-cli/tree/main
Hexix23:fix/angular-build-serialize-server-asset-pathshttps://github.com/Hexix23/angular-cli/tree/fix/angular-build-serialize-server-asset-paths
Conversation 12 https://github.com/angular/angular-cli/pull/33901
Commits 1 https://github.com/angular/angular-cli/pull/33901/commits
Checks 47 https://github.com/angular/angular-cli/pull/33901/checks
Files changed https://github.com/angular/angular-cli/pull/33901/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33901/files
fix(@angular/build): serialize server manifest asset paths https://github.com/angular/angular-cli/pull/33901/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/33901/files
7ac0aa0 fix(@angular/build): serialize server manifest asset paths Hexix23 Aug 23, 2026 https://github.com/angular/angular-cli/pull/33901/commits/7ac0aa00fc6efb7864dfc378b70b3ee2ed25a583
Clear filters https://github.com/angular/angular-cli/pull/33901/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33901/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33901/files
manifest.ts https://github.com/angular/angular-cli/pull/33901/files#diff-3f09e4d9132c5aa172dfc29091ed09b8f6ee9bdbb1bd13a0e446d05da861a5f4
manifest_spec.ts https://github.com/angular/angular-cli/pull/33901/files#diff-fe1f8b239419ce809936106aea8de5475e2b66533ae64ce982c4836c1a499445
packages/angular/build/src/utils/server-rendering/manifest.tshttps://github.com/angular/angular-cli/pull/33901/files#diff-3f09e4d9132c5aa172dfc29091ed09b8f6ee9bdbb1bd13a0e446d05da861a5f4
View file https://github.com/Hexix23/angular-cli/blob/7ac0aa00fc6efb7864dfc378b70b3ee2ed25a583/packages/angular/build/src/utils/server-rendering/manifest.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33901/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/33901/files#diff-3f09e4d9132c5aa172dfc29091ed09b8f6ee9bdbb1bd13a0e446d05da861a5f4
https://github.com/angular/angular-cli/pull/33901/files#diff-3f09e4d9132c5aa172dfc29091ed09b8f6ee9bdbb1bd13a0e446d05da861a5f4
https://github.com/angular/angular-cli/pull/33901/files#diff-3f09e4d9132c5aa172dfc29091ed09b8f6ee9bdbb1bd13a0e446d05da861a5f4
packages/angular/build/src/utils/server-rendering/manifest_spec.tshttps://github.com/angular/angular-cli/pull/33901/files#diff-fe1f8b239419ce809936106aea8de5475e2b66533ae64ce982c4836c1a499445
View file https://github.com/Hexix23/angular-cli/blob/7ac0aa00fc6efb7864dfc378b70b3ee2ed25a583/packages/angular/build/src/utils/server-rendering/manifest_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33901/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.