René's URL Explorer Experiment


Title: fix(@angular/ssr): use router to normalize URLs for comparison by alan-agius4 · Pull Request #33057 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/ssr): use router to normalize URLs for comparison by alan-agius4 · Pull Request #33057 · angular/angular-cli

X Title: fix(@angular/ssr): use router to normalize URLs for comparison by alan-agius4 · Pull Request #33057 · angular/angular-cli

Description: Updates constructDecodedUrl in the SSR engine to use the Angular Router for parsing and serializing URLs instead of manual string manipulation and decoding. This ensures that the URL comparison used to determine if a redirect is necessary is consistent with how the router interprets and serializes the URL. This prevents issues where differences in encoding or edge cases (like duplicate query parameters or empty values) could lead to incorrect comparison results and unexpected redirects. Also updates tests to include edge cases for query parameters and paths to verify this behavior. Fixes #33053

Open Graph Description: Updates constructDecodedUrl in the SSR engine to use the Angular Router for parsing and serializing URLs instead of manual string manipulation and decoding. This ensures that the URL comparison use...

X Description: Updates constructDecodedUrl in the SSR engine to use the Angular Router for parsing and serializing URLs instead of manual string manipulation and decoding. This ensures that the URL comparison use...

Opengraph URL: https://github.com/angular/angular-cli/pull/33057

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:84d11e5a-38e3-04ac-f99c-4616eb3b796f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB10C:4141:5612B9:7C2FB9:6AFDD13E
html-safe-nonceefcde542b0224f345c68f4977e73836c08df143708e85cb0c2ff7d3e24055c3c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTBDOjQxNDE6NTYxMkI5OjdDMkZCOTo2QUZERDEzRSIsInZpc2l0b3JfaWQiOiI0Njc2MDgyNzgzMTQ4OTc3MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfbd6aa2cde7eb5a38d1e713a5fb2e2377aaff349fc3dddc308b89ee79c21cec6
hovercard-subject-tagpull_request:3588352182
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/33057/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altUpdates constructDecodedUrl in the SSR engine to use the Angular Router for parsing and serializing URLs instead of manual string manipulation and decoding. This ensures that the URL comparison use...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None26886a40b582b821a7a76351e0a2f42b6d6160854b6e2520db24f31fd7be5da7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release68ebaa631a1d248d69ebde4b9c5defd3a19aeb2f
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/33057/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33057%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F33057%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/33057/files
Reloadhttps://github.com/angular/angular-cli/pull/33057/files
Reloadhttps://github.com/angular/angular-cli/pull/33057/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues196 (196)https://github.com/angular/angular-cli/issues
Pull requests20 (20)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
alan-agius4:encodingshttps://github.com/alan-agius4/angular-cli/tree/encodings
Conversation 5 https://github.com/angular/angular-cli/pull/33057
Commits 2 https://github.com/angular/angular-cli/pull/33057/commits
Checks 34 https://github.com/angular/angular-cli/pull/33057/checks
Files changed https://github.com/angular/angular-cli/pull/33057/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33057/files
fix(@angular/ssr): use router to normalize URLs for comparison https://github.com/angular/angular-cli/pull/33057/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/33057/files
128ff68 fix(@angular/ssr): use router to normalize URLs for comparison alan-agius4 Apr 27, 2026 https://github.com/angular/angular-cli/pull/33057/commits/128ff6834481e6c80d8dbadd1909ca12c4600433
8c926e8 fix(@angular/ssr): decode route segments when building and matching r… alan-agius4 Apr 27, 2026 https://github.com/angular/angular-cli/pull/33057/commits/8c926e8dd93bf8d53802565f310c57135adb8703
Clear filters https://github.com/angular/angular-cli/pull/33057/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33057/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/33057/files
route-tree.ts https://github.com/angular/angular-cli/pull/33057/files#diff-b4b0925a73ba21cdbb98f0484e05db8f74689e5915f3ff70b5c3cd0cb5e3caea
router.ts https://github.com/angular/angular-cli/pull/33057/files#diff-eb7b53e837bfede12674228495a8ef7bfba9ea4c9a3e25cce936df815e240f56
ng.ts https://github.com/angular/angular-cli/pull/33057/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
app_spec.ts https://github.com/angular/angular-cli/pull/33057/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
router_spec.ts https://github.com/angular/angular-cli/pull/33057/files#diff-f7bc9a661e4a6b2b3501864fc99943cc21b87a1c5c5a098a64a3b04213d29dfd
packages/angular/ssr/src/routes/route-tree.tshttps://github.com/angular/angular-cli/pull/33057/files#diff-b4b0925a73ba21cdbb98f0484e05db8f74689e5915f3ff70b5c3cd0cb5e3caea
View file https://github.com/alan-agius4/angular-cli/blob/8c926e8dd93bf8d53802565f310c57135adb8703/packages/angular/ssr/src/routes/route-tree.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33057/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/33057/files#diff-b4b0925a73ba21cdbb98f0484e05db8f74689e5915f3ff70b5c3cd0cb5e3caea
https://github.com/angular/angular-cli/pull/33057/files#diff-b4b0925a73ba21cdbb98f0484e05db8f74689e5915f3ff70b5c3cd0cb5e3caea
packages/angular/ssr/src/routes/router.tshttps://github.com/angular/angular-cli/pull/33057/files#diff-eb7b53e837bfede12674228495a8ef7bfba9ea4c9a3e25cce936df815e240f56
View file https://github.com/alan-agius4/angular-cli/blob/8c926e8dd93bf8d53802565f310c57135adb8703/packages/angular/ssr/src/routes/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33057/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/33057/files#diff-eb7b53e837bfede12674228495a8ef7bfba9ea4c9a3e25cce936df815e240f56
https://github.com/angular/angular-cli/pull/33057/files#diff-eb7b53e837bfede12674228495a8ef7bfba9ea4c9a3e25cce936df815e240f56
packages/angular/ssr/src/utils/ng.tshttps://github.com/angular/angular-cli/pull/33057/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
View file https://github.com/alan-agius4/angular-cli/blob/8c926e8dd93bf8d53802565f310c57135adb8703/packages/angular/ssr/src/utils/ng.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33057/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/33057/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
Please reload this pagehttps://github.com/angular/angular-cli/pull/33057/files
https://github.com/angular/angular-cli/pull/33057/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
https://github.com/angular/angular-cli/pull/33057/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
Please reload this pagehttps://github.com/angular/angular-cli/pull/33057/files
https://github.com/angular/angular-cli/pull/33057/files#diff-ff9bebde3248fcdf148a338cf97ed47dcc15d684c2af9c62d20dd619eb6c1f53
packages/angular/ssr/test/app_spec.tshttps://github.com/angular/angular-cli/pull/33057/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
View file https://github.com/alan-agius4/angular-cli/blob/8c926e8dd93bf8d53802565f310c57135adb8703/packages/angular/ssr/test/app_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33057/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/33057/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
https://github.com/angular/angular-cli/pull/33057/files#diff-fe02aa4a8c3c5a40e80d93a8b2d4a51bb2a6df36d3b1ee5533a6167e02e18ff5
packages/angular/ssr/test/routes/router_spec.tshttps://github.com/angular/angular-cli/pull/33057/files#diff-f7bc9a661e4a6b2b3501864fc99943cc21b87a1c5c5a098a64a3b04213d29dfd
View file https://github.com/alan-agius4/angular-cli/blob/8c926e8dd93bf8d53802565f310c57135adb8703/packages/angular/ssr/test/routes/router_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/33057/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/33057/files#diff-f7bc9a661e4a6b2b3501864fc99943cc21b87a1c5c5a098a64a3b04213d29dfd
Please reload this pagehttps://github.com/angular/angular-cli/pull/33057/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.