René's URL Explorer Experiment


Title: fix(@angular/build): ensure correct URL joining for prerender routes by alan-agius4 · Pull Request #31884 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/build): ensure correct URL joining for prerender routes by alan-agius4 · Pull Request #31884 · angular/angular-cli

X Title: fix(@angular/build): ensure correct URL joining for prerender routes by alan-agius4 · Pull Request #31884 · angular/angular-cli

Description: This commit addresses an issue where prerendering with i18n and a routesFile could lead to infinite redirect loops or failure to prerender index.html. The previous urlJoin utility was replaced with more robust URL manipulation functions (joinUrlParts, addTrailingSlash, stripLeadingSlash) to ensure that paths are correctly constructed, especially when dealing with base hrefs and locale subpaths. This ensures that routes from the routesFile are correctly joined with the base href, preventing malformed URLs that cause the redirection issues. Closes #31877

Open Graph Description: This commit addresses an issue where prerendering with i18n and a routesFile could lead to infinite redirect loops or failure to prerender index.html. The previous urlJoin utility was replaced with...

X Description: This commit addresses an issue where prerendering with i18n and a routesFile could lead to infinite redirect loops or failure to prerender index.html. The previous urlJoin utility was replaced with...

Opengraph URL: https://github.com/angular/angular-cli/pull/31884

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fc8e56c3-1556-39fe-7d11-5ae46ec2432b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8480:22ACE7:1FFEAC:2D4713:6AFDE1B4
html-safe-nonce11d5c579e0411b0408fa380ee9d138f6268bfc794fd50f10dc256c836228819a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDgwOjIyQUNFNzoxRkZFQUM6MkQ0NzEzOjZBRkRFMUI0IiwidmlzaXRvcl9pZCI6IjgzMzMyNTE5Mzc4NDM0MDUyMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace940e30603814d0ead9bf8cecb1e4873436a9899acea6d3bcd124736f8f6f01d
hovercard-subject-tagpull_request:3028782914
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/31884/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altThis commit addresses an issue where prerendering with i18n and a routesFile could lead to infinite redirect loops or failure to prerender index.html. The previous urlJoin utility was replaced with...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None90d7884679efe0f89b35e0eef84213a75179f38d11a62f2a0af551bbe5110799
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89e3d4b2f59ef440fc496c853aee1d9a06a137d6
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/31884/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F31884%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F31884%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/31884/files
Reloadhttps://github.com/angular/angular-cli/pull/31884/files
Reloadhttps://github.com/angular/angular-cli/pull/31884/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues196 (196)https://github.com/angular/angular-cli/issues
Pull requests20 (20)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular-cli/tree/main
alan-agius4:redirect-loop-ssghttps://github.com/alan-agius4/angular-cli/tree/redirect-loop-ssg
Conversation 5 https://github.com/angular/angular-cli/pull/31884
Commits 1 https://github.com/angular/angular-cli/pull/31884/commits
Checks 0 https://github.com/angular/angular-cli/pull/31884/checks
Files changed https://github.com/angular/angular-cli/pull/31884/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/31884/files
fix(@angular/build): ensure correct URL joining for prerender routes https://github.com/angular/angular-cli/pull/31884/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/31884/files
88b906d fix(@angular/build): ensure correct URL joining for prerender routes alan-agius4 Nov 20, 2025 https://github.com/angular/angular-cli/pull/31884/commits/88b906db65b9526680425868e4c1d2d8f35d6e3e
Clear filters https://github.com/angular/angular-cli/pull/31884/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/31884/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/31884/files
options.ts https://github.com/angular/angular-cli/pull/31884/files#diff-c31d390b8683db112fcc30e2ee984d893bdce6bd8e6d7d70c43ecc410a626a3d
prerender.ts https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
url.ts https://github.com/angular/angular-cli/pull/31884/files#diff-9a1232b645028b4575a2818030185f2f7364a06a3aaedd0dec3bb183df0c4a5a
packages/angular/build/src/builders/application/options.tshttps://github.com/angular/angular-cli/pull/31884/files#diff-c31d390b8683db112fcc30e2ee984d893bdce6bd8e6d7d70c43ecc410a626a3d
View file https://github.com/alan-agius4/angular-cli/blob/88b906db65b9526680425868e4c1d2d8f35d6e3e/packages/angular/build/src/builders/application/options.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31884/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/31884/files#diff-c31d390b8683db112fcc30e2ee984d893bdce6bd8e6d7d70c43ecc410a626a3d
https://github.com/angular/angular-cli/pull/31884/files#diff-c31d390b8683db112fcc30e2ee984d893bdce6bd8e6d7d70c43ecc410a626a3d
https://github.com/angular/angular-cli/pull/31884/files#diff-c31d390b8683db112fcc30e2ee984d893bdce6bd8e6d7d70c43ecc410a626a3d
https://github.com/angular/angular-cli/pull/31884/files#diff-c31d390b8683db112fcc30e2ee984d893bdce6bd8e6d7d70c43ecc410a626a3d
packages/angular/build/src/utils/server-rendering/prerender.tshttps://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
View file https://github.com/alan-agius4/angular-cli/blob/88b906db65b9526680425868e4c1d2d8f35d6e3e/packages/angular/build/src/utils/server-rendering/prerender.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31884/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
https://github.com/angular/angular-cli/pull/31884/files#diff-eebae2605918b70b406f13c94c8645f0a57cdda92502704e0dece31a5e15fcc0
packages/angular/build/src/utils/url.tshttps://github.com/angular/angular-cli/pull/31884/files#diff-9a1232b645028b4575a2818030185f2f7364a06a3aaedd0dec3bb183df0c4a5a
View file https://github.com/alan-agius4/angular-cli/blob/88b906db65b9526680425868e4c1d2d8f35d6e3e/packages/angular/build/src/utils/url.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31884/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/31884/files#diff-9a1232b645028b4575a2818030185f2f7364a06a3aaedd0dec3bb183df0c4a5a
hybristhttps://github.com/hybrist
Nov 20, 2025https://github.com/angular/angular-cli/pull/31884/files#r2546039453
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/athttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/at
Please reload this pagehttps://github.com/angular/angular-cli/pull/31884/files
alan-agius4https://github.com/alan-agius4
Nov 20, 2025https://github.com/angular/angular-cli/pull/31884/files#r2546167933
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/31884/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.