René's URL Explorer Experiment


Title: test(@angular/cli): add CI validation for MCP example code by clydin · Pull Request #31174 · angular/angular-cli · GitHub

Open Graph Title: test(@angular/cli): add CI validation for MCP example code by clydin · Pull Request #31174 · angular/angular-cli

X Title: test(@angular/cli): add CI validation for MCP example code by clydin · Pull Request #31174 · angular/angular-cli

Description: This commit introduces a new CI check to validate the correctness of code snippets and markdown structure within the find_examples markdown files. To support this, the previous the example_db_generator.js script has been refactored and consolidated into a single, unified, mode-driven script: process_examples.mjs. This improves maintainability and ensures consistent parsing and validation logic. The new script provides two new validation modes for CI: validate-structure: Parses all examples to validate their front matter and ensure they adhere to the required markdown heading structure. validate-code: Uses a pre-built Angular application harness to perform a full ng build on all example code, ensuring compilation and template correctness. NOTE: Only the structure checks are enabled within CI at this time.

Open Graph Description: This commit introduces a new CI check to validate the correctness of code snippets and markdown structure within the find_examples markdown files. To support this, the previous the example_db_gener...

X Description: This commit introduces a new CI check to validate the correctness of code snippets and markdown structure within the find_examples markdown files. To support this, the previous the example_db_gener...

Opengraph URL: https://github.com/angular/angular-cli/pull/31174

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7408fab8-58f1-c8d8-0830-79a9f5e86f54
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0BE:AA45D:2917F9F:38B5EE2:6964E30A
html-safe-nonce198c81ef4e9089a708b76e8b3dab9f10a0d0438a3e16ab3280b8f2f46f685d28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEJFOkFBNDVEOjI5MTdGOUY6MzhCNUVFMjo2OTY0RTMwQSIsInZpc2l0b3JfaWQiOiI3NTkyNjI4NTM3NTAzNTcyNzQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4f950c0ee5965b50367741705d596de950c3ef28f094ee642b83635aaab1b33b
hovercard-subject-tagpull_request:2817003656
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/31174/files
twitter:imagehttps://avatars.githubusercontent.com/u/19598772?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19598772?s=400&v=4
og:image:altThis commit introduces a new CI check to validate the correctness of code snippets and markdown structure within the find_examples markdown files. To support this, the previous the example_db_gener...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5838582163a1256e5ebd5086b7e1dc5cea93d82086c9c8b1395fb50f6ddab28d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8edad3509fd3b4374694551987974bbbcfd316c0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/31174/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F31174%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F31174%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/31174/files
Reloadhttps://github.com/angular/angular-cli/pull/31174/files
Reloadhttps://github.com/angular/angular-cli/pull/31174/files
angular https://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Notifications https://github.com/login?return_to=%2Fangular%2Fangular-cli
Fork 11.9k https://github.com/login?return_to=%2Fangular%2Fangular-cli
Star 27k https://github.com/login?return_to=%2Fangular%2Fangular-cli
Code https://github.com/angular/angular-cli
Issues 264 https://github.com/angular/angular-cli/issues
Pull requests 22 https://github.com/angular/angular-cli/pulls
Actions https://github.com/angular/angular-cli/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/angular/angular-cli/security
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
Insights https://github.com/angular/angular-cli/pulse
Code https://github.com/angular/angular-cli
Issues https://github.com/angular/angular-cli/issues
Pull requests https://github.com/angular/angular-cli/pulls
Actions https://github.com/angular/angular-cli/actions
Security https://github.com/angular/angular-cli/security
Insights https://github.com/angular/angular-cli/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
clydinhttps://github.com/clydin
angular:mainhttps://github.com/angular/angular-cli/tree/main
clydin:mcp/example-validationhttps://github.com/clydin/angular-cli/tree/mcp/example-validation
Conversation 6 https://github.com/angular/angular-cli/pull/31174
Commits 2 https://github.com/angular/angular-cli/pull/31174/commits
Checks 5 https://github.com/angular/angular-cli/pull/31174/checks
Files changed https://github.com/angular/angular-cli/pull/31174/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
test(@angular/cli): add CI validation for MCP example code https://github.com/angular/angular-cli/pull/31174/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/31174/files
0e9d54a test(@angular/cli): create validation harness for example code clydin Sep 9, 2025 https://github.com/angular/angular-cli/pull/31174/commits/0e9d54ad3b7299ca4b91150d3b1d081fb14458ea
815d358 test(@angular/cli): add CI validation for MCP example code clydin Sep 10, 2025 https://github.com/angular/angular-cli/pull/31174/commits/815d358760fbaaa75f9935533b1b0ae6439285b4
Clear filters https://github.com/angular/angular-cli/pull/31174/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
pr.yml https://github.com/angular/angular-cli/pull/31174/files#diff-15c806aa509538190832852f439e9921a23bec2da81f95ed0e4bf13c14e5b160
FIND_EXAMPLES_FORMAT.md https://github.com/angular/angular-cli/pull/31174/files#diff-617a8c9aef75b38122dd88a2dd424855cad93cb97a026d2825a0586622daffba
package.json https://github.com/angular/angular-cli/pull/31174/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
pnpm-lock.yaml https://github.com/angular/angular-cli/pull/31174/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bb
BUILD.bazel https://github.com/angular/angular-cli/pull/31174/files#diff-0ab1e1c1585e240617dbd4a7eb3fe258f2ffc2b95f85a8fd35854996b58c1ccb
angular.json https://github.com/angular/angular-cli/pull/31174/files#diff-472d633728856d5533d843982b9856e2432e16e6100e2a782a1924acdb309c82
package.json https://github.com/angular/angular-cli/pull/31174/files#diff-6ed24783cd45619535f1c5442c31ecb6e725216589ac4cc57636fc798a850aa0
app.ts https://github.com/angular/angular-cli/pull/31174/files#diff-310b9389861d6834483769ba960c4139f8f99328d0f38e7bb092dd63e7cdfe60
index.html https://github.com/angular/angular-cli/pull/31174/files#diff-a581598bdb6e6548d77eb7df05ba60b4168d691d9945e61b4365917ef716ddd1
main.ts https://github.com/angular/angular-cli/pull/31174/files#diff-2983d9daa9479dc0e522f56190d50db791716eeee7ba5bef088e29fd3ade2237
tsconfig.app.json https://github.com/angular/angular-cli/pull/31174/files#diff-cca6ed96782aa70e6ba51be82fd3ee484eda9f5e1741953c3edd3dd09163dcf2
tsconfig.json https://github.com/angular/angular-cli/pull/31174/files#diff-a485ec1b6b1c60cc09fd8d8c71ad1d862041591a5b6c81b21c61e7241b961fa5
example_db_generator.bzl https://github.com/angular/angular-cli/pull/31174/files#diff-802d8a0a63cf2f0a222d1d0223bda7d9fd8793ef8fc79295d402e3ac1cefb893
example_db_generator.js https://github.com/angular/angular-cli/pull/31174/files#diff-4f1d82d632d836de7a59c1c5f7bb83424357aebed1d4959dde545f45eb16e14d
process_examples.mjs https://github.com/angular/angular-cli/pull/31174/files#diff-2595534b27981194052fee3a9fb556948cdcb2236ef61b9eb1993f1e6625e70c
.github/workflows/pr.ymlhttps://github.com/angular/angular-cli/pull/31174/files#diff-15c806aa509538190832852f439e9921a23bec2da81f95ed0e4bf13c14e5b160
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/.github/workflows/pr.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/31174/files#diff-15c806aa509538190832852f439e9921a23bec2da81f95ed0e4bf13c14e5b160
alan-agius4https://github.com/alan-agius4
Sep 12, 2025https://github.com/angular/angular-cli/pull/31174/files#r2343470985
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
https://github.com/angular/angular-cli/pull/31174/files#diff-15c806aa509538190832852f439e9921a23bec2da81f95ed0e4bf13c14e5b160
docs/FIND_EXAMPLES_FORMAT.mdhttps://github.com/angular/angular-cli/pull/31174/files#diff-617a8c9aef75b38122dd88a2dd424855cad93cb97a026d2825a0586622daffba
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/docs/FIND_EXAMPLES_FORMAT.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
package.jsonhttps://github.com/angular/angular-cli/pull/31174/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/31174/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angular-cli/pull/31174/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angular-cli/pull/31174/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angular-cli/pull/31174/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
pnpm-lock.yamlhttps://github.com/angular/angular-cli/pull/31174/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bb
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/pnpm-lock.yaml
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
tools/BUILD.bazelhttps://github.com/angular/angular-cli/pull/31174/files#diff-0ab1e1c1585e240617dbd4a7eb3fe258f2ffc2b95f85a8fd35854996b58c1ccb
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/31174/files#diff-0ab1e1c1585e240617dbd4a7eb3fe258f2ffc2b95f85a8fd35854996b58c1ccb
tools/example-validation-harness/angular.jsonhttps://github.com/angular/angular-cli/pull/31174/files#diff-472d633728856d5533d843982b9856e2432e16e6100e2a782a1924acdb309c82
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/example-validation-harness/angular.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
alan-agius4https://github.com/alan-agius4
Sep 12, 2025https://github.com/angular/angular-cli/pull/31174/files#r2343482153
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
angular-cli/scripts/json-help.mtshttps://github.com/angular/angular-cli/blob/a195db338465f8b01d5e14b723bea350edd98b56/scripts/json-help.mts#L34-L35
a195db3https://github.com/angular/angular-cli/commit/a195db338465f8b01d5e14b723bea350edd98b56
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
alan-agius4https://github.com/alan-agius4
Sep 12, 2025https://github.com/angular/angular-cli/pull/31174/files#r2343780370
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
tools/example-validation-harness/package.jsonhttps://github.com/angular/angular-cli/pull/31174/files#diff-6ed24783cd45619535f1c5442c31ecb6e725216589ac4cc57636fc798a850aa0
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/example-validation-harness/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
alan-agius4https://github.com/alan-agius4
Sep 12, 2025https://github.com/angular/angular-cli/pull/31174/files#r2343468651
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
tools/example-validation-harness/src/app/app.tshttps://github.com/angular/angular-cli/pull/31174/files#diff-310b9389861d6834483769ba960c4139f8f99328d0f38e7bb092dd63e7cdfe60
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/example-validation-harness/src/app/app.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
tools/example-validation-harness/src/index.htmlhttps://github.com/angular/angular-cli/pull/31174/files#diff-a581598bdb6e6548d77eb7df05ba60b4168d691d9945e61b4365917ef716ddd1
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/example-validation-harness/src/index.html
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
tools/example-validation-harness/src/main.tshttps://github.com/angular/angular-cli/pull/31174/files#diff-2983d9daa9479dc0e522f56190d50db791716eeee7ba5bef088e29fd3ade2237
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/example-validation-harness/src/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
tools/example-validation-harness/tsconfig.app.jsonhttps://github.com/angular/angular-cli/pull/31174/files#diff-cca6ed96782aa70e6ba51be82fd3ee484eda9f5e1741953c3edd3dd09163dcf2
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/example-validation-harness/tsconfig.app.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
tools/example-validation-harness/tsconfig.jsonhttps://github.com/angular/angular-cli/pull/31174/files#diff-a485ec1b6b1c60cc09fd8d8c71ad1d862041591a5b6c81b21c61e7241b961fa5
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/example-validation-harness/tsconfig.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
tools/example_db_generator.bzlhttps://github.com/angular/angular-cli/pull/31174/files#diff-802d8a0a63cf2f0a222d1d0223bda7d9fd8793ef8fc79295d402e3ac1cefb893
View file https://github.com/angular/angular-cli/blob/815d358760fbaaa75f9935533b1b0ae6439285b4/tools/example_db_generator.bzl
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/31174/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/31174/files#diff-802d8a0a63cf2f0a222d1d0223bda7d9fd8793ef8fc79295d402e3ac1cefb893
Please reload this pagehttps://github.com/angular/angular-cli/pull/31174/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.