René's URL Explorer Experiment


Title: fix(@angular-devkit/build-angular): add a base href to karma debug context by IxquitilisSaid · Pull Request #19119 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular-devkit/build-angular): add a base href to karma debug context by IxquitilisSaid · Pull Request #19119 · angular/angular-cli

X Title: fix(@angular-devkit/build-angular): add a base href to karma debug context by IxquitilisSaid · Pull Request #19119 · angular/angular-cli

Description: This commits adds a base href value in the karma context iframe used to run unit tests. It solves #19116 where a unit test throws: No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document. Even if the application is fine. This is because the index.html from Angular CLI contains a base href value, but not the Karma context iframe. So when adding a unit test with a testing module that imports a NgModule, for example AppModule, which itself imports RouterModule, the unit test used to throw an error (regression appeared in router 3.1). That could be solved by either adding RouterTestingModule to the testing module, or by adding a provider { provide: APP_BASE_HREF, useValue: '/' }, but required to understand the issue. This solves the issue in a transparent way: developers won't even encounter the problem anymore.

Open Graph Description: This commits adds a base href value in the karma context iframe used to run unit tests. It solves #19116 where a unit test throws: No base href set. Please provide a value for the APP_BASE_HREF to...

X Description: This commits adds a base href value in the karma context iframe used to run unit tests. It solves #19116 where a unit test throws: No base href set. Please provide a value for the APP_BASE_HREF to...

Opengraph URL: https://github.com/angular/angular-cli/pull/19119

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:fed4d6b7-b780-966c-eddc-63ad9efd5bb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD188:31FE5:2D74DF:3B2738:6B025155
html-safe-nonceab7128d22dac18424c025b56953173dedd27a5b0463ddd5ea37da35c8db05f6f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTg4OjMxRkU1OjJENzRERjozQjI3Mzg6NkIwMjUxNTUiLCJ2aXNpdG9yX2lkIjoiNTk3MTc4MjcwNjk0MDQ5ODI2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca607dd87cf49155707a457f65211561232b90a5c9232cbee1cf7f207540f430e
hovercard-subject-tagpull_request:505817056
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/19119/files
twitter:imagehttps://avatars.githubusercontent.com/u/37155060?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/37155060?s=400&v=4
og:image:altThis commits adds a base href value in the karma context iframe used to run unit tests. It solves #19116 where a unit test throws: No base href set. Please provide a value for the APP_BASE_HREF to...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/19119/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F19119%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F19119%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/19119/files
Reloadhttps://github.com/angular/angular-cli/pull/19119/files
Reloadhttps://github.com/angular/angular-cli/pull/19119/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:masterhttps://github.com/angular/angular-cli/tree/master
IxquitilisSaid:fix-add-base-href-to-karma-debughttps://github.com/IxquitilisSaid/angular-cli/tree/fix-add-base-href-to-karma-debug
Conversation 5 https://github.com/angular/angular-cli/pull/19119
Commits 1 https://github.com/angular/angular-cli/pull/19119/commits
Checks 0 https://github.com/angular/angular-cli/pull/19119/checks
Files changed https://github.com/angular/angular-cli/pull/19119/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/19119/files
fix(@angular-devkit/build-angular): add a base href to karma debug context https://github.com/angular/angular-cli/pull/19119/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/19119/files
24854df fix(@angular-devkit/build-angular): add a base href to karma debug co… IxquitilisSaid Oct 19, 2020 https://github.com/angular/angular-cli/pull/19119/commits/24854df61ac7ee5d5ae95cf6b6114794134e776e
Clear filters https://github.com/angular/angular-cli/pull/19119/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/19119/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/19119/files
packages/angular_devkit/build_angular/src/webpack/plugins/karma-debug.htmlhttps://github.com/angular/angular-cli/pull/19119/files#diff-38ea98ac001d0363f067955cb491b6efa8aa23bba6b24fed0c052e68648bbbb2
View file https://github.com/IxquitilisSaid/angular-cli/blob/24854df61ac7ee5d5ae95cf6b6114794134e776e/packages/angular_devkit/build_angular/src/webpack/plugins/karma-debug.html
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/19119/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/19119/files#diff-38ea98ac001d0363f067955cb491b6efa8aa23bba6b24fed0c052e68648bbbb2
https://github.com/angular/angular-cli/pull/19119/files#diff-38ea98ac001d0363f067955cb491b6efa8aa23bba6b24fed0c052e68648bbbb2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.