| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9fb57abc-95b0-1698-034f-6523ddcc352f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DBA8:1EC9BC:2B32D1A:3716733:6B01B472 |
| html-safe-nonce | 436a5fb8b88e501e4a984899b29c47ddd736cfa7d50ae7afefa7a0ffdfc08c83 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkE4OjFFQzlCQzoyQjMyRDFBOjM3MTY3MzM6NkIwMUI0NzIiLCJ2aXNpdG9yX2lkIjoiNjU2NzEyOTkyOTM4Nzk3OTg5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ee363152e08f732a3b0f9364dd842abd00f681300fdc78c33f38d80dc7b6a37d |
| hovercard-subject-tag | pull_request:496613649 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/18951/files |
| twitter:image | https://avatars.githubusercontent.com/u/19598772?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19598772?s=400&v=4 |
| og:image:alt | This change adjusts the E2E schematic to generate a protractor configuration with the selenium promise manager disabled. It also adjusts the generated test files to use native promises and async/a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular-cli/pull/18951/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18951%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18951%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli |
| Reload | https://github.com/angular/angular-cli/pull/18951/files |
| Reload | https://github.com/angular/angular-cli/pull/18951/files |
| Reload | https://github.com/angular/angular-cli/pull/18951/files |
| angular | https://github.com/angular |
| angular-cli | https://github.com/angular/angular-cli |
| Code | https://github.com/angular/angular-cli |
| Issues198 (198) | https://github.com/angular/angular-cli/issues |
| Pull requests23 (23) | https://github.com/angular/angular-cli/pulls |
| Actions | https://github.com/angular/angular-cli/actions |
| Security and quality8 (8) | https://github.com/angular/angular-cli/security |
| Insights | https://github.com/angular/angular-cli/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose |
| clydin | https://github.com/clydin |
| angular:master | https://github.com/angular/angular-cli/tree/master |
| clydin:protractor-promise-manager | https://github.com/clydin/angular-cli/tree/protractor-promise-manager |
|
Conversation
1
| https://github.com/angular/angular-cli/pull/18951 |
|
Commits
3
| https://github.com/angular/angular-cli/pull/18951/commits |
|
Checks
0
| https://github.com/angular/angular-cli/pull/18951/checks |
|
Files changed
| https://github.com/angular/angular-cli/pull/18951/files |
| Please reload this page | https://github.com/angular/angular-cli/pull/18951/files |
|
feat(@schematics/angular): generate E2E tests with native promise support
| https://github.com/angular/angular-cli/pull/18951/files#top |
|
Show all changes
3 commits
| https://github.com/angular/angular-cli/pull/18951/files |
|
5530ba5
feat(@schematics/angular): generate E2E tests with native promise sup…
clydin Oct 1, 2020
| https://github.com/angular/angular-cli/pull/18951/commits/5530ba56dcde587d20259a774e123a0d488e0d59 |
|
8087404
test: update browser tests to support protractor with native promises
clydin Oct 2, 2020
| https://github.com/angular/angular-cli/pull/18951/commits/8087404c18222661aa692d77f6e2c0a4db562532 |
|
531d0f6
test: update E2E tests to support protractor with native promises
clydin Oct 2, 2020
| https://github.com/angular/angular-cli/pull/18951/commits/531d0f66bac119806eab8b2c207f37bb7f77e5a3 |
|
Clear filters
| https://github.com/angular/angular-cli/pull/18951/files |
| Please reload this page | https://github.com/angular/angular-cli/pull/18951/files |
| Please reload this page | https://github.com/angular/angular-cli/pull/18951/files |
|
protractor.conf.js.template
| https://github.com/angular/angular-cli/pull/18951/files#diff-8cbd31a1061e8fdcc7f001b9a5965cbc5c38442973afdd4d372cee1f1158cf1d |
|
app.e2e-spec.ts.template
| https://github.com/angular/angular-cli/pull/18951/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf |
|
app.po.ts.template
| https://github.com/angular/angular-cli/pull/18951/files#diff-c8e773a3af9ef3a4fdfb390fe10ab6a9f31f4fd9b1bd2f4c08d3cfbbd2925a90 |
|
tsconfig.json.template
| https://github.com/angular/angular-cli/pull/18951/files#diff-fb49b9e192f18a1dd79909a3e61eca86b232dd8c747ae12442a58cdbf2b4cd06 |
|
package.json.template
| https://github.com/angular/angular-cli/pull/18951/files#diff-73568a1e44c8a68fb000c5993540b30479d975f31491a97f3fd74b9ebab07835 |
|
protractor-saucelabs.conf.js
| https://github.com/angular/angular-cli/pull/18951/files#diff-90ee1b9c16c39c983c650bce70b18d64893022f21418042eb153af94948be040 |
|
lazy-load-syntax.ts
| https://github.com/angular/angular-cli/pull/18951/files#diff-ea7f544e587fd5ee7471605baaec3b77b25988a851002d6f6416e2782b290b24 |
|
rollup.ts
| https://github.com/angular/angular-cli/pull/18951/files#diff-85a4f1334ebb5698b3b4a9f38b3b6154c9f3f3c7bb4127be6d79d03cc2b4d227 |
|
library-consumption.ts
| https://github.com/angular/angular-cli/pull/18951/files#diff-939d5524496df91904a24f79573abfb29ab84d0456e7e968f02b385be80a91f3 |
|
legacy.ts
| https://github.com/angular/angular-cli/pull/18951/files#diff-eae74e8ee8259d0188da5bb282fb547e6e489e04a4d5c63cdedcfedc56d71b6f |
|
browsers.ts
| https://github.com/angular/angular-cli/pull/18951/files#diff-9fcacb31fee818ab756c17725ecdbf43693c8f0c75cb9d4cbbcfe0fab5168eca |
|
third-party-decorators.ts
| https://github.com/angular/angular-cli/pull/18951/files#diff-1504c7a134e45793e2f0c5e0c0ba5f570fea6714ece31d406bcd774f355aa661 |
| packages/schematics/angular/e2e/files/protractor.conf.js.template | https://github.com/angular/angular-cli/pull/18951/files#diff-8cbd31a1061e8fdcc7f001b9a5965cbc5c38442973afdd4d372cee1f1158cf1d |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/packages/schematics/angular/e2e/files/protractor.conf.js.template |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-8cbd31a1061e8fdcc7f001b9a5965cbc5c38442973afdd4d372cee1f1158cf1d |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-8cbd31a1061e8fdcc7f001b9a5965cbc5c38442973afdd4d372cee1f1158cf1d |
| packages/schematics/angular/e2e/files/src/app.e2e-spec.ts.template | https://github.com/angular/angular-cli/pull/18951/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/packages/schematics/angular/e2e/files/src/app.e2e-spec.ts.template |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf |
| packages/schematics/angular/e2e/files/src/app.po.ts.template | https://github.com/angular/angular-cli/pull/18951/files#diff-c8e773a3af9ef3a4fdfb390fe10ab6a9f31f4fd9b1bd2f4c08d3cfbbd2925a90 |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/packages/schematics/angular/e2e/files/src/app.po.ts.template |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
| packages/schematics/angular/e2e/files/tsconfig.json.template | https://github.com/angular/angular-cli/pull/18951/files#diff-fb49b9e192f18a1dd79909a3e61eca86b232dd8c747ae12442a58cdbf2b4cd06 |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/packages/schematics/angular/e2e/files/tsconfig.json.template |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-fb49b9e192f18a1dd79909a3e61eca86b232dd8c747ae12442a58cdbf2b4cd06 |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-fb49b9e192f18a1dd79909a3e61eca86b232dd8c747ae12442a58cdbf2b4cd06 |
| packages/schematics/angular/workspace/files/package.json.template | https://github.com/angular/angular-cli/pull/18951/files#diff-73568a1e44c8a68fb000c5993540b30479d975f31491a97f3fd74b9ebab07835 |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/packages/schematics/angular/workspace/files/package.json.template |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-73568a1e44c8a68fb000c5993540b30479d975f31491a97f3fd74b9ebab07835 |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-73568a1e44c8a68fb000c5993540b30479d975f31491a97f3fd74b9ebab07835 |
| tests/legacy-cli/e2e/assets/protractor-saucelabs.conf.js | https://github.com/angular/angular-cli/pull/18951/files#diff-90ee1b9c16c39c983c650bce70b18d64893022f21418042eb153af94948be040 |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/tests/legacy-cli/e2e/assets/protractor-saucelabs.conf.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-90ee1b9c16c39c983c650bce70b18d64893022f21418042eb153af94948be040 |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-90ee1b9c16c39c983c650bce70b18d64893022f21418042eb153af94948be040 |
| tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts | https://github.com/angular/angular-cli/pull/18951/files#diff-ea7f544e587fd5ee7471605baaec3b77b25988a851002d6f6416e2782b290b24 |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-ea7f544e587fd5ee7471605baaec3b77b25988a851002d6f6416e2782b290b24 |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-ea7f544e587fd5ee7471605baaec3b77b25988a851002d6f6416e2782b290b24 |
| tests/legacy-cli/e2e/tests/build/rollup.ts | https://github.com/angular/angular-cli/pull/18951/files#diff-85a4f1334ebb5698b3b4a9f38b3b6154c9f3f3c7bb4127be6d79d03cc2b4d227 |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/tests/legacy-cli/e2e/tests/build/rollup.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-85a4f1334ebb5698b3b4a9f38b3b6154c9f3f3c7bb4127be6d79d03cc2b4d227 |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-85a4f1334ebb5698b3b4a9f38b3b6154c9f3f3c7bb4127be6d79d03cc2b4d227 |
| tests/legacy-cli/e2e/tests/generate/library/library-consumption.ts | https://github.com/angular/angular-cli/pull/18951/files#diff-939d5524496df91904a24f79573abfb29ab84d0456e7e968f02b385be80a91f3 |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/tests/legacy-cli/e2e/tests/generate/library/library-consumption.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-939d5524496df91904a24f79573abfb29ab84d0456e7e968f02b385be80a91f3 |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-939d5524496df91904a24f79573abfb29ab84d0456e7e968f02b385be80a91f3 |
| tests/legacy-cli/e2e/tests/i18n/legacy.ts | https://github.com/angular/angular-cli/pull/18951/files#diff-eae74e8ee8259d0188da5bb282fb547e6e489e04a4d5c63cdedcfedc56d71b6f |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/tests/legacy-cli/e2e/tests/i18n/legacy.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-eae74e8ee8259d0188da5bb282fb547e6e489e04a4d5c63cdedcfedc56d71b6f |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-eae74e8ee8259d0188da5bb282fb547e6e489e04a4d5c63cdedcfedc56d71b6f |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-eae74e8ee8259d0188da5bb282fb547e6e489e04a4d5c63cdedcfedc56d71b6f |
| tests/legacy-cli/e2e/tests/misc/browsers.ts | https://github.com/angular/angular-cli/pull/18951/files#diff-9fcacb31fee818ab756c17725ecdbf43693c8f0c75cb9d4cbbcfe0fab5168eca |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/tests/legacy-cli/e2e/tests/misc/browsers.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-9fcacb31fee818ab756c17725ecdbf43693c8f0c75cb9d4cbbcfe0fab5168eca |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-9fcacb31fee818ab756c17725ecdbf43693c8f0c75cb9d4cbbcfe0fab5168eca |
| tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts | https://github.com/angular/angular-cli/pull/18951/files#diff-1504c7a134e45793e2f0c5e0c0ba5f570fea6714ece31d406bcd774f355aa661 |
|
View file
| https://github.com/clydin/angular-cli/blob/531d0f66bac119806eab8b2c207f37bb7f77e5a3/tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18951/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-1504c7a134e45793e2f0c5e0c0ba5f570fea6714ece31d406bcd774f355aa661 |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-1504c7a134e45793e2f0c5e0c0ba5f570fea6714ece31d406bcd774f355aa661 |
|
| https://github.com/angular/angular-cli/pull/18951/files#diff-1504c7a134e45793e2f0c5e0c0ba5f570fea6714ece31d406bcd774f355aa661 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |