René's URL Explorer Experiment


Title: Improve async handling in generated code by apeeters · Pull Request #18783 · angular/angular-cli · GitHub

Open Graph Title: Improve async handling in generated code by apeeters · Pull Request #18783 · angular/angular-cli

X Title: Improve async handling in generated code by apeeters · Pull Request #18783 · angular/angular-cli

Description: This PR fixes two tslint errors in generated projects: Promise returning method should be async Avoid floating promises

Open Graph Description: This PR fixes two tslint errors in generated projects: Promise returning method should be async Avoid floating promises

X Description: This PR fixes two tslint errors in generated projects: Promise returning method should be async Avoid floating promises

Opengraph URL: https://github.com/angular/angular-cli/pull/18783

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a800da74-a98b-6454-76c0-fcaca5b52325
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD306:2463BD:2EABA4E:3BA00F4:6B01B478
html-safe-noncef080fe2d9df48eeab38fbe353cb7eb5a36e20b2ad9a83546403f26abb4783c11
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzA2OjI0NjNCRDoyRUFCQTRFOjNCQTAwRjQ6NkIwMUI0NzgiLCJ2aXNpdG9yX2lkIjoiNDAzNzYwMjQ5Nzk1NzgzNTg5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5ef9810dc5b6c9898ffddc9ad4960a35aad418f40768fb4ad85f170c15cfd649
hovercard-subject-tagpull_request:486580565
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/18783/files
twitter:imagehttps://avatars.githubusercontent.com/u/180816?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/180816?s=400&v=4
og:image:altThis PR fixes two tslint errors in generated projects: Promise returning method should be async Avoid floating promises
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/18783/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18783%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18783%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/18783/files
Reloadhttps://github.com/angular/angular-cli/pull/18783/files
Reloadhttps://github.com/angular/angular-cli/pull/18783/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
apeetershttps://github.com/apeeters
angular:masterhttps://github.com/angular/angular-cli/tree/master
apeeters:fix_asynchttps://github.com/apeeters/angular-cli/tree/fix_async
Conversation 9 https://github.com/angular/angular-cli/pull/18783
Commits 2 https://github.com/angular/angular-cli/pull/18783/commits
Checks 0 https://github.com/angular/angular-cli/pull/18783/checks
Files changed https://github.com/angular/angular-cli/pull/18783/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783/files
Improve async handling in generated code https://github.com/angular/angular-cli/pull/18783/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/18783/files
c35b541 fix(@schematics/angular): Make sure promise returning methods are async apeeters Sep 14, 2020 https://github.com/angular/angular-cli/pull/18783/commits/c35b5415cb6f69db338a936e3714786bb339e46d
a960cc0 fix(@schematics/angular): Fix handling of returned promises apeeters Sep 14, 2020 https://github.com/angular/angular-cli/pull/18783/commits/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5
Clear filters https://github.com/angular/angular-cli/pull/18783/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783/files
app.e2e-spec.ts https://github.com/angular/angular-cli/pull/18783/files#diff-dc79b38b0b46bc1c951c0332da49f6cd94bf997dae485edd7f862dcb2ceb0ebb
app.po.ts https://github.com/angular/angular-cli/pull/18783/files#diff-902a61f2d53a8d0fa6ec6be514999d236ee46ef8d9c0e550d3c1bb72bdd4b910
app.e2e-spec.ts https://github.com/angular/angular-cli/pull/18783/files#diff-fd5138b2d24d38f1d20b902e52f287e4cbb490c0ad6cacfb4fa930d09f87e2ce
app.po.ts https://github.com/angular/angular-cli/pull/18783/files#diff-e956c7567a7905d219dedd1dcd9db209d3d51bd1edbf7db8cbe5cbf40f71f6c7
app.e2e-spec.ts.template https://github.com/angular/angular-cli/pull/18783/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf
app.po.ts.template https://github.com/angular/angular-cli/pull/18783/files#diff-c8e773a3af9ef3a4fdfb390fe10ab6a9f31f4fd9b1bd2f4c08d3cfbbd2925a90
integration/angular_cli/e2e/src/app.e2e-spec.tshttps://github.com/angular/angular-cli/pull/18783/files#diff-dc79b38b0b46bc1c951c0332da49f6cd94bf997dae485edd7f862dcb2ceb0ebb
View file https://github.com/apeeters/angular-cli/blob/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5/integration/angular_cli/e2e/src/app.e2e-spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18783/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18783/files#diff-dc79b38b0b46bc1c951c0332da49f6cd94bf997dae485edd7f862dcb2ceb0ebb
clydinhttps://github.com/clydin
Sep 15, 2020https://github.com/angular/angular-cli/pull/18783/files#r488662719
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783/files
apeetershttps://github.com/apeeters
Sep 15, 2020https://github.com/angular/angular-cli/pull/18783/files#r488801497
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783/files
alan-agius4https://github.com/alan-agius4
Sep 18, 2020https://github.com/angular/angular-cli/pull/18783/files#r490971224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783/files
https://github.com/angular/angular-cli/pull/18783/files#diff-dc79b38b0b46bc1c951c0332da49f6cd94bf997dae485edd7f862dcb2ceb0ebb
integration/angular_cli/e2e/src/app.po.tshttps://github.com/angular/angular-cli/pull/18783/files#diff-902a61f2d53a8d0fa6ec6be514999d236ee46ef8d9c0e550d3c1bb72bdd4b910
View file https://github.com/apeeters/angular-cli/blob/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5/integration/angular_cli/e2e/src/app.po.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18783/{{ revealButtonHref }}
packages/angular_devkit/build_angular/test/hello-world-app/e2e/app.e2e-spec.tshttps://github.com/angular/angular-cli/pull/18783/files#diff-fd5138b2d24d38f1d20b902e52f287e4cbb490c0ad6cacfb4fa930d09f87e2ce
View file https://github.com/apeeters/angular-cli/blob/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5/packages/angular_devkit/build_angular/test/hello-world-app/e2e/app.e2e-spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18783/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18783/files#diff-fd5138b2d24d38f1d20b902e52f287e4cbb490c0ad6cacfb4fa930d09f87e2ce
packages/angular_devkit/build_angular/test/hello-world-app/e2e/app.po.tshttps://github.com/angular/angular-cli/pull/18783/files#diff-e956c7567a7905d219dedd1dcd9db209d3d51bd1edbf7db8cbe5cbf40f71f6c7
View file https://github.com/apeeters/angular-cli/blob/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5/packages/angular_devkit/build_angular/test/hello-world-app/e2e/app.po.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18783/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18783/files#diff-e956c7567a7905d219dedd1dcd9db209d3d51bd1edbf7db8cbe5cbf40f71f6c7
packages/schematics/angular/e2e/files/src/app.e2e-spec.ts.templatehttps://github.com/angular/angular-cli/pull/18783/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf
View file https://github.com/apeeters/angular-cli/blob/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5/packages/schematics/angular/e2e/files/src/app.e2e-spec.ts.template
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18783/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18783/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf
https://github.com/angular/angular-cli/pull/18783/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf
packages/schematics/angular/e2e/files/src/app.po.ts.templatehttps://github.com/angular/angular-cli/pull/18783/files#diff-c8e773a3af9ef3a4fdfb390fe10ab6a9f31f4fd9b1bd2f4c08d3cfbbd2925a90
View file https://github.com/apeeters/angular-cli/blob/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5/packages/schematics/angular/e2e/files/src/app.po.ts.template
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18783/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.