René's URL Explorer Experiment


Title: Improve async handling in generated code by apeeters · Pull Request #18783 · angular/angular-cli · GitHub

Open Graph Title: Improve async handling in generated code by apeeters · Pull Request #18783 · angular/angular-cli

X Title: Improve async handling in generated code by apeeters · Pull Request #18783 · angular/angular-cli

Description: CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.

Open Graph Description: This PR fixes two tslint errors in generated projects: Promise returning method should be async Avoid floating promises

X Description: This PR fixes two tslint errors in generated projects: Promise returning method should be async Avoid floating promises

Opengraph URL: https://github.com/angular/angular-cli/pull/18783

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:29f04296-6bb4-8019-c596-e1a80d840413
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEA6:3CBB3E:1DA2096:25C898B:6B01A548
html-safe-nonce17c8a02822067d4e5b3062c917443ef9ff2ac884327d90c0256ebf5fa6e28ede
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUE2OjNDQkIzRToxREEyMDk2OjI1Qzg5OEI6NkIwMUE1NDgiLCJ2aXNpdG9yX2lkIjoiNjEyMDY1NzU4MjA2ODcwNDU4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac960e3f4ffefca80a0216400b55b141d73e1e66741632e303fe4469b233a6ef53
hovercard-subject-tagpull_request:486580565
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular-cli/18783/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5c34967d7cc97034a71f914776cd3993e2ddb14c79ca20317e89cd92d48c5cc3/angular/angular-cli/pull/18783
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c34967d7cc97034a71f914776cd3993e2ddb14c79ca20317e89cd92d48c5cc3/angular/angular-cli/pull/18783
og:image:altThis PR fixes two tslint errors in generated projects: Promise returning method should be async Avoid floating promises
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameapeeters
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/18783#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18783
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18783
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/18783
Reloadhttps://github.com/angular/angular-cli/pull/18783
Reloadhttps://github.com/angular/angular-cli/pull/18783
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
apeetershttps://github.com/apeeters
angular:masterhttps://github.com/angular/angular-cli/tree/master
apeeters:fix_asynchttps://github.com/apeeters/angular-cli/tree/fix_async
Conversationhttps://github.com/angular/angular-cli/pull/18783
Commits2 (2)https://github.com/angular/angular-cli/pull/18783/commits
Checkshttps://github.com/angular/angular-cli/pull/18783/checks
Files changedhttps://github.com/angular/angular-cli/pull/18783/files
Improve async handling in generated codehttps://github.com/angular/angular-cli/pull/18783#top
apeetershttps://github.com/apeeters
angular:masterhttps://github.com/angular/angular-cli/tree/master
apeeters:fix_asynchttps://github.com/apeeters/angular-cli/tree/fix_async
https://github.com/apeeters
apeetershttps://github.com/apeeters
Sep 14, 2020https://github.com/angular/angular-cli/pull/18783#issue-701061666
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 14, 2020https://github.com/angular/angular-cli/pull/18783#event-3763131600
https://github.com/apeeters
apeetershttps://github.com/apeeters
force-pushedhttps://github.com/angular/angular-cli/compare/f03b4935e0f4a76089bc4339b1b4e724c8b24f33..a529bccabe75ed19dfb81b0cb9a1d78dbde3c762
f03b493https://github.com/angular/angular-cli/commit/f03b4935e0f4a76089bc4339b1b4e724c8b24f33
a529bcchttps://github.com/angular/angular-cli/commit/a529bccabe75ed19dfb81b0cb9a1d78dbde3c762
Compare https://github.com/angular/angular-cli/compare/f03b4935e0f4a76089bc4339b1b4e724c8b24f33..a529bccabe75ed19dfb81b0cb9a1d78dbde3c762
September 14, 2020 13:20https://github.com/angular/angular-cli/pull/18783#event-3763297698
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Sep 14, 2020https://github.com/angular/angular-cli/pull/18783#issuecomment-692081177
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
#17652 (comment)https://github.com/angular/angular-cli/pull/17652#discussion_r420878945
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
https://github.com/apeeters
apeetershttps://github.com/apeeters
Sep 15, 2020https://github.com/angular/angular-cli/pull/18783#issuecomment-692509176
#17652 (comment)https://github.com/angular/angular-cli/pull/17652#discussion_r420878945
#15472https://github.com/angular/angular-cli/pull/15472
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Sep 15, 2020 https://github.com/angular/angular-cli/pull/18783#pullrequestreview-488531678
View reviewed changes https://github.com/angular/angular-cli/pull/18783/files
alan-agius4https://github.com/alan-agius4
https://github.com/angular/angular-cli/pull/18783#pullrequestreview-488531678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
action: cleanup https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Sep 15, 2020https://github.com/angular/angular-cli/pull/18783#event-3767553576
https://github.com/clydin
clydinhttps://github.com/clydin
Sep 15, 2020 https://github.com/angular/angular-cli/pull/18783#pullrequestreview-488676488
View reviewed changes https://github.com/angular/angular-cli/pull/18783/files
integration/angular_cli/e2e/src/app.e2e-spec.tshttps://github.com/angular/angular-cli/pull/18783/files#diff-dc79b38b0b46bc1c951c0332da49f6cd94bf997dae485edd7f862dcb2ceb0ebb
clydinhttps://github.com/clydin
Sep 15, 2020https://github.com/angular/angular-cli/pull/18783#discussion_r488662719
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
apeetershttps://github.com/apeeters
Sep 15, 2020https://github.com/angular/angular-cli/pull/18783#discussion_r488801497
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
alan-agius4https://github.com/alan-agius4
Sep 18, 2020https://github.com/angular/angular-cli/pull/18783#discussion_r490971224
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
apeetershttps://github.com/apeeters
September 15, 2020 17:54https://github.com/angular/angular-cli/pull/18783#commits-pushed-c35b541
https://github.com/apeeters
fix(@schematics/angular): Make sure promise returning methods are asynchttps://github.com/angular/angular-cli/pull/18783/commits/c35b5415cb6f69db338a936e3714786bb339e46d
c35b541https://github.com/angular/angular-cli/pull/18783/commits/c35b5415cb6f69db338a936e3714786bb339e46d
https://palantir.github.io/tslint/rules/promise-function-async/https://palantir.github.io/tslint/rules/promise-function-async/
https://github.com/apeeters
fix(@schematics/angular): Fix handling of returned promiseshttps://github.com/angular/angular-cli/pull/18783/commits/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5
a960cc0https://github.com/angular/angular-cli/pull/18783/commits/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5
https://palantir.github.io/tslint/rules/no-floating-promises/https://palantir.github.io/tslint/rules/no-floating-promises/
https://github.com/apeeters
apeetershttps://github.com/apeeters
force-pushedhttps://github.com/angular/angular-cli/compare/28a188acc1572aeec12e652c04961bf2ef5bdc27..a960cc072d13864cd95fecf00b9fde8aa8e8c5d5
28a188ahttps://github.com/angular/angular-cli/commit/28a188acc1572aeec12e652c04961bf2ef5bdc27
a960cc0https://github.com/angular/angular-cli/commit/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5
Compare https://github.com/angular/angular-cli/compare/28a188acc1572aeec12e652c04961bf2ef5bdc27..a960cc072d13864cd95fecf00b9fde8aa8e8c5d5
September 15, 2020 16:28https://github.com/angular/angular-cli/pull/18783#event-3769272955
https://github.com/apeeters
apeetershttps://github.com/apeeters
Sep 15, 2020https://github.com/angular/angular-cli/pull/18783#issuecomment-692828745
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
https://github.com/clydin
clydinhttps://github.com/clydin
Oct 6, 2020https://github.com/angular/angular-cli/pull/18783#issuecomment-704460558
#18951https://github.com/angular/angular-cli/pull/18951
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
https://github.com/clydin
clydinhttps://github.com/clydin
Oct 6, 2020https://github.com/angular/angular-cli/pull/18783#event-3846921290
https://github.com/clydin
clydinhttps://github.com/clydin
action: cleanup https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Oct 6, 2020https://github.com/angular/angular-cli/pull/18783#event-3846921716
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 6, 2020https://github.com/angular/angular-cli/pull/18783#issuecomment-722940207
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 6, 2020https://github.com/angular/angular-cli/pull/18783#event-3966019046
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18783
https://github.com/alan-agius4
alan-agius4 https://github.com/alan-agius4
https://github.com/angular/angular-cli/pull/18783/files/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5
https://github.com/clydin
clydin https://github.com/clydin
https://github.com/angular/angular-cli/pull/18783/files/28a188acc1572aeec12e652c04961bf2ef5bdc27
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
Please reload this pagehttps://github.com/angular/angular-cli/pull/18783
https://github.com/apeeters
https://github.com/alan-agius4
https://github.com/clydin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.