| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:29f04296-6bb4-8019-c596-e1a80d840413 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEA6:3CBB3E:1DA2096:25C898B:6B01A548 |
| html-safe-nonce | 17c8a02822067d4e5b3062c917443ef9ff2ac884327d90c0256ebf5fa6e28ede |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUE2OjNDQkIzRToxREEyMDk2OjI1Qzg5OEI6NkIwMUE1NDgiLCJ2aXNpdG9yX2lkIjoiNjEyMDY1NzU4MjA2ODcwNDU4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 960e3f4ffefca80a0216400b55b141d73e1e66741632e303fe4469b233a6ef53 |
| hovercard-subject-tag | pull_request:486580565 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular-cli/18783/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5c34967d7cc97034a71f914776cd3993e2ddb14c79ca20317e89cd92d48c5cc3/angular/angular-cli/pull/18783 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5c34967d7cc97034a71f914776cd3993e2ddb14c79ca20317e89cd92d48c5cc3/angular/angular-cli/pull/18783 |
| og:image:alt | This PR fixes two tslint errors in generated projects:
Promise returning method should be async
Avoid floating promises |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | apeeters |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular-cli/pull/18783#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18783 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18783 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular-cli |
| Reload | https://github.com/angular/angular-cli/pull/18783 |
| Reload | https://github.com/angular/angular-cli/pull/18783 |
| Reload | https://github.com/angular/angular-cli/pull/18783 |
| angular | https://github.com/angular |
| angular-cli | https://github.com/angular/angular-cli |
| Code | https://github.com/angular/angular-cli |
| Issues198 (198) | https://github.com/angular/angular-cli/issues |
| Pull requests23 (23) | https://github.com/angular/angular-cli/pulls |
| Actions | https://github.com/angular/angular-cli/actions |
| Security and quality8 (8) | https://github.com/angular/angular-cli/security |
| Insights | https://github.com/angular/angular-cli/insights |
| https://github.com/angular/angular-cli |
| apeeters | https://github.com/apeeters |
| angular:master | https://github.com/angular/angular-cli/tree/master |
| apeeters:fix_async | https://github.com/apeeters/angular-cli/tree/fix_async |
| Conversation | https://github.com/angular/angular-cli/pull/18783 |
| Commits2 (2) | https://github.com/angular/angular-cli/pull/18783/commits |
| Checks | https://github.com/angular/angular-cli/pull/18783/checks |
| Files changed | https://github.com/angular/angular-cli/pull/18783/files |
| Improve async handling in generated code | https://github.com/angular/angular-cli/pull/18783#top |
| apeeters | https://github.com/apeeters |
| angular:master | https://github.com/angular/angular-cli/tree/master |
| apeeters:fix_async | https://github.com/apeeters/angular-cli/tree/fix_async |
|
| https://github.com/apeeters |
| apeeters | https://github.com/apeeters |
| Sep 14, 2020 | https://github.com/angular/angular-cli/pull/18783#issue-701061666 |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Sep 14, 2020 | https://github.com/angular/angular-cli/pull/18783#event-3763131600 |
| https://github.com/apeeters |
| apeeters | https://github.com/apeeters |
| force-pushed | https://github.com/angular/angular-cli/compare/f03b4935e0f4a76089bc4339b1b4e724c8b24f33..a529bccabe75ed19dfb81b0cb9a1d78dbde3c762 |
| f03b493 | https://github.com/angular/angular-cli/commit/f03b4935e0f4a76089bc4339b1b4e724c8b24f33 |
| a529bcc | https://github.com/angular/angular-cli/commit/a529bccabe75ed19dfb81b0cb9a1d78dbde3c762 |
|
Compare
| https://github.com/angular/angular-cli/compare/f03b4935e0f4a76089bc4339b1b4e724c8b24f33..a529bccabe75ed19dfb81b0cb9a1d78dbde3c762 |
| September 14, 2020 13:20 | https://github.com/angular/angular-cli/pull/18783#event-3763297698 |
| https://github.com/alan-agius4 |
| alan-agius4 | https://github.com/alan-agius4 |
| Sep 14, 2020 | https://github.com/angular/angular-cli/pull/18783#issuecomment-692081177 |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| #17652 (comment) | https://github.com/angular/angular-cli/pull/17652#discussion_r420878945 |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| https://github.com/apeeters |
| apeeters | https://github.com/apeeters |
| Sep 15, 2020 | https://github.com/angular/angular-cli/pull/18783#issuecomment-692509176 |
| #17652 (comment) | https://github.com/angular/angular-cli/pull/17652#discussion_r420878945 |
| #15472 | https://github.com/angular/angular-cli/pull/15472 |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| https://github.com/alan-agius4 |
| alan-agius4 | https://github.com/alan-agius4 |
|
Sep 15, 2020
| https://github.com/angular/angular-cli/pull/18783#pullrequestreview-488531678 |
|
View reviewed changes
| https://github.com/angular/angular-cli/pull/18783/files |
| alan-agius4 | https://github.com/alan-agius4 |
| https://github.com/angular/angular-cli/pull/18783#pullrequestreview-488531678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| https://github.com/alan-agius4 |
| alan-agius4 | https://github.com/alan-agius4 |
|
action: cleanup
| https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Sep 15, 2020 | https://github.com/angular/angular-cli/pull/18783#event-3767553576 |
| https://github.com/clydin |
| clydin | https://github.com/clydin |
|
Sep 15, 2020
| https://github.com/angular/angular-cli/pull/18783#pullrequestreview-488676488 |
|
View reviewed changes
| https://github.com/angular/angular-cli/pull/18783/files |
| integration/angular_cli/e2e/src/app.e2e-spec.ts | https://github.com/angular/angular-cli/pull/18783/files#diff-dc79b38b0b46bc1c951c0332da49f6cd94bf997dae485edd7f862dcb2ceb0ebb |
| clydin | https://github.com/clydin |
| Sep 15, 2020 | https://github.com/angular/angular-cli/pull/18783#discussion_r488662719 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| apeeters | https://github.com/apeeters |
| Sep 15, 2020 | https://github.com/angular/angular-cli/pull/18783#discussion_r488801497 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| alan-agius4 | https://github.com/alan-agius4 |
| Sep 18, 2020 | https://github.com/angular/angular-cli/pull/18783#discussion_r490971224 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| apeeters | https://github.com/apeeters |
| September 15, 2020 17:54 | https://github.com/angular/angular-cli/pull/18783#commits-pushed-c35b541 |
|
| https://github.com/apeeters |
| fix(@schematics/angular): Make sure promise returning methods are async | https://github.com/angular/angular-cli/pull/18783/commits/c35b5415cb6f69db338a936e3714786bb339e46d |
| c35b541 | https://github.com/angular/angular-cli/pull/18783/commits/c35b5415cb6f69db338a936e3714786bb339e46d |
| https://palantir.github.io/tslint/rules/promise-function-async/ | https://palantir.github.io/tslint/rules/promise-function-async/ |
|
| https://github.com/apeeters |
| fix(@schematics/angular): Fix handling of returned promises | https://github.com/angular/angular-cli/pull/18783/commits/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5 |
| a960cc0 | https://github.com/angular/angular-cli/pull/18783/commits/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5 |
| https://palantir.github.io/tslint/rules/no-floating-promises/ | https://palantir.github.io/tslint/rules/no-floating-promises/ |
| https://github.com/apeeters |
| apeeters | https://github.com/apeeters |
| force-pushed | https://github.com/angular/angular-cli/compare/28a188acc1572aeec12e652c04961bf2ef5bdc27..a960cc072d13864cd95fecf00b9fde8aa8e8c5d5 |
| 28a188a | https://github.com/angular/angular-cli/commit/28a188acc1572aeec12e652c04961bf2ef5bdc27 |
| a960cc0 | https://github.com/angular/angular-cli/commit/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5 |
|
Compare
| https://github.com/angular/angular-cli/compare/28a188acc1572aeec12e652c04961bf2ef5bdc27..a960cc072d13864cd95fecf00b9fde8aa8e8c5d5 |
| September 15, 2020 16:28 | https://github.com/angular/angular-cli/pull/18783#event-3769272955 |
| https://github.com/apeeters |
| apeeters | https://github.com/apeeters |
| Sep 15, 2020 | https://github.com/angular/angular-cli/pull/18783#issuecomment-692828745 |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| https://github.com/clydin |
| clydin | https://github.com/clydin |
| Oct 6, 2020 | https://github.com/angular/angular-cli/pull/18783#issuecomment-704460558 |
| #18951 | https://github.com/angular/angular-cli/pull/18951 |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| https://github.com/clydin |
| clydin | https://github.com/clydin |
| Oct 6, 2020 | https://github.com/angular/angular-cli/pull/18783#event-3846921290 |
| https://github.com/clydin |
| clydin | https://github.com/clydin |
|
action: cleanup
| https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Oct 6, 2020 | https://github.com/angular/angular-cli/pull/18783#event-3846921716 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Nov 6, 2020 | https://github.com/angular/angular-cli/pull/18783#issuecomment-722940207 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Nov 6, 2020 | https://github.com/angular/angular-cli/pull/18783#event-3966019046 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18783 |
|
| https://github.com/alan-agius4 |
|
alan-agius4
| https://github.com/alan-agius4 |
|
| https://github.com/angular/angular-cli/pull/18783/files/a960cc072d13864cd95fecf00b9fde8aa8e8c5d5 |
|
| https://github.com/clydin |
|
clydin
| https://github.com/clydin |
|
| https://github.com/angular/angular-cli/pull/18783/files/28a188acc1572aeec12e652c04961bf2ef5bdc27 |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
| Please reload this page | https://github.com/angular/angular-cli/pull/18783 |
|
| https://github.com/apeeters |
|
| https://github.com/alan-agius4 |
|
| https://github.com/clydin |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |