| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7a39876b-cc1f-0d27-93ee-5818c5157434 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EC88:1C94F:1F6F69F:284B5BF:6B01B3A6 |
| html-safe-nonce | 46b0f01a5e4468c1fd4441cb2ac558c6b33ff07db7da2cbcc7c87970821406e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzg4OjFDOTRGOjFGNkY2OUY6Mjg0QjVCRjo2QjAxQjNBNiIsInZpc2l0b3JfaWQiOiI4MDk4MzYwNTI0MzE3NzY2NTY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 99fd525019e2d0223f3a7f8d85f6bc11a21ac5438ed8f8fb9924f4bd58f436b8 |
| hovercard-subject-tag | pull_request:448488406 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/18243/files |
| twitter:image | https://avatars.githubusercontent.com/u/19598772?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19598772?s=400&v=4 |
| og:image:alt | jasmine has supported promises and async/await natively since 2.7.
The only usage of the async helper function is currently within the beforeEach of the component test schematic but async/await pro... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular-cli/pull/18243/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18243%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18243%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli |
| Reload | https://github.com/angular/angular-cli/pull/18243/files |
| Reload | https://github.com/angular/angular-cli/pull/18243/files |
| Reload | https://github.com/angular/angular-cli/pull/18243/files |
| angular | https://github.com/angular |
| angular-cli | https://github.com/angular/angular-cli |
| Code | https://github.com/angular/angular-cli |
| Issues198 (198) | https://github.com/angular/angular-cli/issues |
| Pull requests23 (23) | https://github.com/angular/angular-cli/pulls |
| Actions | https://github.com/angular/angular-cli/actions |
| Security and quality8 (8) | https://github.com/angular/angular-cli/security |
| Insights | https://github.com/angular/angular-cli/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose |
| clydin | https://github.com/clydin |
| angular:master | https://github.com/angular/angular-cli/tree/master |
| clydin:schematics-remove-async-helper | https://github.com/clydin/angular-cli/tree/schematics-remove-async-helper |
|
Conversation
1
| https://github.com/angular/angular-cli/pull/18243 |
|
Commits
2
| https://github.com/angular/angular-cli/pull/18243/commits |
|
Checks
0
| https://github.com/angular/angular-cli/pull/18243/checks |
|
Files changed
| https://github.com/angular/angular-cli/pull/18243/files |
| Please reload this page | https://github.com/angular/angular-cli/pull/18243/files |
|
fix(@schematics/angular): remove async test helper function from component schematic
| https://github.com/angular/angular-cli/pull/18243/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angular-cli/pull/18243/files |
|
a7326bf
fix(@schematics/angular): remove async test helper function from comp…
clydin Jul 13, 2020
| https://github.com/angular/angular-cli/pull/18243/commits/a7326bf1b75bc3d772327949f4144a84e041c8cb |
|
ae4d7f0
test: update generated tests to not use async helper function
clydin Jul 13, 2020
| https://github.com/angular/angular-cli/pull/18243/commits/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690 |
|
Clear filters
| https://github.com/angular/angular-cli/pull/18243/files |
| Please reload this page | https://github.com/angular/angular-cli/pull/18243/files |
| Please reload this page | https://github.com/angular/angular-cli/pull/18243/files |
|
app.component.spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-70c1a179d6408011b6b2c20853efef936b288b9175855b707ea371b4d9fec2bb |
|
works_spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed |
|
app.component.spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-5a6e4591d549789ba094b92c7f8ca7b4790592001e75166ff50285172faf721e |
|
lib.component.spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-886e783d39ba04d4ba8d5eff838a218b20435e45a2bdc0918aec9388878fc6cf |
|
app.component.spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-a824964e53903265e6175a77d643916dfd3ee8f39aadabb7665f71cf9f7db203 |
|
app.component.spec.ts.template
| https://github.com/angular/angular-cli/pull/18243/files#diff-7dd48bb454da1e3b9745f482d367c15136a3560dca0b9f1c74bd6e3b58d939aa |
|
__name@dasherize__.__type@dasherize__.spec.ts.template
| https://github.com/angular/angular-cli/pull/18243/files#diff-26c761d40d1c0d81db72d5341d91b3664b1bbc25f4e91cbdecabd04c3220accb |
|
app.component.spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-8566458d5739984a2a4dbacbbdfe149d7727ed26a2126a6e62ea1032270c3495 |
|
app.component.spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-783dbe8f66454dd2504c6c9edcb1e344003111ab8c1838439a9e81cc947fa9e8 |
|
app.component.spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-5c06a8e0387803f597e55c0a9f02ceccfd8144e080be1134be5a7eb5a6d5c6c0 |
|
lazy-comp.component.spec.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-6226be765647032bae850544ef742abf62b363f6767a5d32c35b6a542f0f29fc |
|
test-scripts.ts
| https://github.com/angular/angular-cli/pull/18243/files#diff-b7bdd9db77c09cd187f64e2bc308b27b0bf1a02fe635e89da0c4be9a5737e9cc |
| integration/angular_cli/src/app/app.component.spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-70c1a179d6408011b6b2c20853efef936b288b9175855b707ea371b4d9fec2bb |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/integration/angular_cli/src/app/app.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-70c1a179d6408011b6b2c20853efef936b288b9175855b707ea371b4d9fec2bb |
| packages/angular_devkit/build_angular/src/karma/works_spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/angular_devkit/build_angular/src/karma/works_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed |
| packages/angular_devkit/build_angular/test/hello-world-app/src/app/app.component.spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-5a6e4591d549789ba094b92c7f8ca7b4790592001e75166ff50285172faf721e |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/angular_devkit/build_angular/test/hello-world-app/src/app/app.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-5a6e4591d549789ba094b92c7f8ca7b4790592001e75166ff50285172faf721e |
| ...gular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/src/lib/lib.component.spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-886e783d39ba04d4ba8d5eff838a218b20435e45a2bdc0918aec9388878fc6cf |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/src/lib/lib.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-886e783d39ba04d4ba8d5eff838a218b20435e45a2bdc0918aec9388878fc6cf |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-886e783d39ba04d4ba8d5eff838a218b20435e45a2bdc0918aec9388878fc6cf |
| packages/angular_devkit/build_webpack/test/angular-app/src/app/app.component.spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-a824964e53903265e6175a77d643916dfd3ee8f39aadabb7665f71cf9f7db203 |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/angular_devkit/build_webpack/test/angular-app/src/app/app.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-a824964e53903265e6175a77d643916dfd3ee8f39aadabb7665f71cf9f7db203 |
| packages/schematics/angular/application/other-files/app.component.spec.ts.template | https://github.com/angular/angular-cli/pull/18243/files#diff-7dd48bb454da1e3b9745f482d367c15136a3560dca0b9f1c74bd6e3b58d939aa |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/schematics/angular/application/other-files/app.component.spec.ts.template |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-7dd48bb454da1e3b9745f482d367c15136a3560dca0b9f1c74bd6e3b58d939aa |
| ...t/files/__name@dasherize@if-flat__/__name@dasherize__.__type@dasherize__.spec.ts.template | https://github.com/angular/angular-cli/pull/18243/files#diff-26c761d40d1c0d81db72d5341d91b3664b1bbc25f4e91cbdecabd04c3220accb |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/schematics/angular/component/files/__name%40dasherize%40if-flat__/__name%40dasherize__.__type%40dasherize__.spec.ts.template |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-26c761d40d1c0d81db72d5341d91b3664b1bbc25f4e91cbdecabd04c3220accb |
| tests/legacy-cli/e2e/assets/1.0-project/src/app/app.component.spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-8566458d5739984a2a4dbacbbdfe149d7727ed26a2126a6e62ea1032270c3495 |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/tests/legacy-cli/e2e/assets/1.0-project/src/app/app.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
| tests/legacy-cli/e2e/assets/1.7-project/src/app/app.component.spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-783dbe8f66454dd2504c6c9edcb1e344003111ab8c1838439a9e81cc947fa9e8 |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/tests/legacy-cli/e2e/assets/1.7-project/src/app/app.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
| tests/legacy-cli/e2e/assets/7.0-project/src/app/app.component.spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-5c06a8e0387803f597e55c0a9f02ceccfd8144e080be1134be5a7eb5a6d5c6c0 |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/tests/legacy-cli/e2e/assets/7.0-project/src/app/app.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-5c06a8e0387803f597e55c0a9f02ceccfd8144e080be1134be5a7eb5a6d5c6c0 |
| tests/legacy-cli/e2e/assets/7.0-project/src/app/lazy/lazy-comp/lazy-comp.component.spec.ts | https://github.com/angular/angular-cli/pull/18243/files#diff-6226be765647032bae850544ef742abf62b363f6767a5d32c35b6a542f0f29fc |
|
View file
| https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/tests/legacy-cli/e2e/assets/7.0-project/src/app/lazy/lazy-comp/lazy-comp.component.spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }} |
|
| https://github.com/angular/angular-cli/pull/18243/files#diff-6226be765647032bae850544ef742abf62b363f6767a5d32c35b6a542f0f29fc |
| Please reload this page | https://github.com/angular/angular-cli/pull/18243/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |