René's URL Explorer Experiment


Title: fix(@schematics/angular): remove async test helper function from component schematic by clydin · Pull Request #18243 · angular/angular-cli · GitHub

Open Graph Title: fix(@schematics/angular): remove async test helper function from component schematic by clydin · Pull Request #18243 · angular/angular-cli

X Title: fix(@schematics/angular): remove async test helper function from component schematic by clydin · Pull Request #18243 · angular/angular-cli

Description: jasmine has supported promises and async/await natively since 2.7. The only usage of the async helper function is currently within the beforeEach of the component test schematic but async/await provides equivalent functionality in this context without the need for an additional Zone.js layer. While the call to compileComponents is typically unneeded when using ng test, the generated test files may be also be used outside the command.

Open Graph Description: jasmine has supported promises and async/await natively since 2.7. The only usage of the async helper function is currently within the beforeEach of the component test schematic but async/await pro...

X Description: jasmine has supported promises and async/await natively since 2.7. The only usage of the async helper function is currently within the beforeEach of the component test schematic but async/await pro...

Opengraph URL: https://github.com/angular/angular-cli/pull/18243

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7a39876b-cc1f-0d27-93ee-5818c5157434
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC88:1C94F:1F6F69F:284B5BF:6B01B3A6
html-safe-nonce46b0f01a5e4468c1fd4441cb2ac558c6b33ff07db7da2cbcc7c87970821406e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzg4OjFDOTRGOjFGNkY2OUY6Mjg0QjVCRjo2QjAxQjNBNiIsInZpc2l0b3JfaWQiOiI4MDk4MzYwNTI0MzE3NzY2NTY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac99fd525019e2d0223f3a7f8d85f6bc11a21ac5438ed8f8fb9924f4bd58f436b8
hovercard-subject-tagpull_request:448488406
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/18243/files
twitter:imagehttps://avatars.githubusercontent.com/u/19598772?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19598772?s=400&v=4
og:image:altjasmine has supported promises and async/await natively since 2.7. The only usage of the async helper function is currently within the beforeEach of the component test schematic but async/await pro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/18243/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18243%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F18243%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/18243/files
Reloadhttps://github.com/angular/angular-cli/pull/18243/files
Reloadhttps://github.com/angular/angular-cli/pull/18243/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
clydinhttps://github.com/clydin
angular:masterhttps://github.com/angular/angular-cli/tree/master
clydin:schematics-remove-async-helperhttps://github.com/clydin/angular-cli/tree/schematics-remove-async-helper
Conversation 1 https://github.com/angular/angular-cli/pull/18243
Commits 2 https://github.com/angular/angular-cli/pull/18243/commits
Checks 0 https://github.com/angular/angular-cli/pull/18243/checks
Files changed https://github.com/angular/angular-cli/pull/18243/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/18243/files
fix(@schematics/angular): remove async test helper function from component schematic https://github.com/angular/angular-cli/pull/18243/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/18243/files
a7326bf fix(@schematics/angular): remove async test helper function from comp… clydin Jul 13, 2020 https://github.com/angular/angular-cli/pull/18243/commits/a7326bf1b75bc3d772327949f4144a84e041c8cb
ae4d7f0 test: update generated tests to not use async helper function clydin Jul 13, 2020 https://github.com/angular/angular-cli/pull/18243/commits/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690
Clear filters https://github.com/angular/angular-cli/pull/18243/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/18243/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/18243/files
app.component.spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-70c1a179d6408011b6b2c20853efef936b288b9175855b707ea371b4d9fec2bb
works_spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed
app.component.spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-5a6e4591d549789ba094b92c7f8ca7b4790592001e75166ff50285172faf721e
lib.component.spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-886e783d39ba04d4ba8d5eff838a218b20435e45a2bdc0918aec9388878fc6cf
app.component.spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-a824964e53903265e6175a77d643916dfd3ee8f39aadabb7665f71cf9f7db203
app.component.spec.ts.template https://github.com/angular/angular-cli/pull/18243/files#diff-7dd48bb454da1e3b9745f482d367c15136a3560dca0b9f1c74bd6e3b58d939aa
__name@dasherize__.__type@dasherize__.spec.ts.template https://github.com/angular/angular-cli/pull/18243/files#diff-26c761d40d1c0d81db72d5341d91b3664b1bbc25f4e91cbdecabd04c3220accb
app.component.spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-8566458d5739984a2a4dbacbbdfe149d7727ed26a2126a6e62ea1032270c3495
app.component.spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-783dbe8f66454dd2504c6c9edcb1e344003111ab8c1838439a9e81cc947fa9e8
app.component.spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-5c06a8e0387803f597e55c0a9f02ceccfd8144e080be1134be5a7eb5a6d5c6c0
lazy-comp.component.spec.ts https://github.com/angular/angular-cli/pull/18243/files#diff-6226be765647032bae850544ef742abf62b363f6767a5d32c35b6a542f0f29fc
test-scripts.ts https://github.com/angular/angular-cli/pull/18243/files#diff-b7bdd9db77c09cd187f64e2bc308b27b0bf1a02fe635e89da0c4be9a5737e9cc
integration/angular_cli/src/app/app.component.spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-70c1a179d6408011b6b2c20853efef936b288b9175855b707ea371b4d9fec2bb
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/integration/angular_cli/src/app/app.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-70c1a179d6408011b6b2c20853efef936b288b9175855b707ea371b4d9fec2bb
packages/angular_devkit/build_angular/src/karma/works_spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/angular_devkit/build_angular/src/karma/works_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed
https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed
https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed
https://github.com/angular/angular-cli/pull/18243/files#diff-df2c2b355a7156649527e8e037887c60ead79e1adbb3fd6c6fac4a50a4505eed
packages/angular_devkit/build_angular/test/hello-world-app/src/app/app.component.spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-5a6e4591d549789ba094b92c7f8ca7b4790592001e75166ff50285172faf721e
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/angular_devkit/build_angular/test/hello-world-app/src/app/app.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-5a6e4591d549789ba094b92c7f8ca7b4790592001e75166ff50285172faf721e
...gular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/src/lib/lib.component.spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-886e783d39ba04d4ba8d5eff838a218b20435e45a2bdc0918aec9388878fc6cf
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/angular_devkit/build_ng_packagr/test/ng-packaged/projects/lib/src/lib/lib.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-886e783d39ba04d4ba8d5eff838a218b20435e45a2bdc0918aec9388878fc6cf
https://github.com/angular/angular-cli/pull/18243/files#diff-886e783d39ba04d4ba8d5eff838a218b20435e45a2bdc0918aec9388878fc6cf
packages/angular_devkit/build_webpack/test/angular-app/src/app/app.component.spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-a824964e53903265e6175a77d643916dfd3ee8f39aadabb7665f71cf9f7db203
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/angular_devkit/build_webpack/test/angular-app/src/app/app.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-a824964e53903265e6175a77d643916dfd3ee8f39aadabb7665f71cf9f7db203
packages/schematics/angular/application/other-files/app.component.spec.ts.templatehttps://github.com/angular/angular-cli/pull/18243/files#diff-7dd48bb454da1e3b9745f482d367c15136a3560dca0b9f1c74bd6e3b58d939aa
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/schematics/angular/application/other-files/app.component.spec.ts.template
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-7dd48bb454da1e3b9745f482d367c15136a3560dca0b9f1c74bd6e3b58d939aa
...t/files/__name@dasherize@if-flat__/__name@dasherize__.__type@dasherize__.spec.ts.templatehttps://github.com/angular/angular-cli/pull/18243/files#diff-26c761d40d1c0d81db72d5341d91b3664b1bbc25f4e91cbdecabd04c3220accb
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/packages/schematics/angular/component/files/__name%40dasherize%40if-flat__/__name%40dasherize__.__type%40dasherize__.spec.ts.template
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-26c761d40d1c0d81db72d5341d91b3664b1bbc25f4e91cbdecabd04c3220accb
tests/legacy-cli/e2e/assets/1.0-project/src/app/app.component.spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-8566458d5739984a2a4dbacbbdfe149d7727ed26a2126a6e62ea1032270c3495
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/tests/legacy-cli/e2e/assets/1.0-project/src/app/app.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
tests/legacy-cli/e2e/assets/1.7-project/src/app/app.component.spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-783dbe8f66454dd2504c6c9edcb1e344003111ab8c1838439a9e81cc947fa9e8
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/tests/legacy-cli/e2e/assets/1.7-project/src/app/app.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
tests/legacy-cli/e2e/assets/7.0-project/src/app/app.component.spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-5c06a8e0387803f597e55c0a9f02ceccfd8144e080be1134be5a7eb5a6d5c6c0
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/tests/legacy-cli/e2e/assets/7.0-project/src/app/app.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-5c06a8e0387803f597e55c0a9f02ceccfd8144e080be1134be5a7eb5a6d5c6c0
tests/legacy-cli/e2e/assets/7.0-project/src/app/lazy/lazy-comp/lazy-comp.component.spec.tshttps://github.com/angular/angular-cli/pull/18243/files#diff-6226be765647032bae850544ef742abf62b363f6767a5d32c35b6a542f0f29fc
View file https://github.com/clydin/angular-cli/blob/ae4d7f0531b97a57e1a681ec4f69f0c61dedd690/tests/legacy-cli/e2e/assets/7.0-project/src/app/lazy/lazy-comp/lazy-comp.component.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/18243/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/18243/files#diff-6226be765647032bae850544ef742abf62b363f6767a5d32c35b6a542f0f29fc
Please reload this pagehttps://github.com/angular/angular-cli/pull/18243/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.