René's URL Explorer Experiment


Title: build: vendor typescript 3.6 in build optimizer by alan-agius4 · Pull Request #17670 · angular/angular-cli · GitHub

Open Graph Title: build: vendor typescript 3.6 in build optimizer by alan-agius4 · Pull Request #17670 · angular/angular-cli

X Title: build: vendor typescript 3.6 in build optimizer by alan-agius4 · Pull Request #17670 · angular/angular-cli

Description: With this change we "vendor" TypeScript 3.6 in build optimizer instead of using directly the npm package. Reasons: We cannot update to a more recent version of TypeScript due to microsoft/TypeScript#38412 Yarn workspace are not supported under Bazel. This means currently we are running unit testswhich uses a different TypeScript version at runtime. In TypeScript 3.9, the shape of ES2015 classes changed microsoft/TypeScript#32011, this requires some changes in the UT expects, but this again will not be correct to change now.

Open Graph Description: With this change we "vendor" TypeScript 3.6 in build optimizer instead of using directly the npm package. Reasons: We cannot update to a more recent version of TypeScript due to microsof...

X Description: With this change we "vendor" TypeScript 3.6 in build optimizer instead of using directly the npm package. Reasons: We cannot update to a more recent version of TypeScript due to ...

Opengraph URL: https://github.com/angular/angular-cli/pull/17670

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:81897b65-50aa-36f5-2097-5c2c6fee71a9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE060:26ECEB:284A0CA:33373EE:6B018923
html-safe-nonce2c64f28dd779cdc8531b57958cfa7ee16742d1b1018a7a3316562d8a4d7d84b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDYwOjI2RUNFQjoyODRBMENBOjMzMzczRUU6NkIwMTg5MjMiLCJ2aXNpdG9yX2lkIjoiNTM0NDMzMTY3NjY3NDY0NDgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6ab23fc767d2f1f5844d2db564c6987db0dbc8b498390c9e6614de500ad4f076
hovercard-subject-tagpull_request:415192188
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/17670/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altWith this change we "vendor" TypeScript 3.6 in build optimizer instead of using directly the npm package. Reasons: We cannot update to a more recent version of TypeScript due to microsof...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/17670/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F17670%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F17670%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/17670/files
Reloadhttps://github.com/angular/angular-cli/pull/17670/files
Reloadhttps://github.com/angular/angular-cli/pull/17670/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
clydinhttps://github.com/clydin
angular:masterhttps://github.com/angular/angular-cli/tree/master
Conversation 10 https://github.com/angular/angular-cli/pull/17670
Commits 3 https://github.com/angular/angular-cli/pull/17670/commits
Checks 0 https://github.com/angular/angular-cli/pull/17670/checks
Files changed https://github.com/angular/angular-cli/pull/17670/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/17670/files
build: vendor typescript 3.6 in build optimizer https://github.com/angular/angular-cli/pull/17670/files#top
Show all changes 3 commits https://github.com/angular/angular-cli/pull/17670/files
0cea48d build: vendor typescript 3.6 in build optimizer alan-agius4 May 8, 2020 https://github.com/angular/angular-cli/pull/17670/commits/0cea48d9697540d8762b788545fa263a88d307a9
83fdf1b test: update no_typescript_runtime_dep_spec to check javascript files alan-agius4 May 8, 2020 https://github.com/angular/angular-cli/pull/17670/commits/83fdf1b4c0bd46d59ba0422f8df2503dce4c61f4
03f3e02 build: remove module_name and module_root alan-agius4 May 9, 2020 https://github.com/angular/angular-cli/pull/17670/commits/03f3e029366f5bd47995e177a26c7e5c106e4037
Clear filters https://github.com/angular/angular-cli/pull/17670/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/17670/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/17670/files
BUILD.bazel https://github.com/angular/angular-cli/pull/17670/files#diff-5f460ce33e0c40a6fc1293c46d92c6d305d9decaba763697f5419ef863fc0921
no_typescript_runtime_dep_spec.js https://github.com/angular/angular-cli/pull/17670/files#diff-a0779b75752decafb434ba592169a30e36b4f7ca48fd48f3c31ac13a705dcabb
package.json https://github.com/angular/angular-cli/pull/17670/files#diff-cde7a47fa6aeb323c727d72e8e65e4e7df7cd14a935682bb07de946de8102bb6
ast-utils.ts https://github.com/angular/angular-cli/pull/17670/files#diff-8b8524158e416a246057837b1be24a33285346387202e53dcc32991c29ccfe86
transform-javascript.ts https://github.com/angular/angular-cli/pull/17670/files#diff-99f84c2d67704342940127c8b839b58efad7c7c04d10f8107134a11d68714e17
prefix-classes.ts https://github.com/angular/angular-cli/pull/17670/files#diff-924de023dac86ca6bde7369883d760a0bd6c1c9b46413228dd81ca4ac908c81b
prefix-functions.ts https://github.com/angular/angular-cli/pull/17670/files#diff-5a5417a55e0b5f500b487b9afb2e39736a5d009e3e4aafa515b991e875a7e1a7
scrub-file.ts https://github.com/angular/angular-cli/pull/17670/files#diff-39b793ad37db4e792ec6180b7453b21625468ef2a4e1d9d7a108ab9a2749d455
wrap-enums.ts https://github.com/angular/angular-cli/pull/17670/files#diff-c6c9ae7ecd8ae73e29072c6c0f3451a956853855e9715c21fcc98b0f5ca526dc
BUILD.bazel https://github.com/angular/angular-cli/pull/17670/files#diff-79b2d9ce6265f5d9c6902129828ce09131b8a481214f591358b11d4599f2552b
LICENSE https://github.com/angular/angular-cli/pull/17670/files#diff-93a8eb40f8f7854e7f2b7c43cc51c92ae052c9d2a41a138877b140d02dbfdb99
typescript.d.ts https://github.com/angular/angular-cli/pull/17670/files#diff-867b01fd5ae6cefa745b58e863322e6c1103d21cc5c2abd94829a7aa8d167f93
typescript.js https://github.com/angular/angular-cli/pull/17670/files#diff-e84a7dbbcf60a0949d5f3970f7758a6b5d5af58a2b594276c3990aee0e3eebd1
no_typescript_runtime_dep_spec.js https://github.com/angular/angular-cli/pull/17670/files#diff-bb16422500b4556eaab89bd6ba39f715faeb0e63daa5db5fb9c51780d201ae39
BUILD.bazel https://github.com/angular/angular-cli/pull/17670/files#diff-c7f7d8eb58025e52f8fb6d49bf68b0b64107ca088aaf67814191e6f7e6afe469
yarn.lock https://github.com/angular/angular-cli/pull/17670/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
packages/angular_devkit/build_optimizer/BUILD.bazelhttps://github.com/angular/angular-cli/pull/17670/files#diff-5f460ce33e0c40a6fc1293c46d92c6d305d9decaba763697f5419ef863fc0921
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/17670/files#diff-5f460ce33e0c40a6fc1293c46d92c6d305d9decaba763697f5419ef863fc0921
https://github.com/angular/angular-cli/pull/17670/files#diff-5f460ce33e0c40a6fc1293c46d92c6d305d9decaba763697f5419ef863fc0921
https://github.com/angular/angular-cli/pull/17670/files#diff-5f460ce33e0c40a6fc1293c46d92c6d305d9decaba763697f5419ef863fc0921
https://github.com/angular/angular-cli/pull/17670/files#diff-5f460ce33e0c40a6fc1293c46d92c6d305d9decaba763697f5419ef863fc0921
packages/angular_devkit/build_optimizer/no_typescript_runtime_dep_spec.jshttps://github.com/angular/angular-cli/pull/17670/files#diff-a0779b75752decafb434ba592169a30e36b4f7ca48fd48f3c31ac13a705dcabb
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/no_typescript_runtime_dep_spec.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
packages/angular_devkit/build_optimizer/package.jsonhttps://github.com/angular/angular-cli/pull/17670/files#diff-cde7a47fa6aeb323c727d72e8e65e4e7df7cd14a935682bb07de946de8102bb6
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/17670/files#diff-cde7a47fa6aeb323c727d72e8e65e4e7df7cd14a935682bb07de946de8102bb6
packages/angular_devkit/build_optimizer/src/helpers/ast-utils.tshttps://github.com/angular/angular-cli/pull/17670/files#diff-8b8524158e416a246057837b1be24a33285346387202e53dcc32991c29ccfe86
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/src/helpers/ast-utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/17670/files#diff-8b8524158e416a246057837b1be24a33285346387202e53dcc32991c29ccfe86
https://github.com/angular/angular-cli/pull/17670/files#diff-8b8524158e416a246057837b1be24a33285346387202e53dcc32991c29ccfe86
packages/angular_devkit/build_optimizer/src/helpers/transform-javascript.tshttps://github.com/angular/angular-cli/pull/17670/files#diff-99f84c2d67704342940127c8b839b58efad7c7c04d10f8107134a11d68714e17
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/src/helpers/transform-javascript.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/17670/files#diff-99f84c2d67704342940127c8b839b58efad7c7c04d10f8107134a11d68714e17
https://github.com/angular/angular-cli/pull/17670/files#diff-99f84c2d67704342940127c8b839b58efad7c7c04d10f8107134a11d68714e17
packages/angular_devkit/build_optimizer/src/transforms/prefix-classes.tshttps://github.com/angular/angular-cli/pull/17670/files#diff-924de023dac86ca6bde7369883d760a0bd6c1c9b46413228dd81ca4ac908c81b
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/src/transforms/prefix-classes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/17670/files#diff-924de023dac86ca6bde7369883d760a0bd6c1c9b46413228dd81ca4ac908c81b
https://github.com/angular/angular-cli/pull/17670/files#diff-924de023dac86ca6bde7369883d760a0bd6c1c9b46413228dd81ca4ac908c81b
packages/angular_devkit/build_optimizer/src/transforms/prefix-functions.tshttps://github.com/angular/angular-cli/pull/17670/files#diff-5a5417a55e0b5f500b487b9afb2e39736a5d009e3e4aafa515b991e875a7e1a7
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/src/transforms/prefix-functions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/17670/files#diff-5a5417a55e0b5f500b487b9afb2e39736a5d009e3e4aafa515b991e875a7e1a7
https://github.com/angular/angular-cli/pull/17670/files#diff-5a5417a55e0b5f500b487b9afb2e39736a5d009e3e4aafa515b991e875a7e1a7
packages/angular_devkit/build_optimizer/src/transforms/scrub-file.tshttps://github.com/angular/angular-cli/pull/17670/files#diff-39b793ad37db4e792ec6180b7453b21625468ef2a4e1d9d7a108ab9a2749d455
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/src/transforms/scrub-file.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/17670/files#diff-39b793ad37db4e792ec6180b7453b21625468ef2a4e1d9d7a108ab9a2749d455
https://github.com/angular/angular-cli/pull/17670/files#diff-39b793ad37db4e792ec6180b7453b21625468ef2a4e1d9d7a108ab9a2749d455
packages/angular_devkit/build_optimizer/src/transforms/wrap-enums.tshttps://github.com/angular/angular-cli/pull/17670/files#diff-c6c9ae7ecd8ae73e29072c6c0f3451a956853855e9715c21fcc98b0f5ca526dc
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/src/transforms/wrap-enums.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/17670/files#diff-c6c9ae7ecd8ae73e29072c6c0f3451a956853855e9715c21fcc98b0f5ca526dc
https://github.com/angular/angular-cli/pull/17670/files#diff-c6c9ae7ecd8ae73e29072c6c0f3451a956853855e9715c21fcc98b0f5ca526dc
...es/angular_devkit/build_optimizer/third_party/github.com/Microsoft/TypeScript/BUILD.bazelhttps://github.com/angular/angular-cli/pull/17670/files#diff-79b2d9ce6265f5d9c6902129828ce09131b8a481214f591358b11d4599f2552b
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/third_party/github.com/Microsoft/TypeScript/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
packages/angular_devkit/build_optimizer/third_party/github.com/Microsoft/TypeScript/LICENSEhttps://github.com/angular/angular-cli/pull/17670/files#diff-93a8eb40f8f7854e7f2b7c43cc51c92ae052c9d2a41a138877b140d02dbfdb99
View file https://github.com/angular/angular-cli/blob/03f3e029366f5bd47995e177a26c7e5c106e4037/packages/angular_devkit/build_optimizer/third_party/github.com/Microsoft/TypeScript/LICENSE
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/17670/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular-cli/pull/17670/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.