René's URL Explorer Experiment


Title: fix(@angular/cli): Do not use floating promises, we can resolve these… by timfrijtersppw · Pull Request #17652 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular/cli): Do not use floating promises, we can resolve these… by timfrijtersppw · Pull Request #17652 · angular/angular-cli

X Title: fix(@angular/cli): Do not use floating promises, we can resolve these… by timfrijtersppw · Pull Request #17652 · angular/angular-cli

Description: CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.

Open Graph Description: In this PR I've fixed some floating promises in the generation of component spec files and app.component.spec.ts. Without this fix tslint errors occur when generating components when the tslint...

X Description: In this PR I've fixed some floating promises in the generation of component spec files and app.component.spec.ts. Without this fix tslint errors occur when generating components when the ts...

Opengraph URL: https://github.com/angular/angular-cli/pull/17652

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f6924311-0f34-45e0-5cb7-0903abbd410f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC238:1F2D:1F382F7:2789E34:6B01A025
html-safe-nonce2e343ad965472645f988b79b24fd10b5ec54a94b227b1fc872415967d72e7e4d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjM4OjFGMkQ6MUYzODJGNzoyNzg5RTM0OjZCMDFBMDI1IiwidmlzaXRvcl9pZCI6IjY3MDY3MzA1MDEyNDUzNDU4MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac42b6d66d09577d8b75bdcc677ec897ea62f42fe972a8054b5bf4b1912a1726db
hovercard-subject-tagpull_request:414158870
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular-cli/17652/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5774e5f8fe2ec25e3ca6b9ece89938e42849feaf8a6a561e67dc49f0005639c6/angular/angular-cli/pull/17652
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5774e5f8fe2ec25e3ca6b9ece89938e42849feaf8a6a561e67dc49f0005639c6/angular/angular-cli/pull/17652
og:image:altIn this PR I've fixed some floating promises in the generation of component spec files and app.component.spec.ts. Without this fix tslint errors occur when generating components when the tslint...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametimfrijtersppw
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/17652#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F17652
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F17652
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/17652
Reloadhttps://github.com/angular/angular-cli/pull/17652
Reloadhttps://github.com/angular/angular-cli/pull/17652
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
timfrijtersppwhttps://github.com/timfrijtersppw
angular:masterhttps://github.com/angular/angular-cli/tree/master
timfrijtersppw:fix-promise-handlinghttps://github.com/timfrijtersppw/angular-cli/tree/fix-promise-handling
Conversationhttps://github.com/angular/angular-cli/pull/17652
Commits2 (2)https://github.com/angular/angular-cli/pull/17652/commits
Checkshttps://github.com/angular/angular-cli/pull/17652/checks
Files changedhttps://github.com/angular/angular-cli/pull/17652/files
fix(@angular/cli): Do not use floating promises, we can resolve these…https://github.com/angular/angular-cli/pull/17652#top
timfrijtersppwhttps://github.com/timfrijtersppw
angular:masterhttps://github.com/angular/angular-cli/tree/master
timfrijtersppw:fix-promise-handlinghttps://github.com/timfrijtersppw/angular-cli/tree/fix-promise-handling
https://github.com/timfrijtersppw
timfrijtersppwhttps://github.com/timfrijtersppw
May 6, 2020https://github.com/angular/angular-cli/pull/17652#issue-613396975
https://palantir.github.io/tslint/rules/no-floating-promises/https://palantir.github.io/tslint/rules/no-floating-promises/
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 6, 2020https://github.com/angular/angular-cli/pull/17652#event-3308961865
https://github.com/clydin
clydinhttps://github.com/clydin
May 6, 2020 https://github.com/angular/angular-cli/pull/17652#pullrequestreview-406717448
View reviewed changes https://github.com/angular/angular-cli/pull/17652/files
packages/schematics/angular/application/other-files/app.component.spec.ts.templatehttps://github.com/angular/angular-cli/pull/17652/files#diff-7dd48bb454da1e3b9745f482d367c15136a3560dca0b9f1c74bd6e3b58d939aa
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
https://github.com/clydin
clydinhttps://github.com/clydin
May 6, 2020 https://github.com/angular/angular-cli/pull/17652#pullrequestreview-406724233
View reviewed changes https://github.com/angular/angular-cli/pull/17652/files
packages/schematics/angular/e2e/files/src/app.e2e-spec.ts.templatehttps://github.com/angular/angular-cli/pull/17652/files#diff-5cb134e855f021cc08a0170f39006bd1cca359609342ba78133ff0651b74e5bf
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
https://github.com/timfrijtersppw
timfrijtersppwhttps://github.com/timfrijtersppw
force-pushedhttps://github.com/angular/angular-cli/compare/4573010878b727f64e007d56a0fd6f9a8fb620ac..e948768f9e55201c824b689b65b191f9d822c8b9
4573010https://github.com/angular/angular-cli/commit/4573010878b727f64e007d56a0fd6f9a8fb620ac
e948768https://github.com/angular/angular-cli/commit/e948768f9e55201c824b689b65b191f9d822c8b9
Compare https://github.com/angular/angular-cli/compare/4573010878b727f64e007d56a0fd6f9a8fb620ac..e948768f9e55201c824b689b65b191f9d822c8b9
May 6, 2020 15:39https://github.com/angular/angular-cli/pull/17652#event-3309089127
https://github.com/timfrijtersppw
timfrijtersppwhttps://github.com/timfrijtersppw
May 6, 2020https://github.com/angular/angular-cli/pull/17652#issuecomment-624725441
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
timfrijtersppwhttps://github.com/timfrijtersppw
May 6, 2020 17:43https://github.com/angular/angular-cli/pull/17652#commits-pushed-6bfe728
https://github.com/timfrijtersppw
fix(@angular/cli): Do not use floating promises, we can resolve these…https://github.com/angular/angular-cli/pull/17652/commits/6bfe728b428417bad21bd0cb68288001275a869e
6bfe728https://github.com/angular/angular-cli/pull/17652/commits/6bfe728b428417bad21bd0cb68288001275a869e
https://github.com/timfrijtersppw
fix(@angular/cli): Functions that return promises must be asynchttps://github.com/angular/angular-cli/pull/17652/commits/b6f5bd4f75d9e1671c729d63972204c5d4bdb125
b6f5bd4https://github.com/angular/angular-cli/pull/17652/commits/b6f5bd4f75d9e1671c729d63972204c5d4bdb125
https://github.com/timfrijtersppw
timfrijtersppwhttps://github.com/timfrijtersppw
force-pushedhttps://github.com/angular/angular-cli/compare/e948768f9e55201c824b689b65b191f9d822c8b9..b6f5bd4f75d9e1671c729d63972204c5d4bdb125
e948768https://github.com/angular/angular-cli/commit/e948768f9e55201c824b689b65b191f9d822c8b9
b6f5bd4https://github.com/angular/angular-cli/commit/b6f5bd4f75d9e1671c729d63972204c5d4bdb125
Compare https://github.com/angular/angular-cli/compare/e948768f9e55201c824b689b65b191f9d822c8b9..b6f5bd4f75d9e1671c729d63972204c5d4bdb125
May 6, 2020 15:43https://github.com/angular/angular-cli/pull/17652#event-3309107351
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 6, 2020 https://github.com/angular/angular-cli/pull/17652#pullrequestreview-406757345
View reviewed changes https://github.com/angular/angular-cli/pull/17652/files/b6f5bd4f75d9e1671c729d63972204c5d4bdb125
packages/schematics/angular/application/other-files/app.component.spec.ts.templatehttps://github.com/angular/angular-cli/pull/17652/files/b6f5bd4f75d9e1671c729d63972204c5d4bdb125#diff-7dd48bb454da1e3b9745f482d367c15136a3560dca0b9f1c74bd6e3b58d939aa
gkalpakhttps://github.com/gkalpak
May 6, 2020https://github.com/angular/angular-cli/pull/17652#discussion_r420904985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
clydinhttps://github.com/clydin
May 6, 2020https://github.com/angular/angular-cli/pull/17652#discussion_r420966865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
timfrijtersppwhttps://github.com/timfrijtersppw
May 7, 2020https://github.com/angular/angular-cli/pull/17652#discussion_r421488433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
packages/schematics/angular/e2e/files/src/app.po.ts.templatehttps://github.com/angular/angular-cli/pull/17652/files/b6f5bd4f75d9e1671c729d63972204c5d4bdb125#diff-c8e773a3af9ef3a4fdfb390fe10ab6a9f31f4fd9b1bd2f4c08d3cfbbd2925a90
gkalpakhttps://github.com/gkalpak
May 6, 2020https://github.com/angular/angular-cli/pull/17652#discussion_r420906410
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
clydinhttps://github.com/clydin
May 6, 2020https://github.com/angular/angular-cli/pull/17652#discussion_r420971341
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
alan-agius4https://github.com/alan-agius4
May 7, 2020https://github.com/angular/angular-cli/pull/17652#discussion_r421661976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Sep 14, 2020 https://github.com/angular/angular-cli/pull/17652#ref-pullrequest-701061666
Improve async handling in generated code #18783 https://github.com/angular/angular-cli/pull/18783
https://github.com/clydin
clydinhttps://github.com/clydin
Oct 6, 2020https://github.com/angular/angular-cli/pull/17652#issuecomment-704459609
#18243https://github.com/angular/angular-cli/pull/18243
#18951https://github.com/angular/angular-cli/pull/18951
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
https://github.com/clydin
clydinhttps://github.com/clydin
Oct 6, 2020https://github.com/angular/angular-cli/pull/17652#event-3846914969
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 6, 2020https://github.com/angular/angular-cli/pull/17652#issuecomment-722940196
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 6, 2020https://github.com/angular/angular-cli/pull/17652#event-3966018956
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F17652
https://github.com/alan-agius4
alan-agius4 https://github.com/alan-agius4
https://github.com/angular/angular-cli/pull/17652/files/b6f5bd4f75d9e1671c729d63972204c5d4bdb125
https://github.com/clydin
clydin https://github.com/clydin
https://github.com/angular/angular-cli/pull/17652/files/b6f5bd4f75d9e1671c729d63972204c5d4bdb125
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular-cli/pull/17652/files/b6f5bd4f75d9e1671c729d63972204c5d4bdb125
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
Please reload this pagehttps://github.com/angular/angular-cli/pull/17652
https://github.com/timfrijtersppw
https://github.com/clydin
https://github.com/gkalpak
https://github.com/alan-agius4
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.