René's URL Explorer Experiment


Title: Ivy app shell by alan-agius4 · Pull Request #15517 · angular/angular-cli · GitHub

Open Graph Title: Ivy app shell by alan-agius4 · Pull Request #15517 · angular/angular-cli

X Title: Ivy app shell by alan-agius4 · Pull Request #15517 · angular/angular-cli

Description: feat(@angular-devkit/build-angular): enable bundleDependencies by default for server builder BREAKING CHANGE: bundleDependencies default value has been changed from none to all. This will result in all of node_modules to be bundled in the final server bundle. Under Ivy, if users choose to opt-out from bundling dependencies they will need to run NGCC binary manually to make non-bundled node_modules compatible with Ivy. feat(@schematics/angular): add export to renderModule in server main file This will be used by universal and app-shell to render the server module fix(@angular-devkit/build-angular): make app-shell work with Ivy Fixes #15383 feat(@schematics/angular): add export to renderModuleFactory in server main file feat(@schematics/angular): add migration to add missing exports in main server file Update the main.server.ts file by adding exports to renderModule and renderModuleFactory which are now required for Universal and App-Shell for Ivy and bundleDependencies.

Open Graph Description: feat(@angular-devkit/build-angular): enable bundleDependencies by default for server builder BREAKING CHANGE: bundleDependencies default value has been changed from none to all. This will result in...

X Description: feat(@angular-devkit/build-angular): enable bundleDependencies by default for server builder BREAKING CHANGE: bundleDependencies default value has been changed from none to all. This will result in...

Opengraph URL: https://github.com/angular/angular-cli/pull/15517

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b4a96581-ba14-ea78-6830-3f26886f3f9c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB84E:14700E:1BBE133:2327579:6B0152A5
html-safe-nonce62043dbafd0d684540883614b9f88fc470350b18fa65a913dc26e0017878be07
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODRFOjE0NzAwRToxQkJFMTMzOjIzMjc1Nzk6NkIwMTUyQTUiLCJ2aXNpdG9yX2lkIjoiNzIxNjQxNTg5Mzc1OTI4Mzg3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac811d3d529b7c537820d028fe136b5c2b52e331bb86cb3eb5ab2a4d94e06e6c6d
hovercard-subject-tagpull_request:313928268
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/15517/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altfeat(@angular-devkit/build-angular): enable bundleDependencies by default for server builder BREAKING CHANGE: bundleDependencies default value has been changed from none to all. This will result in...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/15517/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F15517%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F15517%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/15517/files
Reloadhttps://github.com/angular/angular-cli/pull/15517/files
Reloadhttps://github.com/angular/angular-cli/pull/15517/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
kyliauhttps://github.com/kyliau
angular:masterhttps://github.com/angular/angular-cli/tree/master
Conversation 13 https://github.com/angular/angular-cli/pull/15517
Commits 7 https://github.com/angular/angular-cli/pull/15517/commits
Checks 0 https://github.com/angular/angular-cli/pull/15517/checks
Files changed https://github.com/angular/angular-cli/pull/15517/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/15517/files
Ivy app shell https://github.com/angular/angular-cli/pull/15517/files#top
Show all changes 7 commits https://github.com/angular/angular-cli/pull/15517/files
69422b1 feat(@angular-devkit/build-angular): enable bundleDependencies by def… alan-agius4 Sep 4, 2019 https://github.com/angular/angular-cli/pull/15517/commits/69422b189493023e9afe55723ca42a436759698a
61ff8e2 feat(@schematics/angular): add export to `renderModule` in server mai… alan-agius4 Sep 4, 2019 https://github.com/angular/angular-cli/pull/15517/commits/61ff8e2d0b3f95ddaf9e6bee725db9c4a918a782
5cc4734 fix(@angular-devkit/build-angular): make app-shell work with Ivy alan-agius4 Sep 4, 2019 https://github.com/angular/angular-cli/pull/15517/commits/5cc4734abfe0fa7fbaea87483f06f6a9b951f757
9263fba test: run ivy-ngcc binary to reduce flakes alan-agius4 Sep 4, 2019 https://github.com/angular/angular-cli/pull/15517/commits/9263fbaffefe0c68729fbbb3e30dbc9b998386bc
155dea8 test: add production app-shell test alan-agius4 Sep 4, 2019 https://github.com/angular/angular-cli/pull/15517/commits/155dea81deb7151c190d5e0d7700eb2d60f2088e
8fb8e59 feat(@schematics/angular): add export to `renderModuleFactory` in ser… alan-agius4 Sep 5, 2019 https://github.com/angular/angular-cli/pull/15517/commits/8fb8e59dd0e643dcba29a0888b7457b5f1ee0210
7a80959 feat(@schematics/angular): add migration to add missing exports in ma… alan-agius4 Sep 5, 2019 https://github.com/angular/angular-cli/pull/15517/commits/7a80959bdc6811aa01ea8da9bb2796acb243628a
Clear filters https://github.com/angular/angular-cli/pull/15517/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/15517/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/15517/files
index.ts https://github.com/angular/angular-cli/pull/15517/files#diff-c27eebfed648da87b19f46ee6674e6aa4abda0fd2d03f9538a5ca78c5585b85c
schema.json https://github.com/angular/angular-cli/pull/15517/files#diff-cd0bed751513bb381dc98c2b2fa67b36a86cbac673d4489552621bb36cd8fdf1
app-shell_spec_large.ts https://github.com/angular/angular-cli/pull/15517/files#diff-94be258a185c056f8e95b9ff716db111e65e04ad746ed2aacae8e29cd0918259
base_spec_large.ts https://github.com/angular/angular-cli/pull/15517/files#diff-bcf631bcd2da3775d4e0b471e46f2d07b878c142cc361f5bab720035fe6e27f9
index.ts https://github.com/angular/angular-cli/pull/15517/files#diff-7dd55efb1b92f5727222c6ccc608b8ced5b240efd4358b170a42e8424ae80d6a
update-server-main-file.ts https://github.com/angular/angular-cli/pull/15517/files#diff-4d931b587a4614621b91c77ef92ebecab30f71d5415e6b94b1fde0ab6b1a366e
update-server-main-file_spec.ts https://github.com/angular/angular-cli/pull/15517/files#diff-8cbb40914f0e51e28d3e35d453d0f5f275260400ea5023840eec8a1e801d92a6
__main@stripTsExtension__.ts.template https://github.com/angular/angular-cli/pull/15517/files#diff-ea3f134f2268461f0fbee755a6bc4340bf729674e338317903484027e4fec71f
test.ts https://github.com/angular/angular-cli/pull/15517/files#diff-213b9d826a210bb254ea8ffe4706178d59d5bb51d068cc069618adec1ea8beff
main.server.ts https://github.com/angular/angular-cli/pull/15517/files#diff-cf9cea81ec20b785698e8a0177ab42f04cda487a8b0eba461d501e4fd58d192b
app.module.ts https://github.com/angular/angular-cli/pull/15517/files#diff-1b7e9f320971b29b587b4add3cbef9e15cd11426ffc0bccae6fc8b2c4e180301
app.server.module.ts https://github.com/angular/angular-cli/pull/15517/files#diff-be95928476ef68d30f8161f43b548d32dd0bfda598b16d6853b5d610cc2250c9
main.server.ts https://github.com/angular/angular-cli/pull/15517/files#diff-082db17a0001576e6375559d5cdda7f79fb64a7fddaf7a590c2288c90f4e1a18
build-app-shell-with-schematic.ts https://github.com/angular/angular-cli/pull/15517/files#diff-f95ca5366e0a04da8714b2f42264d8dd363b38556e2a5c3c4b2629ba9a19a2b2
build-app-shell.ts https://github.com/angular/angular-cli/pull/15517/files#diff-0e84c2e0f2ea30ddb3e166880733bb47153228a3687daffab21dadd64b694e98
platform-server.ts https://github.com/angular/angular-cli/pull/15517/files#diff-0bcf3872393afe9ebf5a1bdf91c80613110a5e74032c77e8bb19f3cd3b0eb63e
e2e_runner.ts https://github.com/angular/angular-cli/pull/15517/files#diff-0f755f000f6703e96cffe62120c9922d7bbeff5906ef243aba12adeddf8c4181
packages/angular_devkit/build_angular/src/app-shell/index.tshttps://github.com/angular/angular-cli/pull/15517/files#diff-c27eebfed648da87b19f46ee6674e6aa4abda0fd2d03f9538a5ca78c5585b85c
View file https://github.com/angular/angular-cli/blob/7a80959bdc6811aa01ea8da9bb2796acb243628a/packages/angular_devkit/build_angular/src/app-shell/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/15517/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/15517/files#diff-c27eebfed648da87b19f46ee6674e6aa4abda0fd2d03f9538a5ca78c5585b85c
https://github.com/angular/angular-cli/pull/15517/files#diff-c27eebfed648da87b19f46ee6674e6aa4abda0fd2d03f9538a5ca78c5585b85c
https://github.com/angular/angular-cli/pull/15517/files#diff-c27eebfed648da87b19f46ee6674e6aa4abda0fd2d03f9538a5ca78c5585b85c
packages/angular_devkit/build_angular/src/server/schema.jsonhttps://github.com/angular/angular-cli/pull/15517/files#diff-cd0bed751513bb381dc98c2b2fa67b36a86cbac673d4489552621bb36cd8fdf1
View file https://github.com/angular/angular-cli/blob/7a80959bdc6811aa01ea8da9bb2796acb243628a/packages/angular_devkit/build_angular/src/server/schema.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/15517/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/15517/files#diff-cd0bed751513bb381dc98c2b2fa67b36a86cbac673d4489552621bb36cd8fdf1
https://github.com/angular/angular-cli/pull/15517/files#diff-cd0bed751513bb381dc98c2b2fa67b36a86cbac673d4489552621bb36cd8fdf1
packages/angular_devkit/build_angular/test/app-shell/app-shell_spec_large.tshttps://github.com/angular/angular-cli/pull/15517/files#diff-94be258a185c056f8e95b9ff716db111e65e04ad746ed2aacae8e29cd0918259
View file https://github.com/angular/angular-cli/blob/7a80959bdc6811aa01ea8da9bb2796acb243628a/packages/angular_devkit/build_angular/test/app-shell/app-shell_spec_large.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/15517/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/15517/files#diff-94be258a185c056f8e95b9ff716db111e65e04ad746ed2aacae8e29cd0918259
https://github.com/angular/angular-cli/pull/15517/files#diff-94be258a185c056f8e95b9ff716db111e65e04ad746ed2aacae8e29cd0918259
packages/angular_devkit/build_angular/test/server/base_spec_large.tshttps://github.com/angular/angular-cli/pull/15517/files#diff-bcf631bcd2da3775d4e0b471e46f2d07b878c142cc361f5bab720035fe6e27f9
View file https://github.com/angular/angular-cli/blob/7a80959bdc6811aa01ea8da9bb2796acb243628a/packages/angular_devkit/build_angular/test/server/base_spec_large.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/15517/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/15517/files#diff-bcf631bcd2da3775d4e0b471e46f2d07b878c142cc361f5bab720035fe6e27f9
https://github.com/angular/angular-cli/pull/15517/files#diff-bcf631bcd2da3775d4e0b471e46f2d07b878c142cc361f5bab720035fe6e27f9
https://github.com/angular/angular-cli/pull/15517/files#diff-bcf631bcd2da3775d4e0b471e46f2d07b878c142cc361f5bab720035fe6e27f9
https://github.com/angular/angular-cli/pull/15517/files#diff-bcf631bcd2da3775d4e0b471e46f2d07b878c142cc361f5bab720035fe6e27f9
https://github.com/angular/angular-cli/pull/15517/files#diff-bcf631bcd2da3775d4e0b471e46f2d07b878c142cc361f5bab720035fe6e27f9
packages/schematics/angular/migrations/update-9/index.tshttps://github.com/angular/angular-cli/pull/15517/files#diff-7dd55efb1b92f5727222c6ccc608b8ced5b240efd4358b170a42e8424ae80d6a
View file https://github.com/angular/angular-cli/blob/7a80959bdc6811aa01ea8da9bb2796acb243628a/packages/schematics/angular/migrations/update-9/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/15517/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/15517/files#diff-7dd55efb1b92f5727222c6ccc608b8ced5b240efd4358b170a42e8424ae80d6a
https://github.com/angular/angular-cli/pull/15517/files#diff-7dd55efb1b92f5727222c6ccc608b8ced5b240efd4358b170a42e8424ae80d6a
https://github.com/angular/angular-cli/pull/15517/files#diff-7dd55efb1b92f5727222c6ccc608b8ced5b240efd4358b170a42e8424ae80d6a
packages/schematics/angular/migrations/update-9/update-server-main-file.tshttps://github.com/angular/angular-cli/pull/15517/files#diff-4d931b587a4614621b91c77ef92ebecab30f71d5415e6b94b1fde0ab6b1a366e
View file https://github.com/angular/angular-cli/blob/7a80959bdc6811aa01ea8da9bb2796acb243628a/packages/schematics/angular/migrations/update-9/update-server-main-file.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/15517/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular-cli/pull/15517/files
packages/schematics/angular/migrations/update-9/update-server-main-file_spec.tshttps://github.com/angular/angular-cli/pull/15517/files#diff-8cbb40914f0e51e28d3e35d453d0f5f275260400ea5023840eec8a1e801d92a6
View file https://github.com/angular/angular-cli/blob/7a80959bdc6811aa01ea8da9bb2796acb243628a/packages/schematics/angular/migrations/update-9/update-server-main-file_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/15517/{{ revealButtonHref }}
packages/schematics/angular/universal/files/src/__main@stripTsExtension__.ts.templatehttps://github.com/angular/angular-cli/pull/15517/files#diff-ea3f134f2268461f0fbee755a6bc4340bf729674e338317903484027e4fec71f
View file https://github.com/angular/angular-cli/blob/7a80959bdc6811aa01ea8da9bb2796acb243628a/packages/schematics/angular/universal/files/src/__main%40stripTsExtension__.ts.template
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/15517/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/15517/files#diff-ea3f134f2268461f0fbee755a6bc4340bf729674e338317903484027e4fec71f
Please reload this pagehttps://github.com/angular/angular-cli/pull/15517/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.