René's URL Explorer Experiment


Title: fix(@ngtools/webpack): NGCC should process secondary entry-points by petebacondarwin · Pull Request #14934 · angular/angular-cli · GitHub

Open Graph Title: fix(@ngtools/webpack): NGCC should process secondary entry-points by petebacondarwin · Pull Request #14934 · angular/angular-cli

X Title: fix(@ngtools/webpack): NGCC should process secondary entry-points by petebacondarwin · Pull Request #14934 · angular/angular-cli

Description: Previously secondary entry-points, e.g @angular/common/http, were being resolved to the primary entry-point, e.g @angular/common. This meant that these entry-points were not being processed as part of a compilation leading to error messages. This change inverts the tryResolvePackage logic to attempt to use require.resolve() first and only looking in the parent directory of the typings file as a fallback if the main resolve fails. Fixes angular/angular#30972 (comment)

Open Graph Description: Previously secondary entry-points, e.g @angular/common/http, were being resolved to the primary entry-point, e.g @angular/common. This meant that these entry-points were not being processed as par...

X Description: Previously secondary entry-points, e.g @angular/common/http, were being resolved to the primary entry-point, e.g @angular/common. This meant that these entry-points were not being processed as par...

Opengraph URL: https://github.com/angular/angular-cli/pull/14934

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:20982fb2-fb0a-3d29-0db1-94e499ae8cfe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id924E:33444D:10D5E45:1669FE0:6B01170B
html-safe-nonce53e92b0fa65e12c482f88a7be5530d8a9d74b16fc94abec06cede3f5a5453ed9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjRFOjMzNDQ0RDoxMEQ1RTQ1OjE2NjlGRTA6NkIwMTE3MEIiLCJ2aXNpdG9yX2lkIjoiNjQxMjY1MDAzNjAzOTA2MzMwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4deb6b339bd3199ad7538a06447842fa385d86a2fb42b26a61a0600091fb1bd3
hovercard-subject-tagpull_request:292758990
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/14934/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altPreviously secondary entry-points, e.g @angular/common/http, were being resolved to the primary entry-point, e.g @angular/common. This meant that these entry-points were not being processed as par...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/14934/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14934%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14934%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/14934/files
Reloadhttps://github.com/angular/angular-cli/pull/14934/files
Reloadhttps://github.com/angular/angular-cli/pull/14934/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
vikermanhttps://github.com/vikerman
angular:masterhttps://github.com/angular/angular-cli/tree/master
petebacondarwin:ngcc-integration-fixhttps://github.com/petebacondarwin/angular-cli/tree/ngcc-integration-fix
Conversation 3 https://github.com/angular/angular-cli/pull/14934
Commits 1 https://github.com/angular/angular-cli/pull/14934/commits
Checks 0 https://github.com/angular/angular-cli/pull/14934/checks
Files changed https://github.com/angular/angular-cli/pull/14934/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14934/files
fix(@ngtools/webpack): NGCC should process secondary entry-points https://github.com/angular/angular-cli/pull/14934/files#top
Show all changes 1 commit https://github.com/angular/angular-cli/pull/14934/files
80c90af fix(@ngtools/webpack): NGCC should process secondary entry-points petebacondarwin Jun 28, 2019 https://github.com/angular/angular-cli/pull/14934/commits/80c90af5612679e422ecfc59c51e5a054c81af61
Clear filters https://github.com/angular/angular-cli/pull/14934/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14934/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14934/files
ngcc_processor.ts https://github.com/angular/angular-cli/pull/14934/files#diff-ad002d194bd8ec810786bb7aa9f3b66c21dda7f336809bf2974648c304a81a86
ivy.ts https://github.com/angular/angular-cli/pull/14934/files#diff-025d8af784585a830cdebb7a1c80b2ab8e0c4289b86bb7a54eaecf00ac2d299c
packages/ngtools/webpack/src/ngcc_processor.tshttps://github.com/angular/angular-cli/pull/14934/files#diff-ad002d194bd8ec810786bb7aa9f3b66c21dda7f336809bf2974648c304a81a86
View file https://github.com/petebacondarwin/angular-cli/blob/80c90af5612679e422ecfc59c51e5a054c81af61/packages/ngtools/webpack/src/ngcc_processor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14934/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14934/files#diff-ad002d194bd8ec810786bb7aa9f3b66c21dda7f336809bf2974648c304a81a86
https://github.com/angular/angular-cli/pull/14934/files#diff-ad002d194bd8ec810786bb7aa9f3b66c21dda7f336809bf2974648c304a81a86
https://github.com/angular/angular-cli/pull/14934/files#diff-ad002d194bd8ec810786bb7aa9f3b66c21dda7f336809bf2974648c304a81a86
https://github.com/angular/angular-cli/pull/14934/files#diff-ad002d194bd8ec810786bb7aa9f3b66c21dda7f336809bf2974648c304a81a86
https://github.com/angular/angular-cli/pull/14934/files#diff-ad002d194bd8ec810786bb7aa9f3b66c21dda7f336809bf2974648c304a81a86
tests/legacy-cli/e2e/tests/ivy/ivy.tshttps://github.com/angular/angular-cli/pull/14934/files#diff-025d8af784585a830cdebb7a1c80b2ab8e0c4289b86bb7a54eaecf00ac2d299c
View file https://github.com/petebacondarwin/angular-cli/blob/80c90af5612679e422ecfc59c51e5a054c81af61/tests/legacy-cli/e2e/tests/ivy/ivy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14934/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14934/files#diff-025d8af784585a830cdebb7a1c80b2ab8e0c4289b86bb7a54eaecf00ac2d299c
https://github.com/angular/angular-cli/pull/14934/files#diff-025d8af784585a830cdebb7a1c80b2ab8e0c4289b86bb7a54eaecf00ac2d299c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.