René's URL Explorer Experiment


Title: DL fixes for safari and false negatives for ES6 module support by alan-agius4 · Pull Request #14716 · angular/angular-cli · GitHub

Open Graph Title: DL fixes for safari and false negatives for ES6 module support by alan-agius4 · Pull Request #14716 · angular/angular-cli

X Title: DL fixes for safari and false negatives for ES6 module support by alan-agius4 · Pull Request #14716 · angular/angular-cli

Description: fix(@angular-devkit/build-angular): nomodule polyfill for Safari 10.1 and iOS Safari 10.3 The nomodule polyfill needs to be inject prior to any script and be outside of webpack compilation because otherwise webpack will cause the script to be wrapped in window["webpackJsonp"] which causes this to fail. Also, this ensures that it's loaded and executed prior to any other nomodule script. This polyfill will only be injected when the either Safari 10.1 or iOS Safari 10.3 support is required, which is based on the browsers defined in browserslist file. Fixes #14680 fix(@angular-devkit/build-angular): browsers that partially support es6 modules are being marked as not supported caniuse-api only returns true for a feature when it's fully supported. This might causes redundant ES5 builds if users opt to support only browsers which do support ES6 modules but either require polyfills such as Safari 10.1 or when both bundles will be downloaded such as Edge 18 See: https://github.com/Nyalab/caniuse-api/blob/1b74c10257e36877709da4f6630513db10203a78/src/index.js#L49 and MoOx/caniuse-api#82 Fixes #14580

Open Graph Description: fix(@angular-devkit/build-angular): nomodule polyfill for Safari 10.1 and iOS Safari 10.3 The nomodule polyfill needs to be inject prior to any script and be outside of webpack compilation because ...

X Description: fix(@angular-devkit/build-angular): nomodule polyfill for Safari 10.1 and iOS Safari 10.3 The nomodule polyfill needs to be inject prior to any script and be outside of webpack compilation because ...

Opengraph URL: https://github.com/angular/angular-cli/pull/14716

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73ab8254-84a6-b97b-a9e4-8ee13d5f1c65
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC43E:3F8A67:1632667:1DAC059:6B013FA7
html-safe-noncec7a3cccc67e9379a0d6c06a224e8312caaefef561d1a32bf9446181386d1a076
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDNFOjNGOEE2NzoxNjMyNjY3OjFEQUMwNTk6NkIwMTNGQTciLCJ2aXNpdG9yX2lkIjoiODkyNjA0NTI3Mzk1MjY5ODI3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdf2cfcd9c4297c0b5dc0d80151b9c47e18e4b613833c50056185b893761f5dcf
hovercard-subject-tagpull_request:286612716
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/14716/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altfix(@angular-devkit/build-angular): nomodule polyfill for Safari 10.1 and iOS Safari 10.3 The nomodule polyfill needs to be inject prior to any script and be outside of webpack compilation because ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/14716/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14716%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14716%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/14716/files
Reloadhttps://github.com/angular/angular-cli/pull/14716/files
Reloadhttps://github.com/angular/angular-cli/pull/14716/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
kyliauhttps://github.com/kyliau
angular:masterhttps://github.com/angular/angular-cli/tree/master
Conversation 4 https://github.com/angular/angular-cli/pull/14716
Commits 3 https://github.com/angular/angular-cli/pull/14716/commits
Checks 0 https://github.com/angular/angular-cli/pull/14716/checks
Files changed https://github.com/angular/angular-cli/pull/14716/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14716/files
DL fixes for safari and false negatives for ES6 module support https://github.com/angular/angular-cli/pull/14716/files#top
Show all changes 3 commits https://github.com/angular/angular-cli/pull/14716/files
5178f9c fix(@angular-devkit/build-angular): nomodule polyfill for Safari alan-agius4 Jun 8, 2019 https://github.com/angular/angular-cli/pull/14716/commits/5178f9c01749af891fe4a0c1dc150e77051c26f5
89e806d test: change polyfills in hello-world-app which causes `rebuilds TS w… alan-agius4 Jun 11, 2019 https://github.com/angular/angular-cli/pull/14716/commits/89e806d92623db8b8f75524adadd074ca00c9d0f
f3f9a69 fix(@angular-devkit/build-angular): browsers that partially support E… alan-agius4 Jun 11, 2019 https://github.com/angular/angular-cli/pull/14716/commits/f3f9a69f165e04117733dea1a406abbed922000f
Clear filters https://github.com/angular/angular-cli/pull/14716/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14716/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14716/files
package.json https://github.com/angular/angular-cli/pull/14716/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
package.json https://github.com/angular/angular-cli/pull/14716/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f
safari-nomodule.js https://github.com/angular/angular-cli/pull/14716/files#diff-5f9bdda3221177fd7e3344a314aad2b305e754c3d490dd210deb3d60ccf11eee
common.ts https://github.com/angular/angular-cli/pull/14716/files#diff-a379da5935b1daa3a260482705b7dcbbefa6b1596a277b6d7513fef8eb641ca4
utils.ts https://github.com/angular/angular-cli/pull/14716/files#diff-44e06aef23f3206cdf4cc3b4246e88fc20922430677c149400229f48287b9b1a
package-chunk-sort.ts https://github.com/angular/angular-cli/pull/14716/files#diff-74a70ac16571cba26305786b408f6a6f46836e6b2a7c80e72d42583277aac5ac
index.ts https://github.com/angular/angular-cli/pull/14716/files#diff-5b54a4601b5d50cc0617712190a902a19f4ea2d044c836e98d5cf8e9e6c4a6f3
build-browser-features.ts https://github.com/angular/angular-cli/pull/14716/files#diff-a359a009c93aa22ab4f58178300e490976aca98cdffc5ccdd0ee2974d308c635
build-browser-features_spec.ts https://github.com/angular/angular-cli/pull/14716/files#diff-e299182e312c05b221c0dfe313d34361d7cc1ec6583c6cbad022d3b7e6b1321f
differential-loading.ts https://github.com/angular/angular-cli/pull/14716/files#diff-de9390f6a290973ecfad3dd105a12d53d79687808cc13235794376aac0005cc7
differential-loading_spec.ts https://github.com/angular/angular-cli/pull/14716/files#diff-bc7c445ace7c49201f09f0a0ccc9a4dec32ce8fff2eedd2067232beed10db4af
index.ts https://github.com/angular/angular-cli/pull/14716/files#diff-1e486dc7a7b946144df84662012eb38bc5fa5d1cc404801ce25d465e95f412f9
webpack-browser-config.ts https://github.com/angular/angular-cli/pull/14716/files#diff-56f1164a266df12cd75aaba3f6ecc8f8388a65bb29f68bdc09e4b79997f2ad96
differential_loading_spec_large.ts https://github.com/angular/angular-cli/pull/14716/files#diff-14226af4abf1da6aea952cc009ba3b75ab8cec500e71ed4740045f2500165f57
package.json https://github.com/angular/angular-cli/pull/14716/files#diff-51d1b16f0c96fa4958edd3c58010f9049bbbad0abc0b39ecf3da796c431a4c4b
polyfills.ts https://github.com/angular/angular-cli/pull/14716/files#diff-46ccd1b30a07ebe92c5d66b2965cd64387e17f7c1e68879af64287e86926dcf8
support-safari-10.1.ts https://github.com/angular/angular-cli/pull/14716/files#diff-4b6054cd1e1f03b875a1fa15e88f102abbf0583d162e6e3f6efbf83d2d6e1459
yarn.lock https://github.com/angular/angular-cli/pull/14716/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
package.jsonhttps://github.com/angular/angular-cli/pull/14716/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/angular/angular-cli/blob/f3f9a69f165e04117733dea1a406abbed922000f/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14716/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14716/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angular-cli/pull/14716/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
packages/angular_devkit/build_angular/package.jsonhttps://github.com/angular/angular-cli/pull/14716/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f
View file https://github.com/angular/angular-cli/blob/f3f9a69f165e04117733dea1a406abbed922000f/packages/angular_devkit/build_angular/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14716/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14716/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f
https://github.com/angular/angular-cli/pull/14716/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f
packages/angular_devkit/build_angular/src/angular-cli-files/models/safari-nomodule.jshttps://github.com/angular/angular-cli/pull/14716/files#diff-5f9bdda3221177fd7e3344a314aad2b305e754c3d490dd210deb3d60ccf11eee
View file https://github.com/angular/angular-cli/blob/f3f9a69f165e04117733dea1a406abbed922000f/packages/angular_devkit/build_angular/src/angular-cli-files/models/safari-nomodule.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14716/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14716/files#diff-5f9bdda3221177fd7e3344a314aad2b305e754c3d490dd210deb3d60ccf11eee
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.tshttps://github.com/angular/angular-cli/pull/14716/files#diff-a379da5935b1daa3a260482705b7dcbbefa6b1596a277b6d7513fef8eb641ca4
View file https://github.com/angular/angular-cli/blob/f3f9a69f165e04117733dea1a406abbed922000f/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14716/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14716/files#diff-a379da5935b1daa3a260482705b7dcbbefa6b1596a277b6d7513fef8eb641ca4
https://github.com/angular/angular-cli/pull/14716/files#diff-a379da5935b1daa3a260482705b7dcbbefa6b1596a277b6d7513fef8eb641ca4
https://github.com/angular/angular-cli/pull/14716/files#diff-a379da5935b1daa3a260482705b7dcbbefa6b1596a277b6d7513fef8eb641ca4
https://github.com/angular/angular-cli/pull/14716/files#diff-a379da5935b1daa3a260482705b7dcbbefa6b1596a277b6d7513fef8eb641ca4
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.tshttps://github.com/angular/angular-cli/pull/14716/files#diff-44e06aef23f3206cdf4cc3b4246e88fc20922430677c149400229f48287b9b1a
View file https://github.com/angular/angular-cli/blob/f3f9a69f165e04117733dea1a406abbed922000f/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14716/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14716/files#diff-44e06aef23f3206cdf4cc3b4246e88fc20922430677c149400229f48287b9b1a
https://github.com/angular/angular-cli/pull/14716/files#diff-44e06aef23f3206cdf4cc3b4246e88fc20922430677c149400229f48287b9b1a
packages/angular_devkit/build_angular/src/angular-cli-files/utilities/package-chunk-sort.tshttps://github.com/angular/angular-cli/pull/14716/files#diff-74a70ac16571cba26305786b408f6a6f46836e6b2a7c80e72d42583277aac5ac
View file https://github.com/angular/angular-cli/blob/f3f9a69f165e04117733dea1a406abbed922000f/packages/angular_devkit/build_angular/src/angular-cli-files/utilities/package-chunk-sort.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14716/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14716/files#diff-74a70ac16571cba26305786b408f6a6f46836e6b2a7c80e72d42583277aac5ac
https://github.com/angular/angular-cli/pull/14716/files#diff-74a70ac16571cba26305786b408f6a6f46836e6b2a7c80e72d42583277aac5ac
packages/angular_devkit/build_angular/src/browser/index.tshttps://github.com/angular/angular-cli/pull/14716/files#diff-5b54a4601b5d50cc0617712190a902a19f4ea2d044c836e98d5cf8e9e6c4a6f3
View file https://github.com/angular/angular-cli/blob/f3f9a69f165e04117733dea1a406abbed922000f/packages/angular_devkit/build_angular/src/browser/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14716/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14716/files#diff-5b54a4601b5d50cc0617712190a902a19f4ea2d044c836e98d5cf8e9e6c4a6f3
https://github.com/angular/angular-cli/pull/14716/files#diff-5b54a4601b5d50cc0617712190a902a19f4ea2d044c836e98d5cf8e9e6c4a6f3
https://github.com/angular/angular-cli/pull/14716/files#diff-5b54a4601b5d50cc0617712190a902a19f4ea2d044c836e98d5cf8e9e6c4a6f3
https://github.com/angular/angular-cli/pull/14716/files#diff-5b54a4601b5d50cc0617712190a902a19f4ea2d044c836e98d5cf8e9e6c4a6f3
packages/angular_devkit/build_angular/src/utils/build-browser-features.tshttps://github.com/angular/angular-cli/pull/14716/files#diff-a359a009c93aa22ab4f58178300e490976aca98cdffc5ccdd0ee2974d308c635
View file https://github.com/angular/angular-cli/blob/f3f9a69f165e04117733dea1a406abbed922000f/packages/angular_devkit/build_angular/src/utils/build-browser-features.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14716/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular-cli/pull/14716/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.