René's URL Explorer Experiment


Title: fix(@ngtools/webpack): downlevel constructor parameter type information by clydin · Pull Request #14473 · angular/angular-cli · GitHub

Open Graph Title: fix(@ngtools/webpack): downlevel constructor parameter type information by clydin · Pull Request #14473 · angular/angular-cli

X Title: fix(@ngtools/webpack): downlevel constructor parameter type information by clydin · Pull Request #14473 · angular/angular-cli

Description: The Angular JIT compiler uses the output of TypeScript's emitDecoratorMetadata to support dependency injection at runtime. This option stores type and DI token information so that the runtime JIT compiler can inject the proper provider. This option is not needed for AOT compilation and the metadata is indirectly stripped from the output due to all Angular decorators being removed during the compilation process. Unfortunately, the emitDecoratorMetadata option does not support forward references (or more generally circular dependencies) within ES2015+ output due to the TypeScript compiler transforming the metadata into a direct reference of the yet to be defined class. This results in a runtime TDZ error. This is a known limitation of the emitDecoratorMetadata option (reference). This situation is not unique to Angular and can occur in any TypeScript code. As it is marked as a design limitation, it is considered that it cannot be fixed within the current architecture of TypeScript. As a result, the change in this PR removes the need for the use of the option by storing the DI information in a static property function via the use of the tsickle ctorParameters transformation. By leveraging the existing functionality, no changes to the framework code is necessary. Also, minimal new code is required within the CLI, as the relevant tsickle code can be extracted and used with several local modifications. For forward references to function in ES2015+, the emitDecoratorMetadata option must be disabled based on the current implementation. To support both the option and forward references, the metadata generated by TypeScript would need to be altered to remove the type information that would trigger a TDZ error. However, by doing so the metadata information is no longer useful to Angular and technically incorrect as it will not contain the information from the source code as described by the option. Closes: #14424

Open Graph Description: The Angular JIT compiler uses the output of TypeScript's emitDecoratorMetadata to support dependency injection at runtime. This option stores type and DI token information so that the runtime ...

X Description: The Angular JIT compiler uses the output of TypeScript's emitDecoratorMetadata to support dependency injection at runtime. This option stores type and DI token information so that the runt...

Opengraph URL: https://github.com/angular/angular-cli/pull/14473

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e3ae6d36-9d05-acec-a581-24990d457286
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB6FE:21BD98:1C22D12:23AA5F2:6B019195
html-safe-nonce09c84641812d246cecc15490e32fb7d18aa44ef016cf64cca2e8f0df8eb084b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkZFOjIxQkQ5ODoxQzIyRDEyOjIzQUE1RjI6NkIwMTkxOTUiLCJ2aXNpdG9yX2lkIjoiMTc5MzU3NTY2NDU0NTI3MjIxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac75091d07a73d57558cc1a85ac03affcd17c1167bc018fbda5dd87d38c6040302
hovercard-subject-tagpull_request:280203814
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/14473/files
twitter:imagehttps://avatars.githubusercontent.com/u/19598772?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19598772?s=400&v=4
og:image:altThe Angular JIT compiler uses the output of TypeScript's emitDecoratorMetadata to support dependency injection at runtime. This option stores type and DI token information so that the runtime ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/14473/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14473%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14473%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/14473/files
Reloadhttps://github.com/angular/angular-cli/pull/14473/files
Reloadhttps://github.com/angular/angular-cli/pull/14473/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
mgechevhttps://github.com/mgechev
angular:masterhttps://github.com/angular/angular-cli/tree/master
clydin:forwardref-metadatahttps://github.com/clydin/angular-cli/tree/forwardref-metadata
Conversation 12 https://github.com/angular/angular-cli/pull/14473
Commits 3 https://github.com/angular/angular-cli/pull/14473/commits
Checks 0 https://github.com/angular/angular-cli/pull/14473/checks
Files changed https://github.com/angular/angular-cli/pull/14473/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14473/files
fix(@ngtools/webpack): downlevel constructor parameter type information https://github.com/angular/angular-cli/pull/14473/files#top
Show all changes 3 commits https://github.com/angular/angular-cli/pull/14473/files
7008efa fix(@ngtools/webpack): downlevel constructor parameter type information clydin May 19, 2019 https://github.com/angular/angular-cli/pull/14473/commits/7008efa6dd76f7d09125e3f41f8dcb94c73d6590
203cf78 fix(@schematics/angular): remove `emitDecoratorMetadata` TS option fo… clydin May 21, 2019 https://github.com/angular/angular-cli/pull/14473/commits/203cf783d34f76a2a9bc7ddd7c70e4f29ab204ea
239b216 fix(@schematics/angular): enable tsickle for library compilation clydin May 21, 2019 https://github.com/angular/angular-cli/pull/14473/commits/239b216e1fc90901ba3aa03730c7590d3332a1db
Clear filters https://github.com/angular/angular-cli/pull/14473/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14473/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/14473/files
angular_compiler_plugin.ts https://github.com/angular/angular-cli/pull/14473/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
ctor-parameters.ts https://github.com/angular/angular-cli/pull/14473/files#diff-077bcf8386595f1c2a55200844aef6a5293cae0b151c3d609717fd8da018df76
tsconfig.lib.json.template https://github.com/angular/angular-cli/pull/14473/files#diff-92cf1ea6d2a513a7d5465f91d168b26c4ab5173b85c32a092a4d8f94d2a48769
index.ts https://github.com/angular/angular-cli/pull/14473/files#diff-4d163faca87f95833f62c7302cac5298a1f6ad66bff75e88cc08744673e62f4a
tsconfig.json.template https://github.com/angular/angular-cli/pull/14473/files#diff-14e086880f5e0bfa0793b79f05df0a7a1eddd909581f433a2c7270fb8578e0a6
forwardref-es2105.ts https://github.com/angular/angular-cli/pull/14473/files#diff-da73cf6cb0873ef83633f460061f03dd39be1fccb8619880095e6405281550db
packages/ngtools/webpack/src/angular_compiler_plugin.tshttps://github.com/angular/angular-cli/pull/14473/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
View file https://github.com/clydin/angular-cli/blob/239b216e1fc90901ba3aa03730c7590d3332a1db/packages/ngtools/webpack/src/angular_compiler_plugin.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14473/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/14473/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/14473/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/14473/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/14473/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
packages/ngtools/webpack/src/transformers/ctor-parameters.tshttps://github.com/angular/angular-cli/pull/14473/files#diff-077bcf8386595f1c2a55200844aef6a5293cae0b151c3d609717fd8da018df76
View file https://github.com/clydin/angular-cli/blob/239b216e1fc90901ba3aa03730c7590d3332a1db/packages/ngtools/webpack/src/transformers/ctor-parameters.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/14473/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular-cli/pull/14473/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.