René's URL Explorer Experiment


Title: fix(@angular-devkit/build-angular): remove pure_getters by filipesilva · Pull Request #14187 · angular/angular-cli · GitHub

Open Graph Title: fix(@angular-devkit/build-angular): remove pure_getters by filipesilva · Pull Request #14187 · angular/angular-cli

X Title: fix(@angular-devkit/build-angular): remove pure_getters by filipesilva · Pull Request #14187 · angular/angular-cli

Description: CLI tool for Angular. Contribute to angular/angular-cli development by creating an account on GitHub.

Open Graph Description: When we first started using Build Optimizer, we saw a lot of the savings were tied to using the Uglify/Terser pure_getters option. This was intimately related with the structure and shape of the An...

X Description: When we first started using Build Optimizer, we saw a lot of the savings were tied to using the Uglify/Terser pure_getters option. This was intimately related with the structure and shape of the An...

Opengraph URL: https://github.com/angular/angular-cli/pull/14187

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8c42df6a-50fd-3d15-8a0b-2b6fc78ee1fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF2E:2C4BED:113F3C2:15FA11E:6B01190E
html-safe-nonce1dba639e225c8920725a83eb2a425a6e071aaba827d76e8aaf880edb7e4cd7c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjJFOjJDNEJFRDoxMTNGM0MyOjE1RkExMUU6NkIwMTE5MEUiLCJ2aXNpdG9yX2lkIjoiMzM4NDk1NTk1MzYwNTU4MTA3MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3facca4c7cee0bd7191c655d82cc87db46f528d9381257c97056f956386bb542
hovercard-subject-tagpull_request:270930454
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular-cli/14187/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/57bd93ddc0b6df5ed4df285dda9d40ab57563069076e77464e9cf5d196fa19d5/angular/angular-cli/pull/14187
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/57bd93ddc0b6df5ed4df285dda9d40ab57563069076e77464e9cf5d196fa19d5/angular/angular-cli/pull/14187
og:image:altWhen we first started using Build Optimizer, we saw a lot of the savings were tied to using the Uglify/Terser pure_getters option. This was intimately related with the structure and shape of the An...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefilipesilva
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/14187#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14187
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14187
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/14187
Reloadhttps://github.com/angular/angular-cli/pull/14187
Reloadhttps://github.com/angular/angular-cli/pull/14187
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
alexeaglehttps://github.com/alexeagle
angular:masterhttps://github.com/angular/angular-cli/tree/master
filipesilva:remove-pure-gettershttps://github.com/filipesilva/angular-cli/tree/remove-pure-getters
Conversationhttps://github.com/angular/angular-cli/pull/14187
Commits3 (3)https://github.com/angular/angular-cli/pull/14187/commits
Checkshttps://github.com/angular/angular-cli/pull/14187/checks
Files changedhttps://github.com/angular/angular-cli/pull/14187/files
fix(@angular-devkit/build-angular): remove pure_gettershttps://github.com/angular/angular-cli/pull/14187#top
alexeaglehttps://github.com/alexeagle
angular:masterhttps://github.com/angular/angular-cli/tree/master
filipesilva:remove-pure-gettershttps://github.com/filipesilva/angular-cli/tree/remove-pure-getters
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Apr 16, 2019https://github.com/angular/angular-cli/pull/14187#issue-433805809
Please reload this pagehttps://github.com/angular/angular-cli/pull/14187
#9231https://github.com/angular/angular-cli/issues/9231
#11439https://github.com/angular/angular-cli/issues/11439
#12096https://github.com/angular/angular-cli/issues/12096
#12128https://github.com/angular/angular-cli/issues/12128
Please reload this pagehttps://github.com/angular/angular-cli/pull/14187
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 16, 2019https://github.com/angular/angular-cli/pull/14187#event-2279839130
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
clydinhttps://github.com/clydin
April 16, 2019 14:17https://github.com/angular/angular-cli/pull/14187#event-2279839375
https://github.com/clydin
clydinhttps://github.com/clydin
Apr 16, 2019 https://github.com/angular/angular-cli/pull/14187#pullrequestreview-227226066
View reviewed changes https://github.com/angular/angular-cli/pull/14187/files
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
target: major https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
state: blocked https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Apr 16, 2019https://github.com/angular/angular-cli/pull/14187#event-2279918761
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Apr 16, 2019https://github.com/angular/angular-cli/pull/14187#issuecomment-483721596
angular/angular#29929https://github.com/angular/angular/pull/29929
Please reload this pagehttps://github.com/angular/angular-cli/pull/14187
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
force-pushedhttps://github.com/angular/angular-cli/compare/0f4cf193dad5b7f62faa5ebfda30be15df4a8c4e..04322b3517e609a1d2d43142b5e80419ff5e53d1
0f4cf19https://github.com/angular/angular-cli/commit/0f4cf193dad5b7f62faa5ebfda30be15df4a8c4e
04322b3https://github.com/angular/angular-cli/commit/04322b3517e609a1d2d43142b5e80419ff5e53d1
Compare https://github.com/angular/angular-cli/compare/0f4cf193dad5b7f62faa5ebfda30be15df4a8c4e..04322b3517e609a1d2d43142b5e80419ff5e53d1
April 22, 2019 11:18https://github.com/angular/angular-cli/pull/14187#event-2291078009
filipesilvahttps://github.com/filipesilva
April 24, 2019 10:31https://github.com/angular/angular-cli/pull/14187#commits-pushed-88fc7f6
https://github.com/filipesilva
fix(@angular-devkit/build-angular): remove pure_gettershttps://github.com/angular/angular-cli/pull/14187/commits/88fc7f60f56797f5d25713b95e579d3f08e65f5a
88fc7f6https://github.com/angular/angular-cli/pull/14187/commits/88fc7f60f56797f5d25713b95e579d3f08e65f5a
angular#9231https://github.com/angular/angular-cli/issues/9231
angular#11439https://github.com/angular/angular-cli/issues/11439
angular#12096https://github.com/angular/angular-cli/issues/12096
angular#12128https://github.com/angular/angular-cli/issues/12128
https://github.com/filipesilva
build: update to Angular 8.0.0-beta.14https://github.com/angular/angular-cli/pull/14187/commits/3c4c62bc313003945cdb57bb8464451ffb2251b0
3c4c62bhttps://github.com/angular/angular-cli/pull/14187/commits/3c4c62bc313003945cdb57bb8464451ffb2251b0
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
force-pushedhttps://github.com/angular/angular-cli/compare/04322b3517e609a1d2d43142b5e80419ff5e53d1..e094fa21988f59d948e0ee099af38b00b41eb695
04322b3https://github.com/angular/angular-cli/commit/04322b3517e609a1d2d43142b5e80419ff5e53d1
e094fa2https://github.com/angular/angular-cli/commit/e094fa21988f59d948e0ee099af38b00b41eb695
Compare https://github.com/angular/angular-cli/compare/04322b3517e609a1d2d43142b5e80419ff5e53d1..e094fa21988f59d948e0ee099af38b00b41eb695
April 24, 2019 09:37https://github.com/angular/angular-cli/pull/14187#event-2296595371
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
state: blocked https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Apr 24, 2019https://github.com/angular/angular-cli/pull/14187#event-2296595524
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
force-pushedhttps://github.com/angular/angular-cli/compare/e094fa21988f59d948e0ee099af38b00b41eb695..4e55bf64b8f63634a869d46e1f5d09e842b7e342
e094fa2https://github.com/angular/angular-cli/commit/e094fa21988f59d948e0ee099af38b00b41eb695
4e55bf6https://github.com/angular/angular-cli/commit/4e55bf64b8f63634a869d46e1f5d09e842b7e342
Compare https://github.com/angular/angular-cli/compare/e094fa21988f59d948e0ee099af38b00b41eb695..4e55bf64b8f63634a869d46e1f5d09e842b7e342
April 24, 2019 10:17https://github.com/angular/angular-cli/pull/14187#event-2296708553
https://github.com/clydin
clydinhttps://github.com/clydin
Apr 24, 2019 https://github.com/angular/angular-cli/pull/14187#pullrequestreview-230096874
View reviewed changes https://github.com/angular/angular-cli/pull/14187/files
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.tshttps://github.com/angular/angular-cli/pull/14187/files#diff-a379da5935b1daa3a260482705b7dcbbefa6b1596a277b6d7513fef8eb641ca4
Please reload this pagehttps://github.com/angular/angular-cli/pull/14187
packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.tshttps://github.com/angular/angular-cli/pull/14187/files#diff-a379da5935b1daa3a260482705b7dcbbefa6b1596a277b6d7513fef8eb641ca4
Please reload this pagehttps://github.com/angular/angular-cli/pull/14187
https://github.com/filipesilva
fix(@angular-devkit/build-angular): use known Terser global defshttps://github.com/angular/angular-cli/pull/14187/commits/fe485c402c02c0f890e6889dbcaf45cbe5f54ac3
fe485c4https://github.com/angular/angular-cli/pull/14187/commits/fe485c402c02c0f890e6889dbcaf45cbe5f54ac3
angular/angular#29929https://github.com/angular/angular/pull/29929
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
force-pushedhttps://github.com/angular/angular-cli/compare/4e55bf64b8f63634a869d46e1f5d09e842b7e342..fe485c402c02c0f890e6889dbcaf45cbe5f54ac3
4e55bf6https://github.com/angular/angular-cli/commit/4e55bf64b8f63634a869d46e1f5d09e842b7e342
fe485c4https://github.com/angular/angular-cli/commit/fe485c402c02c0f890e6889dbcaf45cbe5f54ac3
Compare https://github.com/angular/angular-cli/compare/4e55bf64b8f63634a869d46e1f5d09e842b7e342..fe485c402c02c0f890e6889dbcaf45cbe5f54ac3
April 24, 2019 16:24https://github.com/angular/angular-cli/pull/14187#event-2297764738
https://github.com/clydin
clydinhttps://github.com/clydin
Apr 24, 2019 https://github.com/angular/angular-cli/pull/14187#pullrequestreview-230220689
View reviewed changes https://github.com/angular/angular-cli/pull/14187/files/fe485c402c02c0f890e6889dbcaf45cbe5f54ac3
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
eec39a2https://github.com/angular/angular-cli/commit/eec39a20c30e10a6c64b209a490ccd68bb02e0ba
Apr 24, 2019https://github.com/angular/angular-cli/pull/14187#event-2297890827
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
April 24, 2019 17:18https://github.com/angular/angular-cli/pull/14187#event-2297908892
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Apr 26, 2019 https://github.com/angular/angular-cli/pull/14187#ref-issue-357006671
BuildOptimizer breaks 3rd party library #12096 https://github.com/angular/angular-cli/issues/12096
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
May 13, 2019 https://github.com/angular/angular-cli/pull/14187#ref-pullrequest-421476700
Add integration test for side effects, ban top-level property access angular/angular#29329 https://github.com/angular/angular/pull/29329
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
Aug 7, 2019 https://github.com/angular/angular-cli/pull/14187#ref-pullrequest-437776999
Revert "fix(@angular-devkit/build-angular): remove pure_getters" #14287 https://github.com/angular/angular-cli/pull/14287
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular-cli/pull/14187#issuecomment-531067816
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular-cli/pull/14187
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 13, 2019https://github.com/angular/angular-cli/pull/14187#event-2630994415
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F14187
https://github.com/clydin
clydin https://github.com/clydin
https://github.com/angular/angular-cli/pull/14187/files/fe485c402c02c0f890e6889dbcaf45cbe5f54ac3
Please reload this pagehttps://github.com/angular/angular-cli/pull/14187
target: major https://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
1.6.1+ build optimizer breaking bootstrap carousel transition effects https://github.com/angular/angular-cli/issues/9231
Please reload this pagehttps://github.com/angular/angular-cli/pull/14187
https://github.com/filipesilva
https://github.com/clydin
https://github.com/alexeagle
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.