René's URL Explorer Experiment


Title: revert: fix(@ngtools/webpack): emit lazy routes errors on rebuilds by alan-agius4 · Pull Request #13309 · angular/angular-cli · GitHub

Open Graph Title: revert: fix(@ngtools/webpack): emit lazy routes errors on rebuilds by alan-agius4 · Pull Request #13309 · angular/angular-cli

X Title: revert: fix(@ngtools/webpack): emit lazy routes errors on rebuilds by alan-agius4 · Pull Request #13309 · angular/angular-cli

Description: This reverts commit edb84b3 The team has decided to bring back the faster but potentially less accurate method of detecting lazy routes upon JIT rebuilds (first builds will always use the more complete Angular compiler method). Applications that do not have lazy routes within libraries and that only use direct string literals with loadChildren should not be affected by the potential of less accurate detection. Note that the function overload of loadChildren also does not apply to this situation. For those projects where correctness of lazy route detection outweighs rebuild speed, please consider using AOT mode for development. AOT mode will also provide a full set of template errors as well which JIT mode is not capable of doing. Fixes #13102

Open Graph Description: This reverts commit edb84b3 The team has decided to bring back the faster but potentially less accurate method of detecting lazy routes upon JIT rebuilds (first builds will always use the more comp...

X Description: This reverts commit edb84b3 The team has decided to bring back the faster but potentially less accurate method of detecting lazy routes upon JIT rebuilds (first builds will always use the more comp...

Opengraph URL: https://github.com/angular/angular-cli/pull/13309

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4c2a7a17-05ae-7876-c496-75c094a204ce
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8252:2F9718:1221FC7:185384A:6B012820
html-safe-nonced70474e5ca8efd96d4c0f166e735c5f8e59a046efdfdee2ddae95985ad0f77f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjUyOjJGOTcxODoxMjIxRkM3OjE4NTM4NEE6NkIwMTI4MjAiLCJ2aXNpdG9yX2lkIjoiNDY0ODE4NzIxMjEwNDU0MjI0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac47b50bad42b92b2068c35d1d528bfe36ee87eebb759ceeef33cc9eb2f1340b06
hovercard-subject-tagpull_request:241121068
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/13309/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altThis reverts commit edb84b3 The team has decided to bring back the faster but potentially less accurate method of detecting lazy routes upon JIT rebuilds (first builds will always use the more comp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/13309/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F13309%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F13309%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/13309/files
Reloadhttps://github.com/angular/angular-cli/pull/13309/files
Reloadhttps://github.com/angular/angular-cli/pull/13309/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
alexeaglehttps://github.com/alexeagle
angular:masterhttps://github.com/angular/angular-cli/tree/master
Conversation 3 https://github.com/angular/angular-cli/pull/13309
Commits 2 https://github.com/angular/angular-cli/pull/13309/commits
Checks 0 https://github.com/angular/angular-cli/pull/13309/checks
Files changed https://github.com/angular/angular-cli/pull/13309/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/13309/files
revert: fix(@ngtools/webpack): emit lazy routes errors on rebuilds https://github.com/angular/angular-cli/pull/13309/files#top
Show all changes 2 commits https://github.com/angular/angular-cli/pull/13309/files
e20ba14 revert: fix(@ngtools/webpack): emit lazy routes errors on rebuilds Dec 27, 2018 https://github.com/angular/angular-cli/pull/13309/commits/e20ba14da61e52edf388e84a37a852bb659395a5
2b408f2 test: add test for invalid lazy routes in AOT Dec 27, 2018 https://github.com/angular/angular-cli/pull/13309/commits/2b408f245ec8ce9bbff4ab82441d5fcf1b96c5e2
Clear filters https://github.com/angular/angular-cli/pull/13309/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/13309/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/13309/files
lazy-module_spec_large.ts https://github.com/angular/angular-cli/pull/13309/files#diff-ed92cf0249ce1f2607f916933322662c26ec57fcc059a555a09427add9fe296a
rebuild_spec_large.ts https://github.com/angular/angular-cli/pull/13309/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
angular_compiler_plugin.ts https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
lazy_routes.ts https://github.com/angular/angular-cli/pull/13309/files#diff-980e73eee8e91c63285766f0f84b011d0612aea4c2b6b059c6a66b5c73a6d152
export_lazy_module_map.ts https://github.com/angular/angular-cli/pull/13309/files#diff-ffd5781c0b90a2248e20cc648aa852761094adda7a7b2a1e84fd42801b1d116a
packages/angular_devkit/build_angular/test/browser/lazy-module_spec_large.tshttps://github.com/angular/angular-cli/pull/13309/files#diff-ed92cf0249ce1f2607f916933322662c26ec57fcc059a555a09427add9fe296a
View file https://github.com/angular/angular-cli/blob/2b408f245ec8ce9bbff4ab82441d5fcf1b96c5e2/packages/angular_devkit/build_angular/test/browser/lazy-module_spec_large.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/13309/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/13309/files#diff-ed92cf0249ce1f2607f916933322662c26ec57fcc059a555a09427add9fe296a
https://github.com/angular/angular-cli/pull/13309/files#diff-ed92cf0249ce1f2607f916933322662c26ec57fcc059a555a09427add9fe296a
packages/angular_devkit/build_angular/test/browser/rebuild_spec_large.tshttps://github.com/angular/angular-cli/pull/13309/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
View file https://github.com/angular/angular-cli/blob/2b408f245ec8ce9bbff4ab82441d5fcf1b96c5e2/packages/angular_devkit/build_angular/test/browser/rebuild_spec_large.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/13309/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/13309/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
https://github.com/angular/angular-cli/pull/13309/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
packages/ngtools/webpack/src/angular_compiler_plugin.tshttps://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
View file https://github.com/angular/angular-cli/blob/2b408f245ec8ce9bbff4ab82441d5fcf1b96c5e2/packages/ngtools/webpack/src/angular_compiler_plugin.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/13309/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/13309/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
packages/ngtools/webpack/src/lazy_routes.tshttps://github.com/angular/angular-cli/pull/13309/files#diff-980e73eee8e91c63285766f0f84b011d0612aea4c2b6b059c6a66b5c73a6d152
View file https://github.com/angular/angular-cli/blob/2b408f245ec8ce9bbff4ab82441d5fcf1b96c5e2/packages/ngtools/webpack/src/lazy_routes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/13309/{{ revealButtonHref }}
packages/ngtools/webpack/src/transformers/export_lazy_module_map.tshttps://github.com/angular/angular-cli/pull/13309/files#diff-ffd5781c0b90a2248e20cc648aa852761094adda7a7b2a1e84fd42801b1d116a
View file https://github.com/angular/angular-cli/blob/2b408f245ec8ce9bbff4ab82441d5fcf1b96c5e2/packages/ngtools/webpack/src/transformers/export_lazy_module_map.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/13309/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/13309/files#diff-ffd5781c0b90a2248e20cc648aa852761094adda7a7b2a1e84fd42801b1d116a
https://github.com/angular/angular-cli/pull/13309/files#diff-ffd5781c0b90a2248e20cc648aa852761094adda7a7b2a1e84fd42801b1d116a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.