René's URL Explorer Experiment


Title: Stop karma gracefully, test watch mode, and check syntactic diagnostics on rebuilds by filipesilva · Pull Request #12824 · angular/angular-cli · GitHub

Open Graph Title: Stop karma gracefully, test watch mode, and check syntactic diagnostics on rebuilds by filipesilva · Pull Request #12824 · angular/angular-cli

X Title: Stop karma gracefully, test watch mode, and check syntactic diagnostics on rebuilds by filipesilva · Pull Request #12824 · angular/angular-cli

Description: Followup to karma-runner/karma#3153

Open Graph Description: Followup to karma-runner/karma#3153

X Description: Followup to karma-runner/karma#3153

Opengraph URL: https://github.com/angular/angular-cli/pull/12824

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c51df731-a177-05a7-2b81-cc289ea1d4a2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8E8:ADA9D:1695146:1D0B13F:6B01282A
html-safe-noncee4d955fae1d20ead15ef441ca7e58a810c66d9856a3c8000924632265cac3b4b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEU4OkFEQTlEOjE2OTUxNDY6MUQwQjEzRjo2QjAxMjgyQSIsInZpc2l0b3JfaWQiOiIxNDc4MzEyNDI5MjI1MDYwMzk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca18be9dabdc34c5b7bd8aa39007b031a7169b43c6a718c280227fb866cf1acd7
hovercard-subject-tagpull_request:227349475
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular-cli/pull/12824/files
twitter:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4172079?s=400&v=4
og:image:altFollowup to karma-runner/karma#3153
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/pull/12824/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F12824%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fpull%2F12824%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/pull/12824/files
Reloadhttps://github.com/angular/angular-cli/pull/12824/files
Reloadhttps://github.com/angular/angular-cli/pull/12824/files
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular-cli%2Fissues%2Fnew%2Fchoose
alexeaglehttps://github.com/alexeagle
angular:masterhttps://github.com/angular/angular-cli/tree/master
filipesilva:karma-stophttps://github.com/filipesilva/angular-cli/tree/karma-stop
Conversation 9 https://github.com/angular/angular-cli/pull/12824
Commits 5 https://github.com/angular/angular-cli/pull/12824/commits
Checks 0 https://github.com/angular/angular-cli/pull/12824/checks
Files changed https://github.com/angular/angular-cli/pull/12824/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/12824/files
Stop karma gracefully, test watch mode, and check syntactic diagnostics on rebuilds https://github.com/angular/angular-cli/pull/12824/files#top
Show all changes 5 commits https://github.com/angular/angular-cli/pull/12824/files
27d9882 fix(@schematics/angular): update karma version filipesilva Oct 31, 2018 https://github.com/angular/angular-cli/pull/12824/commits/27d98828f21ed44446ce9779e9b4bb32dae7caec
7dd7955 feat(@angular-devkit/build-angular): stop karma gracefully filipesilva Oct 31, 2018 https://github.com/angular/angular-cli/pull/12824/commits/7dd79555503f95690aa9a55b8999ffc2ff638a05
6803b91 feat(@ngtools/webpack): only do type checking on forked type checker filipesilva Oct 31, 2018 https://github.com/angular/angular-cli/pull/12824/commits/6803b91ea5efe31b95141132595dcf6a07d4b774
1774624 test(@angular-devkit/build-angular): remove unneeded flag from test filipesilva Oct 31, 2018 https://github.com/angular/angular-cli/pull/12824/commits/17746246d2eae8decb3995472eb80d0c63518aec
1453b9d test(@angular-devkit/build-angular): test karma on watch mode filipesilva Oct 31, 2018 https://github.com/angular/angular-cli/pull/12824/commits/1453b9dbd293fff895c7a61b0ed1bd04f551f30b
Clear filters https://github.com/angular/angular-cli/pull/12824/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/12824/files
Please reload this pagehttps://github.com/angular/angular-cli/pull/12824/files
package.json https://github.com/angular/angular-cli/pull/12824/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
package.json https://github.com/angular/angular-cli/pull/12824/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f
karma.ts https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
index.ts https://github.com/angular/angular-cli/pull/12824/files#diff-c30dbae42e1787c4374273f63d476119e35d65aa940dba0b39ca6f3dcb33edb3
rebuild_spec_large.ts https://github.com/angular/angular-cli/pull/12824/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
rebuilds_spec_large.ts https://github.com/angular/angular-cli/pull/12824/files#diff-b2d3ef6d3b393c204b4e81b4a03c3eb590ec0f14c646eca2e962697b32f35c6b
angular_compiler_plugin.ts https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
gather_diagnostics.ts https://github.com/angular/angular-cli/pull/12824/files#diff-594982351fd77a4bbb38d7603b76d5faaba7ba1eb7a8313ec9b55db723058f62
type_checker.ts https://github.com/angular/angular-cli/pull/12824/files#diff-2323a17bb6fb06a9cb7b5c762db0a006395382d09bc50886ec3985eac818b2e3
package.json https://github.com/angular/angular-cli/pull/12824/files#diff-a901e2f61e90e66425059f8db28543ce99a1698137d62841367eeaf6f3909d79
yarn.lock https://github.com/angular/angular-cli/pull/12824/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
package.jsonhttps://github.com/angular/angular-cli/pull/12824/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/filipesilva/angular-cli/blob/1453b9dbd293fff895c7a61b0ed1bd04f551f30b/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/12824/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/12824/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angular-cli/pull/12824/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
packages/angular_devkit/build_angular/package.jsonhttps://github.com/angular/angular-cli/pull/12824/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f
View file https://github.com/filipesilva/angular-cli/blob/1453b9dbd293fff895c7a61b0ed1bd04f551f30b/packages/angular_devkit/build_angular/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/12824/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/12824/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f
https://github.com/angular/angular-cli/pull/12824/files#diff-53a0da39e6b029472ba808fdd567f8706e752434fa51be6009f0140532b9fe2f
packages/angular_devkit/build_angular/src/angular-cli-files/plugins/karma.tshttps://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
View file https://github.com/filipesilva/angular-cli/blob/1453b9dbd293fff895c7a61b0ed1bd04f551f30b/packages/angular_devkit/build_angular/src/angular-cli-files/plugins/karma.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/12824/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
https://github.com/angular/angular-cli/pull/12824/files#diff-8b01439af153f54071d400b6a13a156e2a7d3bf42c970c6cba26c23cde3bc9a0
packages/angular_devkit/build_angular/src/karma/index.tshttps://github.com/angular/angular-cli/pull/12824/files#diff-c30dbae42e1787c4374273f63d476119e35d65aa940dba0b39ca6f3dcb33edb3
View file https://github.com/filipesilva/angular-cli/blob/1453b9dbd293fff895c7a61b0ed1bd04f551f30b/packages/angular_devkit/build_angular/src/karma/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/12824/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/12824/files#diff-c30dbae42e1787c4374273f63d476119e35d65aa940dba0b39ca6f3dcb33edb3
https://github.com/angular/angular-cli/pull/12824/files#diff-c30dbae42e1787c4374273f63d476119e35d65aa940dba0b39ca6f3dcb33edb3
alan-agius4https://github.com/alan-agius4
Oct 31, 2018https://github.com/angular/angular-cli/pull/12824/files#r229781474
Please reload this pagehttps://github.com/angular/angular-cli/pull/12824/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/12824/files
filipesilvahttps://github.com/filipesilva
Nov 1, 2018https://github.com/angular/angular-cli/pull/12824/files#r229982968
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular-cli/pull/12824/files
https://github.com/angular/angular-cli/pull/12824/files#diff-c30dbae42e1787c4374273f63d476119e35d65aa940dba0b39ca6f3dcb33edb3
packages/angular_devkit/build_angular/test/browser/rebuild_spec_large.tshttps://github.com/angular/angular-cli/pull/12824/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
View file https://github.com/filipesilva/angular-cli/blob/1453b9dbd293fff895c7a61b0ed1bd04f551f30b/packages/angular_devkit/build_angular/test/browser/rebuild_spec_large.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/12824/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/12824/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
https://github.com/angular/angular-cli/pull/12824/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
https://github.com/angular/angular-cli/pull/12824/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
https://github.com/angular/angular-cli/pull/12824/files#diff-e26c94f6b342ca21eba89d52f33fe1b0f05f68ee7edd8b652644cdf2df615665
packages/angular_devkit/build_angular/test/karma/rebuilds_spec_large.tshttps://github.com/angular/angular-cli/pull/12824/files#diff-b2d3ef6d3b393c204b4e81b4a03c3eb590ec0f14c646eca2e962697b32f35c6b
View file https://github.com/filipesilva/angular-cli/blob/1453b9dbd293fff895c7a61b0ed1bd04f551f30b/packages/angular_devkit/build_angular/test/karma/rebuilds_spec_large.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/12824/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/12824/files#diff-b2d3ef6d3b393c204b4e81b4a03c3eb590ec0f14c646eca2e962697b32f35c6b
packages/ngtools/webpack/src/angular_compiler_plugin.tshttps://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
View file https://github.com/filipesilva/angular-cli/blob/1453b9dbd293fff895c7a61b0ed1bd04f551f30b/packages/ngtools/webpack/src/angular_compiler_plugin.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular-cli/pull/12824/{{ revealButtonHref }}
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
https://github.com/angular/angular-cli/pull/12824/files#diff-e9d36622aeef33c4f2716908fef66473046e62691dcaf22ae0b7966eff25a128
Please reload this pagehttps://github.com/angular/angular-cli/pull/12824/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.