Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #9913 · angular/angular-cli · GitHub
Open Graph Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #9913 · angular/angular-cli
X Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #9913 · angular/angular-cli
Description: Versions node 6.11.5 npm 5.6.0 angular 5.2.8 @ngtools/webpack 1.10.2 Repro steps We have a custom webpack setup that uses @ngtools/webpack . Everything has been working good for us so far, in both JiT and AoT. Right now we are trying to ...
Open Graph Description: Versions node 6.11.5 npm 5.6.0 angular 5.2.8 @ngtools/webpack 1.10.2 Repro steps We have a custom webpack setup that uses @ngtools/webpack . Everything has been working good for us so far, in both ...
X Description: Versions node 6.11.5 npm 5.6.0 angular 5.2.8 @ngtools/webpack 1.10.2 Repro steps We have a custom webpack setup that uses @ngtools/webpack . Everything has been working good for us so far, in both ...
Opengraph URL: https://github.com/angular/angular-cli/issues/9913
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Creating ROUTES with custom factory function ends up with \"Cannot read property 'loadChildren' of undefined\" error","articleBody":"### Versions\r\n```\r\nnode 6.11.5\r\nnpm 5.6.0\r\nangular 5.2.8\r\n@ngtools/webpack 1.10.2\r\n```\r\n\r\n### Repro steps\r\n\r\nWe have a custom webpack setup that uses `@ngtools/webpack` . Everything has been working good for us so far, in both JiT and AoT. Right now we are trying to setup lazy routes. \r\n\r\nWe wanted to implement them using the standard way (`loadChildren: '../features/dashboard/dashboard.module#DashboardFeatureModule'`), but it just didn't work. (We tried and checked everything.) Anyways, it doesn't matter, because loadChildren can accept a function returning a promise with ngModule. So we decided to load the module ourselves.\r\n\r\nExample:\r\n\r\n```ts\r\nimport { NgModule, NgModuleFactory, Compiler } from '@angular/core';\r\nimport { Routes, RouterModule, ROUTES } from '@angular/router';\r\n\r\nexport function MainRoutingLazyRoutesFactory(compiler: Compiler): Routes {\r\n return [\r\n {\r\n path: 'dashboard',\r\n loadChildren: () => {\r\n return \u003cany>System.import('../features/dashboard/dashboard.module')\r\n .then(({ DashboardFeatureModule }) => DashboardFeatureModule)\r\n .then(ngModule => {\r\n if (ngModule instanceof NgModuleFactory) {\r\n return ngModule;\r\n } else {\r\n return compiler.compileModuleAsync(ngModule);\r\n }\r\n });\r\n },\r\n },\r\n ];\r\n}\r\n\r\n@NgModule({\r\n imports: [RouterModule],\r\n exports: [RouterModule],\r\n providers: [\r\n {\r\n provide: ROUTES,\r\n multi: true,\r\n deps: [Compiler],\r\n useFactory: MainRoutingLazyRoutesFactory,\r\n },\r\n ],\r\n})\r\nexport class MainRoutingModule {}\r\n```\r\n\r\n### Observed behavior\r\n\r\nIt fails with the following error during the first compilation in JiT and in any compilation in AoT:\r\n\r\n```\r\nERROR in Cannot read property 'loadChildren' of undefined\r\nwebpack: Failed to compile.\r\n```\r\n\r\n(It leaves no stacktrace).\r\n\r\nIn JiT with webpack-dev-server, if you trigger a recompilation (by changing any file), it compiles correctly since the 2nd compilation and on every following one.\r\n\r\nSeems like angular's compiler has some trouble while trying to parse our factory function. Should it parse it at all? I think we don't need the compiler to parse it all. Do you know any workaround, so we can fix the error, so the compiler parses it correctly or just doesn't try to parse it at all?\r\n\r\n### Desired behavior\r\n\r\nDefining routes with a custom `FactoryProvider` should just work.\r\n\r\nIt lets you to easily implement lazy loaded modules with a custom way.\r\n\r\n---\r\n\r\n### Additional note\r\n\r\nIf we downgrade to angular 5.2.5 and ngtools/webpack 1.10.0, then it behaves in the same way, but the error includes a stacktrace as well:\r\n\r\n```\r\nERROR in TypeError: Cannot read property 'loadChildren' of undefined\r\n at _collectLoadChildren (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:29034:20)\r\n at listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:29009:49)\r\n at AotCompiler.listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:31150:51)\r\n at AngularCompilerProgram.listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler-cli/src/transformers/program.js:156:30)\r\n at AngularCompilerPlugin._listLazyRoutesFromProgram (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:304:38)\r\n at Promise.resolve.then.then (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:583:50)\r\n at process._tickCallback (internal/process/next_tick.js:109:7)\r\nwebpack: Failed to compile.\r\n```","author":{"url":"https://github.com/jtomaszewski","@type":"Person","name":"jtomaszewski"},"datePublished":"2018-03-09T08:05:27Z","url":"https://github.com/angular/angular-cli/issues/9913"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:62f16e18-2ba3-7a6b-aae0-037c443b7221 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9EBC:CC1A4:DC1E0F:118F705:6B0104F5 |
| html-safe-nonce | 24e52d4ac5bba6d62e01690fbcb400ab6ba34f5037763b08f11a5aad40e082d0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUJDOkNDMUE0OkRDMUUwRjoxMThGNzA1OjZCMDEwNEY1IiwidmlzaXRvcl9pZCI6IjU4MDYzNDA5NzkwMTUzNTM1OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | db162e7a436b98a182fe91080596e6b9586c32636278bf23ad3473be052ff057 |
| hovercard-subject-tag | issue:303756475 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/9913/issue_layout |
| twitter:image | https://opengraph.githubassets.com/10700227b3c11b8afbf830b72db469d579f7e8d8d275bad6ebd9836c8dc31e41/angular/angular-cli/issues/9913 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/10700227b3c11b8afbf830b72db469d579f7e8d8d275bad6ebd9836c8dc31e41/angular/angular-cli/issues/9913 |
| og:image:alt | Versions node 6.11.5 npm 5.6.0 angular 5.2.8 @ngtools/webpack 1.10.2 Repro steps We have a custom webpack setup that uses @ngtools/webpack . Everything has been working good for us so far, in both ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jtomaszewski |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width