René's URL Explorer Experiment


Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #9913 · angular/angular-cli · GitHub

Open Graph Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #9913 · angular/angular-cli

X Title: Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" error · Issue #9913 · angular/angular-cli

Description: Versions node 6.11.5 npm 5.6.0 angular 5.2.8 @ngtools/webpack 1.10.2 Repro steps We have a custom webpack setup that uses @ngtools/webpack . Everything has been working good for us so far, in both JiT and AoT. Right now we are trying to ...

Open Graph Description: Versions node 6.11.5 npm 5.6.0 angular 5.2.8 @ngtools/webpack 1.10.2 Repro steps We have a custom webpack setup that uses @ngtools/webpack . Everything has been working good for us so far, in both ...

X Description: Versions node 6.11.5 npm 5.6.0 angular 5.2.8 @ngtools/webpack 1.10.2 Repro steps We have a custom webpack setup that uses @ngtools/webpack . Everything has been working good for us so far, in both ...

Opengraph URL: https://github.com/angular/angular-cli/issues/9913

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Creating ROUTES with custom factory function ends up with \"Cannot read property 'loadChildren' of undefined\" error","articleBody":"### Versions\r\n```\r\nnode 6.11.5\r\nnpm 5.6.0\r\nangular 5.2.8\r\n@ngtools/webpack 1.10.2\r\n```\r\n\r\n### Repro steps\r\n\r\nWe have a custom webpack setup that uses `@ngtools/webpack` . Everything has been working good for us so far, in both JiT and AoT. Right now we are trying to setup lazy routes. \r\n\r\nWe wanted to implement them using the standard way (`loadChildren: '../features/dashboard/dashboard.module#DashboardFeatureModule'`), but it just didn't work. (We tried and checked everything.) Anyways, it doesn't matter, because loadChildren can accept a function returning a promise with ngModule. So we decided to load the module ourselves.\r\n\r\nExample:\r\n\r\n```ts\r\nimport { NgModule, NgModuleFactory, Compiler } from '@angular/core';\r\nimport { Routes, RouterModule, ROUTES } from '@angular/router';\r\n\r\nexport function MainRoutingLazyRoutesFactory(compiler: Compiler): Routes {\r\n  return [\r\n    {\r\n      path: 'dashboard',\r\n      loadChildren: () => {\r\n        return \u003cany>System.import('../features/dashboard/dashboard.module')\r\n          .then(({ DashboardFeatureModule }) => DashboardFeatureModule)\r\n          .then(ngModule => {\r\n            if (ngModule instanceof NgModuleFactory) {\r\n              return ngModule;\r\n            } else {\r\n              return compiler.compileModuleAsync(ngModule);\r\n            }\r\n          });\r\n      },\r\n    },\r\n  ];\r\n}\r\n\r\n@NgModule({\r\n  imports: [RouterModule],\r\n  exports: [RouterModule],\r\n  providers: [\r\n    {\r\n      provide: ROUTES,\r\n      multi: true,\r\n      deps: [Compiler],\r\n      useFactory: MainRoutingLazyRoutesFactory,\r\n    },\r\n  ],\r\n})\r\nexport class MainRoutingModule {}\r\n```\r\n\r\n### Observed behavior\r\n\r\nIt fails with the following error during the first compilation in JiT and in any compilation in AoT:\r\n\r\n```\r\nERROR in Cannot read property 'loadChildren' of undefined\r\nwebpack: Failed to compile.\r\n```\r\n\r\n(It leaves no stacktrace).\r\n\r\nIn JiT with webpack-dev-server, if you trigger a recompilation (by changing any file), it compiles correctly since the 2nd compilation and on every following one.\r\n\r\nSeems like angular's compiler has some trouble while trying to parse our factory function. Should it parse it at all? I think we don't need the compiler to parse it all. Do you know any workaround, so we can fix the error, so the compiler parses it correctly or just doesn't try to parse it at all?\r\n\r\n### Desired behavior\r\n\r\nDefining routes with a custom `FactoryProvider` should just work.\r\n\r\nIt lets you to easily implement lazy loaded modules with a custom way.\r\n\r\n---\r\n\r\n### Additional note\r\n\r\nIf we downgrade to angular 5.2.5 and ngtools/webpack 1.10.0, then it behaves in the same way, but the error includes a stacktrace as well:\r\n\r\n```\r\nERROR in TypeError: Cannot read property 'loadChildren' of undefined\r\n    at _collectLoadChildren (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:29034:20)\r\n    at listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:29009:49)\r\n    at AotCompiler.listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler/bundles/compiler.umd.js:31150:51)\r\n    at AngularCompilerProgram.listLazyRoutes (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@angular/compiler-cli/src/transformers/program.js:156:30)\r\n    at AngularCompilerPlugin._listLazyRoutesFromProgram (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:304:38)\r\n    at Promise.resolve.then.then (/Users/jtomaszewski/src/recruitee/rails/admin_app/node_modules/@ngtools/webpack/src/angular_compiler_plugin.js:583:50)\r\n    at process._tickCallback (internal/process/next_tick.js:109:7)\r\nwebpack: Failed to compile.\r\n```","author":{"url":"https://github.com/jtomaszewski","@type":"Person","name":"jtomaszewski"},"datePublished":"2018-03-09T08:05:27Z","url":"https://github.com/angular/angular-cli/issues/9913"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:62f16e18-2ba3-7a6b-aae0-037c443b7221
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9EBC:CC1A4:DC1E0F:118F705:6B0104F5
html-safe-nonce24e52d4ac5bba6d62e01690fbcb400ab6ba34f5037763b08f11a5aad40e082d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUJDOkNDMUE0OkRDMUUwRjoxMThGNzA1OjZCMDEwNEY1IiwidmlzaXRvcl9pZCI6IjU4MDYzNDA5NzkwMTUzNTM1OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdb162e7a436b98a182fe91080596e6b9586c32636278bf23ad3473be052ff057
hovercard-subject-tagissue:303756475
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/9913/issue_layout
twitter:imagehttps://opengraph.githubassets.com/10700227b3c11b8afbf830b72db469d579f7e8d8d275bad6ebd9836c8dc31e41/angular/angular-cli/issues/9913
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/10700227b3c11b8afbf830b72db469d579f7e8d8d275bad6ebd9836c8dc31e41/angular/angular-cli/issues/9913
og:image:altVersions node 6.11.5 npm 5.6.0 angular 5.2.8 @ngtools/webpack 1.10.2 Repro steps We have a custom webpack setup that uses @ngtools/webpack . Everything has been working good for us so far, in both ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejtomaszewski
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular-cli/issues/9913#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F9913
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F9913
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/issues/9913
Reloadhttps://github.com/angular/angular-cli/issues/9913
Reloadhttps://github.com/angular/angular-cli/issues/9913
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/9913
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/9913
Creating ROUTES with custom factory function ends up with "Cannot read property 'loadChildren' of undefined" errorhttps://github.com/angular/angular-cli/issues/9913#top
https://github.com/jtomaszewski
jtomaszewskihttps://github.com/jtomaszewski
on Mar 9, 2018https://github.com/angular/angular-cli/issues/9913#issue-303756475
https://github.com/jtomaszewski
jtomaszewskihttps://github.com/jtomaszewski
on Mar 9, 2018https://github.com/angular/angular-cli/issues/9913#issuecomment-371745131
this codehttps://github.com/angular/angular/blob/c8a1a14b87e5907458e8e87021e47f9796cb3257/packages/compiler/src/aot/lazy_routes.ts#L28
https://github.com/clydin
clydinhttps://github.com/clydin
on Mar 9, 2018https://github.com/angular/angular-cli/issues/9913#issuecomment-371859744
herehttps://github.com/angular/angular/issues
https://github.com/Brocco
Broccohttps://github.com/Brocco
on Mar 9, 2018https://github.com/angular/angular-cli/issues/9913#issuecomment-371889987
Broccohttps://github.com/Brocco
completedhttps://github.com/angular/angular-cli/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 9, 2018https://github.com/angular/angular-cli/issues/9913#event-1513789417
https://github.com/mjamin
mjaminhttps://github.com/mjamin
on Jul 11, 2018https://github.com/angular/angular-cli/issues/9913#issuecomment-404148935
#9343https://github.com/angular/angular-cli/issues/9343
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 8, 2019https://github.com/angular/angular-cli/issues/9913#issuecomment-529186582
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 8, 2019https://github.com/angular/angular-cli/issues/9913#event-2616660581
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular-cli/issues/9913
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/9913
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.