René's URL Explorer Experiment


Title: Support for Electron and Externals · Issue #4227 · angular/angular-cli · GitHub

Open Graph Title: Support for Electron and Externals · Issue #4227 · angular/angular-cli

X Title: Support for Electron and Externals · Issue #4227 · angular/angular-cli

Description: Please provide us with the following information: OS? All OSes Versions. 1.0.0-beta.26 Repro steps. clone my electron starter project git clone https://github.com/gregvis/angularcli-electron.git cd into it npm i npm start error in consol...

Open Graph Description: Please provide us with the following information: OS? All OSes Versions. 1.0.0-beta.26 Repro steps. clone my electron starter project git clone https://github.com/gregvis/angularcli-electron.git cd...

X Description: Please provide us with the following information: OS? All OSes Versions. 1.0.0-beta.26 Repro steps. clone my electron starter project git clone https://github.com/gregvis/angularcli-electron.git cd...

Opengraph URL: https://github.com/angular/angular-cli/issues/4227

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Support for Electron and Externals","articleBody":"\u003e Please provide us with the following information:\r\n\u003e ---------------------------------------------------------------\r\n\r\n### OS?\r\n\u003e All OSes\r\n\r\n\r\n### Versions.\r\n\u003e1.0.0-beta.26\r\n\r\n\r\n### Repro steps.\r\n\u003e clone my electron starter project\r\n\u003e git clone https://github.com/gregvis/angularcli-electron.git\r\n\u003e cd into it\r\n\u003e npm i\r\n\u003e npm start\r\n\u003e error in console \"Uncaught TypeError: fs.existsSync is not a function\"\r\n\r\n\r\n### The log given by the failure.\r\n\u003e \"Uncaught TypeError: fs.existsSync is not a function\"\r\n\r\n\r\n### Mention any other details that might be useful.\r\n\r\n\u003e In app.component.ts, i have this code:\r\n`import { Component } from '@angular/core';\r\nconst remote = require('electron').remote;\r\n@Component({\r\n  selector: 'app-root',\r\n  templateUrl: './app.component.html',\r\n  styleUrls: ['./app.component.css']\r\n})\r\nexport class AppComponent {\r\n  title = 'app works!';\r\n  constructor() {\r\n    remote.dialog.showOpenDialog({ title: 'Electron Works!' });\r\n  }\r\n}`\r\n\r\nThe remote.dialog.showOpenDialog does a call to a nodejs fs function. In order to fix this, I need the require('electron') to be ignored by webpack. \r\n\r\nThere are 2 ways to do this. In \"webpack-build-common\", \r\n1.\r\n`target: 'electron-renderer'`\r\nThis basically adds a bunch of 'externals' that webpack ignores for packing. You can see the code here:\r\nhttps://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js#L70-L185\r\n\r\nThis does fix the issue, however, there are cases where I would like to be able to add other externals, such as the npm package \"drivelist\" which uses a \"child_process\" to get a list of drives connected to the system. It doesn't work properly if it is bundled by webpack. \r\n\r\nSo in order for me to use both electron AND drivelist, i added the following to \"webpack-build-common\"\r\n\r\n2. \r\n`externals: {\r\n            'electron' : 'commonjs electron',\r\n            'drivelist' : 'commonjs ' + nodeModules + '/drivelist'\r\n        }`\r\n\r\n\r\nSo ideally, I need a way to add target and/or externals to the webpack build. ","author":{"url":"https://github.com/gregvis","@type":"Person","name":"gregvis"},"datePublished":"2017-01-25T16:26:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":22},"url":"https://github.com/4227/angular-cli/issues/4227"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2f56497c-097e-5cff-b929-954630a13458
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id94EE:60C4F:24AF95:323344:698EF098
html-safe-nonce9f47bea9fadc21ed005f22fa071e13af91bb264de2454081ece6bb4abd551a68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEVFOjYwQzRGOjI0QUY5NTozMjMzNDQ6Njk4RUYwOTgiLCJ2aXNpdG9yX2lkIjoiNTI1ODg0NTMzNDU2Njk1NDQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdb3d99d4839901ed78bb3c888ef94745c2dc3c509d40cccef5e20d0137fde234
hovercard-subject-tagissue:203150815
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/4227/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dca15c602ef115b53552cdd2628eff8ce4650fa5fba598b19c8282ac0e8a02b3/angular/angular-cli/issues/4227
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dca15c602ef115b53552cdd2628eff8ce4650fa5fba598b19c8282ac0e8a02b3/angular/angular-cli/issues/4227
og:image:altPlease provide us with the following information: OS? All OSes Versions. 1.0.0-beta.26 Repro steps. clone my electron starter project git clone https://github.com/gregvis/angularcli-electron.git cd...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegregvis
hostnamegithub.com
expected-hostnamegithub.com
None7f7bf82d8907f81525d95af82e60354b419d083df9534c8631d06bb9c0bf07ac
turbo-cache-controlno-preview
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebc36007ff5167349dcfee9a75c7fa7184ab272c4
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular-cli/issues/4227#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F4227
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F4227
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/issues/4227
Reloadhttps://github.com/angular/angular-cli/issues/4227
Reloadhttps://github.com/angular/angular-cli/issues/4227
angular https://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Notifications https://github.com/login?return_to=%2Fangular%2Fangular-cli
Fork 11.9k https://github.com/login?return_to=%2Fangular%2Fangular-cli
Star 27k https://github.com/login?return_to=%2Fangular%2Fangular-cli
Code https://github.com/angular/angular-cli
Issues 259 https://github.com/angular/angular-cli/issues
Pull requests 20 https://github.com/angular/angular-cli/pulls
Actions https://github.com/angular/angular-cli/actions
Security 1 https://github.com/angular/angular-cli/security
Insights https://github.com/angular/angular-cli/pulse
Code https://github.com/angular/angular-cli
Issues https://github.com/angular/angular-cli/issues
Pull requests https://github.com/angular/angular-cli/pulls
Actions https://github.com/angular/angular-cli/actions
Security https://github.com/angular/angular-cli/security
Insights https://github.com/angular/angular-cli/pulse
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/4227
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/4227
Support for Electron and Externalshttps://github.com/angular/angular-cli/issues/4227#top
type: RFC / discussion / questionhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22type%3A%20RFC%20%2F%20discussion%20%2F%20question%22
https://github.com/gregvis
https://github.com/gregvis
gregvishttps://github.com/gregvis
on Jan 25, 2017https://github.com/angular/angular-cli/issues/4227#issue-203150815
https://github.com/gregvis/angularcli-electron.githttps://github.com/gregvis/angularcli-electron.git
https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js#L70-L185https://github.com/webpack/webpack/blob/master/lib/WebpackOptionsApply.js#L70-L185
type: RFC / discussion / questionhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22type%3A%20RFC%20%2F%20discussion%20%2F%20question%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.