René's URL Explorer Experiment


Title: Third party library: google-protobuf eval issue · Issue #4016 · angular/angular-cli · GitHub

Open Graph Title: Third party library: google-protobuf eval issue · Issue #4016 · angular/angular-cli

X Title: Third party library: google-protobuf eval issue · Issue #4016 · angular/angular-cli

Description: I am trying to install google-protobuf, which has two components a) npm package b) generated js files OS? Mac OSX Sierra Versions. angular-cli: 1.0.0-beta.24 node: 6.8.1 os: darwin x64 @angular/common: 2.4.1 @angular/compiler: 2.4.1 @ang...

Open Graph Description: I am trying to install google-protobuf, which has two components a) npm package b) generated js files OS? Mac OSX Sierra Versions. angular-cli: 1.0.0-beta.24 node: 6.8.1 os: darwin x64 @angular/com...

X Description: I am trying to install google-protobuf, which has two components a) npm package b) generated js files OS? Mac OSX Sierra Versions. angular-cli: 1.0.0-beta.24 node: 6.8.1 os: darwin x64 @angular/com...

Opengraph URL: https://github.com/angular/angular-cli/issues/4016

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Third party library: google-protobuf eval issue","articleBody":"I am trying to install google-protobuf, which has two components\r\na) npm package\r\nb) generated js files\r\n\r\n### OS?\r\n> Mac OSX Sierra\r\n\r\n### Versions.\r\n> angular-cli: 1.0.0-beta.24\r\nnode: 6.8.1\r\nos: darwin x64\r\n@angular/common: 2.4.1\r\n@angular/compiler: 2.4.1\r\n@angular/core: 2.4.1\r\n@angular/forms: 2.4.1\r\n@angular/http: 2.4.1\r\n@angular/platform-browser: 2.4.1\r\n@angular/platform-browser-dynamic: 2.4.1\r\n@angular/router: 3.4.1\r\n@angular/compiler-cli: 2.4.1\r\n\r\n### Repro steps.\r\n> per doc:\r\n1) npm install google-protobuf --save\r\n  copied the protoc generated js files in a local folder libraries/protoc\r\n2) added in angular-cli.json:\r\n```\r\n      \"scripts\": [\r\n        \"../node_modules/google-protobuf/google-protobuf.js\",\r\n        \"libraries/protoc/client_pb.js\"\r\n      ],\r\n```\r\n3) in src/typings.d.ts:\r\n```\r\ndeclare module 'google-protobuf';\r\ndeclare module 'client_pb';\r\n```\r\n4) in the service\r\n```\r\nimport * as googleProtobuf from 'google-protobuf';\r\nimport * as p from 'client_pb';\r\n```\r\n\r\n### The log given by the failure.\r\n\r\n> after running **ng build** (no errors),\r\nthe scripts.bundle.js contains\r\n```\r\n/***/ 217:\r\n/***/ function(module, exports) {\r\nmodule.exports = \"var COMPILED=!0,goog=....\"...\r\n```\r\nand\r\n```\r\n/***/ 615:\r\n/***/ function(module, exports) {\r\nmodule.exports = \"/**\\n * @fileoverview\\n * @enhanceable\\n * @public\\n */\\n// GENERATED CODE...\"...\r\n```\r\n\r\n(i.e. code is in quotes) \r\n\r\nwhen running (ng serve), this creates errors like\r\n```\r\nVM739:321Uncaught ReferenceError: exports is not defined\r\n    at eval (eval at module.exports (addScript.js:9), \u003canonymous>:321:471)\r\n    at eval (\u003canonymous>)\r\n    at module.exports (addScript.js:9)\r\n    at Object.161 (google-protobuf.js?a64b:1)\r\n    at __webpack_require__ (bootstrap 44c22f0…:52)\r\n    at Object.720 (scripts.bundle.js:51)\r\n    at __webpack_require__ (bootstrap 44c22f0…:52)\r\n    at webpackJsonpCallback (bootstrap 44c22f0…:23)\r\n    at scripts.bundle.js:1\r\n```\r\n\r\nlooks to me that evaluating the code in the string causes these errors\r\n\r\n### Mention any other details that might be useful.\r\n\r\nWhen using webpack 2.2 directly in a **js** project, it creates code like\r\n```\r\n/* 1 */\r\n/***/ function(module, exports) {\r\nvar COMPILED=!0,goog=...\r\n```\r\nworking fine\r\ni.e. without bundling/eval the code in a string like\r\n\r\n```\r\nmodule.exports = \"...\"\r\n```\r\n\r\nQuestions:\r\n- How do I include the js code directly in scripts.bundle.js  (assume that the eval is the cause of the error)?\r\n- I copied the generated js code (i.e. not npm packaged) in the project and referenced it in the script file (see above) _ Is this the correct/recommended approach?\r\n\r\n","author":{"url":"https://github.com/jorgjanke","@type":"Person","name":"jorgjanke"},"datePublished":"2017-01-15T03:01:32Z","url":"https://github.com/angular/angular-cli/issues/4016"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e0ac821e-f154-bfa2-22ca-70bb3cf6eadf
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB6D4:E9D16:3AC538C:4A7C1E2:6B02333C
html-safe-nonce8b61a91a5bf9cc97334e2210ee91e301997aa0fe2660a0ecffca39400aed8977
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkQ0OkU5RDE2OjNBQzUzOEM6NEE3QzFFMjo2QjAyMzMzQyIsInZpc2l0b3JfaWQiOiI4MDM0NTY2NzA5MzUwMzgwMzQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfe481a443fbecdd55783a6a745cdcc1f01450534d7539910fe38357462894c91
hovercard-subject-tagissue:200844697
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/4016/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9db9a19398a3d59af26fbc64cbffaaa9d6455360ae3b5efe0d47d31a4ebc9e7c/angular/angular-cli/issues/4016
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9db9a19398a3d59af26fbc64cbffaaa9d6455360ae3b5efe0d47d31a4ebc9e7c/angular/angular-cli/issues/4016
og:image:altI am trying to install google-protobuf, which has two components a) npm package b) generated js files OS? Mac OSX Sierra Versions. angular-cli: 1.0.0-beta.24 node: 6.8.1 os: darwin x64 @angular/com...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejorgjanke
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular-cli/issues/4016#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F4016
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F4016
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/issues/4016
Reloadhttps://github.com/angular/angular-cli/issues/4016
Reloadhttps://github.com/angular/angular-cli/issues/4016
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/4016
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/4016
Third party library: google-protobuf eval issuehttps://github.com/angular/angular-cli/issues/4016#top
https://github.com/jorgjanke
jorgjankehttps://github.com/jorgjanke
on Jan 15, 2017https://github.com/angular/angular-cli/issues/4016#issue-200844697
https://github.com/jorgjanke
jorgjankehttps://github.com/jorgjanke
on Jan 15, 2017https://github.com/angular/angular-cli/issues/4016#issuecomment-272670891
https://github.com/filipesilva
filipesilvahttps://github.com/filipesilva
on Jan 24, 2017https://github.com/angular/angular-cli/issues/4016#issuecomment-274859653
#2141https://github.com/angular/angular-cli/issues/2141
#3814https://github.com/angular/angular-cli/pull/3814
filipesilvahttps://github.com/filipesilva
completedhttps://github.com/angular/angular-cli/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 24, 2017https://github.com/angular/angular-cli/issues/4016#event-934792455
https://github.com/larrytin
larrytinhttps://github.com/larrytin
on May 11, 2017https://github.com/angular/angular-cli/issues/4016#issuecomment-300778783
@jorgjankehttps://github.com/jorgjanke
https://github.com/jorgjanke
jorgjankehttps://github.com/jorgjanke
on May 11, 2017https://github.com/angular/angular-cli/issues/4016#issuecomment-300931026
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 7, 2019https://github.com/angular/angular-cli/issues/4016#issuecomment-529068573
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 7, 2019https://github.com/angular/angular-cli/issues/4016#event-2615968094
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular-cli/issues/4016
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/4016
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.