Title: Third party library: google-protobuf eval issue · Issue #4016 · angular/angular-cli · GitHub
Open Graph Title: Third party library: google-protobuf eval issue · Issue #4016 · angular/angular-cli
X Title: Third party library: google-protobuf eval issue · Issue #4016 · angular/angular-cli
Description: I am trying to install google-protobuf, which has two components a) npm package b) generated js files OS? Mac OSX Sierra Versions. angular-cli: 1.0.0-beta.24 node: 6.8.1 os: darwin x64 @angular/common: 2.4.1 @angular/compiler: 2.4.1 @ang...
Open Graph Description: I am trying to install google-protobuf, which has two components a) npm package b) generated js files OS? Mac OSX Sierra Versions. angular-cli: 1.0.0-beta.24 node: 6.8.1 os: darwin x64 @angular/com...
X Description: I am trying to install google-protobuf, which has two components a) npm package b) generated js files OS? Mac OSX Sierra Versions. angular-cli: 1.0.0-beta.24 node: 6.8.1 os: darwin x64 @angular/com...
Opengraph URL: https://github.com/angular/angular-cli/issues/4016
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Third party library: google-protobuf eval issue","articleBody":"I am trying to install google-protobuf, which has two components\r\na) npm package\r\nb) generated js files\r\n\r\n### OS?\r\n> Mac OSX Sierra\r\n\r\n### Versions.\r\n> angular-cli: 1.0.0-beta.24\r\nnode: 6.8.1\r\nos: darwin x64\r\n@angular/common: 2.4.1\r\n@angular/compiler: 2.4.1\r\n@angular/core: 2.4.1\r\n@angular/forms: 2.4.1\r\n@angular/http: 2.4.1\r\n@angular/platform-browser: 2.4.1\r\n@angular/platform-browser-dynamic: 2.4.1\r\n@angular/router: 3.4.1\r\n@angular/compiler-cli: 2.4.1\r\n\r\n### Repro steps.\r\n> per doc:\r\n1) npm install google-protobuf --save\r\n copied the protoc generated js files in a local folder libraries/protoc\r\n2) added in angular-cli.json:\r\n```\r\n \"scripts\": [\r\n \"../node_modules/google-protobuf/google-protobuf.js\",\r\n \"libraries/protoc/client_pb.js\"\r\n ],\r\n```\r\n3) in src/typings.d.ts:\r\n```\r\ndeclare module 'google-protobuf';\r\ndeclare module 'client_pb';\r\n```\r\n4) in the service\r\n```\r\nimport * as googleProtobuf from 'google-protobuf';\r\nimport * as p from 'client_pb';\r\n```\r\n\r\n### The log given by the failure.\r\n\r\n> after running **ng build** (no errors),\r\nthe scripts.bundle.js contains\r\n```\r\n/***/ 217:\r\n/***/ function(module, exports) {\r\nmodule.exports = \"var COMPILED=!0,goog=....\"...\r\n```\r\nand\r\n```\r\n/***/ 615:\r\n/***/ function(module, exports) {\r\nmodule.exports = \"/**\\n * @fileoverview\\n * @enhanceable\\n * @public\\n */\\n// GENERATED CODE...\"...\r\n```\r\n\r\n(i.e. code is in quotes) \r\n\r\nwhen running (ng serve), this creates errors like\r\n```\r\nVM739:321Uncaught ReferenceError: exports is not defined\r\n at eval (eval at module.exports (addScript.js:9), \u003canonymous>:321:471)\r\n at eval (\u003canonymous>)\r\n at module.exports (addScript.js:9)\r\n at Object.161 (google-protobuf.js?a64b:1)\r\n at __webpack_require__ (bootstrap 44c22f0…:52)\r\n at Object.720 (scripts.bundle.js:51)\r\n at __webpack_require__ (bootstrap 44c22f0…:52)\r\n at webpackJsonpCallback (bootstrap 44c22f0…:23)\r\n at scripts.bundle.js:1\r\n```\r\n\r\nlooks to me that evaluating the code in the string causes these errors\r\n\r\n### Mention any other details that might be useful.\r\n\r\nWhen using webpack 2.2 directly in a **js** project, it creates code like\r\n```\r\n/* 1 */\r\n/***/ function(module, exports) {\r\nvar COMPILED=!0,goog=...\r\n```\r\nworking fine\r\ni.e. without bundling/eval the code in a string like\r\n\r\n```\r\nmodule.exports = \"...\"\r\n```\r\n\r\nQuestions:\r\n- How do I include the js code directly in scripts.bundle.js (assume that the eval is the cause of the error)?\r\n- I copied the generated js code (i.e. not npm packaged) in the project and referenced it in the script file (see above) _ Is this the correct/recommended approach?\r\n\r\n","author":{"url":"https://github.com/jorgjanke","@type":"Person","name":"jorgjanke"},"datePublished":"2017-01-15T03:01:32Z","url":"https://github.com/angular/angular-cli/issues/4016"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e0ac821e-f154-bfa2-22ca-70bb3cf6eadf |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B6D4:E9D16:3AC538C:4A7C1E2:6B02333C |
| html-safe-nonce | 8b61a91a5bf9cc97334e2210ee91e301997aa0fe2660a0ecffca39400aed8977 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkQ0OkU5RDE2OjNBQzUzOEM6NEE3QzFFMjo2QjAyMzMzQyIsInZpc2l0b3JfaWQiOiI4MDM0NTY2NzA5MzUwMzgwMzQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fe481a443fbecdd55783a6a745cdcc1f01450534d7539910fe38357462894c91 |
| hovercard-subject-tag | issue:200844697 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/4016/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9db9a19398a3d59af26fbc64cbffaaa9d6455360ae3b5efe0d47d31a4ebc9e7c/angular/angular-cli/issues/4016 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9db9a19398a3d59af26fbc64cbffaaa9d6455360ae3b5efe0d47d31a4ebc9e7c/angular/angular-cli/issues/4016 |
| og:image:alt | I am trying to install google-protobuf, which has two components a) npm package b) generated js files OS? Mac OSX Sierra Versions. angular-cli: 1.0.0-beta.24 node: 6.8.1 os: darwin x64 @angular/com... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jorgjanke |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width