René's URL Explorer Experiment


Title: refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them · Issue #34730 · angular/angular-cli · GitHub

Open Graph Title: refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them · Issue #34730 · angular/angular-cli

X Title: refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them · Issue #34730 · angular/angular-cli

Description: Command e2e, generate Is this a regression? Yes, this behavior used to work in the previous version The previous version in which this bug was not present was No response Description When a spec uses Jasmine's done callback inside an asy...

Open Graph Description: Command e2e, generate Is this a regression? Yes, this behavior used to work in the previous version The previous version in which this bug was not present was No response Description When a spec us...

X Description: Command e2e, generate Is this a regression? Yes, this behavior used to work in the previous version The previous version in which this bug was not present was No response Description When a spec us...

Opengraph URL: https://github.com/angular/angular-cli/issues/34730

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them","articleBody":"### Command\n\ne2e, generate\n\n### Is this a regression?\n\n- [ ] Yes, this behavior used to work in the previous version\n\n### The previous version in which this bug was not present was\n\n_No response_\n\n### Description\n\nWhen a spec uses Jasmine's `done` callback inside an asynchronous callback — `subscribe(...)`,\n`setTimeout(...)`, an event listener — the `refactor-jasmine-vitest` schematic deletes the `done()`\ncall and converts the test to a plain `async` function. The migrated test then resolves immediately,\nbefore the callback ever runs, so it no longer waits for — or asserts anything about — the\nasynchronous work:\n\n```ts\n// before (fails under Jasmine if the observable never emits: done timeout;\n// fails if the assertion inside the callback throws)\nit('emits the loaded data', (done) => {\n  service.getData().subscribe((data) => {\n    expect(data).toEqual(expected);\n    done();\n  });\n});\n\n// after migration (passes unconditionally if the emission is not synchronous)\nit('emits the loaded data', async () => {\n  service.getData().subscribe((data) => {\n    expect(data).toEqual(expected);\n  });\n});\n```\n\nTwo guarantees are lost at once:\n\n1. **The completion guarantee.** In Jasmine, a test whose `done` is never called fails with a\n   timeout. The migrated test passes instantly, so \"the event/emission never happened\" bugs are no\n   longer caught.\n2. **Failure attribution.** If the callback does fire later, an assertion failure inside it throws\n   outside any test. Depending on timing it surfaces as an unattributed unhandled error or not at\n   all (when the run ends first) — instead of failing this test.\n\nThe transformation is correct for `done()` at the top level of the test body and for the explicitly\nhandled promise forms (`.then(done)`, `.then(() => done())`, `.catch(done.fail)`), which are\nrewritten to `await`. The problem is only `done()` inside a nested function that the transformer\ncannot `await`. The existing safety check (`unhandled-done-usage`) does not catch this, because\nremoving the nested `done()` counts as a handled usage.\n\nSince Vitest has no `done` callback, a faithful migration for the nested case would wrap the body in\nan awaited promise whose resolver takes `done`'s place:\n\n```ts\nit('emits the loaded data', () =>\n  new Promise\u003cvoid>((done) => {\n    service.getData().subscribe((data) => {\n      expect(data).toEqual(expected);\n      done();\n    });\n  }));\n```\n\nAlternatively, the schematic could leave the test unchanged with a TODO (like\n`unhandled-done-usage`) whenever `done` is referenced inside a nested function. Happy to send a PR\nfor whichever direction you prefer.\n\n### Minimal Reproduction\n\n1. `ng new repro --defaults && cd repro`\n2. Replace the body of `src/app/app.spec.ts` (or any spec) with a test whose callback never fires:\n\n   ```ts\n   import { Subject } from 'rxjs';\n\n   describe('done in async callback', () => {\n     it('fails when the data never arrives', (done) => {\n       const data$ = new Subject\u003cnumber>();\n       data$.subscribe(() => done());\n       // nothing ever emits — under Jasmine this test fails with a done timeout\n     });\n   });\n   ```\n\n3. Run it with Karma/Jasmine (`ng test` with the Karma builder): the test fails after the timeout —\n   `Async function did not complete within 5000ms`.\n4. `ng generate @schematics/angular:refactor-jasmine-vitest`\n5. The spec becomes `it('fails when the data never arrives', async () => { data$.subscribe(() => {}); });`\n   and `ng test` (Vitest runner) reports it as passing.\n\n### Exception or Error\n\n```text\n\n```\n\n### Your Environment\n\n```text\n_                      _                 ____ _     ___\n    / \\   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|\n   / △ \\ | '_ \\ / _` | | | | |/ _` | '__|   | |   | |    | |\n  / ___ \\| | | | (_| | |_| | | (_| | |      | |___| |___ | |\n /_/   \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_|       \\____|_____|___|\n                |___/\n    \n\nAngular CLI       : 22.3.0-next.5\nNode.js           : 24.15.0\nPackage Manager   : yarn 1.22.22\nOperating System  : darwin arm64\n\n┌──────────────┬───────────────────┬───────────────────┐\n│ Package      │ Installed Version │ Requested Version │\n├──────────────┼───────────────────┼───────────────────┤\n│ @angular/cli │ 22.3.0-next.5     │ ^22.3.0-next.5    │\n```\n\n### Anything else relevant?\n\n- `packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-lifecycle.ts` —\n  `transformDoneCallback`: the body visitor recurses into nested functions and replaces any\n  `done()` statement with an empty statement, then marks the test `async`.\n- The current output is asserted by the first case in\n  `transformers/jasmine-lifecycle_spec.ts` (`setTimeout` with `done()` → `async` with `done()`\n  removed), so I wanted to raise this before proposing a behavior change.\n- Not OS- or browser-specific.","author":{"url":"https://github.com/MeAkib","@type":"Person","name":"MeAkib"},"datePublished":"2026-11-16T15:43:08Z","url":"https://github.com/angular/angular-cli/issues/34730"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:403a05f2-c5b0-b85b-8f12-690d668d8bf4
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8A72:313081:10E96D7:1658EC3:6B01DE4E
html-safe-nonce609d1a420d66d1cdb6680bc741be9aac64a44215e97a1615d3a5a8e0a35c5024
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTcyOjMxMzA4MToxMEU5NkQ3OjE2NThFQzM6NkIwMURFNEUiLCJ2aXNpdG9yX2lkIjoiNjkwMDQ5OTMyOTQ4ODkwMzc1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac94dd453e2956fdeceba309ed1803ee245be52ef3040f03242244bca95c56a9a9
hovercard-subject-tagissue:6424877105
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/34730/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9223eda3176f7aff37b7fcc02e96508bdb0e0ef29218969da1a4258d32cc2a81/angular/angular-cli/issues/34730
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9223eda3176f7aff37b7fcc02e96508bdb0e0ef29218969da1a4258d32cc2a81/angular/angular-cli/issues/34730
og:image:altCommand e2e, generate Is this a regression? Yes, this behavior used to work in the previous version The previous version in which this bug was not present was No response Description When a spec us...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMeAkib
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular-cli/issues/34730#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F34730
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F34730
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/issues/34730
Reloadhttps://github.com/angular/angular-cli/issues/34730
Reloadhttps://github.com/angular/angular-cli/issues/34730
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/34730
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/34730
refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for themhttps://github.com/angular/angular-cli/issues/34730#top
area: @schematics/angularhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40schematics%2Fangular%22
needsTriagehttps://github.com/angular/angular-cli/milestone/11
https://github.com/MeAkib
MeAkibhttps://github.com/MeAkib
on Nov 16, 2026https://github.com/angular/angular-cli/issues/34730#issue-6424877105
angular-robothttps://github.com/apps/angular-robot
area: @schematics/angularhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40schematics%2Fangular%22
on Nov 16, 2026https://github.com/angular/angular-cli/issues/34730#event-36295253972
angular-robothttps://github.com/apps/angular-robot
needsTriagehttps://github.com/angular/angular-cli/milestone/11
on Nov 16, 2026https://github.com/angular/angular-cli/issues/34730#event-36295257352
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular-cli/issues/34730
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/34730
area: @schematics/angularhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40schematics%2Fangular%22
needsTriageNo due datehttps://github.com/angular/angular-cli/milestone/11
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.