Title: refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them · Issue #34730 · angular/angular-cli · GitHub
Open Graph Title: refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them · Issue #34730 · angular/angular-cli
X Title: refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them · Issue #34730 · angular/angular-cli
Description: Command e2e, generate Is this a regression? Yes, this behavior used to work in the previous version The previous version in which this bug was not present was No response Description When a spec uses Jasmine's done callback inside an asy...
Open Graph Description: Command e2e, generate Is this a regression? Yes, this behavior used to work in the previous version The previous version in which this bug was not present was No response Description When a spec us...
X Description: Command e2e, generate Is this a regression? Yes, this behavior used to work in the previous version The previous version in which this bug was not present was No response Description When a spec us...
Opengraph URL: https://github.com/angular/angular-cli/issues/34730
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"refactor-jasmine-vitest removes done() from asynchronous callbacks, so migrated tests no longer wait for them","articleBody":"### Command\n\ne2e, generate\n\n### Is this a regression?\n\n- [ ] Yes, this behavior used to work in the previous version\n\n### The previous version in which this bug was not present was\n\n_No response_\n\n### Description\n\nWhen a spec uses Jasmine's `done` callback inside an asynchronous callback — `subscribe(...)`,\n`setTimeout(...)`, an event listener — the `refactor-jasmine-vitest` schematic deletes the `done()`\ncall and converts the test to a plain `async` function. The migrated test then resolves immediately,\nbefore the callback ever runs, so it no longer waits for — or asserts anything about — the\nasynchronous work:\n\n```ts\n// before (fails under Jasmine if the observable never emits: done timeout;\n// fails if the assertion inside the callback throws)\nit('emits the loaded data', (done) => {\n service.getData().subscribe((data) => {\n expect(data).toEqual(expected);\n done();\n });\n});\n\n// after migration (passes unconditionally if the emission is not synchronous)\nit('emits the loaded data', async () => {\n service.getData().subscribe((data) => {\n expect(data).toEqual(expected);\n });\n});\n```\n\nTwo guarantees are lost at once:\n\n1. **The completion guarantee.** In Jasmine, a test whose `done` is never called fails with a\n timeout. The migrated test passes instantly, so \"the event/emission never happened\" bugs are no\n longer caught.\n2. **Failure attribution.** If the callback does fire later, an assertion failure inside it throws\n outside any test. Depending on timing it surfaces as an unattributed unhandled error or not at\n all (when the run ends first) — instead of failing this test.\n\nThe transformation is correct for `done()` at the top level of the test body and for the explicitly\nhandled promise forms (`.then(done)`, `.then(() => done())`, `.catch(done.fail)`), which are\nrewritten to `await`. The problem is only `done()` inside a nested function that the transformer\ncannot `await`. The existing safety check (`unhandled-done-usage`) does not catch this, because\nremoving the nested `done()` counts as a handled usage.\n\nSince Vitest has no `done` callback, a faithful migration for the nested case would wrap the body in\nan awaited promise whose resolver takes `done`'s place:\n\n```ts\nit('emits the loaded data', () =>\n new Promise\u003cvoid>((done) => {\n service.getData().subscribe((data) => {\n expect(data).toEqual(expected);\n done();\n });\n }));\n```\n\nAlternatively, the schematic could leave the test unchanged with a TODO (like\n`unhandled-done-usage`) whenever `done` is referenced inside a nested function. Happy to send a PR\nfor whichever direction you prefer.\n\n### Minimal Reproduction\n\n1. `ng new repro --defaults && cd repro`\n2. Replace the body of `src/app/app.spec.ts` (or any spec) with a test whose callback never fires:\n\n ```ts\n import { Subject } from 'rxjs';\n\n describe('done in async callback', () => {\n it('fails when the data never arrives', (done) => {\n const data$ = new Subject\u003cnumber>();\n data$.subscribe(() => done());\n // nothing ever emits — under Jasmine this test fails with a done timeout\n });\n });\n ```\n\n3. Run it with Karma/Jasmine (`ng test` with the Karma builder): the test fails after the timeout —\n `Async function did not complete within 5000ms`.\n4. `ng generate @schematics/angular:refactor-jasmine-vitest`\n5. The spec becomes `it('fails when the data never arrives', async () => { data$.subscribe(() => {}); });`\n and `ng test` (Vitest runner) reports it as passing.\n\n### Exception or Error\n\n```text\n\n```\n\n### Your Environment\n\n```text\n_ _ ____ _ ___\n / \\ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|\n / △ \\ | '_ \\ / _` | | | | |/ _` | '__| | | | | | |\n / ___ \\| | | | (_| | |_| | | (_| | | | |___| |___ | |\n /_/ \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_| \\____|_____|___|\n |___/\n \n\nAngular CLI : 22.3.0-next.5\nNode.js : 24.15.0\nPackage Manager : yarn 1.22.22\nOperating System : darwin arm64\n\n┌──────────────┬───────────────────┬───────────────────┐\n│ Package │ Installed Version │ Requested Version │\n├──────────────┼───────────────────┼───────────────────┤\n│ @angular/cli │ 22.3.0-next.5 │ ^22.3.0-next.5 │\n```\n\n### Anything else relevant?\n\n- `packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-lifecycle.ts` —\n `transformDoneCallback`: the body visitor recurses into nested functions and replaces any\n `done()` statement with an empty statement, then marks the test `async`.\n- The current output is asserted by the first case in\n `transformers/jasmine-lifecycle_spec.ts` (`setTimeout` with `done()` → `async` with `done()`\n removed), so I wanted to raise this before proposing a behavior change.\n- Not OS- or browser-specific.","author":{"url":"https://github.com/MeAkib","@type":"Person","name":"MeAkib"},"datePublished":"2026-11-16T15:43:08Z","url":"https://github.com/angular/angular-cli/issues/34730"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:403a05f2-c5b0-b85b-8f12-690d668d8bf4 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8A72:313081:10E96D7:1658EC3:6B01DE4E |
| html-safe-nonce | 609d1a420d66d1cdb6680bc741be9aac64a44215e97a1615d3a5a8e0a35c5024 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTcyOjMxMzA4MToxMEU5NkQ3OjE2NThFQzM6NkIwMURFNEUiLCJ2aXNpdG9yX2lkIjoiNjkwMDQ5OTMyOTQ4ODkwMzc1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 94dd453e2956fdeceba309ed1803ee245be52ef3040f03242244bca95c56a9a9 |
| hovercard-subject-tag | issue:6424877105 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/34730/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9223eda3176f7aff37b7fcc02e96508bdb0e0ef29218969da1a4258d32cc2a81/angular/angular-cli/issues/34730 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9223eda3176f7aff37b7fcc02e96508bdb0e0ef29218969da1a4258d32cc2a81/angular/angular-cli/issues/34730 |
| og:image:alt | Command e2e, generate Is this a regression? Yes, this behavior used to work in the previous version The previous version in which this bug was not present was No response Description When a spec us... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MeAkib |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width