Title: `@angular/build:unit-test` virtual `init-testbed.js` guards `initTestEnvironment()` behind a once-per-worker symbol → stale DomAdapter under vitest ≥4.0.5 + `isolate: false` · Issue #33047 · angular/angular-cli · GitHub
Open Graph Title: `@angular/build:unit-test` virtual `init-testbed.js` guards `initTestEnvironment()` behind a once-per-worker symbol → stale DomAdapter under vitest ≥4.0.5 + `isolate: false` · Issue #33047 · angular/angular-cli
X Title: `@angular/build:unit-test` virtual `init-testbed.js` guards `initTestEnvironment()` behind a once-per-worker symbol → stale DomAdapter under vitest ≥4.0.5 + `isolate: false` · Issue #33047 · angular/angular-cli
Description: This is a follow-up to the now-closed/auto-locked #32754 with the missing details. That issue was dismissed as potentially analog-specific because the reporter had @analogjs/vitest-angular in their deps. This report uses @angular/build:u...
Open Graph Description: This is a follow-up to the now-closed/auto-locked #32754 with the missing details. That issue was dismissed as potentially analog-specific because the reporter had @analogjs/vitest-angular in their...
X Description: This is a follow-up to the now-closed/auto-locked #32754 with the missing details. That issue was dismissed as potentially analog-specific because the reporter had @analogjs/vitest-angular in their...
Opengraph URL: https://github.com/angular/angular-cli/issues/33047
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`@angular/build:unit-test` virtual `init-testbed.js` guards `initTestEnvironment()` behind a once-per-worker symbol → stale DomAdapter under vitest ≥4.0.5 + `isolate: false`","articleBody":"> This is a follow-up to the now-closed/auto-locked [#32754](https://github.com/angular/angular-cli/issues/32754) with the missing details. That issue was dismissed as potentially analog-specific because the reporter had `@analogjs/vitest-angular` in their deps. This report uses **`@angular/build:unit-test` only** and pins the bug to specific lines in `@angular/build`'s own source.\n\n### Which `@angular/*` package(s) are the source of the bug?\n\n`@angular/build`\n\n### Is this a regression?\n\nYes — surfaces with vitest ≥4.0.5 (see vitest-dev/vitest#8944).\n\n### Description\n\n`@angular/build:unit-test`'s vitest runner combines two defaults that interact badly under vitest ≥4.0.5:\n\n- [`plugins.ts:254`](https://github.com/angular/angular-cli/blob/main/packages/angular/build/src/builders/unit-test/runners/vitest/plugins.ts#L254) hardcodes `isolate: false` for the vitest pool (intentional, \"align with the Karma/Jasmine experience\"). Worker module graphs are therefore reused across spec files.\n- [`build-options.ts:73-89`](https://github.com/angular/angular-cli/blob/main/packages/angular/build/src/builders/unit-test/runners/vitest/build-options.ts#L73) — the injected virtual `init-testbed.js` wraps `getTestBed().initTestEnvironment(...)` in an `if (!globalThis[ANGULAR_TESTBED_SETUP])` guard. The comment on line 79 explicitly says *\"the guard condition above ensures that the setup is only performed once\"*. That's the anti-pattern.\n\nThe first spec file in a worker initializes a `platformBrowserTesting` whose `DomAdapter` captures the jsdom `document` as a closure reference. Subsequent spec files in the same worker skip the init block entirely, so the `DomAdapter` keeps being reused. When jsdom's document swaps between spec files — and vitest ≥4.0.5 no longer re-executes setup files between spec files under `isolate: false` (vitest-dev/vitest#8944) — `_getDOM().getDefaultDocument().createElement(tagName)` returns something that is not a real `HTMLElement`, and `DOMTestComponentRenderer.insertRootElement` crashes:\n\n\\`\\`\\`\nTypeError: rootElement.setAttribute is not a function\n at DOMTestComponentRenderer.insertRootElement (@angular/platform-browser/testing)\n at _TestBedImpl.createComponent\n\\`\\`\\`\n\nDifferent spec files fail each run; each failing spec passes in isolation. Classic test-isolation bug.\n\nThe analog project had the analogous pattern in `setupTestBed()` and fixed it in [analogjs/analog#2244](https://github.com/analogjs/analog/pull/2244) by calling `resetTestEnvironment()` + `initTestEnvironment()` on every setup invocation instead of guarding with a once-only singleton.\n\n### Reproduction\n\nI can put up a public minimal repro if helpful, but the bug is visible from the builder source alone — the conditions are:\n\n- Angular 22 (or 21 with vitest ≥4.0.5) monorepo using `@angular/build:unit-test` with jsdom.\n- `runnerConfig` unset, so the builder's default `isolate: false` applies.\n- Suite of ~50+ spec files to make the race frequent.\n- Run `ng test --force` (or equivalent) several times. A different 1–10 specs crash each run with the `setAttribute` trace.\n\nConfirmed environment:\n\n\\`\\`\\`\nAngular CLI: 22.0.0-next.6\n@angular/build: 22.0.0-next.6\n@angular/core: 22.0.0-next.9\nvitest: 4.1.4 (via ^4.0.17)\nEnvironment: jsdom\nRuntime: Node 22 / Bun 1.x\nOS: Windows 11 (also reported on Ubuntu CI via analogjs/analog#2222)\n\\`\\`\\`\n\n### Exception\n\n\\`\\`\\`\nTypeError: rootElement.setAttribute is not a function\n ❯ DOMTestComponentRenderer.insertRootElement node_modules/@angular/platform-browser/fesm2022/testing.mjs:24\n ❯ _TestBedImpl.createComponent packages/core/testing/src/test_bed.ts:420\n\\`\\`\\`\n\n(The #32754 variant `Cannot set base providers because it has already been called` is the same root cause but a different downstream symptom — it fires when the user's own `test-setup.ts` re-calls `initTestEnvironment`. Projects that don't re-call it land on `setAttribute is not a function` instead.)\n\n### Proposed fix\n\n**Primary** — mirror [analogjs/analog#2244](https://github.com/analogjs/analog/pull/2244). Replace the `if (!globalThis[ANGULAR_TESTBED_SETUP])` guard in `build-options.ts:73-89` with a reset-and-reinit pattern:\n\n\\`\\`\\`ts\ngetTestBed().resetTestEnvironment();\ngetTestBed().initTestEnvironment([BrowserTestingModule, TestModule], platformBrowserTesting(), {\n errorOnUnknownElements: true,\n errorOnUnknownProperties: true,\n // ...\n});\n\\`\\`\\`\n\nEven under `isolate: false`, if the setup file re-runs (or a user hook calls it), each spec file gets a fresh platform targeting the current jsdom.\n\n**Secondary (defensive)** — either flip the default to `isolate: true` with a documented opt-out for projects that want the Karma-style speed, or make `DOMTestComponentRenderer.insertRootElement` throw a clearer error when `rootElement.setAttribute` is not callable (e.g. *\"TestBed's DOM adapter is referencing a document that has been torn down — check your vitest \\`isolate\\` setting\"*). Today the `TypeError` has no breadcrumb to the root cause.\n\n**Docs** — the unit-test builder docs should warn that `isolate: false` + vitest ≥4.0.5 + jsdom silently bleeds DOM state across spec files.\n\n### Local workaround\n\nOverride to `isolate: true` via a project-level `vitest-base.config.ts` (possible because `runnerConfig: true` merges user config on top of the builder defaults). 10 consecutive `ng test --force` runs then pass deterministically. Wall-time cost is ~10–30%. This is a workaround, not a fix — the builder's guard is what should change.\n\n### References\n\n- [vitest-dev/vitest#8944](https://github.com/vitest-dev/vitest/issues/8944) — vitest 4.0.5 regression that triggers this class of flake.\n- [angular/angular-cli#32754](https://github.com/angular/angular-cli/issues/32754) — closed/auto-locked predecessor of this report. Same root cause, different surface symptom, closed as \"insufficient information.\"\n- [analogjs/analog#2222](https://github.com/analogjs/analog/issues/2222) — same error stack downstream in analog's vitest-angular stack.\n- [analogjs/analog#2244](https://github.com/analogjs/analog/pull/2244) — reference fix pattern.","author":{"url":"https://github.com/michael-dg","@type":"Person","name":"michael-dg"},"datePublished":"2026-04-24T09:24:33Z","url":"https://github.com/angular/angular-cli/issues/33047"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:60211fd2-50a0-3c3e-6303-69ab0c429bcf |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9510:8AE25:11B0C2B:1775B86:6B01E84B |
| html-safe-nonce | 81437fd0882ed7e7efb67590caffbd601ff814a21912df48398eff8c601275fd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTEwOjhBRTI1OjExQjBDMkI6MTc3NUI4Njo2QjAxRTg0QiIsInZpc2l0b3JfaWQiOiIyNDg2OTI5NTE4MDg2OTczNTE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 522fa93c9455687ec7908e2a12aae814aea241e440b4ce7379ba74f86b7ebd84 |
| hovercard-subject-tag | issue:4321949093 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/33047/issue_layout |
| twitter:image | https://opengraph.githubassets.com/db166c23b2f264a51a0113e2bc8aceb9347fa3785c881f797da8692a6c0db96e/angular/angular-cli/issues/33047 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/db166c23b2f264a51a0113e2bc8aceb9347fa3785c881f797da8692a6c0db96e/angular/angular-cli/issues/33047 |
| og:image:alt | This is a follow-up to the now-closed/auto-locked #32754 with the missing details. That issue was dismissed as potentially analog-specific because the reporter had @analogjs/vitest-angular in their... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | michael-dg |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width