René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Architect#scheduleBuilder or context.scheduleBuilder results in incorrect target on context","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅--\u003e\r\n\r\n\r\n# 🐞 Bug report\r\n\r\n### Command (mark with an `x`)\r\n\u003c!-- Can you pin-point the command or commands that are effected by this bug? --\u003e\r\n\u003c!-- ✍️edit: --\u003e\r\n\r\n- [ ] new\r\n- [ ] build\r\n- [ ] serve\r\n- [ ] test\r\n- [ ] e2e\r\n- [ ] generate\r\n- [ ] add\r\n- [ ] update\r\n- [ ] lint\r\n- [ ] extract-i18n\r\n- [ ] run\r\n- [ ] config\r\n- [ ] help\r\n- [ ] version\r\n- [ ] doc\r\n\r\n\r\n### Is this a regression?\r\n\r\nNot that I know of\r\n\r\n\r\n### Description\r\n\r\nIf a builder is executed via `architect.scheduleBuilder`, that builder is passed a context that doesn't match the declared interface in typescript. The same happens when using `context.scheduleBuilder` if no target is passed via the `scheduleOptions`.\r\n\r\n```js\r\nconsole.log(context.target);\r\n// logs {project: undefined, target: undefined, configuration: undefined}\r\n// but type is {project: string, target: string, configuration?: string} | undefined\r\n```\r\n\r\n## 🔬 Minimal Reproduction\r\n\r\nRun `yarn bazel test //packages/angular_devkit/architect:architect_test` with the following patch:\r\n\r\n```patch\r\ndiff --git a/packages/angular_devkit/architect/src/index_spec.ts b/packages/angular_devkit/architect/src/index_spec.ts\r\nindex 57d76c5a6..bbd59b3fc 100644\r\n--- a/packages/angular_devkit/architect/src/index_spec.ts\r\n+++ b/packages/angular_devkit/architect/src/index_spec.ts\r\n@@ -36,10 +36,12 @@ describe('architect', () =\u003e {\r\n \r\n     options = {};\r\n     called = 0;\r\n-    testArchitectHost.addBuilder('package:test', createBuilder(async o =\u003e {\r\n+    testArchitectHost.addBuilder('package:test', createBuilder(async (o, ctx) =\u003e {\r\n       called++;\r\n       options = o;\r\n \r\n+      expect(ctx.target != null \u0026\u0026 ctx.target.target == null).toBe(false);\r\n+\r\n       return new Promise\u003cBuilderOutput\u003e(resolve =\u003e {\r\n         setTimeout(() =\u003e resolve({ success: true }), 10);\r\n       });\r\n```\r\n\r\n## 🔥 Exception or Error\r\n\r\n\u003cpre\u003e\u003ccode\u003e\r\nFailures:\r\n1) architect runs builders parallel\r\n  Message:\r\n    Expected true to be false.\r\n  Stack:\r\n    Error: Expected true to be false.\r\n        at \u003cJasmine\u003e\r\n        at packages/angular_devkit/architect/src/index_spec.ts:43:63\r\n        at onInput (packages/angular_devkit/architect/src/create-builder.ts:201:20)\r\n        at SafeSubscriber._next (packages/angular_devkit/architect/src/create-builder.ts:87:17)\r\n\u003c/code\u003e\u003c/pre\u003e\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\nMaster branch on this repo\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. --\u003e\r\n\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. --\u003e\r\n","author":{"url":"https://github.com/bgotink","@type":"Person","name":"bgotink"},"datePublished":"2021-01-29T23:58:07.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/19905/angular-cli/issues/19905"}