Title: Remove legacy guessing logic from app-shell · Issue #16353 · angular/angular-cli · GitHub
Open Graph Title: Remove legacy guessing logic from app-shell · Issue #16353 · angular/angular-cli
X Title: Remove legacy guessing logic from app-shell · Issue #16353 · angular/angular-cli
Description: Currently _getServerModuleBundlePath of app-shell/index.ts uses a regular expression to try to find the main bundle file. https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/app-shell/index.ts#L11...
Open Graph Description: Currently _getServerModuleBundlePath of app-shell/index.ts uses a regular expression to try to find the main bundle file. https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/...
X Description: Currently _getServerModuleBundlePath of app-shell/index.ts uses a regular expression to try to find the main bundle file. https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/...
Opengraph URL: https://github.com/angular/angular-cli/issues/16353
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Remove legacy guessing logic from app-shell","articleBody":"Currently `_getServerModuleBundlePath` of `app-shell/index.ts` uses a regular expression to try to find the main bundle file.\r\n\r\nhttps://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/app-shell/index.ts#L111\r\n\r\nThis is unnecessary since the main bundle will always be named main.js\r\n\r\n@alan-agius4 I noticed this issue as a result of your comment that revealed this guessing logic is no longer needed\r\n\r\nhttps://github.com/angular/universal/pull/1357#discussion_r353970284","author":{"url":"https://github.com/wagnermaciel","@type":"Person","name":"wagnermaciel"},"datePublished":"2019-12-04T22:41:44Z","url":"https://github.com/angular/angular-cli/issues/16353"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6940fcf8-297e-2126-5104-131b53fedc2a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CDBE:EDA7A:174B45F:1D9857E:6B013B0E |
| html-safe-nonce | 242dead696cdd3e6e89289099fff338451cf5baff47dd380d4580e355b68a572 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREJFOkVEQTdBOjE3NEI0NUY6MUQ5ODU3RTo2QjAxM0IwRSIsInZpc2l0b3JfaWQiOiI3MTczNjY3NTA4NzM2NTcyMTc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1d6a9dfd58101ea863ea876a82f3f14c90c522ec77bfc211caeecabe4815bfbb |
| hovercard-subject-tag | issue:532980069 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/16353/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7b8aa7e1461a2517e52686553cc2d0492df59faa0326c58f5a5b130d3a33eb9b/angular/angular-cli/issues/16353 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7b8aa7e1461a2517e52686553cc2d0492df59faa0326c58f5a5b130d3a33eb9b/angular/angular-cli/issues/16353 |
| og:image:alt | Currently _getServerModuleBundlePath of app-shell/index.ts uses a regular expression to try to find the main bundle file. https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | wagnermaciel |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width