Title: Provide better story for individual migration results · Issue #16016 · angular/angular-cli · GitHub
Open Graph Title: Provide better story for individual migration results · Issue #16016 · angular/angular-cli
X Title: Provide better story for individual migration results · Issue #16016 · angular/angular-cli
Description: This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/johannesjo/super-productivity and https://github.com/SAP/cloud-commerce-spartacus-storefront. A failed update will show a message saying both the individual mig...
Open Graph Description: This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/johannesjo/super-productivity and https://github.com/SAP/cloud-commerce-spartacus-storefront. A failed update will show ...
X Description: This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/johannesjo/super-productivity and https://github.com/SAP/cloud-commerce-spartacus-storefront. A failed update will show ...
Opengraph URL: https://github.com/angular/angular-cli/issues/16016
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Provide better story for individual migration results","articleBody":"This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/johannesjo/super-productivity and https://github.com/SAP/cloud-commerce-spartacus-storefront.\r\n\r\nA failed update will show a message saying both the individual migration and the update failed:\r\n```\r\n× Package install failed, see above.\r\nThe update failed. See above.\r\ngit HEAD was at 85f08a4d93e684566f751e38e2a2feffe0194cd9 before migrations.\r\n× Migration failed. See above for further details.\r\n```\r\n\r\nThe update below did not finish successfully however, and instead just shows the last migration as successful (@devversion confirms this). In this case the migration shows an error that it seems to suggest was actually recovered from, but it fact the intent is that the migration was interrupted and should later be resumed.\r\n```\r\n\u003e Undecorated classes with DI migration.\r\n As of Angular 9, it is no longer supported to use Angular DI on a class that does not have an Angular decorator.\r\n Read more about this here: https://v9.angular.io/guide/migration-undecorated-classes\r\n \r\n This migration uses the Angular compiler internally and therefore projects that no longer build successfully after the update cannot run the migration. Please ensure there are \r\nno AOT compilation errors and rerun the migration.. The following project failed: projects/storefrontlib/tsconfig.lib.json\r\n \r\n TypeError: Cannot read property 'module' of undefined\r\n \r\n Could not migrate all undecorated classes that use dependency\r\n injection. Some project targets could not be analyzed due to\r\n TypeScript program failures.\r\n\r\n Migration can be rerun with: \"ng update @angular/core --from 8.0.0 --to 9.0.0 --migrate-only\"\r\n\r\n√ Migration succeeded.\r\n```\r\n\r\nA completely successful migration will look the same as the migration above though:\r\n```\r\nkamik@RED-X1C6 MINGW64 /d/sandbox/latest-app (master)\r\n$ ng update @angular/cli @angular/core --next\r\nThe installed Angular CLI version is older than the latest published version.\r\nInstalling a temporary version to perform the update.\r\nInstalling packages for tooling via yarn.\r\nwarning @angular-devkit/architect@0.900.0-rc.0: The engine \"pnpm\" appears to be invalid.\r\nwarning @schematics/angular@9.0.0-rc.0: The engine \"pnpm\" appears to be invalid.\r\nwarning @angular-devkit/schematics@9.0.0-rc.0: The engine \"pnpm\" appears to be invalid.\r\nwarning @angular-devkit/core@9.0.0-rc.0: The engine \"pnpm\" appears to be invalid.\r\nwarning @schematics/update@0.900.0-rc.0: The engine \"pnpm\" appears to be invalid.\r\nwarning @angular/cli@9.0.0-rc.0: The engine \"pnpm\" appears to be invalid.\r\nInstalled packages for tooling via yarn.\r\nUsing package manager: 'yarn'\r\nCollecting installed dependencies...\r\nFound 35 dependencies.\r\nFetching dependency metadata from registry...\r\n Updating package.json with dependency @angular/cli @ \"9.0.0-rc.0\" (was \"8.3.17\")...\r\n Updating package.json with dependency @angular/core @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/language-service @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/compiler-cli @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/animations @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/platform-browser @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/platform-browser-dynamic @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/common @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/compiler @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/forms @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular/router @ \"9.0.0-rc.0\" (was \"8.2.13\")...\r\n Updating package.json with dependency @angular-devkit/build-angular @ \"0.900.0-rc.0\" (was \"0.803.17\")...\r\nUPDATE package.json (1636 bytes)\r\n√ Packages installed successfully.\r\n** Executing migrations of package '@angular/cli' **\r\n\r\n\u003e Update an Angular CLI project to version 9.\r\nUPDATE angular.json (6359 bytes)\r\nUPDATE package.json (1637 bytes)\r\nUPDATE server.ts (1863 bytes)\r\n√ Packages installed successfully.\r\n√ Migration succeeded.\r\n\r\n\u003e Update lazy loading syntax to use dynamic imports.\r\n√ Migration succeeded.\r\n\r\n** Executing migrations of package '@angular/core' **\r\n\r\n\u003e Static flag migration.\r\n Removes the `static` flag from dynamic queries.\r\n As of Angular 9, the \"static\" flag defaults to false and is no longer required for your view and content queries.\r\n Read more about this here: https://v9.angular.io/guide/migration-dynamic-flag\r\n√ Migration succeeded.\r\n\r\n\u003e Missing @Injectable migration.\r\n In Angular 9, enforcement of @Injectable decorators for DI is a bit stricter.\r\n Read more about this here: https://v9.angular.io/guide/migration-injectable\r\n√ Migration succeeded.\r\n\r\n\u003e ModuleWithProviders migration.\r\n In Angular 9, the ModuleWithProviders type without a generic has been deprecated.\r\n This migration adds the generic where it is missing.\r\n Read more about this here: https://v9.angular.io/guide/migration-module-with-providers\r\n√ Migration succeeded.\r\n\r\n\u003e NGCC postinstall migration.\r\n Adds an ngcc invocation to npm/yarn's postinstall script.\r\n Read more about this here: https://v9.angular.io/guide/migration-ngcc\r\nUPDATE package.json (1743 bytes)\r\n√ Packages installed successfully.\r\n√ Migration succeeded.\r\n\r\n\u003e Renderer to Renderer2 migration.\r\n As of Angular 9, the Renderer class is no longer available.\r\n Renderer2 should be used instead.\r\n Read more about this here: https://v9.angular.io/guide/migration-renderer\r\n√ Migration succeeded.\r\n\r\n\u003e Undecorated classes with decorated fields migration.\r\n As of Angular 9, it is no longer supported to have Angular field decorators on a class that does not have an Angular decorator.\r\n Read more about this here: https://v9.angular.io/guide/migration-undecorated-classes\r\n√ Migration succeeded.\r\n\r\n\u003e Undecorated classes with DI migration.\r\n As of Angular 9, it is no longer supported to use Angular DI on a class that does not have an Angular decorator.\r\n Read more about this here: https://v9.angular.io/guide/migration-undecorated-classes\r\n√ Migration succeeded.\r\n```\r\n\r\nWe should confirm the update finished, was successful, or if it was interrupted midway and should later be continued.","author":{"url":"https://github.com/filipesilva","@type":"Person","name":"filipesilva"},"datePublished":"2019-11-01T20:44:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":12},"url":"https://github.com/16016/angular-cli/issues/16016"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6a815390-4c6a-bcde-8009-76950b676f06 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D110:2D3E84:1AE8547:24D8FB0:6964BFCF |
| html-safe-nonce | a3052037f14efaff0bab17cb39af2fdbf18ccf660de88734b744fc8c910788a6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTEwOjJEM0U4NDoxQUU4NTQ3OjI0RDhGQjA6Njk2NEJGQ0YiLCJ2aXNpdG9yX2lkIjoiMjk0MDcwMDI3MzI0MDQ4OTkzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 131684200b0b8bde919288de60eeafae7707c41980e0541c3349365cd14486ed |
| hovercard-subject-tag | issue:516337162 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/16016/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4ac0f3fc3afda3566fc42e8df73e6fbbc6ee98fc7794c4389782d8cc6cbb3455/angular/angular-cli/issues/16016 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4ac0f3fc3afda3566fc42e8df73e6fbbc6ee98fc7794c4389782d8cc6cbb3455/angular/angular-cli/issues/16016 |
| og:image:alt | This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/johannesjo/super-productivity and https://github.com/SAP/cloud-commerce-spartacus-storefront. A failed update will show ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | filipesilva |
| hostname | github.com |
| expected-hostname | github.com |
| None | 21df671ce2c9f1a16940ccbd3af6cb4f3f12a856929ca7eb1b4aea8e384ea442 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5707c685ac172d50a0bdd7533dde4f8aabcf8eef |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width