René's URL Explorer Experiment


Title: 8.3.x ES5 build broken for spread operator on set · Issue #15673 · angular/angular-cli · GitHub

Open Graph Title: 8.3.x ES5 build broken for spread operator on set · Issue #15673 · angular/angular-cli

X Title: 8.3.x ES5 build broken for spread operator on set · Issue #15673 · angular/angular-cli

Description: 🐞 Bug report Command (mark with an x) - [x] build Is this a regression? No, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds were created on their own, everything was ...

Open Graph Description: 🐞 Bug report Command (mark with an x) - [x] build Is this a regression? No, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds we...

X Description: 🐞 Bug report Command (mark with an x) - [x] build Is this a regression? No, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds we...

Opengraph URL: https://github.com/angular/angular-cli/issues/15673

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"8.3.x ES5 build broken for spread operator on set","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 Bug report\r\n\r\n### Command (mark with an `x`)\r\n\u003c!-- Can you pin-point the command or commands that are effected by this bug? -->\r\n\u003c!-- ✍️edit: -->\r\n```\r\n- [x] build\r\n```\r\n\r\n### Is this a regression?\r\nNo, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds were created on their own, everything was fine.\r\n\r\n### Description\r\nSince updating `angular/cli` to 8.3.x it turns our that our ES5 builds are broken - exceptions are thrown during runtime. \r\n\r\nWhat I found out so far: \r\n\r\nES2015 builds are fine. \r\nES5 builds, created with `NG_BUILD_DIFFERENTIAL_FULL=true` are fine.\r\nES5 builds, created without `NG_BUILD_DIFFERENTIAL_FULL=true` are broken.\r\n\r\nIt turns out, that the following line creates `undefined` in es5 builds whereas it creates an array of strings in es2015 builds:\r\n\r\n\u003cpre>\u003ccode>\r\n// Make demand ids in day unique\r\ncardDataByDay[ key ] = [ ...new Set(cardDataByDay[ key ]) ];\r\n\u003c/code>\u003c/pre>\r\n\r\nHappens in any browser in which you load the es5 build. \r\n\r\n## 🔬 Minimal Reproduction / 🔥 Exception or Error\r\n\r\n~~As its quite some effort due to the size to extract it and you maybe already \r\nknow what and where to fix it, I will create a test repo when you really need it. \r\nJust drop a comment in this case.~~\r\n\r\nEdit: You can find the repo here: https://github.com/readme42/repro-angular-cli83-es5-15673\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 8.3.5\r\nNode: 12.6.0\r\nOS: darwin x64\r\nAngular: 8.2.7\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... platform-server, router\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.803.2\r\n@angular-devkit/build-angular     0.803.2\r\n@angular-devkit/build-optimizer   0.803.2\r\n@angular-devkit/build-webpack     0.803.2\r\n@angular-devkit/core              8.3.2\r\n@angular-devkit/schematics        8.3.5\r\n@angular/cdk                      8.2.1\r\n@angular/cli                      8.3.5\r\n@angular/material                 8.2.1\r\n@ngtools/webpack                  8.3.2\r\n@schematics/angular               8.3.5\r\n@schematics/update                0.803.5\r\nrxjs                              6.5.2\r\ntypescript                        3.4.5\r\nwebpack                           4.39.2\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/readme42","@type":"Person","name":"readme42"},"datePublished":"2019-09-25T12:21:13Z","url":"https://github.com/angular/angular-cli/issues/15673"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3d7bd897-4cac-ea2b-a269-2e2466119e62
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA512:4279A:1F28D94:29EC13B:6B0188CF
html-safe-nonce1e6df25a14af7716f5bb9506c2938e22adfc02a9828838cefe1f476ee62b1f60
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTEyOjQyNzlBOjFGMjhEOTQ6MjlFQzEzQjo2QjAxODhDRiIsInZpc2l0b3JfaWQiOiI2MTIzNjE1NDgyMDczMjc0MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4d820403e147e79f9ca54ed2e56324058287ec9b7af961226f1980e355a31052
hovercard-subject-tagissue:498250193
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/15673/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8be87eb8468008f78bc3832be8b8b99e8a7a4a4471441fcc39291799d2d60140/angular/angular-cli/issues/15673
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8be87eb8468008f78bc3832be8b8b99e8a7a4a4471441fcc39291799d2d60140/angular/angular-cli/issues/15673
og:image:alt🐞 Bug report Command (mark with an x) - [x] build Is this a regression? No, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds we...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamereadme42
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular-cli/issues/15673#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F15673
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F15673
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/issues/15673
Reloadhttps://github.com/angular/angular-cli/issues/15673
Reloadhttps://github.com/angular/angular-cli/issues/15673
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/15673
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/15673
#15675https://github.com/angular/angular-cli/pull/15675
8.3.x ES5 build broken for spread operator on sethttps://github.com/angular/angular-cli/issues/15673#top
#15675https://github.com/angular/angular-cli/pull/15675
area: @angular-devkit/build-angularhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40angular-devkit%2Fbuild-angular%22
freq2: mediumhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity5: regressionhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22severity5%3A%20regression%22
type: bug/fixhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular-cli/milestone/12
https://github.com/readme42
readme42https://github.com/readme42
on Sep 25, 2019https://github.com/angular/angular-cli/issues/15673#issue-498250193
https://github.com/readme42/repro-angular-cli83-es5-15673https://github.com/readme42/repro-angular-cli83-es5-15673
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
on Sep 25, 2019https://github.com/angular/angular-cli/issues/15673#issuecomment-535004136
@readme42https://github.com/readme42
alan-agius4https://github.com/alan-agius4
needs: more infoReporter must clarify the issuehttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22needs%3A%20more%20info%22
on Sep 25, 2019https://github.com/angular/angular-cli/issues/15673#event-2661536885
https://github.com/readme42
readme42https://github.com/readme42
on Sep 25, 2019https://github.com/angular/angular-cli/issues/15673#issuecomment-535015737
@alan-agius4https://github.com/alan-agius4
https://github.com/readme42
readme42https://github.com/readme42
on Sep 25, 2019https://github.com/angular/angular-cli/issues/15673#issuecomment-535055202
@alan-agius4https://github.com/alan-agius4
https://github.com/readme42/repro-angular-cli83-es5-15673https://github.com/readme42/repro-angular-cli83-es5-15673
clydinhttps://github.com/clydin
on Sep 25, 2019https://github.com/angular/angular-cli/issues/15673#event-2662654966
fix(@angular-devkit/build-angular): downlevel with non-loose ECMA com…https://github.com/clydin/angular-cli/commit/9586de7a70accf817b0d3cb65d6b2a72705832d0
https://docs.github.com/articles/closing-issues-via-commit-messages
9586de7https://github.com/clydin/angular-cli/commit/9586de7a70accf817b0d3cb65d6b2a72705832d0
clydinhttps://github.com/clydin
severity5: regressionhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22severity5%3A%20regression%22
type: bug/fixhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
freq2: mediumhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
area: @angular-devkit/build-angularhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40angular-devkit%2Fbuild-angular%22
needs: more infoReporter must clarify the issuehttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22needs%3A%20more%20info%22
on Sep 25, 2019https://github.com/angular/angular-cli/issues/15673#event-2662659315
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular-cli/milestone/12
on Sep 25, 2019https://github.com/angular/angular-cli/issues/15673#event-2662661854
clydinhttps://github.com/clydin
on Sep 26, 2019https://github.com/angular/angular-cli/issues/15673#event-2665348333
fix(@angular-devkit/build-angular): downlevel with non-loose ECMA com…https://github.com/clydin/angular-cli/commit/51e4eaa0b8816c7931d004087663552a76eb5052
https://docs.github.com/articles/closing-issues-via-commit-messages
51e4eaahttps://github.com/clydin/angular-cli/commit/51e4eaa0b8816c7931d004087663552a76eb5052
fix(@angular-devkit/build-angular): downlevel with non-loose ECMA com…https://github.com/clydin/angular-cli/commit/28fafbab44d1e7e6d202d2a7511b3f923e7b8ba7
https://docs.github.com/articles/closing-issues-via-commit-messages
28fafbahttps://github.com/clydin/angular-cli/commit/28fafbab44d1e7e6d202d2a7511b3f923e7b8ba7
fix(@angular-devkit/build-angular): downlevel with non-loose ECMA com…https://github.com/clydin/angular-cli/commit/d839aa84073809ea7bd264c987bc08c862bff41c
https://docs.github.com/articles/closing-issues-via-commit-messages
d839aa8https://github.com/clydin/angular-cli/commit/d839aa84073809ea7bd264c987bc08c862bff41c
vikermanhttps://github.com/vikerman
completedhttps://github.com/angular/angular-cli/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#15675https://github.com/angular/angular-cli/pull/15675
on Sep 30, 2019https://github.com/angular/angular-cli/issues/15673#event-2674070495
vikermanhttps://github.com/vikerman
on Sep 30, 2019https://github.com/angular/angular-cli/issues/15673#event-2674070753
fix(@angular-devkit/build-angular): downlevel with non-loose ECMA com…https://github.com/angular/angular-cli/commit/941c6af1ed79d4aac7604773265650142346b099
https://docs.github.com/articles/closing-issues-via-commit-messages
941c6afhttps://github.com/angular/angular-cli/commit/941c6af1ed79d4aac7604773265650142346b099
fix(@angular-devkit/build-angular): downlevel with non-loose ECMA com…https://github.com/angular/angular-cli/commit/f96a58e55a2479f0ff022e2f647712870b79be08
https://docs.github.com/articles/closing-issues-via-commit-messages
f96a58ehttps://github.com/angular/angular-cli/commit/f96a58e55a2479f0ff022e2f647712870b79be08
mheveryhttps://github.com/mhevery
on Oct 10, 2019https://github.com/angular/angular-cli/issues/15673#event-2704172767
build(docs-infra): update @angular/cli to 9.0.0-next.8 (#32980)https://github.com/angular/angular/commit/9abc1f91565738a7752f97e4143b23b5a1f2423c
#32980https://github.com/angular/angular/pull/32980
9abc1f9https://github.com/angular/angular/commit/9abc1f91565738a7752f97e4143b23b5a1f2423c
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 31, 2019https://github.com/angular/angular-cli/issues/15673#issuecomment-548256676
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 31, 2019https://github.com/angular/angular-cli/issues/15673#event-2758786657
mostafaibrhttps://github.com/mostafaibr
on May 29, 2026https://github.com/angular/angular-cli/issues/15673#event-26099595802
fix(@angular-devkit/build-angular): downlevel with non-loose ECMA com…https://github.com/mostafaibr/angular-cli/commit/82a32c9c360713251c02ba8054773d778b0658cb
https://docs.github.com/articles/closing-issues-via-commit-messages
82a32c9https://github.com/mostafaibr/angular-cli/commit/82a32c9c360713251c02ba8054773d778b0658cb
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular-cli/issues/15673
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/15673
area: @angular-devkit/build-angularhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22area%3A%20%40angular-devkit%2Fbuild-angular%22
freq2: mediumhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity5: regressionhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22severity5%3A%20regression%22
type: bug/fixhttps://github.com/angular/angular-cli/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular-cli/milestone/12
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.