Title: 8.3.x ES5 build broken for spread operator on set · Issue #15673 · angular/angular-cli · GitHub
Open Graph Title: 8.3.x ES5 build broken for spread operator on set · Issue #15673 · angular/angular-cli
X Title: 8.3.x ES5 build broken for spread operator on set · Issue #15673 · angular/angular-cli
Description: 🐞 Bug report Command (mark with an x) - [x] build Is this a regression? No, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds were created on their own, everything was ...
Open Graph Description: 🐞 Bug report Command (mark with an x) - [x] build Is this a regression? No, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds we...
X Description: 🐞 Bug report Command (mark with an x) - [x] build Is this a regression? No, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds we...
Opengraph URL: https://github.com/angular/angular-cli/issues/15673
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"8.3.x ES5 build broken for spread operator on set","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 Bug report\r\n\r\n### Command (mark with an `x`)\r\n\u003c!-- Can you pin-point the command or commands that are effected by this bug? -->\r\n\u003c!-- ✍️edit: -->\r\n```\r\n- [x] build\r\n```\r\n\r\n### Is this a regression?\r\nNo, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds were created on their own, everything was fine.\r\n\r\n### Description\r\nSince updating `angular/cli` to 8.3.x it turns our that our ES5 builds are broken - exceptions are thrown during runtime. \r\n\r\nWhat I found out so far: \r\n\r\nES2015 builds are fine. \r\nES5 builds, created with `NG_BUILD_DIFFERENTIAL_FULL=true` are fine.\r\nES5 builds, created without `NG_BUILD_DIFFERENTIAL_FULL=true` are broken.\r\n\r\nIt turns out, that the following line creates `undefined` in es5 builds whereas it creates an array of strings in es2015 builds:\r\n\r\n\u003cpre>\u003ccode>\r\n// Make demand ids in day unique\r\ncardDataByDay[ key ] = [ ...new Set(cardDataByDay[ key ]) ];\r\n\u003c/code>\u003c/pre>\r\n\r\nHappens in any browser in which you load the es5 build. \r\n\r\n## 🔬 Minimal Reproduction / 🔥 Exception or Error\r\n\r\n~~As its quite some effort due to the size to extract it and you maybe already \r\nknow what and where to fix it, I will create a test repo when you really need it. \r\nJust drop a comment in this case.~~\r\n\r\nEdit: You can find the repo here: https://github.com/readme42/repro-angular-cli83-es5-15673\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 8.3.5\r\nNode: 12.6.0\r\nOS: darwin x64\r\nAngular: 8.2.7\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... platform-server, router\r\n\r\nPackage Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect 0.803.2\r\n@angular-devkit/build-angular 0.803.2\r\n@angular-devkit/build-optimizer 0.803.2\r\n@angular-devkit/build-webpack 0.803.2\r\n@angular-devkit/core 8.3.2\r\n@angular-devkit/schematics 8.3.5\r\n@angular/cdk 8.2.1\r\n@angular/cli 8.3.5\r\n@angular/material 8.2.1\r\n@ngtools/webpack 8.3.2\r\n@schematics/angular 8.3.5\r\n@schematics/update 0.803.5\r\nrxjs 6.5.2\r\ntypescript 3.4.5\r\nwebpack 4.39.2\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/readme42","@type":"Person","name":"readme42"},"datePublished":"2019-09-25T12:21:13Z","url":"https://github.com/angular/angular-cli/issues/15673"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3d7bd897-4cac-ea2b-a269-2e2466119e62 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A512:4279A:1F28D94:29EC13B:6B0188CF |
| html-safe-nonce | 1e6df25a14af7716f5bb9506c2938e22adfc02a9828838cefe1f476ee62b1f60 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTEyOjQyNzlBOjFGMjhEOTQ6MjlFQzEzQjo2QjAxODhDRiIsInZpc2l0b3JfaWQiOiI2MTIzNjE1NDgyMDczMjc0MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4d820403e147e79f9ca54ed2e56324058287ec9b7af961226f1980e355a31052 |
| hovercard-subject-tag | issue:498250193 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/15673/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8be87eb8468008f78bc3832be8b8b99e8a7a4a4471441fcc39291799d2d60140/angular/angular-cli/issues/15673 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8be87eb8468008f78bc3832be8b8b99e8a7a4a4471441fcc39291799d2d60140/angular/angular-cli/issues/15673 |
| og:image:alt | 🐞 Bug report Command (mark with an x) - [x] build Is this a regression? No, its broken since the optimized creation of es5 out of es2015 builds were introduced in 8.3. In 8.2.x, when both builds we... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | readme42 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width