Title: App Shell builder fails with Ivy · Issue #15383 · angular/angular-cli · GitHub
Open Graph Title: App Shell builder fails with Ivy · Issue #15383 · angular/angular-cli
X Title: App Shell builder fails with Ivy · Issue #15383 · angular/angular-cli
Description: The builder for App Shell will fail with Ivy as of 9.0.0-next versions of FW/CLI. It's hard to reproduce with a new project but it can be seen when using #15384, running the works (basic) spec in packages/angular_devkit/build_angular/tes...
Open Graph Description: The builder for App Shell will fail with Ivy as of 9.0.0-next versions of FW/CLI. It's hard to reproduce with a new project but it can be seen when using #15384, running the works (basic) spec in p...
X Description: The builder for App Shell will fail with Ivy as of 9.0.0-next versions of FW/CLI. It's hard to reproduce with a new project but it can be seen when using #15384, running the works (basic) spec ...
Opengraph URL: https://github.com/angular/angular-cli/issues/15383
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"App Shell builder fails with Ivy","articleBody":"The builder for App Shell will fail with Ivy as of 9.0.0-next versions of FW/CLI.\r\n\r\nIt's hard to reproduce with a new project but it can be seen when using https://github.com/angular/angular-cli/pull/15384, running the `works (basic)` spec in `packages/angular_devkit/build_angular/test/app-shell/app-shell_spec_large.ts`, and wrapping the `_renderUniversal` inside `packages/angular_devkit/build_angular/src/app-shell/index.ts` in a trycatch, logging the error.\r\n\r\nThe error will be:\r\n```\r\n{ Error: Can't resolve all parameters for ApplicationModule: (?).\r\n at syntaxError (D:\\work\\packages\\compiler\\src\\util.ts:100:17)\r\n at CompileMetadataResolver._getDependenciesMetadata (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:957:27)\r\n at CompileMetadataResolver._getTypeMetadata (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:836:20)\r\n at CompileMetadataResolver.getNgModuleMetadata (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:680:18)\r\n at CompileMetadataResolver.getNgModuleSummary (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:450:31)\r\n at D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:586:44\r\n at Array.forEach (\u003canonymous>)\r\n at CompileMetadataResolver.getNgModuleMetadata (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:569:43)\r\n at CompileMetadataResolver.getNgModuleSummary (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:450:31)\r\n at D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:548:20\r\n at Array.forEach (\u003canonymous>)\r\n at CompileMetadataResolver.getNgModuleMetadata (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:521:43)\r\n at CompileMetadataResolver.getNgModuleSummary (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:450:31)\r\n at D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:548:20\r\n at Array.forEach (\u003canonymous>)\r\n at CompileMetadataResolver.getNgModuleMetadata (D:\\work\\packages\\compiler\\src\\metadata_resolver.ts:521:43)\r\n at JitCompiler._loadModules (D:\\work\\packages\\compiler\\src\\jit\\compiler.ts:127:49)\r\n at JitCompiler._compileModuleAndComponents (D:\\work\\packages\\compiler\\src\\jit\\compiler.ts:107:32)\r\n at JitCompiler.compileModuleAsync (D:\\work\\packages\\compiler\\src\\jit\\compiler.ts:61:33)\r\n at CompilerImpl.compileModuleAsync (D:\\work\\packages\\platform-browser-dynamic\\src\\compiler_factory.ts:58:27)\r\n at compileNgModuleFactory__PRE_R3__ (D:\\work\\packages\\core\\src\\application_ref.ts:50:19)\r\n at PlatformRef.bootstrapModule (D:\\work\\packages\\core\\src\\application_ref.ts:307:12)\r\n at Object.renderModule (D:\\work\\packages\\platform-server\\src\\utils.ts:103:37)\r\n at Promise.resolve.then.then (D:\\work\\cli\\packages\\angular_devkit\\build_angular\\src\\app-shell\\packages\\angular_devkit\\build_angular\\src\\app-shell\\index.ts:66:13)\r\n at ZoneDelegate.invoke (D:\\work\\cli\\node_modules\\zone.js\\dist\\zone-node.js:391:26)\r\n at Zone.run (D:\\work\\cli\\node_modules\\zone.js\\dist\\zone-node.js:150:43)\r\n at D:\\work\\cli\\node_modules\\zone.js\\dist\\zone-node.js:910:34\r\n at ZoneDelegate.invokeTask (D:\\work\\cli\\node_modules\\zone.js\\dist\\zone-node.js:423:31) ngSyntaxError: true }\r\n```\r\n\r\nThe error mentions `compileNgModuleFactory__PRE_R3__`, which makes me think the non-Ivy version FW is being used. This makes sense, because we import `@angular/platform-server` directly from the app shell builder, and thus will always get the default node entry points and not the ngcc compiled ones.","author":{"url":"https://github.com/filipesilva","@type":"Person","name":"filipesilva"},"datePublished":"2019-08-20T16:24:50Z","url":"https://github.com/angular/angular-cli/issues/15383"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1a93eb6b-6d9d-d0b9-2209-f35b82d1f409 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9BFC:2C3566:1C71D5C:257E8E7:6B015267 |
| html-safe-nonce | 9a39c6bd6dac2a415ece4e2fff6cc46ec9853d3f0ae1f6d014915efc00f86907 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkZDOjJDMzU2NjoxQzcxRDVDOjI1N0U4RTc6NkIwMTUyNjciLCJ2aXNpdG9yX2lkIjoiNjczNjcyMzA1NjczNzIxMDk4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7c9c5e2c234d77927b6495279e4be03b4150e893a16002c1e3a5e93e1b8e50d6 |
| hovercard-subject-tag | issue:482960808 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/15383/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e5cca475b44b97f7c6556e9eef449fc3acb5a6adb9e83df47067515f6b9d3e8b/angular/angular-cli/issues/15383 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e5cca475b44b97f7c6556e9eef449fc3acb5a6adb9e83df47067515f6b9d3e8b/angular/angular-cli/issues/15383 |
| og:image:alt | The builder for App Shell will fail with Ivy as of 9.0.0-next versions of FW/CLI. It's hard to reproduce with a new project but it can be seen when using #15384, running the works (basic) spec in p... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | filipesilva |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular-cli git https://github.com/angular/angular-cli.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 36891867 |
| octolytics-dimension-repository_nwo | angular/angular-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 36891867 |
| octolytics-dimension-repository_network_root_nwo | angular/angular-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width