René's URL Explorer Experiment


Title: Build optimizer breaks third party libraries · Issue #12128 · angular/angular-cli · GitHub

Open Graph Title: Build optimizer breaks third party libraries · Issue #12128 · angular/angular-cli

X Title: Build optimizer breaks third party libraries · Issue #12128 · angular/angular-cli

Description: From @yGuy on April 3, 2018 11:56 Bug Report or Feature Request (mark with an x) - [x] bug report -> please search issues before submitting - [ ] feature request Area - [x] devkit - [ ] schematics Versions all Repro steps Scaffold a proj...

Open Graph Description: From @yGuy on April 3, 2018 11:56 Bug Report or Feature Request (mark with an x) - [x] bug report -> please search issues before submitting - [ ] feature request Area - [x] devkit - [ ] schematics ...

X Description: From @yGuy on April 3, 2018 11:56 Bug Report or Feature Request (mark with an x) - [x] bug report -> please search issues before submitting - [ ] feature request Area - [x] devkit - [ ] schemati...

Opengraph URL: https://github.com/angular/angular-cli/issues/12128

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Build optimizer breaks third party libraries","articleBody":"_From @yGuy on April 3, 2018 11:56_\n\n\u003c!--\r\nIF YOU DON'T FILL OUT THE FOLLOWING INFORMATION YOUR ISSUE MIGHT BE CLOSED WITHOUT INVESTIGATING\r\n-->\r\n### Bug Report or Feature Request (mark with an `x`)\r\n```\r\n- [x] bug report -> please search issues before submitting\r\n- [ ] feature request\r\n```\r\n\r\n### Area\r\n```\r\n- [x] devkit\r\n- [ ] schematics\r\n```\r\n\r\n### Versions\r\n\u003c!--\r\nOutput from: `node --version` and `npm --version`.\r\n  Windows (7/8/10). Linux (incl. distribution). macOS (El Capitan? Sierra? High Sierra?)\r\n-->\r\nall\r\n\r\n### Repro steps\r\n - Scaffold a project that uses code (e.g. a third party library) that contains code that cannot be properly \"optimized\" using uglifyjs. E.g. code that uses \"non-pure getters\" like this:\r\n```\r\nlet object = {};\r\nObject.defineProperty(object,\"nonSideEffectFreeGetterBasedMember\", \r\n    {get: function(){ console.log(\"side effect\")}});\r\n\r\n(function () {\r\n  object.nonSideEffectFreeGetterBasedMember;\r\n}());\r\n``` \r\n- Enable the angular build optimizer\r\n- Run the program with the build optimizer enabled and observe that the code does not work as expected anymore, because the non-pure getter has been removed and the side-effect does not happen anymore.\r\n\r\n### The log given by the failure\r\n\u003c!-- Normally this include a stack trace and some more information. -->\r\nn/a\r\n\r\n### Desired functionality\r\n\u003c!--\r\nWhat would like to see implemented?\r\nWhat is the usecase?\r\n-->\r\nIt should be possible to either configure the build optimizer and disable possibly logic-breaking optimizations altogether or at least on a per dependency basis. Especially if the third party library is already optimized/minified/preprocessed the danger of breaking things is higher than the benefits of possibly saving a few more bytes.\r\n\r\n### Mention any other details that might be useful\r\n\u003c!-- Please include a link to the repo if this is related to an OSS project. -->\r\nRight now it is an either/or - either the code runs and you can rely on it, or it may be \"optimized\" but broken in some cases. \r\n\r\nThe tool-chain makes it easy to include all kind of packages from third parties via npm, etc. The \"build-optimizer\" cannot dictate how the code of all of these packages needs to be written in order to work with the \"optimization\" step. It's OK to forbid non-pure getters in the angular code base, but not in *any* third party code. Either add an option to only apply safe code transformations for third party code or make this an opt-in. The binary API right now is not sufficient.\r\n\n\n_Copied from original issue: angular/devkit#612_","author":{"url":"https://github.com/alexeagle","@type":"Person","name":"alexeagle"},"datePublished":"2018-09-04T23:22:01Z","url":"https://github.com/angular/angular-cli/issues/12128"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:28fca511-6991-6967-404f-7c3ce78c5737
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE8A8:20AA01:14514D2:19EC58F:6B011693
html-safe-nonce9fdb1524120fc55f1a7a07a4cab03a40ea2050e7cef3a2b8674829e15407b47a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEE4OjIwQUEwMToxNDUxNEQyOjE5RUM1OEY6NkIwMTE2OTMiLCJ2aXNpdG9yX2lkIjoiODYxOTU3MDkwMzIyNDc1MTc2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4cb70f7851ede66934966c5987c7511a96886cc1f7e222530aad2a30e6091922
hovercard-subject-tagissue:357010814
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular-cli/12128/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ce6c031b990ab2c6c738e9f0a63d590e35dbc9526debdf32a68e968f7dd84044/angular/angular-cli/issues/12128
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ce6c031b990ab2c6c738e9f0a63d590e35dbc9526debdf32a68e968f7dd84044/angular/angular-cli/issues/12128
og:image:altFrom @yGuy on April 3, 2018 11:56 Bug Report or Feature Request (mark with an x) - [x] bug report -> please search issues before submitting - [ ] feature request Area - [x] devkit - [ ] schematics ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealexeagle
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular-cli git https://github.com/angular/angular-cli.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id36891867
octolytics-dimension-repository_nwoangular/angular-cli
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id36891867
octolytics-dimension-repository_network_root_nwoangular/angular-cli
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular-cli/issues/12128#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F12128
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular-cli%2Fissues%2F12128
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular-cli
Reloadhttps://github.com/angular/angular-cli/issues/12128
Reloadhttps://github.com/angular/angular-cli/issues/12128
Reloadhttps://github.com/angular/angular-cli/issues/12128
angularhttps://github.com/angular
angular-clihttps://github.com/angular/angular-cli
Codehttps://github.com/angular/angular-cli
Issues198 (198)https://github.com/angular/angular-cli/issues
Pull requests23 (23)https://github.com/angular/angular-cli/pulls
Actionshttps://github.com/angular/angular-cli/actions
Security and quality8 (8)https://github.com/angular/angular-cli/security
Insightshttps://github.com/angular/angular-cli/insights
https://github.com/angular/angular-cli
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/12128
New issuehttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/12128
Build optimizer breaks third party librarieshttps://github.com/angular/angular-cli/issues/12128#top
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
on Sep 4, 2018https://github.com/angular/angular-cli/issues/12128#issue-357010814
@yGuyhttps://github.com/yGuy
angular/devkit#612https://github.com/angular/devkit/issues/612
https://github.com/alexeagle
alexeaglehttps://github.com/alexeagle
on Sep 4, 2018https://github.com/angular/angular-cli/issues/12128#issuecomment-418548845
@seanbrighthttps://github.com/seanbright
https://github.com/onsip/SIP.jshttps://github.com/onsip/SIP.js
https://github.com/seanbright
seanbrighthttps://github.com/seanbright
on Sep 5, 2018https://github.com/angular/angular-cli/issues/12128#issuecomment-418577655
https://github.com/onsip/SIP.jshttps://github.com/onsip/SIP.js
onsip/SIP.js@9dde443https://github.com/onsip/SIP.js/commit/9dde443d2951252ea6528564cebe16e97fe003b3
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
on Mar 13, 2019https://github.com/angular/angular-cli/issues/12128#issuecomment-472309593
alan-agius4https://github.com/alan-agius4
completedhttps://github.com/angular/angular-cli/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 13, 2019https://github.com/angular/angular-cli/issues/12128#event-2199355982
https://github.com/yGuy
yGuyhttps://github.com/yGuy
on Mar 13, 2019https://github.com/angular/angular-cli/issues/12128#issuecomment-472364448
filipesilvahttps://github.com/filipesilva
on Apr 22, 2019https://github.com/angular/angular-cli/issues/12128#event-2291078016
fix(@angular-devkit/build-angular): remove pure_gettershttps://github.com/filipesilva/angular-cli/commit/04322b3517e609a1d2d43142b5e80419ff5e53d1
04322b3https://github.com/filipesilva/angular-cli/commit/04322b3517e609a1d2d43142b5e80419ff5e53d1
fix(@angular-devkit/build-angular): remove pure_gettershttps://github.com/filipesilva/angular-cli/commit/88fc7f60f56797f5d25713b95e579d3f08e65f5a
88fc7f6https://github.com/filipesilva/angular-cli/commit/88fc7f60f56797f5d25713b95e579d3f08e65f5a
alexeaglehttps://github.com/alexeagle
on Apr 24, 2019https://github.com/angular/angular-cli/issues/12128#event-2297891134
fix(@angular-devkit/build-angular): remove pure_gettershttps://github.com/angular/angular-cli/commit/9a9939fc4eb92f50241bc1e46b6623505a587bc5
9a9939fhttps://github.com/angular/angular-cli/commit/9a9939fc4eb92f50241bc1e46b6623505a587bc5
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 9, 2019https://github.com/angular/angular-cli/issues/12128#issuecomment-529387752
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 9, 2019https://github.com/angular/angular-cli/issues/12128#event-2618041074
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular-cli/issues/12128
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular-cli/issues/12128
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.