René's URL Explorer Experiment


Title: feat(build): check circular depencies in Node.js by marclaval · Pull Request #980 · angular/angular · GitHub

Open Graph Title: feat(build): check circular depencies in Node.js by marclaval · Pull Request #980 · angular/angular

X Title: feat(build): check circular depencies in Node.js by marclaval · Pull Request #980 · angular/angular

Description: Introduces a new step in the build process which checks for circular dependencies to avoid issues in Node, as we saw in #931. In fact, the check is done after removing all import * as ... since they are safe there. It relies on madge in which support of ES6 modules has been added: pahen/madge#53. The travis build is expected to fail here :)

Open Graph Description: Introduces a new step in the build process which checks for circular dependencies to avoid issues in Node, as we saw in #931. In fact, the check is done after removing all import * as ... since the...

X Description: Introduces a new step in the build process which checks for circular dependencies to avoid issues in Node, as we saw in #931. In fact, the check is done after removing all import * as ... since the...

Opengraph URL: https://github.com/angular/angular/pull/980

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2c746bdc-4945-9b4a-167d-2d204e9694fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0A8:2564F:10516FF:1590A77:6B010B05
html-safe-nonce5cdd01dfbdb9b7f2c6961addf9878d5c63e2deee4e057fb11c4e54f106f279d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEE4OjI1NjRGOjEwNTE2RkY6MTU5MEE3Nzo2QjAxMEIwNSIsInZpc2l0b3JfaWQiOiI2NjU3MzMxODUzMjg1OTg1MDI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccd77e5f9f07dc25ace5c59f9107ef98470f5752061569dbb777a56e951691c0a
hovercard-subject-tagpull_request:31297769
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/980/files
twitter:imagehttps://avatars.githubusercontent.com/u/2316643?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2316643?s=400&v=4
og:image:altIntroduces a new step in the build process which checks for circular dependencies to avoid issues in Node, as we saw in #931. In fact, the check is done after removing all import * as ... since the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/980/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F980%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F980%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/980/files
Reloadhttps://github.com/angular/angular/pull/980/files
Reloadhttps://github.com/angular/angular/pull/980/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
marclavalhttps://github.com/marclaval
angular:masterhttps://github.com/angular/angular/tree/master
marclaval:madgehttps://github.com/marclaval/angular/tree/madge
Conversation 4 https://github.com/angular/angular/pull/980
Commits 1 https://github.com/angular/angular/pull/980/commits
Checks 0 https://github.com/angular/angular/pull/980/checks
Files changed https://github.com/angular/angular/pull/980/files
Please reload this pagehttps://github.com/angular/angular/pull/980/files
feat(build): check circular depencies in Node.js https://github.com/angular/angular/pull/980/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/980/files
07852f2 feat(build): check circular depencies in Node.js marclaval Mar 16, 2015 https://github.com/angular/angular/pull/980/commits/07852f22c31ae9f069927eb3dfb836cd90b97f44
Clear filters https://github.com/angular/angular/pull/980/files
Please reload this pagehttps://github.com/angular/angular/pull/980/files
Please reload this pagehttps://github.com/angular/angular/pull/980/files
gulpfile.js https://github.com/angular/angular/pull/980/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
element_binder.js https://github.com/angular/angular/pull/980/files#diff-1390c43d01605b90fefd5b29b3262633bfe811c2477764c8087d2e8115da24f6
compile_element.js https://github.com/angular/angular/pull/980/files#diff-a1d3ea4e94288df990deed5cad302038552da4d1d40554347de76c77cf528e23
compile_step.js https://github.com/angular/angular/pull/980/files#diff-01dc91ae1b6eca93715d1e8ddedb67ac4fdb7c7dda2daaf69179271e6ffa0870
view_container.js https://github.com/angular/angular/pull/980/files#diff-333ae56548743d72be158f7bc2088cdd6e1bb067919a6f8daea10e1509db3b2f
package.json https://github.com/angular/angular/pull/980/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
gulpfile.jshttps://github.com/angular/angular/pull/980/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
View file https://github.com/marclaval/angular/blob/07852f22c31ae9f069927eb3dfb836cd90b97f44/gulpfile.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/980/{{ revealButtonHref }}
https://github.com/angular/angular/pull/980/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/angular/angular/pull/980/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/angular/angular/pull/980/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/angular/angular/pull/980/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
https://github.com/angular/angular/pull/980/files#diff-25789e3ba4c2adf4a68996260eb693a441b4a834c38b76167a120f0b51b969f7
modules/angular2/src/core/compiler/element_binder.jshttps://github.com/angular/angular/pull/980/files#diff-1390c43d01605b90fefd5b29b3262633bfe811c2477764c8087d2e8115da24f6
View file https://github.com/marclaval/angular/blob/07852f22c31ae9f069927eb3dfb836cd90b97f44/modules/angular2/src/core/compiler/element_binder.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/980/{{ revealButtonHref }}
https://github.com/angular/angular/pull/980/files#diff-1390c43d01605b90fefd5b29b3262633bfe811c2477764c8087d2e8115da24f6
https://github.com/angular/angular/pull/980/files#diff-1390c43d01605b90fefd5b29b3262633bfe811c2477764c8087d2e8115da24f6
modules/angular2/src/core/compiler/pipeline/compile_element.jshttps://github.com/angular/angular/pull/980/files#diff-a1d3ea4e94288df990deed5cad302038552da4d1d40554347de76c77cf528e23
View file https://github.com/marclaval/angular/blob/07852f22c31ae9f069927eb3dfb836cd90b97f44/modules/angular2/src/core/compiler/pipeline/compile_element.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/980/{{ revealButtonHref }}
https://github.com/angular/angular/pull/980/files#diff-a1d3ea4e94288df990deed5cad302038552da4d1d40554347de76c77cf528e23
https://github.com/angular/angular/pull/980/files#diff-a1d3ea4e94288df990deed5cad302038552da4d1d40554347de76c77cf528e23
https://github.com/angular/angular/pull/980/files#diff-a1d3ea4e94288df990deed5cad302038552da4d1d40554347de76c77cf528e23
https://github.com/angular/angular/pull/980/files#diff-a1d3ea4e94288df990deed5cad302038552da4d1d40554347de76c77cf528e23
modules/angular2/src/core/compiler/pipeline/compile_step.jshttps://github.com/angular/angular/pull/980/files#diff-01dc91ae1b6eca93715d1e8ddedb67ac4fdb7c7dda2daaf69179271e6ffa0870
View file https://github.com/marclaval/angular/blob/07852f22c31ae9f069927eb3dfb836cd90b97f44/modules/angular2/src/core/compiler/pipeline/compile_step.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/980/{{ revealButtonHref }}
modules/angular2/src/core/compiler/view_container.jshttps://github.com/angular/angular/pull/980/files#diff-333ae56548743d72be158f7bc2088cdd6e1bb067919a6f8daea10e1509db3b2f
View file https://github.com/marclaval/angular/blob/07852f22c31ae9f069927eb3dfb836cd90b97f44/modules/angular2/src/core/compiler/view_container.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/980/{{ revealButtonHref }}
https://github.com/angular/angular/pull/980/files#diff-333ae56548743d72be158f7bc2088cdd6e1bb067919a6f8daea10e1509db3b2f
https://github.com/angular/angular/pull/980/files#diff-333ae56548743d72be158f7bc2088cdd6e1bb067919a6f8daea10e1509db3b2f
https://github.com/angular/angular/pull/980/files#diff-333ae56548743d72be158f7bc2088cdd6e1bb067919a6f8daea10e1509db3b2f
package.jsonhttps://github.com/angular/angular/pull/980/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/marclaval/angular/blob/07852f22c31ae9f069927eb3dfb836cd90b97f44/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/980/{{ revealButtonHref }}
https://github.com/angular/angular/pull/980/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/angular/angular/pull/980/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.