| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f4da9ba6-3901-2004-d246-c3305d2ff533 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 99EE:26ECEB:1067B91:1509BDB:6B010262 |
| html-safe-nonce | b5d32c3606db0499a7b59f1120dd11fa9097d1656d4b926a11d2a5190950e087 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUVFOjI2RUNFQjoxMDY3QjkxOjE1MDlCREI6NkIwMTAyNjIiLCJ2aXNpdG9yX2lkIjoiNTU0NDIwMzc1MzI1MjUyMDU0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0a107a68ed764323c79141963486d7e70b8a0ed278e8b9c68320a3bbbbb23665 |
| hovercard-subject-tag | pull_request:31297769 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/980/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a695e2e6e9f7bb4bdc693f5def1df01b430e30d0850ca38e57d950727f28b6b0/angular/angular/pull/980 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a695e2e6e9f7bb4bdc693f5def1df01b430e30d0850ca38e57d950727f28b6b0/angular/angular/pull/980 |
| og:image:alt | Introduces a new step in the build process which checks for circular dependencies to avoid issues in Node, as we saw in #931.
In fact, the check is done after removing all import * as ... since the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | marclaval |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/980#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F980 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F980 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/980 |
| Reload | https://github.com/angular/angular/pull/980 |
| Reload | https://github.com/angular/angular/pull/980 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| marclaval | https://github.com/marclaval |
| angular:master | https://github.com/angular/angular/tree/master |
| marclaval:madge | https://github.com/marclaval/angular/tree/madge |
| Conversation | https://github.com/angular/angular/pull/980 |
| Commits1 (1) | https://github.com/angular/angular/pull/980/commits |
| Checks | https://github.com/angular/angular/pull/980/checks |
| Files changed | https://github.com/angular/angular/pull/980/files |
| feat(build): check circular depencies in Node.js | https://github.com/angular/angular/pull/980#top |
| marclaval | https://github.com/marclaval |
| angular:master | https://github.com/angular/angular/tree/master |
| marclaval:madge | https://github.com/marclaval/angular/tree/madge |
|
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| Mar 17, 2015 | https://github.com/angular/angular/pull/980#issue-62244366 |
| #931 | https://github.com/angular/angular/pull/931 |
| madge | https://github.com/pahen/madge |
| pahen/madge#53 | https://github.com/pahen/madge/pull/53 |
| Please reload this page | https://github.com/angular/angular/pull/980 |
| https://github.com/naomiblack |
| naomiblack | https://github.com/naomiblack |
|
in progress
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22in%20progress%22 |
| Mar 17, 2015 | https://github.com/angular/angular/pull/980#event-256236366 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 17, 2015 | https://github.com/angular/angular/pull/980#event-256236371 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| force-pushed | https://github.com/angular/angular/compare/7c3e107472484eac739f4f264a9c82d7257c1e59..021ae6733d7ede64c9a7b03accd7ca863d54287e |
| 7c3e107 | https://github.com/angular/angular/commit/7c3e107472484eac739f4f264a9c82d7257c1e59 |
| 021ae67 | https://github.com/angular/angular/commit/021ae6733d7ede64c9a7b03accd7ca863d54287e |
|
Compare
| https://github.com/angular/angular/compare/7c3e107472484eac739f4f264a9c82d7257c1e59..021ae6733d7ede64c9a7b03accd7ca863d54287e |
| March 17, 2015 00:59 | https://github.com/angular/angular/pull/980#event-256251046 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| Mar 17, 2015 | https://github.com/angular/angular/pull/980#issuecomment-82201164 |
| Please reload this page | https://github.com/angular/angular/pull/980 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| force-pushed | https://github.com/angular/angular/compare/021ae6733d7ede64c9a7b03accd7ca863d54287e..ae20c5e84e33e30bbceea766ae12ac7c5a416542 |
| 021ae67 | https://github.com/angular/angular/commit/021ae6733d7ede64c9a7b03accd7ca863d54287e |
| ae20c5e | https://github.com/angular/angular/commit/ae20c5e84e33e30bbceea766ae12ac7c5a416542 |
|
Compare
| https://github.com/angular/angular/compare/021ae6733d7ede64c9a7b03accd7ca863d54287e..ae20c5e84e33e30bbceea766ae12ac7c5a416542 |
| March 17, 2015 08:53 | https://github.com/angular/angular/pull/980#event-256584642 |
|
| https://github.com/marclaval |
| feat(build): check circular depencies in Node.js | https://github.com/angular/angular/pull/980/commits/07852f22c31ae9f069927eb3dfb836cd90b97f44 |
| 07852f2 | https://github.com/angular/angular/pull/980/commits/07852f22c31ae9f069927eb3dfb836cd90b97f44 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| force-pushed | https://github.com/angular/angular/compare/ae20c5e84e33e30bbceea766ae12ac7c5a416542..07852f22c31ae9f069927eb3dfb836cd90b97f44 |
| ae20c5e | https://github.com/angular/angular/commit/ae20c5e84e33e30bbceea766ae12ac7c5a416542 |
| 07852f2 | https://github.com/angular/angular/commit/07852f22c31ae9f069927eb3dfb836cd90b97f44 |
|
Compare
| https://github.com/angular/angular/compare/ae20c5e84e33e30bbceea766ae12ac7c5a416542..07852f22c31ae9f069927eb3dfb836cd90b97f44 |
| March 17, 2015 10:51 | https://github.com/angular/angular/pull/980#event-256699588 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| Mar 17, 2015 | https://github.com/angular/angular/pull/980#event-256700045 |
| https://github.com/vsavkin |
| vsavkin | https://github.com/vsavkin |
|
@lgtm
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%40lgtm |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Mar 18, 2015 | https://github.com/angular/angular/pull/980#event-257546378 |
| https://github.com/vsavkin |
| vsavkin | https://github.com/vsavkin |
| Mar 18, 2015 | https://github.com/angular/angular/pull/980#event-257546400 |
| https://github.com/vsavkin |
| vsavkin | https://github.com/vsavkin |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
@lgtm
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%40lgtm |
| Mar 18, 2015 | https://github.com/angular/angular/pull/980#event-257546980 |
| https://github.com/vsavkin |
| vsavkin | https://github.com/vsavkin |
| Mar 18, 2015 | https://github.com/angular/angular/pull/980#issuecomment-82648714 |
| @Mlaval | https://github.com/Mlaval |
| Please reload this page | https://github.com/angular/angular/pull/980 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
@lgtm
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%40lgtm |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Mar 18, 2015 | https://github.com/angular/angular/pull/980#event-257692047 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| a46af9c | https://github.com/angular/angular/commit/a46af9c41c3a3afdd513bafb4cb2fa68453c2d0d |
| Mar 18, 2015 | https://github.com/angular/angular/pull/980#event-257722375 |
| https://github.com/naomiblack |
| naomiblack | https://github.com/naomiblack |
|
in progress
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22in%20progress%22 |
| Mar 18, 2015 | https://github.com/angular/angular/pull/980#event-257722386 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| Mar 18, 2015 | https://github.com/angular/angular/pull/980#issuecomment-82898011 |
| @vsavkin | https://github.com/vsavkin |
| Please reload this page | https://github.com/angular/angular/pull/980 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
|
Mar 18, 2015
| https://github.com/angular/angular/pull/980#ref-issue-57984214 |
|
Remove all cyclic dependencies
#683
| https://github.com/angular/angular/issues/683 |
| https://github.com/remojansen |
| remojansen | https://github.com/remojansen |
|
Jan 28, 2016
| https://github.com/angular/angular/pull/980#ref-issue-122164234 |
|
Throw a meaningful error for cyclic dependencies
inversify/InversifyJS#28
| https://github.com/inversify/InversifyJS/issues/28 |
| https://github.com/marclaval |
| marclaval | https://github.com/marclaval |
| December 11, 2017 10:13 | https://github.com/angular/angular/pull/980#event-1381104347 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/980#issuecomment-531059743 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/980 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 13, 2019 | https://github.com/angular/angular/pull/980#event-2630938598 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F980 |
| Please reload this page | https://github.com/angular/angular/pull/980 |
|
| https://github.com/vsavkin |
|
vsavkin
| https://github.com/vsavkin |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Please reload this page | https://github.com/angular/angular/pull/980 |
|
| https://github.com/marclaval |
|
| https://github.com/vsavkin |
|
| https://github.com/mhevery |
|
| https://github.com/naomiblack |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |