René's URL Explorer Experiment


Title: refactor: use attributes for directives matching by pkozlowski-opensource · Pull Request #940 · angular/angular · GitHub

Open Graph Title: refactor: use attributes for directives matching by pkozlowski-opensource · Pull Request #940 · angular/angular

X Title: refactor: use attributes for directives matching by pkozlowski-opensource · Pull Request #940 · angular/angular

Description: This refactoring changes the compiler logic so directives and their bindings are matched against attributes instead of matching property bindings. This is based on the following reasoning: attribute and property names are not always equal (ex. in a template we want to write while the corresponding property binding should be readOnly) people want to express directive selectors as targeting normalized attribute name (ex.: for an element like , I want to always express my attribute selector as [read-only])

Open Graph Description: This refactoring changes the compiler logic so directives and their bindings are matched against attributes instead of matching property bindings. This is based on the following reasoning: attribu...

X Description: This refactoring changes the compiler logic so directives and their bindings are matched against attributes instead of matching property bindings. This is based on the following reasoning: attribu...

Opengraph URL: https://github.com/angular/angular/pull/940

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8e4e114f-102c-e448-92da-ae019f58ffae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE5A:2564D8:E16AA5:12AEB10:6B00FE87
html-safe-nonce9024b37140fcfb4c0583cb8da0ef1325ad4a7cef74ce035f0b66ec687ea8835d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTVBOjI1NjREODpFMTZBQTU6MTJBRUIxMDo2QjAwRkU4NyIsInZpc2l0b3JfaWQiOiI1ODE1MDA2OTM4ODIzNDU4NDM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca8aa87532d6a9ce5a621a5f5f7170cedde3d445c5cc0aadb45ea4e0276bb095a
hovercard-subject-tagpull_request:31032211
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/940/files
twitter:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
og:image:altThis refactoring changes the compiler logic so directives and their bindings are matched against attributes instead of matching property bindings. This is based on the following reasoning: attribu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/940/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F940%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F940%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/940/files
Reloadhttps://github.com/angular/angular/pull/940/files
Reloadhttps://github.com/angular/angular/pull/940/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:match_by_attrshttps://github.com/pkozlowski-opensource/angular/tree/match_by_attrs
Conversation 6 https://github.com/angular/angular/pull/940
Commits 2 https://github.com/angular/angular/pull/940/commits
Checks 0 https://github.com/angular/angular/pull/940/checks
Files changed https://github.com/angular/angular/pull/940/files
Please reload this pagehttps://github.com/angular/angular/pull/940/files
refactor: use attributes for directives matching https://github.com/angular/angular/pull/940/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/940/files
84a1d2f refactor: return copy of DOM attributes in Dart pkozlowski-opensource Mar 12, 2015 https://github.com/angular/angular/pull/940/commits/84a1d2facddcc0e5ac99580aff78fd08ea5e27d3
90e56b6 refactor: use attributes for directives matching pkozlowski-opensource Mar 12, 2015 https://github.com/angular/angular/pull/940/commits/90e56b6e726ae61a06679bf74185df16ba5a71d9
Clear filters https://github.com/angular/angular/pull/940/files
Please reload this pagehttps://github.com/angular/angular/pull/940/files
Please reload this pagehttps://github.com/angular/angular/pull/940/files
directive_parser.js https://github.com/angular/angular/pull/940/files#diff-6838350991f9a5f3b59f0151e8e1ce6e246fc15a7ecb3203ff718ae16f8bae87
property_binding_parser.js https://github.com/angular/angular/pull/940/files#diff-503824a56a1c5e393dd2460cd51dbd4bf07ce045ba91abaaf7482bced22b11a9
view_splitter.js https://github.com/angular/angular/pull/940/files#diff-e1156efd666d62782bae43c0bffd6abb29021fb21d104c4c2d6083cdc72997a6
browser_adapter.dart https://github.com/angular/angular/pull/940/files#diff-fc7a4f96774889d8845a5c70e56e43af44876e37754affaaca543495a61b9ea4
integration_spec.js https://github.com/angular/angular/pull/940/files#diff-cc1f53e7bcdc7ee865e5b57f429fc232bc4b73e84d3d6b649eecf45c98d840c3
directive_parser_spec.js https://github.com/angular/angular/pull/940/files#diff-31210f1f869f68e1778ff730d26d696ea0adb5b3e8a4dc7809c3dada86f051a3
modules/angular2/src/core/compiler/pipeline/directive_parser.jshttps://github.com/angular/angular/pull/940/files#diff-6838350991f9a5f3b59f0151e8e1ce6e246fc15a7ecb3203ff718ae16f8bae87
View file https://github.com/pkozlowski-opensource/angular/blob/90e56b6e726ae61a06679bf74185df16ba5a71d9/modules/angular2/src/core/compiler/pipeline/directive_parser.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/940/{{ revealButtonHref }}
https://github.com/angular/angular/pull/940/files#diff-6838350991f9a5f3b59f0151e8e1ce6e246fc15a7ecb3203ff718ae16f8bae87
https://github.com/angular/angular/pull/940/files#diff-6838350991f9a5f3b59f0151e8e1ce6e246fc15a7ecb3203ff718ae16f8bae87
https://github.com/angular/angular/pull/940/files#diff-6838350991f9a5f3b59f0151e8e1ce6e246fc15a7ecb3203ff718ae16f8bae87
https://github.com/angular/angular/pull/940/files#diff-6838350991f9a5f3b59f0151e8e1ce6e246fc15a7ecb3203ff718ae16f8bae87
https://github.com/angular/angular/pull/940/files#diff-6838350991f9a5f3b59f0151e8e1ce6e246fc15a7ecb3203ff718ae16f8bae87
https://github.com/angular/angular/pull/940/files#diff-6838350991f9a5f3b59f0151e8e1ce6e246fc15a7ecb3203ff718ae16f8bae87
modules/angular2/src/core/compiler/pipeline/property_binding_parser.jshttps://github.com/angular/angular/pull/940/files#diff-503824a56a1c5e393dd2460cd51dbd4bf07ce045ba91abaaf7482bced22b11a9
View file https://github.com/pkozlowski-opensource/angular/blob/90e56b6e726ae61a06679bf74185df16ba5a71d9/modules/angular2/src/core/compiler/pipeline/property_binding_parser.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/940/{{ revealButtonHref }}
https://github.com/angular/angular/pull/940/files#diff-503824a56a1c5e393dd2460cd51dbd4bf07ce045ba91abaaf7482bced22b11a9
https://github.com/angular/angular/pull/940/files#diff-503824a56a1c5e393dd2460cd51dbd4bf07ce045ba91abaaf7482bced22b11a9
https://github.com/angular/angular/pull/940/files#diff-503824a56a1c5e393dd2460cd51dbd4bf07ce045ba91abaaf7482bced22b11a9
modules/angular2/src/core/compiler/pipeline/view_splitter.jshttps://github.com/angular/angular/pull/940/files#diff-e1156efd666d62782bae43c0bffd6abb29021fb21d104c4c2d6083cdc72997a6
View file https://github.com/pkozlowski-opensource/angular/blob/90e56b6e726ae61a06679bf74185df16ba5a71d9/modules/angular2/src/core/compiler/pipeline/view_splitter.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/940/{{ revealButtonHref }}
https://github.com/angular/angular/pull/940/files#diff-e1156efd666d62782bae43c0bffd6abb29021fb21d104c4c2d6083cdc72997a6
https://github.com/angular/angular/pull/940/files#diff-e1156efd666d62782bae43c0bffd6abb29021fb21d104c4c2d6083cdc72997a6
modules/angular2/src/dom/browser_adapter.darthttps://github.com/angular/angular/pull/940/files#diff-fc7a4f96774889d8845a5c70e56e43af44876e37754affaaca543495a61b9ea4
View file https://github.com/pkozlowski-opensource/angular/blob/90e56b6e726ae61a06679bf74185df16ba5a71d9/modules/angular2/src/dom/browser_adapter.dart
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/940/{{ revealButtonHref }}
https://github.com/angular/angular/pull/940/files#diff-fc7a4f96774889d8845a5c70e56e43af44876e37754affaaca543495a61b9ea4
https://github.com/angular/angular/pull/940/files#diff-fc7a4f96774889d8845a5c70e56e43af44876e37754affaaca543495a61b9ea4
modules/angular2/test/core/compiler/integration_spec.jshttps://github.com/angular/angular/pull/940/files#diff-cc1f53e7bcdc7ee865e5b57f429fc232bc4b73e84d3d6b649eecf45c98d840c3
View file https://github.com/pkozlowski-opensource/angular/blob/90e56b6e726ae61a06679bf74185df16ba5a71d9/modules/angular2/test/core/compiler/integration_spec.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/940/{{ revealButtonHref }}
https://github.com/angular/angular/pull/940/files#diff-cc1f53e7bcdc7ee865e5b57f429fc232bc4b73e84d3d6b649eecf45c98d840c3
https://github.com/angular/angular/pull/940/files#diff-cc1f53e7bcdc7ee865e5b57f429fc232bc4b73e84d3d6b649eecf45c98d840c3
https://github.com/angular/angular/pull/940/files#diff-cc1f53e7bcdc7ee865e5b57f429fc232bc4b73e84d3d6b649eecf45c98d840c3
modules/angular2/test/core/compiler/pipeline/directive_parser_spec.jshttps://github.com/angular/angular/pull/940/files#diff-31210f1f869f68e1778ff730d26d696ea0adb5b3e8a4dc7809c3dada86f051a3
View file https://github.com/pkozlowski-opensource/angular/blob/90e56b6e726ae61a06679bf74185df16ba5a71d9/modules/angular2/test/core/compiler/pipeline/directive_parser_spec.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/940/{{ revealButtonHref }}
https://github.com/angular/angular/pull/940/files#diff-31210f1f869f68e1778ff730d26d696ea0adb5b3e8a4dc7809c3dada86f051a3
https://github.com/angular/angular/pull/940/files#diff-31210f1f869f68e1778ff730d26d696ea0adb5b3e8a4dc7809c3dada86f051a3
https://github.com/angular/angular/pull/940/files#diff-31210f1f869f68e1778ff730d26d696ea0adb5b3e8a4dc7809c3dada86f051a3
https://github.com/angular/angular/pull/940/files#diff-31210f1f869f68e1778ff730d26d696ea0adb5b3e8a4dc7809c3dada86f051a3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.