| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0f682499-bb50-da19-7c91-ea8012365478 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C992:D5AA4:1FC7DB1:2A4B085:6B017065 |
| html-safe-nonce | 6c9764bfc991a844f7dd0135bbce96796ec79a2e6ba1a4b25df89fc298911676 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTkyOkQ1QUE0OjFGQzdEQjE6MkE0QjA4NTo2QjAxNzA2NSIsInZpc2l0b3JfaWQiOiI3NjA5NjQzNTg3MzQ0NjI1NzY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5af0bdc43da8e2352c6ce3b2658ae4997c89f03e603abaf7a7b821cee64f2b00 |
| hovercard-subject-tag | pull_request:74167796 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/9283/files |
| twitter:image | https://avatars.githubusercontent.com/u/248818?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/248818?s=400&v=4 |
| og:image:alt | @vsavkin could you please review ?
The idea is that:
We translate messages as a whole (not spliting every single cases)
Expand ICU forms (this is not related to using i18n)
This PR removes the ex... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/9283/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F9283%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F9283%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/9283/files |
| Reload | https://github.com/angular/angular/pull/9283/files |
| Reload | https://github.com/angular/angular/pull/9283/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| vicb | https://github.com/vicb |
| angular:master | https://github.com/angular/angular/tree/master |
| vicb:0616-i18n | https://github.com/vicb/angular/tree/0616-i18n |
|
Conversation
5
| https://github.com/angular/angular/pull/9283 |
|
Commits
1
| https://github.com/angular/angular/pull/9283/commits |
|
Checks
0
| https://github.com/angular/angular/pull/9283/checks |
|
Files changed
| https://github.com/angular/angular/pull/9283/files |
| Please reload this page | https://github.com/angular/angular/pull/9283/files |
|
feat(I18N Expander): do not add extra | https://github.com/angular/angular/pull/9283/files#top |
|
Show all changes
1 commit
| https://github.com/angular/angular/pull/9283/files |
2d81815
feat(I18N Expander): do not add extra `` & `- ` around ICU mess…
vicb Jun 16, 2016
| https://github.com/angular/angular/pull/9283/commits/2d818159f822781b0d18847b4686ef11f8831317 |
|
Clear filters
| https://github.com/angular/angular/pull/9283/files |
| Please reload this page | https://github.com/angular/angular/pull/9283/files |
| Please reload this page | https://github.com/angular/angular/pull/9283/files |
|
ng_plural_spec.ts
| https://github.com/angular/angular/pull/9283/files#diff-940177fe1208392ea48c07152e431a40e44473d2d1ed684bf899bc03a24eafae |
|
expander.ts
| https://github.com/angular/angular/pull/9283/files#diff-691d3a3a7d2b6f6508228d63366e1fc3ff9cbca9a7ccedc3e9db37e7c4354de6 |
|
html_ast_spec_utils.ts
| https://github.com/angular/angular/pull/9283/files#diff-5169f2d73eb5989a4e29247f7401538a57497af9760bd8461f284b1333dd4edf |
|
expander_spec.ts
| https://github.com/angular/angular/pull/9283/files#diff-65f45c68a7e415623fd88adcffcaa2585fa6599dd3cb426e7929d2346daa6b9b |
|
i18n_html_parser_spec.ts
| https://github.com/angular/angular/pull/9283/files#diff-be9f168e4b6cb17e19ddf25c4564a479542171e55f8788e1ec882b0bb586b14c |
|
message_extractor_spec.ts
| https://github.com/angular/angular/pull/9283/files#diff-950de89e211f58219ebc05a9df06bb6f991896d4c771f9e3342ab87eb88c9bb9 |
| modules/@angular/common/test/directives/ng_plural_spec.ts | https://github.com/angular/angular/pull/9283/files#diff-940177fe1208392ea48c07152e431a40e44473d2d1ed684bf899bc03a24eafae |
|
View file
| https://github.com/vicb/angular/blob/2d818159f822781b0d18847b4686ef11f8831317/modules/%40angular/common/test/directives/ng_plural_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/9283/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/9283/files#diff-940177fe1208392ea48c07152e431a40e44473d2d1ed684bf899bc03a24eafae |
|
| https://github.com/angular/angular/pull/9283/files#diff-940177fe1208392ea48c07152e431a40e44473d2d1ed684bf899bc03a24eafae |
|
| https://github.com/angular/angular/pull/9283/files#diff-940177fe1208392ea48c07152e431a40e44473d2d1ed684bf899bc03a24eafae |
| modules/@angular/compiler/src/i18n/expander.ts | https://github.com/angular/angular/pull/9283/files#diff-691d3a3a7d2b6f6508228d63366e1fc3ff9cbca9a7ccedc3e9db37e7c4354de6 |
|
View file
| https://github.com/vicb/angular/blob/2d818159f822781b0d18847b4686ef11f8831317/modules/%40angular/compiler/src/i18n/expander.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/9283/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/9283/files#diff-691d3a3a7d2b6f6508228d63366e1fc3ff9cbca9a7ccedc3e9db37e7c4354de6 |
|
| https://github.com/angular/angular/pull/9283/files#diff-691d3a3a7d2b6f6508228d63366e1fc3ff9cbca9a7ccedc3e9db37e7c4354de6 |
|
| https://github.com/angular/angular/pull/9283/files#diff-691d3a3a7d2b6f6508228d63366e1fc3ff9cbca9a7ccedc3e9db37e7c4354de6 |
|
| https://github.com/angular/angular/pull/9283/files#diff-691d3a3a7d2b6f6508228d63366e1fc3ff9cbca9a7ccedc3e9db37e7c4354de6 |
| modules/@angular/compiler/test/html_ast_spec_utils.ts | https://github.com/angular/angular/pull/9283/files#diff-5169f2d73eb5989a4e29247f7401538a57497af9760bd8461f284b1333dd4edf |
|
View file
| https://github.com/vicb/angular/blob/2d818159f822781b0d18847b4686ef11f8831317/modules/%40angular/compiler/test/html_ast_spec_utils.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/9283/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/9283/files#diff-5169f2d73eb5989a4e29247f7401538a57497af9760bd8461f284b1333dd4edf |
|
| https://github.com/angular/angular/pull/9283/files#diff-5169f2d73eb5989a4e29247f7401538a57497af9760bd8461f284b1333dd4edf |
| modules/@angular/compiler/test/i18n/expander_spec.ts | https://github.com/angular/angular/pull/9283/files#diff-65f45c68a7e415623fd88adcffcaa2585fa6599dd3cb426e7929d2346daa6b9b |
|
View file
| https://github.com/vicb/angular/blob/2d818159f822781b0d18847b4686ef11f8831317/modules/%40angular/compiler/test/i18n/expander_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/9283/{{ revealButtonHref }} |
| Please reload this page | https://github.com/angular/angular/pull/9283/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |